12 Apr
2016
12 Apr
'16
4:28 p.m.
On 11 Apr 2016, at 08:48, sangamesh sajjan
<sangamesh.sajjan(a)radisys.com> wrote:
Hi,
This patch includes the changes for encoding of PUAN
to
handle the CRBB bitmap
same as with Haralds mail. How was this tested? Can you add a testcase for it? In manual
tests how often are the bitmaps compressed in manual tests? Under which conditions?
+ for (i = 0, bsn = (v_q()+1); ((bsn < (v_r()))
&& (i < ws())); i++,
+ bsn = this->mod_sns(bsn + 1)) {
+ if (m_v_n.is_received(bsn)) {
+ rbb[pos] = rbb[pos] | bitmask;
+ } else {
+ rbb[pos] = rbb[pos] & (~bitmask);
+ }
coding style issue and hard to read. By itself such a method would be easy to unit test.
Could you please add a test?
holger