Re: [PATCH net-next v4 3/5] rtnetlink: Decouple net namespaces in rtnl_newlink_create()

Hi Xiao, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Xiao-Liang/net-ip_tunnel-Bui… base: net-next/main patch link: https://lore.kernel.org/r/20241118143244.1773-4-shaw.leon%40gmail.com patch subject: [PATCH net-next v4 3/5] rtnetlink: Decouple net namespaces in rtnl_newlink_create() config: arc-randconfig-002-20241122 (https://download.01.org/0day-ci/archive/20241122/202411220516.rokej98E-lkp@…) compiler: arceb-elf-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241122/202411220516.rokej98E-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411220516.rokej98E-lkp@intel.com/ All warnings (new ones prefixed by >>): vim +1075 net/batman-adv/soft-interface.c 128254ceea6ffe Sven Eckelmann 2020-10-11 1063 128254ceea6ffe Sven Eckelmann 2020-10-11 1064 /** 128254ceea6ffe Sven Eckelmann 2020-10-11 1065 * batadv_softif_newlink() - pre-initialize and register new batadv link c19808cb1d05d1 Xiao Liang 2024-11-18 1066 * @nets: the applicable net namespaces 128254ceea6ffe Sven Eckelmann 2020-10-11 1067 * @dev: network device to register 128254ceea6ffe Sven Eckelmann 2020-10-11 1068 * @tb: IFLA_INFO_DATA netlink attributes 128254ceea6ffe Sven Eckelmann 2020-10-11 1069 * @data: enum batadv_ifla_attrs attributes 128254ceea6ffe Sven Eckelmann 2020-10-11 1070 * @extack: extended ACK report struct 128254ceea6ffe Sven Eckelmann 2020-10-11 1071 * 128254ceea6ffe Sven Eckelmann 2020-10-11 1072 * Return: 0 if successful or error otherwise. 128254ceea6ffe Sven Eckelmann 2020-10-11 1073 */ c19808cb1d05d1 Xiao Liang 2024-11-18 1074 static int batadv_softif_newlink(struct rtnl_newlink_params *params) 128254ceea6ffe Sven Eckelmann 2020-10-11 @1075 { c19808cb1d05d1 Xiao Liang 2024-11-18 1076 struct net_device *dev = params->dev; c19808cb1d05d1 Xiao Liang 2024-11-18 1077 struct nlattr **data = params->data; a5ad457eea41ef Sven Eckelmann 2020-10-11 1078 struct batadv_priv *bat_priv = netdev_priv(dev); a5ad457eea41ef Sven Eckelmann 2020-10-11 1079 const char *algo_name; a5ad457eea41ef Sven Eckelmann 2020-10-11 1080 int err; a5ad457eea41ef Sven Eckelmann 2020-10-11 1081 a5ad457eea41ef Sven Eckelmann 2020-10-11 1082 if (data && data[IFLA_BATADV_ALGO_NAME]) { a5ad457eea41ef Sven Eckelmann 2020-10-11 1083 algo_name = nla_data(data[IFLA_BATADV_ALGO_NAME]); a5ad457eea41ef Sven Eckelmann 2020-10-11 1084 err = batadv_algo_select(bat_priv, algo_name); a5ad457eea41ef Sven Eckelmann 2020-10-11 1085 if (err) a5ad457eea41ef Sven Eckelmann 2020-10-11 1086 return -EINVAL; a5ad457eea41ef Sven Eckelmann 2020-10-11 1087 } a5ad457eea41ef Sven Eckelmann 2020-10-11 1088 128254ceea6ffe Sven Eckelmann 2020-10-11 1089 return register_netdevice(dev); 128254ceea6ffe Sven Eckelmann 2020-10-11 1090 } 128254ceea6ffe Sven Eckelmann 2020-10-11 1091 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki