On Fri, Aug 02, 2013 at 01:56:47PM +0400, Ivan Kluchnikov wrote:
Hi Holger,
I committed this patchset to master branch.
thanks a lot. I will post my PCU emu code. It is a manual test for our SGSN (but can also be a testbed for moving LLC code from OpenBSC to libosmocore, now I copy and pasted some routines/defines). I plan to extend this to also enable PDCHs.. and deal with csn1 packed bits at the end. Do you think it makes sense to keep it in the PCU?
Another thing I will do is to start re-factoring these giant methods into smaller and unit-tested methods. I will also refactor the lookup of a TBF. It should really be based on TLLI and not only on IMSI, but more importantly the decision/logic of finding or creating a new TBF should really really really not be burried inside the Downlink-Data message routine.
holger