13 Feb
2025
13 Feb
'25
7:55 a.m.
From: Xiao Liang <shaw.leon(a)gmail.com>
Date: Mon, 10 Feb 2025 21:29:54 +0800
These netdevice drivers already uses netns parameter
in newlink()
callback. Convert them to use rtnl_newlink_link_net() or
rtnl_newlink_peer_net() for clarity and deprecate params->net.
Signed-off-by: Xiao Liang <shaw.leon(a)gmail.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu(a)amazon.com>
diff --git
a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
index 8151e91395e2..ab7e5b6649b2 100644
--- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
+++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
@@ -122,8 +122,8 @@ static int rmnet_newlink(struct net_device *dev,
struct netlink_ext_ack *extack)
{
u32 data_format = RMNET_FLAGS_INGRESS_DEAGGREGATION;
+ struct net *link_net = rtnl_newlink_link_net(params);
nit: reverse xmas tree
struct nlattr **data = params->data;
- struct net *src_net = params->net;
struct nlattr **tb = params->tb;
struct net_device *real_dev;
int mode = RMNET_EPMODE_VND;