Re: [PATCH] VTY changes for FANR feature

Hi Aravind,

On Wed, Mar 09, 2016 at 06:07:14PM +0530, Aravind Sirsikar wrote:

uint8_t egprs_enabled;

• uint8_t fanr_enabled;

you are adding only one field: fanr_enabled.

• bts->egprs_enabled = true;
• bts->fanr_enabled = false;

here you are enabling egprs in main.c, which is unrelated to the FANR change. Please make sure you don't introduce chanes unrelated to the currently worked on feature.

• if (bts->fanr_enabled)

• vty_out(vty, " egprs fanr %s", VTY_NEWLINE);
  

• else

• vty_out(vty, " no egprs fanr%s", VTY_NEWLINE);
  

+DEFUN(cfg_pcu_egprs_fanr,

•  cfg_pcu_egprs_fanr_cmd,
  

•  "egprs_fanr",
  

•  EGPRS_FANR_STR)
  

+DEFUN(cfg_pcu_no_egprs_fanr,

•  cfg_pcu_no_egprs_fanr_cmd,
  

•  "no egprs fanr",
  

•  NO_STR EGPRS_FANR_STR)
  

So you add a command "egprs_fanr", but you write to the config file as "egprs fanr". Once you save the config file, it will fail to parse and thus the PCU system ends up being unusable. Please be careful with such changes and try to manually re-read a configuration file before sending patches for submission next time :) Thanks!

Regards, Harald