12 Feb
2022
12 Feb
'22
9:15 a.m.
Hi Marcin,
I'm sorry if you think this is too much nit-picking, but moving
around functions and removing forward declarations is making it
unneccessarily hard to read the generated diff:
Now it's not possible to see which bits of the code you really changed,
as entire functions have moved position within the file.
On Fri, Feb 11, 2022 at 06:55:00PM +0100, Marcin Szycik wrote:
-static int gtp_hashtable_new(struct gtp_dev *gtp, int
hsize);
-static int gtp_encap_enable(struct gtp_dev *gtp, struct nlattr *data[]);
+static int gtp_hashtable_new(struct gtp_dev *gtp, int hsize)
+{
+ int i;
+
+ gtp->addr_hash = kmalloc_array(hsize, sizeof(struct hlist_head),
+ GFP_KERNEL | __GFP_NOWARN);
+ if (gtp->addr_hash == NULL)
...
I would appreciate if you could do any re-ordering of functions in a
separate, marked "cosmetic" commit, so we can see the actual changes you
make to the code in one patch, and the re-arranging in another.
Thanks!
--
- Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)