24 Mar
2016
24 Mar
'16
11:45 p.m.
Hi Bhargava,
On Tue, Mar 22, 2016 at 06:42:30PM +0530, Bhargava Abhyankar wrote:
Parsing the uplink data header for GPRS and EGPRS header type 3 is handled in separate functions. This patch will enhance modularity of the code.
I'm not an expert on OsmoPCU, but this patch looks pretty straight-forward and undisputable. Moving away from large switch statements towards separate functions/methods is generally appreciated a lot, as is increasing modularity.
--
- Harald Welte laforge@gnumonks.org http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)