30 Jul
2013
30 Jul
'13
10:56 a.m.
Hi Holger,
I looked through your patches and commited them to master, all of them are
reasonable.
I have only one question about the name of the this variable:
+static struct osmo_pcu the_pcu = { 0, };
Why do you use "the_pcu", not "pcu"?
Actually it is not the problem, just unusual for me. :)
Now I am ready for new patchset.
What is the reasonable amount of time for patchset review for you?
Sometimes I am overloaded by other work, but I will try to delay review no
longer than 1-2 days.
Another mode, you can commit patches to master by yourself and just notify
about it mailing list.
2013/7/29 Holger Hans Peter Freyther <hfreyther(a)sysmocom.de>
On Sat, Jul 27, 2013 at 10:20:47PM +0200, Holger
Freyther wrote:
Dear Ivan,
I have 14 more patches after this patchset. Could you please indicate
how we can end up with a mode where my commit queue is draining within
a reasonable amount of time? I started with the PCU Emu to re-produce
some SGSN issue(s).
I really appreciate someone reviewing and arguing about the changes
I do and each individual one is fairly small and one topic at a time.
Any ideas?
kind regards
holger
--
- Holger Freyther <hfreyther(a)sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Schivelbeiner Str. 5
* 10439 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte
--
Regards,
Ivan Kluchnikov.
http://fairwaves.ru