osmocom-net-gprs

osmocom-net-gprs@lists.osmocom.org

483 discussions

Osmocom redmine upgrade / Let me know if something broke
by Harald Welte 28 Oct '21

28 Oct '21

Dear Osmocom community, today we finally upgraded our redmine installation from the unmaintained 3.4.x to the latest 4.2.3. The upgrade had been overdue for years, but today we (actually, Kevin) finally managed to find out how to make the openid_provider plugin to work with modern rails 5.x. In any case, I'm just informing you in case there is some unexpected fallout. I've verified that at least the following appears working: * logging into redmine * openid authentication from gerrit.osmocom.org (also after logout/relogin) * graphviz rendering * mscgen rendering There could however still be unexpected problems, particularly in features such as * e-mail notifications from redmine * updating redmine issues via e-mail * git integration ("Closes: OS#xxxx") If you run into any troubles, pleas report to https://osmocom.org/projects/osmocom-servers or if that also fails, feel free to send e-mails. Regards, Harald -- - Harald Welte <laforge(a)osmocom.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

1 0

[PATCH net-next] gtp: use skb_dst_update_pmtu_no_confirm() instead of direct call
by Gyeongun Kang 07 Oct '21

07 Oct '21

skb_dst_update_pmtu_no_confirm() is a just wrapper function of ->update_pmtu(). So, it doesn't change logic Signed-off-by: Gyeongun Kang <kyeongun15(a)gmail.com> --- drivers/net/gtp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 30e0a10595a1..24e5c54d06c1 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -539,7 +539,7 @@ static int gtp_build_skb_ip4(struct sk_buff *skb, struct net_device *dev, mtu = dst_mtu(&rt->dst); } - rt->dst.ops->update_pmtu(&rt->dst, NULL, skb, mtu, false); + skb_dst_update_pmtu_no_confirm(skb, mtu); if (!skb_is_gso(skb) && (iph->frag_off & htons(IP_DF)) && mtu < ntohs(iph->tot_len)) { -- 2.25.1

2 1

RFC PATCHES - Merge gtp driver with https://github.com/free5gc/gtp5g
by Richard Haines 05 Aug '21

05 Aug '21

Harald, As requested I've copied this to the osmocom-net-gprs(a)lists.osmocom.org list. I'm not sure if any of you are interested in this (or even if it's useful as the "gtp5g" module is still 'work in progress'), however if you are interested any comments ??. I've attached a tarball (gtp-patches.tar.xz) with all the patches and here are some notes: 1) This has been built and tested on Fedora 34 using linux-5.14-rc4 kernel. 2) The first two kernel patches reinstall the current gtp driver into manageable modules. You can build the kernel with just these patches and should still be able to use libgtpnl, osmo-ggsn etc. as no code changes. 3) The remaining three kernel patches install the services from https://github.com/free5gc/gtp5g to DRV_VERSION "1.0.3a", also update core services (where possible) to use common functions e.g. gtp_dev_xmit(). It is possible to implement more common functions, but that can be done if the patch series is of any use !!! 4) There are three possible Kconfig configuration options: GTP_PDP only - GTP_PDR only - GTP_PDP and GTP_PDR 5) If GTP_PDP and GTP_PDR build selected, the basic tests using osmo-ggsn or openggsn work using tests in [1] and the tests from libgtp5gnl [2] (./run.sh SimpleUPTest & ULCLTest1) will also run - provided the following tarball patch has been applied to update [2]: 0001-libgtp5gnl-Update-to-match-new-linux-gtp.h-entries.patch 6) Be aware that apps/libs should now define their role specifically (i.e. GTP_ROLE_SGSN, GTP_ROLE_RAN) and not default thinking that '0' will always be GTP_ROLE_GGSN or GTP_ROLE_UPF. Both libgtp*nl versions do this. 7) I've only limited test options so cannot guarantee all will work !! 8) The kernel and tests have been built using Fedora 34. When building the kernel with Fedora the gtp5g side will hang when testing. This happens whether I build/load as described in the https://github.com/free5gc/gtp5g README i.e. untouched by me, or with my patches. To solve this issue I've commented out some code in pdr.c pdr_context_free() with a comment: /* FIXME - Stop crash when kernel built on Fedora 34 */ I'll try and fix this at some stage. 9) The original gtp5g driver 'struct net_device_ops' used: .ndo_get_stats64 = ip_tunnel_get_stats64, However this is deprecated so set to: .ndo_get_stats64 = dev_get_tstats64, 10) Running checkpatch on the kernel patches will show plenty of warning and check messages, however all 'errors' are fixed. 11) I've patches that add the LSM/SELinux services, however have not included these as I guess still nfi. [1] https://osmocom.org/projects/linux-kernel-gtp-u/wiki/Basic_Testing [2] https://github.com/free5gc/libgtp5gnl Richard Haines (5): gtp: Delete current gtp driver gtp: Split gtp driver into modules gtp: Add support for PDR services - Part 1 gtp: Add support for PDR services - Part 2 gtp: Add support for PDR services - Part 3 drivers/net/Kconfig | 17 +- drivers/net/Makefile | 2 +- drivers/net/gtp.c | 1462 ---------------------------- drivers/net/gtp/Kconfig | 45 + drivers/net/gtp/Makefile | 8 + drivers/net/gtp/dev_core.c | 103 ++ drivers/net/gtp/encap.c | 406 ++++++++ drivers/net/gtp/far.c | 596 ++++++++++++ drivers/net/gtp/gtp_core.c | 243 +++++ drivers/net/gtp/include/dev_core.h | 59 ++ drivers/net/gtp/include/encap.h | 27 + drivers/net/gtp/include/far.h | 64 ++ drivers/net/gtp/include/gtp_core.h | 105 ++ drivers/net/gtp/include/nl_core.h | 18 + drivers/net/gtp/include/pdp.h | 53 + drivers/net/gtp/include/pdp_ipv4.h | 31 + drivers/net/gtp/include/pdr.h | 96 ++ drivers/net/gtp/include/pdr_ipv4.h | 49 + drivers/net/gtp/include/proc_dbg.h | 85 ++ drivers/net/gtp/include/qer.h | 49 + drivers/net/gtp/nl_core.c | 444 +++++++++ drivers/net/gtp/pdp.c | 578 +++++++++++ drivers/net/gtp/pdp_ipv4.c | 166 ++++ drivers/net/gtp/pdr.c | 1272 ++++++++++++++++++++++++ drivers/net/gtp/pdr_ipv4.c | 330 +++++++ drivers/net/gtp/proc_dbg.c | 384 ++++++++ drivers/net/gtp/qer.c | 463 +++++++++ include/net/gtp.h | 105 +- include/uapi/linux/gtp.h | 200 +++- include/uapi/linux/if_link.h | 5 + 30 files changed, 5981 insertions(+), 1484 deletions(-) delete mode 100644 drivers/net/gtp.c create mode 100644 drivers/net/gtp/Kconfig create mode 100644 drivers/net/gtp/Makefile create mode 100644 drivers/net/gtp/dev_core.c create mode 100644 drivers/net/gtp/encap.c create mode 100644 drivers/net/gtp/far.c create mode 100644 drivers/net/gtp/gtp_core.c create mode 100644 drivers/net/gtp/include/dev_core.h create mode 100644 drivers/net/gtp/include/encap.h create mode 100644 drivers/net/gtp/include/far.h create mode 100644 drivers/net/gtp/include/gtp_core.h create mode 100644 drivers/net/gtp/include/nl_core.h create mode 100644 drivers/net/gtp/include/pdp.h create mode 100644 drivers/net/gtp/include/pdp_ipv4.h create mode 100644 drivers/net/gtp/include/pdr.h create mode 100644 drivers/net/gtp/include/pdr_ipv4.h create mode 100644 drivers/net/gtp/include/proc_dbg.h create mode 100644 drivers/net/gtp/include/qer.h create mode 100644 drivers/net/gtp/nl_core.c create mode 100644 drivers/net/gtp/pdp.c create mode 100644 drivers/net/gtp/pdp_ipv4.c create mode 100644 drivers/net/gtp/pdr.c create mode 100644 drivers/net/gtp/pdr_ipv4.c create mode 100644 drivers/net/gtp/proc_dbg.c create mode 100644 drivers/net/gtp/qer.c -- 2.31.1

1 0

[PATCH net-next] gtp: Fix a typo
by Zheng Yongjun 02 Jun '21

02 Jun '21

Suppport ==> Support Signed-off-by: Zheng Yongjun <zhengyongjun3(a)huawei.com> --- drivers/net/gtp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 39c00f050fbd..1c9023d47e00 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -436,7 +436,7 @@ static inline void gtp1_push_header(struct sk_buff *skb, struct pdp_ctx *pctx) gtp1->length = htons(payload_len); gtp1->tid = htonl(pctx->u.v1.o_tei); - /* TODO: Suppport for extension header, sequence number and N-PDU. + /* TODO: Support for extension header, sequence number and N-PDU. * Update the length field if any of them is available. */ } -- 2.25.1

2 1

Linux kernel GTP-U
by Encinar Sanz, Paula (ext) 26 May '21

26 May '21

Good afternoon, I am investigating linux kernel GTP-U to build a 5G Core with this kernel but I understand that it does not support 5G and only works with 4G. Could you solve this doubt? Thanks in advance, Regards This e-mail and the documents attached are confidential and intended solely for the addressee; it may also be privileged. If you receive this e-mail in error, please notify the sender immediately and destroy it. As its integrity cannot be secured on the Internet, the Atos group liability cannot be triggered for the message content. Although the sender endeavors to maintain a computer virus-free network, the sender does not warrant that this transmission is virus-free and will not be liable for any damages resulting from any virus transmitted. Este mensaje y los ficheros adjuntos pueden contener información confidencial destinada solamente a la(s) persona(s) mencionadas anteriormente y pueden estar protegidos por secreto profesional. Si usted recibe este correo electrónico por error, gracias por informar inmediatamente al remitente y destruir el mensaje. Al no estar asegurada la integridad de este mensaje sobre la red, Atos no se hace responsable por su contenido. Su contenido no constituye ningún compromiso para el grupo Atos, salvo ratificación escrita por ambas partes. Aunque se esfuerza al máximo por mantener su red libre de virus, el emisor no puede garantizar nada al respecto y no será responsable de cualesquiera daños que puedan resultar de una transmisión de virus.

2 1

osmo-pcu always "T3193 timeout expired, freeing TBF" when osmo-sgsn send GPRS ATTACH ACCEPT
by 海鱼 12 May '21

12 May '21

Hi All, Here is the issue when use egprs with osmo-bts-trx,osmo-pcu and osmo-sgsn. osmo-pcu debugging info as below: <000c> gprs_bssgp_pcu.cpp:168 LLC [SGSN -> PCU] = TLLI: 0xaf8ce1ff IMSI: 460000323182742 len: 26 <0008> tbf.cpp:1068 Allocating DL TBF: MS_CLASS=12/12 <0008> tbf.cpp:541 TBF(TFI=0 TLLI=0x00000000 DIR=DL STATE=NULL) Setting Control TS 6 <0008> tbf.cpp:945 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=NULL) Allocated: trx = 0, ul_slots = 40, dl_slots = 40 <0008> bts.cpp:898 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH) <0008> tbf_dl.cpp:520 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=ASSIGN) set ass. type PACCH [prev CCCH:0, PACCH:0] <0008> tbf.cpp:1270 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=ASSIGN) start Packet Downlink Assignment (PACCH) <0009> tbf.cpp:788 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=ASSIGN) Scheduled DL Assignment polling on PACCH (FN=2402222, TS=6) <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2402270, TS=6 <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2402322, TS=6 <0008> tbf.cpp:808 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) poll timeout for FN=2402322, TS=6 (curr FN 2402387) <0008> tbf.cpp:879 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Timeout for polling PACKET DOWNLINK ACK. <0008> tbf.cpp:1184 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Assignment was on PACCH <0008> tbf.cpp:1190 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Downlink ACK was received <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2402426, TS=6 <0008> tbf.cpp:989 Allocating UL TBF: MS_CLASS=12/12 <0008> tbf.cpp:541 TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=NULL) Setting Control TS 6 <0008> tbf.cpp:945 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=UL STATE=NULL) Allocated: trx = 0, ul_slots = 40, dl_slots = 00 <0008> tbf.cpp:1359 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=UL STATE=ASSIGN) start Packet Uplink Assignment (PACCH) <0009> tbf.cpp:782 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled UL Assignment polling on PACCH (FN=2402478, TS=6) <0007> gprs_rlcmac_meas.cpp:184 DL Bandwitdh of IMSI=460000323182742 / TLLI=0xaf8ce1ff: 66 KBits/s <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2402525, TS=6 <000c> tbf_ul.cpp:404 LLC [PCU -> SGSN] TBF(TFI=0 TLLI=0xaf8ce1ff DIR=UL STATE=FLOW) len=97 <000c> gprs_bssgp_pcu.cpp:168 LLC [SGSN -> PCU] = TLLI: 0xaf8ce1ff IMSI: 460000323182742 len: 9 <0008> tbf.cpp:808 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) poll timeout for FN=2402525, TS=6 (curr FN 2402586) <0008> tbf.cpp:879 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Timeout for polling PACKET DOWNLINK ACK. <0008> tbf.cpp:1184 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Assignment was on PACCH <0008> tbf.cpp:1190 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Downlink ACK was received <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2402625, TS=6 <0007> gprs_rlcmac_meas.cpp:106 UL RSSI of TLLI=0xaf8ce1ff: -31 dBm <0008> tbf.cpp:486 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=UL STATE=FINISHED) free <0008> tbf.cpp:989 Allocating UL TBF: MS_CLASS=12/12 <0008> tbf.cpp:541 TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=NULL) Setting Control TS 6 <0008> tbf.cpp:945 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=UL STATE=NULL) Allocated: trx = 0, ul_slots = 40, dl_slots = 00 <0008> tbf.cpp:1359 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=UL STATE=ASSIGN) start Packet Uplink Assignment (PACCH) <0009> tbf.cpp:782 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled UL Assignment polling on PACCH (FN=2402673, TS=6) <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2402720, TS=6 <000c> tbf_ul.cpp:404 LLC [PCU -> SGSN] TBF(TFI=0 TLLI=0xaf8ce1ff DIR=UL STATE=FLOW) len=17 <000c> gprs_bssgp_pcu.cpp:168 LLC [SGSN -> PCU] = TLLI: 0xaf8ce1ff IMSI: 460000323182742 len: 26 <0007> gprs_rlcmac_meas.cpp:184 DL Bandwitdh of IMSI=460000323182742 / TLLI=0xaf8ce1ff: 86 KBits/s <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2402768, TS=6 <0007> gprs_rlcmac_meas.cpp:106 UL RSSI of TLLI=0xaf8ce1ff: -31 dBm <0008> tbf.cpp:486 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=UL STATE=FINISHED) free <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2402816, TS=6 <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2402863, TS=6 <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2402911, TS=6 <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2402959, TS=6 <0007> gprs_rlcmac_meas.cpp:184 DL Bandwitdh of IMSI=460000323182742 / TLLI=0xaf8ce1ff: 240 KBits/s <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2403006, TS=6 <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2403054, TS=6 <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2403102, TS=6 <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2403149, TS=6 <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FINISHED) Scheduled Ack/Nack polling on FN=2403197, TS=6 <0008> tbf.cpp:650 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=WAIT RELEASE) T3193 timeout expired, freeing TBF <0008> tbf.cpp:486 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=RELEASING) free <000c> gprs_bssgp_pcu.cpp:168 LLC [SGSN -> PCU] = TLLI: 0xaf8ce1ff IMSI: 460000323182742 len: 26 <0008> tbf.cpp:1068 Allocating DL TBF: MS_CLASS=12/12 <0008> tbf.cpp:541 TBF(TFI=0 TLLI=0x00000000 DIR=DL STATE=NULL) Setting Control TS 6 <0008> tbf.cpp:945 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=NULL) Allocated: trx = 0, ul_slots = 40, dl_slots = 40 <0008> bts.cpp:898 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH) <0008> tbf_dl.cpp:520 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=ASSIGN) set ass. type PACCH [prev CCCH:0, PACCH:0] <0008> tbf.cpp:1270 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=ASSIGN) start Packet Downlink Assignment (PACCH) <0009> tbf.cpp:788 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=ASSIGN) Scheduled DL Assignment polling on PACCH (FN=2404263, TS=6) <0007> gprs_rlcmac_meas.cpp:184 DL Bandwitdh of IMSI=460000323182742 / TLLI=0xaf8ce1ff: 22 KBits/s <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2404311, TS=6 <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2404358, TS=6 <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2404406, TS=6 <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2404454, TS=6 <0008> tbf.cpp:808 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) poll timeout for FN=2404454, TS=6 (curr FN 2404519) <0008> tbf.cpp:879 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Timeout for polling PACKET DOWNLINK ACK. <0008> tbf.cpp:1184 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Assignment was on PACCH <0008> tbf.cpp:1190 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Downlink ACK was received <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2404558, TS=6 <0007> gprs_rlcmac_meas.cpp:184 DL Bandwitdh of IMSI=460000323182742 / TLLI=0xaf8ce1ff: 163 KBits/s <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2404605, TS=6 <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2404653, TS=6 <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2404701, TS=6 <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FINISHED) Scheduled Ack/Nack polling on FN=2404748, TS=6 <0008> tbf.cpp:650 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=WAIT RELEASE) T3193 timeout expired, freeing TBF <0008> tbf.cpp:486 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=RELEASING) free <000c> gprs_bssgp_pcu.cpp:168 LLC [SGSN -> PCU] = TLLI: 0xaf8ce1ff IMSI: 460000323182742 len: 26 <0008> tbf.cpp:1068 Allocating DL TBF: MS_CLASS=12/12 <0008> tbf.cpp:541 TBF(TFI=0 TLLI=0x00000000 DIR=DL STATE=NULL) Setting Control TS 6 <0008> tbf.cpp:945 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=NULL) Allocated: trx = 0, ul_slots = 40, dl_slots = 40 <0008> bts.cpp:898 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=ASSIGN) TX: START Immediate Assignment Downlink (PCH) <0008> tbf_dl.cpp:520 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=ASSIGN) set ass. type PACCH [prev CCCH:0, PACCH:0] <0008> tbf.cpp:1270 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=ASSIGN) start Packet Downlink Assignment (PACCH) <0009> tbf.cpp:788 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=ASSIGN) Scheduled DL Assignment polling on PACCH (FN=2405537, TS=6) <0007> gprs_rlcmac_meas.cpp:184 DL Bandwitdh of IMSI=460000323182742 / TLLI=0xaf8ce1ff: 25 KBits/s <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2405585, TS=6 <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2405632, TS=6 <0009> tbf_dl.cpp:880 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Scheduled Ack/Nack polling on FN=2405680, TS=6 <0008> tbf.cpp:808 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) poll timeout for FN=2405680, TS=6 (curr FN 2405741) <0008> tbf.cpp:879 TBF(TFI=0 TLLI=0xaf8ce1ff DIR=DL STATE=FLOW) Timeout for polling PACKET DOWNLINK ACK. osmo-sgsn debugging info: <0011> gprs_llc_parse.c:78 LLC SAPI=1 C   U GEA0 IOV-UI=0x000000 FCS=0xa3ad04 CMD=UI DATA <0002> gprs_gmm.c:1118 MM(---/ffffffff) -> GMM ATTACH REQUEST MI(4018987519) type="GPRS attach" <0002> fsm.c:461 GMM(gmm_fsm)[0xaaaaf63e5b50]{Deregistered}: Allocated <0002> fsm.c:461 GMM_ATTACH_REQ_FSM(gb_gmm_req)[0xaaaaf63e5c80]{Init}: Allocated <0002> fsm.c:461 MM_STATE_Gb[0xaaaaf63e5e50]{Idle}: Allocated <0002> gprs_sgsn.c:299 MM(/00000000) Allocated with GEA0 cipher. <0002> gprs_gmm.c:1100 GMM(gmm_fsm)[0xaaaaf63e5b50]{Deregistered}: Received Event E_GMM_COMMON_PROC_INIT_REQ <0002> gprs_gmm_fsm.c:25 GMM(gmm_fsm)[0xaaaaf63e5b50]{Deregistered}: state_chg to CommonProcedureInitiated <0011> gprs_llc.c:1056 LLME(ffffffff/af8ce1ff){UNASSIGNED} LLGM Assign pre (af8ce1ff => cf0ebf06) <0011> gprs_llc.c:1102 LLME(af8ce1ff/cf0ebf06){ASSIGNED} LLGM Assign post (af8ce1ff => cf0ebf06) <0002> gprs_gmm.c:1271 GMM_ATTACH_REQ_FSM(gb_gmm_req)[0xaaaaf63e5c80]{Init}: Received Event E_ATTACH_REQ_RECV <0002> gprs_gmm_attach.c:50 GMM_ATTACH_REQ_FSM(gb_gmm_req)[0xaaaaf63e5c80]{Init}: state_chg to CheckIdentity <0002> gprs_gmm.c:409 MM(/cf0ebf06) <- GPRS IDENTITY REQUEST: mi_type=IMEI <0010> gprs_bssgp.c:423 BSSGP TLLI=0xaf8ce1ff Rx UPLINK-UNITDATA <0011> gprs_llc_parse.c:78 LLC SAPI=1 C   U GEA0 IOV-UI=0x000000 FCS=0x8c64cd CMD=UI DATA <0002> gprs_gb.c:40 MM_STATE_Gb(2945245695)[0xaaaaf63e5e50]{Idle}: Received Event E_MM_PDU_RECEPTION <0002> gprs_gmm.c:1040 MM(/cf0ebf06) -> GMM IDENTITY RESPONSE: MI(IMEI)=866089038960590 <0002> gprs_gmm.c:113 MM(/cf0ebf06) Stopping MM timer 3370 but 0 is running <0002> gprs_gmm.c:1084 GMM_ATTACH_REQ_FSM(gb_gmm_req)[0xaaaaf63e5c80]{CheckIdentity}: Received Event E_IDEN_RESP_RECV <0002> gprs_gmm_attach.c:111 GMM_ATTACH_REQ_FSM(gb_gmm_req)[0xaaaaf63e5c80]{CheckIdentity}: state_chg to CheckIdentity <0002> gprs_gmm.c:409 MM(/cf0ebf06) <- GPRS IDENTITY REQUEST: mi_type=IMSI <0010> gprs_bssgp.c:423 BSSGP TLLI=0xaf8ce1ff Rx UPLINK-UNITDATA <0011> gprs_llc_parse.c:78 LLC SAPI=1 C   U GEA0 IOV-UI=0x000000 FCS=0xb71895 CMD=UI DATA <0002> gprs_gb.c:40 MM_STATE_Gb(2945245695)[0xaaaaf63e5e50]{Idle}: Received Event E_MM_PDU_RECEPTION <0002> gprs_gmm.c:1040 MM(/cf0ebf06) -> GMM IDENTITY RESPONSE: MI(IMSI)=460000323182742 <0002> gprs_gmm.c:113 MM(/cf0ebf06) Stopping MM timer 3370 but 0 is running <0002> gprs_gmm.c:1084 GMM_ATTACH_REQ_FSM(gb_gmm_req)[0xaaaaf63e5c80]{CheckIdentity}: Received Event E_IDEN_RESP_RECV <0002> gprs_gmm_attach.c:113 GMM_ATTACH_REQ_FSM(gb_gmm_req)[0xaaaaf63e5c80]{CheckIdentity}: state_chg to Authenticate <0002> gprs_gmm_attach.c:148 GMM_ATTACH_REQ_FSM(gb_gmm_req)[0xaaaaf63e5c80]{Authenticate}: state_chg to WaitAttachComplete <0002> gprs_gmm.c:289 MM(460000323182742/cf0ebf06) <- GPRS ATTACH ACCEPT (new P-TMSI=0xcf0ebf06) <0002> gprs_gmm.c:305 MM(460000323182742/cf0ebf06) <- GPRS ATTACH ACCEPT (ra_id=0x020xf20x50 lac:2f11 rac:2) <000e> gprs_sgsn.c:1012 Checking for inactive LLMEs, time = 1652 <000f> gprs_ns.c:779 NSEI=1234 Timer expired in mode tns-test (30 seconds) <000f> gprs_ns.c:712 NSEI=1234 Tx NS ALIVE (NSVCI=1234) <000f> gprs_ns.c:751 NSEI=1234 Starting timer in mode tns-alive (3 seconds) <000f> gprs_ns.c:725 NSEI=1234 Tx NS ALIVE_ACK (NSVCI=1234) <000f> gprs_ns.c:1763 NSEI 1234 (NS-VCI=1234) setting state [ALIVE,UNBLOCKED,UNRESET] -> [ALIVE,UNBLOCKED,UNRESET] <000f> gprs_ns.c:751 NSEI=1234 Starting timer in mode tns-test (30 seconds) <0010> gprs_bssgp.c:839 BSSGP BVCI=1234 Rx Flow Control BVC <0002> fsm.c:322 GMM_ATTACH_REQ_FSM(gb_gmm_req)[0xaaaaf63e5c80]{WaitAttachComplete}: Timeout of T3350 <0002> gprs_gmm.c:289 MM(460000323182742/cf0ebf06) <- GPRS ATTACH ACCEPT (new P-TMSI=0xcf0ebf06) <0002> gprs_gmm.c:305 MM(460000323182742/cf0ebf06) <- GPRS ATTACH ACCEPT (ra_id=0x020xf20x50 lac:2f11 rac:2) <0002> fsm.c:322 GMM_ATTACH_REQ_FSM(gb_gmm_req)[0xaaaaf63e5c80]{WaitAttachComplete}: Timeout of T3350 <0002> gprs_gmm.c:289 MM(460000323182742/cf0ebf06) <- GPRS ATTACH ACCEPT (new P-TMSI=0xcf0ebf06) <0002> gprs_gmm.c:305 MM(460000323182742/cf0ebf06) <- GPRS ATTACH ACCEPT (ra_id=0x020xf20x50 lac:2f11 rac:2) <0010> gprs_bssgp.c:423 BSSGP TLLI=0xaf8ce1ff Rx UPLINK-UNITDATA <0011> gprs_llc_parse.c:78 LLC SAPI=1 C   U GEA0 IOV-UI=0x000000 FCS=0x0d0447 CMD=UI DATA <0002> gprs_gb.c:40 MM_STATE_Gb(2945245695)[0xaaaaf63e5e50]{Idle}: Received Event E_MM_PDU_RECEPTION <0002> gprs_gmm.c:1118 MM(460000323182742/cf0ebf06) -> GMM ATTACH REQUEST MI(4018987519) type="GPRS attach" <0002> gprs_gmm.c:1100 GMM(gmm_fsm)[0xaaaaf63e5b50]{CommonProcedureInitiated}: Received Event E_GMM_COMMON_PROC_INIT_REQ <0002> gprs_gmm.c:1100 GMM(gmm_fsm)[0xaaaaf63e5b50]{CommonProcedureInitiated}: Event E_GMM_COMMON_PROC_INIT_REQ not permitted <0011> gprs_llc.c:1056 LLME(af8ce1ff/cf0ebf06){ASSIGNED} LLGM Assign pre (af8ce1ff => cf0ebf06) <0011> gprs_llc.c:1102 LLME(af8ce1ff/cf0ebf06){ASSIGNED} LLGM Assign post (af8ce1ff => cf0ebf06) <0002> gprs_gmm.c:1271 GMM_ATTACH_REQ_FSM(gb_gmm_req)[0xaaaaf63e5c80]{WaitAttachComplete}: Received Event E_ATTACH_REQ_RECV <0002> gprs_gmm_attach.c:360 GMM_ATTACH_REQ_FSM(gb_gmm_req)[0xaaaaf63e5c80]{WaitAttachComplete}: state_chg to Init <0002> gprs_gmm_attach.c:50 GMM_ATTACH_REQ_FSM(gb_gmm_req)[0xaaaaf63e5c80]{Init}: state_chg to CheckIdentity <0002> gprs_gmm.c:409 MM(460000323182742/cf0ebf06) <- GPRS IDENTITY REQUEST: mi_type=IMEI <0010> gprs_bssgp.c:839 BSSGP BVCI=1234 Rx Flow Control BVC <0010> gprs_bssgp.c:423 BSSGP TLLI=0xaf8ce1ff Rx UPLINK-UNITDATA <0011> gprs_llc_parse.c:78 LLC SAPI=1 C   U GEA0 IOV-UI=0x000000 FCS=0xea5c4f CMD=UI DATA <0002> gprs_gb.c:40 MM_STATE_Gb(2945245695)[0xaaaaf63e5e50]{Idle}: Received Event E_MM_PDU_RECEPTION <0002> gprs_gmm.c:1040 MM(460000323182742/cf0ebf06) -> GMM IDENTITY RESPONSE: MI(IMEI)=866089038960590 <0002> gprs_gmm.c:113 MM(460000323182742/cf0ebf06) Stopping MM timer 3370 but 0 is running <0002> gprs_gmm.c:1084 GMM_ATTACH_REQ_FSM(gb_gmm_req)[0xaaaaf63e5c80]{CheckIdentity}: Received Event E_IDEN_RESP_RECV <0002> gprs_gmm_attach.c:113 GMM_ATTACH_REQ_FSM(gb_gmm_req)[0xaaaaf63e5c80]{CheckIdentity}: state_chg to Authenticate <0002> gprs_gmm_attach.c:148 GMM_ATTACH_REQ_FSM(gb_gmm_req)[0xaaaaf63e5c80]{Authenticate}: state_chg to WaitAttachComplete <0002> gprs_gmm.c:289 MM(460000323182742/cf0ebf06) <- GPRS ATTACH ACCEPT (new P-TMSI=0xcf0ebf06) <0002> gprs_gmm.c:305 MM(460000323182742/cf0ebf06) <- GPRS ATTACH ACCEPT (ra_id=0x020xf20x50 lac:2f11 rac:2) <0002> fsm.c:322 GMM_ATTACH_REQ_FSM(gb_gmm_req)[0xaaaaf63e5c80]{WaitAttachComplete}: Timeout of T3350 <0002> gprs_gmm.c:289 MM(460000323182742/cf0ebf06) <- GPRS ATTACH ACCEPT (new P-TMSI=0xcf0ebf06) <0002> gprs_gmm.c:305 MM(460000323182742/cf0ebf06) <- GPRS ATTACH ACCEPT (ra_id=0x020xf20x50 lac:2f11 rac:2) Configure information： gprs mode egprs   gprs routing area 2   gprs cell bvci 1234   gprs nsei 1234   gprs nsvc 0 nsvci 1234   gprs nsvc 0 local udp port 23001   gprs nsvc 0 remote udp port 23000   。。。    timeslot 6     phys_chan_config PDCH     hopping enabled 0    timeslot 7     phys_chan_config PDCH     hopping enabled 0 pcu  flow-control-interval 10  cs 2  cs max 4  cs threshold 10 33  cs downgrade-threshold 200  cs link-quality-ranges cs1 6 cs2 5 8 cs3 7 13 cs4 12  mcs link-quality-ranges mcs1 6 mcs2 5 8 mcs3 7 13 mcs4 12 15 mcs5 14 17 mcs6 16 18 mcs7 17 20 mcs8 19 24 mcs9 23  mcs max 9  window-size 64 0  queue idle-ack-delay 10  queue codel  alloc-algorithm dynamic  alpha 0  gamma 0  dl-tbf-idle-time 2000 sgsn  gtp local-ip 127.0.0.1  ggsn 0 remote-ip 127.0.0.6  ggsn 0 gtp-version 1  auth-policy accept-all ns  timer tns-block 3  timer tns-block-retries 3  timer tns-reset 3  timer tns-reset-retries 3  timer tns-test 30  timer tns-alive 3  timer tns-alive-retries 10  encapsulation udp local-ip 127.0.0.1  encapsulation udp local-port 23000  encapsulation framerelay-gre enabled 0 Version information: OsmoPCU version 0.8.0 OsmoSGSN version 1.6.2 I tried to debug this issue but the no any progress for this issue.The root cause is confifure or something else? I need help. Thanks a lot. Br, Perter

3 5

Osmo-ggsn MTU issue with Kernel GTP
by Keith A. Milner 14 Apr '21

14 Apr '21

I've had an interesting situation with osmo-ggsn and kernel GTP module that I wonder if someone could shed some light on. I've set up osmo-ggsn (v1.7.1) on Debian 10. There are two ethernet interfaces on the system, ens224 (for the Gn Interface) and ens256 (for the Gi Interface). Using the following ggsn configuration seems to work fine: ggsn ggsn0 description Keith's Test APN gtp state-dir /tmp gtp bind-ip <ens224 IP> gtp control-ip <ens224 IP> apn keithtest gtpu-mode tun tun-device apn0 type-support v4 ip prefix dynamic 192.168.42.0/24 ip dns 0 <redacted> ip dns 1 <redacted> ip ifconfig 192.168.42.0/24 no shutdown default-apn keithtest no shutdown ggsn I get the following tun device: 5: apn0: <POINTOPOINT,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UNKNOWN group default qlen 500 link/none inet 192.168.42.0/24 scope global apn0 valid_lft forever preferred_lft forever inet6 fe80::fada:2e69:ad71:a61b/64 scope link stable-privacy valid_lft forever preferred_lft forever Traffic routes, all is good with the world. However, if I change to using Kernel GTP, by changing the gtpu-mode to "kernel-gtp", traffic will not route (and, yes, I have done modprobe gtp). After some exploration, it appears the tun device is being created with an MTU of zero which then, cannot pass traffic: 10: apn0: <POINTOPOINT,UP,LOWER_UP> mtu 0 qdisc noqueue state UNKNOWN group default qlen 1000 link/none inet 192.168.42.0/24 scope global apn0 valid_lft forever preferred_lft forever Here are the logs: Tue Apr 13 11:02:06 2021 DGGSN NOTICE <0002> ggsn.c:830 GGSN(ggsn0): Successfully started Tue Apr 13 11:02:06 2021 DGGSN INFO <0002> ggsn.c:186 APN(keithtest): Starting Tue Apr 13 11:02:06 2021 DGGSN INFO <0002> ggsn.c:204 APN(keithtest): Opening Kernel GTP device apn0 Tue Apr 13 11:02:06 2021 DGGSN NOTICE <0002> gtp-kernel.c:79 Initialized GTP kernel mode (genl ID is 24) Tue Apr 13 11:02:06 2021 DTUN NOTICE <0001> tun.c:217 GTP kernel configured Tue Apr 13 11:02:06 2021 DGGSN INFO <0002> ggsn.c:236 APN(keithtest): Setting tun IP address 192.168.42.0/24 Tue Apr 13 11:02:06 2021 DGGSN INFO <0002> ggsn.c:294 APN(keithtest): Creating IPv4 pool 192.168.42.0/24 Tue Apr 13 11:02:06 2021 DGGSN INFO <0002> ggsn.c:168 APN(keithtest): Blacklist tun IP 192.168.42.0/24 Tue Apr 13 11:02:06 2021 DGGSN NOTICE <0002> ggsn.c:325 APN(keithtest): Successfully started Note that if I manually alter the MTU, everything starts working again: ip link set dev apn0 mtu 1500 So I can put this into a script and run it via ipup-script, and this works fine. I just get the impression I shouldn't have to do this, and the system should be setting the MTU, just as it does when I use tun mode. Any thoughts on what I'm doing wrong here? Cheers, Keith

2 2

Question about establishing stable internet link between UE and HNB connected to our developed network core.
by morteza ali Ahmadi 27 Mar '21

27 Mar '21

Hi, osmocom team members. In order to have an internet connection in UE, we have run OsmoGGSN project to set up GGSN. Also, SGSN is developed in our system. At this step, UE connects to our network core and we can query to an arbitrary site in the UE browser and we see the answer of the query without any problem and everything is OK. But after about 30 or 40 seconds, UE sends "Deactivate PDP Context Request" with SM Cause "SM Cause: Protocol error, unspecified (111)" and the connection is reset and a new "Activate PDP Context Request" is required. What is the reason and how can we solve it? -- *When there is much light, The shadow is deep...*

1 0

Automatic testing for kernel GTP tunnel driver
by Harald Welte 17 Mar '21

17 Mar '21

Hi all, in recent months - after many years of no patches at all - the kernel GTP driver has received significant interest in terms of contributions. Given the presumed few users of the GTP tunnel driver, as well as the tendency to use super ancient versions of software in the telecom world, I think that the usual "let's have the users test -rcX kernels" approach is unlikely going to work. Within Osmocom (a group of FOSS projects implementing various cellular standards, protocol stacks and network elements) we are used to rather comprehensive functional test suites that we execute automatically at least once per 24 hours. That is for the 99% of our software that is userspace code. For the kernel GTP code, it's of course not that simple, and we never had any related testing so far. In 2021, 5 years after the GTP kernel driver was merged mainline, we now finally have set up some test jobs for kernel GTP. Those jobs execute the same GGSN test suite that we run against the userspace dataplane (handling GTP-U and GTP-C in a userspace program "osmo-ggsn"). The only difference is that they configure osmo-ggsn to use the kernel GTP driver for GTP-U. Those tests are executed by jenkins, in the following jobs: * ttcn3-ggsn-test-kernel-latest-torvalds https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-ggsn-test-kernel-l… runs GGSN test suite against latest released osmo-ggsn version with kernel-gtp of torvalds/linux.git test results at https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-ggsn-test-kernel-l… (make sure to click "Expand All") * ttcn3-ggsn-test-kernel-latest-torvalds https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-ggsn-test-kernel-l… runs GGSN test suite against latest released osmo-ggsn version with kernel-gtp of net-next.git test results at https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-ggsn-test-kernel-l… (make sure to click "Expand All") * ttcn3-ggsn-test-kernel-latest https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-ggsn-test-kernel-l… runs GGSN test suite against latest released osmo-ggsn version with kernel-gtp of Debian 10 kernel package test results at https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-ggsn-test-kernel-l… (make sure to click "Expand All") * ttcn3-ggsn-test-latest https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-ggsn-test-latest/ runs GGSN test suite against latest released osmo-ggsn version with userspace GTP-U, not using any kernel GTP driver test results at https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-ggsn-test-latest/t… this serves as a base line that shows the test suite can fully pass, and any failures in the aove are either bugs or lack of features (like IPv6) Contrary to the above jenkins jobs which all run automatically once every 24 hours, there is also one jenkins job for manual execution: * ttcn3-ggsn-test-kernel-git https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-ggsn-test-kernel-g… this is the same test suite and osmo-ggsn as above, but a developer can manually trigger the job and specify * URL of the kernel git repo to build * branch of the kernel git repo to build * whether to use osmo-ggsn latest tag or master If any one is working on the kernel GTP driver and wants to get access to triggering that jenkins job in order to test your patches/branches before submission, please register an account at https://jenkins.osmocom.org/ and contact me privately. We are always happy about any contributions in terms of extending test coverage. This could be done by e.g. adding jobs using other P-GW/GGSN software than osmo-ggsn, or by extending the coverage of the test cases of the test suite. For anyone interested in more details, please see our redmine issue https://osmocom.org/issues/3208 tracks the development of the tests. The test suite source code (in TTCN-3) is at https://git.osmocom.org/osmo-ttcn3-hacks/tree/ggsn_tests with containerization + configs at https://git.osmocom.org/docker-playground/tree/ttcn3-ggsn-test I'd like to thank Oliver Smith <osmith(a)sysmocom.de> for creating the above automatic test CI integration. Development of this was funded by sysmocom (https://sysmocom.de/) If you have any questions, please feel free to reach out to Oliver and/or me. Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

2 1

[PATCH] Net: gtp: Fixed missing blank line after declaration
by Chinmayi Shetty 16 Mar '21

16 Mar '21

Signed-off-by: Chinmayi Shetty <chinmayishetty359(a)gmail.com> --- drivers/net/gtp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index efe5247d8c42..79998f4394e5 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -437,7 +437,7 @@ static inline void gtp1_push_header(struct sk_buff *skb, struct pdp_ctx *pctx) gtp1->length = htons(payload_len); gtp1->tid = htonl(pctx->u.v1.o_tei); - /* TODO: Suppport for extension header, sequence number and N-PDU. + /* TODO: Support for extension header, sequence number and N-PDU. * Update the length field if any of them is available. */ } -- 2.25.1

2 1

← Newer
1
...
7
8
9
10
11
12
13
...
49
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

osmocom-net-gprs