Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40131?usp=email )
Change subject: README: explain how to run testsuites manually
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40131?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1ee9319ada889a8dd43cfb32776dc1a8ae12d607
Gerrit-Change-Number: 40131
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Apr 2025 19:55:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129?usp=email )
Change subject: start-testsuite: remove workaround for TITAN < 9.0.0
......................................................................
Patch Set 1:
(1 comment)
File start-testsuite.sh:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129/comment/9757f33b_5486… :
PS1, Line 48:
> How about adding a version check to ensure we are on at least version 9? I just had version 8 instal […]
This is a good idea, but I am not sure if we should be checking the version here at run-time. Ideally, this should be done at compile-time. Also, AFAIR, the output of `ttcn3_compiler -v` had a slightly different format, so parsing the version is not trivial.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I57eecd6e0ea9e488a2110b029ddc313bd05cd1fa
Gerrit-Change-Number: 40129
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Apr 2025 18:56:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>