- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: Move f_{dec,enc}_mcc_mnc() API BSSMAP_Templates.ttcn -> GSM_Types.ttcn

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40112?usp=email ) Change subject: Move f_{dec,enc}_mcc_mnc() API BSSMAP_Templates.ttcn -> GSM_Types.ttcn ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40112?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iafafd2957a11d34a9402d252a169fec40593f483 Gerrit-Change-Number: 40112 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Apr 2025 20:09:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: set sndbuf/recbuf explicitly for SCTP

by pespin

pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40127?usp=email ) Change subject: osmo_dia2gsup: set sndbuf/recbuf explicitly for SCTP ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: we should probably prepare a new release of osmo_dia2gsup after this. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40127?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I793f1295ab42bfc548511fc5ffbda9070280745f Gerrit-Change-Number: 40127 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Apr 2025 20:08:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: start-testsuite: remove workaround for TITAN < 9.0.0

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129?usp=email ) Change subject: start-testsuite: remove workaround for TITAN < 9.0.0 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I57eecd6e0ea9e488a2110b029ddc313bd05cd1fa Gerrit-Change-Number: 40129 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Apr 2025 20:07:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: Move f_{dec,enc}_mcc_mnc() API BSSMAP_Templates.ttcn -> GSM_Types.ttcn

by pespin

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40112?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: Move f_{dec,enc}_mcc_mnc() API BSSMAP_Templates.ttcn -> GSM_Types.ttcn ...................................................................... Move f_{dec,enc}_mcc_mnc() API BSSMAP_Templates.ttcn -> GSM_Types.ttcn The GsmMcc and GsmMnc types used in the function are defined in GSM_Types.ttcn, which is also incldued by BSSMAP_Templates. Hence, move the function there so that it can be used in other testsuites including more generic GSM_Types.ttcn but not BSSMAP_Templates.ttcn. Change-Id: Iafafd2957a11d34a9402d252a169fec40593f483 --- M cbc/CBC_Tests.ttcn M library/BSSMAP_Templates.ttcn M library/GSM_Types.ttcn 3 files changed, 18 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/12/40112/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40112?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iafafd2957a11d34a9402d252a169fec40593f483 Gerrit-Change-Number: 40112 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: add and use parse_addr/1

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40124?usp=email ) Change subject: osmo_dia2gsup: add and use parse_addr/1 ...................................................................... osmo_dia2gsup: add and use parse_addr/1 Change-Id: If02c3486c937595fcc0d3813ab64445ebccb746e --- M src/osmo_dia2gsup.erl 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index 7c4f2c1..b60d049 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -106,7 +106,7 @@ Port = get_env(diameter_port, 3868), Proto = get_env(diameter_proto, sctp), ConnectTimer = get_env(diameter_connect_timer, 30000), - listen(?SVC_NAME, {address, Proto, element(2,inet:parse_address(Ip)), Port}, {timer, ConnectTimer}), + listen(?SVC_NAME, {address, Proto, parse_addr(Ip), Port}, {timer, ConnectTimer}), lager:info("Diameter HSS Application started on IP ~s, ~p port ~p~n", [Ip, Proto, Port]), {ok, State}. @@ -156,3 +156,14 @@ tmod(tcp) -> diameter_tcp; tmod(sctp) -> diameter_sctp. + +parse_addr(any) -> any; +parse_addr(localhost) -> localhost; + +parse_addr(AddrStr) when is_list(AddrStr) -> + {ok, Addr} = inet:parse_address(AddrStr), + Addr; + +parse_addr(Addr) -> + true = inet:is_ip_address(Addr), + Addr. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40124?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: If02c3486c937595fcc0d3813ab64445ebccb746e Gerrit-Change-Number: 40124 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: add get_env/2 for convenience

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40123?usp=email ) Change subject: osmo_dia2gsup: add get_env/2 for convenience ...................................................................... osmo_dia2gsup: add get_env/2 for convenience Change-Id: I4c6ce2899c8b41a81fd0278ad065ab65bfd0311d --- M src/osmo_dia2gsup.erl M src/osmo_dia2gsup_sup.erl 2 files changed, 13 insertions(+), 10 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index b8d7a34..7c4f2c1 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -36,7 +36,7 @@ -include_lib("diameter/include/diameter_gen_base_rfc6733.hrl"). %-include_lib("diameter_settings.hrl"). --export([main/1]). +-export([get_env/2, main/1]). % API -export([start_link/0]). @@ -56,9 +56,9 @@ -define(DIAMETER_DICT_HSS, diameter_3gpp_ts29_272). -define(APPID_S6, #'diameter_base_Vendor-Specific-Application-Id'{'Vendor-Id'=10415, 'Auth-Application-Id'=[16777251]}). --define(SERVICE(Name), [{'Origin-Host', application:get_env(osmo_dia2gsup, origin_host, "hss.localdomain")}, - {'Origin-Realm', application:get_env(osmo_dia2gsup, origin_realm, "localdomain")}, - {'Vendor-Id', application:get_env(osmo_dia2gsup, vendor_id, 0)}, +-define(SERVICE(Name), [{'Origin-Host', get_env(origin_host, "hss.localdomain")}, + {'Origin-Realm', get_env(origin_realm, "localdomain")}, + {'Vendor-Id', get_env(vendor_id, 0)}, {'Origin-State-Id', diameter:origin_state_id()}, {'Product-Name', Name}, {'Auth-Application-Id', []}, @@ -85,6 +85,9 @@ stop() -> gen_server:cast(?SERVER, stop). +get_env(Param, Default) -> + application:get_env(?MODULE, Param, Default). + main(_Args) -> application:ensure_all_started(?MODULE), timer:sleep(infinity). @@ -99,10 +102,10 @@ ProdName = atom_to_list(?MODULE), ok = diameter:start_service(?SVC_NAME, ?SERVICE(ProdName)), - Ip = application:get_env(osmo_dia2gsup, diameter_ip, "127.0.0.8"), - Port = application:get_env(osmo_dia2gsup, diameter_port, 3868), - Proto = application:get_env(osmo_dia2gsup, diameter_proto, sctp), - ConnectTimer = application:get_env(osmo_dia2gsup, diameter_connect_timer, 30000), + Ip = get_env(diameter_ip, "127.0.0.8"), + Port = get_env(diameter_port, 3868), + Proto = get_env(diameter_proto, sctp), + ConnectTimer = get_env(diameter_connect_timer, 30000), listen(?SVC_NAME, {address, Proto, element(2,inet:parse_address(Ip)), Port}, {timer, ConnectTimer}), lager:info("Diameter HSS Application started on IP ~s, ~p port ~p~n", [Ip, Proto, Port]), {ok, State}. diff --git a/src/osmo_dia2gsup_sup.erl b/src/osmo_dia2gsup_sup.erl index dbb1ae6..929206d 100644 --- a/src/osmo_dia2gsup_sup.erl +++ b/src/osmo_dia2gsup_sup.erl @@ -10,8 +10,8 @@ init([]) -> % GSUP side - HlrIp = application:get_env(osmo_dia2gsup, hlr_ip, "127.0.0.1"), - HlrPort = application:get_env(osmo_dia2gsup, hlr_port, 4222), + HlrIp = osmo_dia2gsup:get_env(hlr_ip, "127.0.0.1"), + HlrPort = osmo_dia2gsup:get_env(hlr_port, 4222), Args = [{local, gsup_client}, gsup_client, [HlrIp, HlrPort, "HSS-00-00-00-00-00-00"], []], GsupChild = {gsup_client, {gen_server, start_link, Args}, permanent, 2000, worker, [gsup_client]}, % DIAMETER side -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I4c6ce2899c8b41a81fd0278ad065ab65bfd0311d Gerrit-Change-Number: 40123 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: move env parsing and logging to listen/1

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40125?usp=email ) Change subject: osmo_dia2gsup: move env parsing and logging to listen/1 ...................................................................... osmo_dia2gsup: move env parsing and logging to listen/1 In preparation for follow-up patches, make the listen/1 function self-contained by letting it consume the environment on its own. Change-Id: I8ca4cc0b830d281ada5ba56bc98a9511937b8b81 --- M src/osmo_dia2gsup.erl 1 file changed, 13 insertions(+), 12 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index b60d049..e38f5e3 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -101,13 +101,7 @@ % DIAMETER side ProdName = atom_to_list(?MODULE), ok = diameter:start_service(?SVC_NAME, ?SERVICE(ProdName)), - - Ip = get_env(diameter_ip, "127.0.0.8"), - Port = get_env(diameter_port, 3868), - Proto = get_env(diameter_proto, sctp), - ConnectTimer = get_env(diameter_connect_timer, 30000), - listen(?SVC_NAME, {address, Proto, parse_addr(Ip), Port}, {timer, ConnectTimer}), - lager:info("Diameter HSS Application started on IP ~s, ~p port ~p~n", [Ip, Proto, Port]), + listen(?SVC_NAME), {ok, State}. %% @callback gen_server @@ -147,12 +141,19 @@ %% Internal Function Definitions %% ------------------------------------------------------------------ -listen(Name, {address, Protocol, IPAddr, Port}, {timer, ConnectTimer}) -> - TransOpts = [{transport_module, tmod(Protocol)}, - {transport_config, [{reuseaddr, true}, - {ip, IPAddr}, {port, Port}]}, +listen(Name) -> + LAddr = get_env(diameter_ip, "127.0.0.8"), + LPort = get_env(diameter_port, 3868), + Proto = get_env(diameter_proto, sctp), + ConnectTimer = get_env(diameter_connect_timer, 30000), + TransOpts = [{transport_module, tmod(Proto)}, + {transport_config, [{ip, parse_addr(LAddr)}, + {port, LPort}, + {reuseaddr, true}]}, {connect_timer, ConnectTimer}], - {ok, _} = diameter:add_transport(Name, {listen, TransOpts}). + {ok, _} = diameter:add_transport(Name, {listen, TransOpts}), + lager:info("Diameter HSS Application started on IP ~s, ~p port ~p~n", + [LAddr, Proto, LPort]). tmod(tcp) -> diameter_tcp; tmod(sctp) -> diameter_sctp. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40125?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I8ca4cc0b830d281ada5ba56bc98a9511937b8b81 Gerrit-Change-Number: 40125 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: disable Nagle for TCP/SCTP by default

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40126?usp=email ) Change subject: osmo_dia2gsup: disable Nagle for TCP/SCTP by default ...................................................................... osmo_dia2gsup: disable Nagle for TCP/SCTP by default Disable the Nagle's algorithm by default in order to reduce latency of the DIAMETER peer. Allow re-enabling it via the environment parameter 'diameter_nodelay' (false enables the Nagle). Change-Id: I1e62cdbcbbdb29a0a98f390b33cf14592079d579 --- M src/osmo_dia2gsup.erl 1 file changed, 15 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index e38f5e3..4f7f21f 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -47,6 +47,7 @@ -export([code_change/3, terminate/2]). -define(SERVER, ?MODULE). +-define(ENV_DEFAULT_NODELAY, true). % Diameter application definitions @@ -147,9 +148,7 @@ Proto = get_env(diameter_proto, sctp), ConnectTimer = get_env(diameter_connect_timer, 30000), TransOpts = [{transport_module, tmod(Proto)}, - {transport_config, [{ip, parse_addr(LAddr)}, - {port, LPort}, - {reuseaddr, true}]}, + {transport_config, tcfg(Proto, LAddr, LPort)}, {connect_timer, ConnectTimer}], {ok, _} = diameter:add_transport(Name, {listen, TransOpts}), lager:info("Diameter HSS Application started on IP ~s, ~p port ~p~n", @@ -158,6 +157,19 @@ tmod(tcp) -> diameter_tcp; tmod(sctp) -> diameter_sctp. +tcfg(tcp, LAddr, LPort) -> + Cfg = #{nodelay => get_env(diameter_nodelay, ?ENV_DEFAULT_NODELAY)}, + tcfg(Cfg, LAddr, LPort); + +tcfg(sctp, LAddr, LPort) -> + Cfg = #{sctp_nodelay => get_env(diameter_nodelay, ?ENV_DEFAULT_NODELAY)}, + tcfg(Cfg, LAddr, LPort); + +tcfg(Cfg, LAddr, LPort) when is_map(Cfg) -> + maps:to_list(Cfg#{ip => parse_addr(LAddr), + port => LPort, + reuseaddr => true}). + parse_addr(any) -> any; parse_addr(localhost) -> localhost; -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40126?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I1e62cdbcbbdb29a0a98f390b33cf14592079d579 Gerrit-Change-Number: 40126 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: set sndbuf/recbuf explicitly for SCTP

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40127?usp=email ) Change subject: osmo_dia2gsup: set sndbuf/recbuf explicitly for SCTP ...................................................................... osmo_dia2gsup: set sndbuf/recbuf explicitly for SCTP When opening an SCTP socket on Linux, Erlang/OTP does set its own default SO_SNDBUF/SO_RCVBUF values if the respective socket options (sndbuf and recbuf) are not given to gen_sctp:open/N explicitly. For some reason, the default RCVBUF size (1024) is much smaller than the default SNDBUF size (65536), and both are well below modern Linux defaults. Such a small RCVBUF size becomes problematic when the remote peer is sending large packets. Let's explicitly set both sndbuf/recbuf parameters to 65536, allowing the user to overwrite this default via the environment parameters. For more details, see https://github.com/erlang/otp/issues/9722. Change-Id: I793f1295ab42bfc548511fc5ffbda9070280745f --- M src/osmo_dia2gsup.erl 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index 4f7f21f..cda616b 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -48,6 +48,7 @@ -define(SERVER, ?MODULE). -define(ENV_DEFAULT_NODELAY, true). +-define(ENV_DEFAULT_SCTP_BUFSZ, 65536). % Diameter application definitions @@ -162,7 +163,9 @@ tcfg(Cfg, LAddr, LPort); tcfg(sctp, LAddr, LPort) -> - Cfg = #{sctp_nodelay => get_env(diameter_nodelay, ?ENV_DEFAULT_NODELAY)}, + Cfg = #{sctp_nodelay => get_env(diameter_nodelay, ?ENV_DEFAULT_NODELAY), + recbuf => get_env(diameter_sctp_recbuf, ?ENV_DEFAULT_SCTP_BUFSZ), + sndbuf => get_env(diameter_sctp_sndbuf, ?ENV_DEFAULT_SCTP_BUFSZ)}, tcfg(Cfg, LAddr, LPort); tcfg(Cfg, LAddr, LPort) when is_map(Cfg) -> -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40127?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I793f1295ab42bfc548511fc5ffbda9070280745f Gerrit-Change-Number: 40127 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: README: explain how to run testsuites manually

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40131?usp=email ) Change subject: README: explain how to run testsuites manually ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40131?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1ee9319ada889a8dd43cfb32776dc1a8ae12d607 Gerrit-Change-Number: 40131 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Apr 2025 20:03:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log