Attention is currently required from: osmith.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129?usp=email )
Change subject: start-testsuite: remove workaround for TITAN < 9.0.0
......................................................................
Patch Set 1:
(1 comment)
File start-testsuite.sh:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129/comment/9757f33b_5486… :
PS1, Line 48:
> How about adding a version check to ensure we are on at least version 9? I just had version 8 instal […]
This is a good idea, but I am not sure if we should be checking the version here at run-time. Ideally, this should be done at compile-time. Also, AFAIR, the output of `ttcn3_compiler -v` had a slightly different format, so parsing the version is not trivial.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I57eecd6e0ea9e488a2110b029ddc313bd05cd1fa
Gerrit-Change-Number: 40129
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Apr 2025 18:56:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40128?usp=email )
Change subject: start-testsuite: respect $TTCN3_DIR (if set)
......................................................................
start-testsuite: respect $TTCN3_DIR (if set)
Change-Id: I5c1cdc6ffbe50cf7ee48a160d2f406e428326d14
---
M start-testsuite.sh
1 file changed, 12 insertions(+), 9 deletions(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
diff --git a/start-testsuite.sh b/start-testsuite.sh
index 4f2fba4..7d06bf2 100755
--- a/start-testsuite.sh
+++ b/start-testsuite.sh
@@ -42,19 +42,22 @@
TEST=$3
fi
-# this is an example for using a non-installed custom (e.g. git master) TITAN
-#TTCN3_DIR="/home/laforge/projects/git/titan/titan.core/Install"
-#export TTCN3_DIR
-#TITAN_LIBRARY_PATH="$TTCN3_DIR/lib"
-#TTCN3_BIN_DIR="$TTCN3_DIR/bin"
-
# Limit max num of open file descriptors to workaround titan.core bug:
# https://gitlab.eclipse.org/eclipse/titan/titan.core/-/issues/690
ulimit -n 100000
-# below is for the debian packages
-TTCN3_BIN_DIR="${TTCN3_BIN_DIR:-/usr/bin}"
-TITAN_LIBRARY_PATH="${TITAN_LIBRARY_PATH:-/usr/lib/titan:/usr/ttcn3/lib}"
+if [ -z "$TTCN3_DIR" ]; then
+ # below is for the debian packages
+ TTCN3_BIN_DIR="${TTCN3_BIN_DIR:-/usr/bin}"
+ TITAN_LIBRARY_PATH="${TITAN_LIBRARY_PATH:-/usr/lib/titan:/usr/ttcn3/lib}"
+else
+ # below is for Arch Linux packages
+ # https://aur.archlinux.org/packages/eclipse-titan
+ # https://aur.archlinux.org/packages/titan-git
+ # ... and non-installed custom (e.g. git master) builds
+ TTCN3_BIN_DIR="${TTCN3_DIR}/bin"
+ TITAN_LIBRARY_PATH="${TTCN3_DIR}/lib"
+fi
# Run ttcn3_start with LD_LIBRARY_PATH. Do not put $TEST in quotes as it can be
# empty and must be omitted in that case. Otherwise ttcn3_start tries to stop
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40128?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5c1cdc6ffbe50cf7ee48a160d2f406e428326d14
Gerrit-Change-Number: 40128
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129?usp=email )
Change subject: start-testsuite: remove workaround for TITAN < 9.0.0
......................................................................
Patch Set 1:
(1 comment)
File start-testsuite.sh:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129/comment/eb2342db_75c4… :
PS1, Line 48:
How about adding a version check to ensure we are on at least version 9? I just had version 8 installed myself until a few days ago and didn't notice it since everything worked otherwise.
```
TTCN3_MIN_VERSION=9
for i in $(seq 0 $(($TTCN3_MIN_VERSION - 1))); do
if ttcn3_compiler -v 2>&1 | grep -q "Version: $i\."; then
echo "ERROR: eclipse-titan $TTCN3_MIN_VERSION or higher is needed!"
exit 1
fi
done
```
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I57eecd6e0ea9e488a2110b029ddc313bd05cd1fa
Gerrit-Change-Number: 40129
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Apr 2025 14:36:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40115?usp=email )
Change subject: hnbgw: Test paging with Page Area ID IE
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40115?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5a053bcf1f8470038e95d03889da077f8f967bfa
Gerrit-Change-Number: 40115
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Apr 2025 14:29:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40114?usp=email )
Change subject: hnbgw: Support configuring RAC and Cell ID on each hnb conn
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40114?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I490e770be5e390a1f55e1dff1cf0c42e917a8d33
Gerrit-Change-Number: 40114
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Apr 2025 14:29:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes