Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129?usp=email ) Change subject: start-testsuite: remove workaround for TITAN < 9.0.0 ...................................................................... Patch Set 1: (1 comment) File start-testsuite.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129/comment/eb2342db_75c46... : PS1, Line 48: How about adding a version check to ensure we are on at least version 9? I just had version 8 installed myself until a few days ago and didn't notice it since everything worked otherwise. ``` TTCN3_MIN_VERSION=9 for i in $(seq 0 $(($TTCN3_MIN_VERSION - 1))); do if ttcn3_compiler -v 2>&1 | grep -q "Version: $i\."; then echo "ERROR: eclipse-titan $TTCN3_MIN_VERSION or higher is needed!" exit 1 fi done ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I57eecd6e0ea9e488a2110b029ddc313bd05cd1fa Gerrit-Change-Number: 40129 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Wed, 23 Apr 2025 14:36:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No