- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: README: explain how to run testsuites manually

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40131?usp=email ) Change subject: README: explain how to run testsuites manually ...................................................................... README: explain how to run testsuites manually As the testsuites are now in the _build directory, running them might not be as obvious. Add an example to the README. While at it, explain a bit more what the testenv script does and where one can read more about it. Change-Id: I1ee9319ada889a8dd43cfb32776dc1a8ae12d607 --- M README.md 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/31/40131/1 diff --git a/README.md b/README.md index 94bc73a..b694fd3 100644 --- a/README.md +++ b/README.md @@ -19,6 +19,26 @@ $ ./testenv.py run mgw ``` +This will build the mgw testsuite from source, as well as osmo-mgw and all its +dependencies and then run the testsuite against it. The Osmocom sources will be +cloned if they don't exist in a sibling directory to osmo-ttcn3-hacks. It is +also possible to use the Osmocom binary packages with this and running +everything inside a podman container. See `./testenv.py -h` and +`_testenv/README.md` for more information. + +### Manually + +Alternatively you can build and run the testsuite yourself, e.g.: + +``` +$ make mgw +$ cd mgw +$ ../start-testsuite.sh ../_build/mgw/MGCP_Test MGCP_Test.cfg +``` + +Make sure that all components that the testsuite requires are running +(`osmo-mgw` in this example). + ## Continuous Integration The individual tests suites are executed against different versions of -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40131?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1ee9319ada889a8dd43cfb32776dc1a8ae12d607 Gerrit-Change-Number: 40131 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: README: use # and ## for headlines

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40130?usp=email ) Change subject: README: use # and ## for headlines ...................................................................... README: use # and ## for headlines Prepare README to be able to use deeper headline levels. Change-Id: Ice2baaf3ffdd1c11238c7791ab39925bed10818d --- M README.md 1 file changed, 4 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/40130/1 diff --git a/README.md b/README.md index c84f31c..94bc73a 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,4 @@ -Osmocom TTCN-3 Test Suites -========================== +# Osmocom TTCN-3 Test Suites This repository contains a collection of test suites developed within the [Osmocom](https://osmocom.org/) (Open Source Mobile Communications) @@ -12,8 +11,7 @@ network elements, from 2G, 3G, 4G to 5G. The individual test-suites are in sub-directories, while some shared library code is in *library*. -Running Testsuites ------------------- +## Running Testsuites Use the `testenv.py` script to run the testsuites, e.g.: @@ -21,8 +19,7 @@ $ ./testenv.py run mgw ``` -Continuous Integration ----------------------- +## Continuous Integration The individual tests suites are executed against different versions of the respective IUT (Implementation Under Test) by the Osmocom jenkins. @@ -30,9 +27,7 @@ See the [list of all TTCN-3 jenkins jobs](https://jenkins.osmocom.org/jenkins/view/TTCN3/) for more details - -Further reading --------------- +## Further reading Some more information about those test suites can be found at <https://osmocom.org/projects/cellular-infrastructure/wiki/Titan_TTCN3_Tests…>. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40130?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ice2baaf3ffdd1c11238c7791ab39925bed10818d Gerrit-Change-Number: 40130 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: start-testsuite: respect $TTCN3_DIR (if set)

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40128?usp=email ) Change subject: start-testsuite: respect $TTCN3_DIR (if set) ...................................................................... start-testsuite: respect $TTCN3_DIR (if set) Change-Id: I5c1cdc6ffbe50cf7ee48a160d2f406e428326d14 --- M start-testsuite.sh 1 file changed, 12 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/28/40128/1 diff --git a/start-testsuite.sh b/start-testsuite.sh index 4f2fba4..7d06bf2 100755 --- a/start-testsuite.sh +++ b/start-testsuite.sh @@ -42,19 +42,22 @@ TEST=$3 fi -# this is an example for using a non-installed custom (e.g. git master) TITAN -#TTCN3_DIR="/home/laforge/projects/git/titan/titan.core/Install" -#export TTCN3_DIR -#TITAN_LIBRARY_PATH="$TTCN3_DIR/lib" -#TTCN3_BIN_DIR="$TTCN3_DIR/bin" - # Limit max num of open file descriptors to workaround titan.core bug: # https://gitlab.eclipse.org/eclipse/titan/titan.core/-/issues/690 ulimit -n 100000 -# below is for the debian packages -TTCN3_BIN_DIR="${TTCN3_BIN_DIR:-/usr/bin}" -TITAN_LIBRARY_PATH="${TITAN_LIBRARY_PATH:-/usr/lib/titan:/usr/ttcn3/lib}" +if [ -z "$TTCN3_DIR" ]; then + # below is for the debian packages + TTCN3_BIN_DIR="${TTCN3_BIN_DIR:-/usr/bin}" + TITAN_LIBRARY_PATH="${TITAN_LIBRARY_PATH:-/usr/lib/titan:/usr/ttcn3/lib}" +else + # below is for Arch Linux packages + # https://aur.archlinux.org/packages/eclipse-titan + # https://aur.archlinux.org/packages/titan-git + # ... and non-installed custom (e.g. git master) builds + TTCN3_BIN_DIR="${TTCN3_DIR}/bin" + TITAN_LIBRARY_PATH="${TTCN3_DIR}/lib" +fi # Run ttcn3_start with LD_LIBRARY_PATH. Do not put $TEST in quotes as it can be # empty and must be omitted in that case. Otherwise ttcn3_start tries to stop -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40128?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5c1cdc6ffbe50cf7ee48a160d2f406e428326d14 Gerrit-Change-Number: 40128 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: start-testsuite: remove workaround for TITAN < 9.0.0

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129?usp=email ) Change subject: start-testsuite: remove workaround for TITAN < 9.0.0 ...................................................................... start-testsuite: remove workaround for TITAN < 9.0.0 We're using the 9.0.0 nowadays, which does not need this workaround. Change-Id: I57eecd6e0ea9e488a2110b029ddc313bd05cd1fa --- M start-testsuite.sh 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/40129/1 diff --git a/start-testsuite.sh b/start-testsuite.sh index 7d06bf2..1cf544d 100755 --- a/start-testsuite.sh +++ b/start-testsuite.sh @@ -42,10 +42,6 @@ TEST=$3 fi -# Limit max num of open file descriptors to workaround titan.core bug: -# https://gitlab.eclipse.org/eclipse/titan/titan.core/-/issues/690 -ulimit -n 100000 - if [ -z "$TTCN3_DIR" ]; then # below is for the debian packages TTCN3_BIN_DIR="${TTCN3_BIN_DIR:-/usr/bin}" -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I57eecd6e0ea9e488a2110b029ddc313bd05cd1fa Gerrit-Change-Number: 40129 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: add and use parse_addr/1

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40124?usp=email ) Change subject: osmo_dia2gsup: add and use parse_addr/1 ...................................................................... Patch Set 2: (1 comment) This change is ready for review. File src/osmo_dia2gsup.erl: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40124/comment/57fbc200_… : PS1, Line 164: addr > Oops, not sure how this happened. Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40124?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: If02c3486c937595fcc0d3813ab64445ebccb746e Gerrit-Change-Number: 40124 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 23 Apr 2025 13:28:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: set sndbuf/recbuf explicitly for SCTP

by fixeria

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40127?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: osmo_dia2gsup: set sndbuf/recbuf explicitly for SCTP ...................................................................... osmo_dia2gsup: set sndbuf/recbuf explicitly for SCTP When opening an SCTP socket on Linux, Erlang/OTP does set its own default SO_SNDBUF/SO_RCVBUF values if the respective socket options (sndbuf and recbuf) are not given to gen_sctp:open/N explicitly. For some reason, the default RCVBUF size (1024) is much smaller than the default SNDBUF size (65536), and both are well below modern Linux defaults. Such a small RCVBUF size becomes problematic when the remote peer is sending large packets. Let's explicitly set both sndbuf/recbuf parameters to 65536, allowing the user to overwrite this default via the environment parameters. For more details, see https://github.com/erlang/otp/issues/9722. Change-Id: I793f1295ab42bfc548511fc5ffbda9070280745f --- M src/osmo_dia2gsup.erl 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/27/40127/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40127?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I793f1295ab42bfc548511fc5ffbda9070280745f Gerrit-Change-Number: 40127 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: disable Nagle for TCP/SCTP by default

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40126?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: osmo_dia2gsup: disable Nagle for TCP/SCTP by default ...................................................................... osmo_dia2gsup: disable Nagle for TCP/SCTP by default Disable the Nagle's algorithm by default in order to reduce latency of the DIAMETER peer. Allow re-enabling it via the environment parameter 'diameter_nodelay' (false enables the Nagle). Change-Id: I1e62cdbcbbdb29a0a98f390b33cf14592079d579 --- M src/osmo_dia2gsup.erl 1 file changed, 15 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/26/40126/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40126?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I1e62cdbcbbdb29a0a98f390b33cf14592079d579 Gerrit-Change-Number: 40126 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

2 months, 2 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: add get_env/2 for convenience

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40123?usp=email ) Change subject: osmo_dia2gsup: add get_env/2 for convenience ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I4c6ce2899c8b41a81fd0278ad065ab65bfd0311d Gerrit-Change-Number: 40123 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Apr 2025 13:22:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 2 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: add and use parse_addr/1

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40124?usp=email ) Change subject: osmo_dia2gsup: add and use parse_addr/1 ...................................................................... osmo_dia2gsup: add and use parse_addr/1 Change-Id: If02c3486c937595fcc0d3813ab64445ebccb746e --- M src/osmo_dia2gsup.erl 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/24/40124/1 diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index 7c4f2c1..4986e7d 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -106,7 +106,7 @@ Port = get_env(diameter_port, 3868), Proto = get_env(diameter_proto, sctp), ConnectTimer = get_env(diameter_connect_timer, 30000), - listen(?SVC_NAME, {address, Proto, element(2,inet:parse_address(Ip)), Port}, {timer, ConnectTimer}), + listen(?SVC_NAME, {address, Proto, parse_addr(Ip), Port}, {timer, ConnectTimer}), lager:info("Diameter HSS Application started on IP ~s, ~p port ~p~n", [Ip, Proto, Port]), {ok, State}. @@ -156,3 +156,16 @@ tmod(tcp) -> diameter_tcp; tmod(sctp) -> diameter_sctp. + +parse_addr(AddrStr) when is_list(AddrStr) -> + {ok, Addr} = inet:parse_address(AddrStr), + Addr; + +parse_addr(addr) -> + case addr of + any -> any; + localhost -> localhost; + _ -> + true = inet:is_ip_address(addr), + addr + end. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40124?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: If02c3486c937595fcc0d3813ab64445ebccb746e Gerrit-Change-Number: 40124 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: move env parsing and logging to listen/1

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40125?usp=email ) Change subject: osmo_dia2gsup: move env parsing and logging to listen/1 ...................................................................... osmo_dia2gsup: move env parsing and logging to listen/1 In preparation for follow-up patches, make the listen/1 function self-contained by letting it consume the environment on its own. Change-Id: I8ca4cc0b830d281ada5ba56bc98a9511937b8b81 --- M src/osmo_dia2gsup.erl 1 file changed, 13 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/25/40125/1 diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index 4986e7d..98a766c 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -101,13 +101,7 @@ % DIAMETER side ProdName = atom_to_list(?MODULE), ok = diameter:start_service(?SVC_NAME, ?SERVICE(ProdName)), - - Ip = get_env(diameter_ip, "127.0.0.8"), - Port = get_env(diameter_port, 3868), - Proto = get_env(diameter_proto, sctp), - ConnectTimer = get_env(diameter_connect_timer, 30000), - listen(?SVC_NAME, {address, Proto, parse_addr(Ip), Port}, {timer, ConnectTimer}), - lager:info("Diameter HSS Application started on IP ~s, ~p port ~p~n", [Ip, Proto, Port]), + listen(?SVC_NAME), {ok, State}. %% @callback gen_server @@ -147,12 +141,19 @@ %% Internal Function Definitions %% ------------------------------------------------------------------ -listen(Name, {address, Protocol, IPAddr, Port}, {timer, ConnectTimer}) -> - TransOpts = [{transport_module, tmod(Protocol)}, - {transport_config, [{reuseaddr, true}, - {ip, IPAddr}, {port, Port}]}, +listen(Name) -> + LAddr = get_env(diameter_ip, "127.0.0.8"), + LPort = get_env(diameter_port, 3868), + Proto = get_env(diameter_proto, sctp), + ConnectTimer = get_env(diameter_connect_timer, 30000), + TransOpts = [{transport_module, tmod(Proto)}, + {transport_config, [{ip, parse_addr(LAddr)}, + {port, LPort}, + {reuseaddr, true}]}, {connect_timer, ConnectTimer}], - {ok, _} = diameter:add_transport(Name, {listen, TransOpts}). + {ok, _} = diameter:add_transport(Name, {listen, TransOpts}), + lager:info("Diameter HSS Application started on IP ~s, ~p port ~p~n", + [LAddr, Proto, LPort]). tmod(tcp) -> diameter_tcp; tmod(sctp) -> diameter_sctp. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40125?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I8ca4cc0b830d281ada5ba56bc98a9511937b8b81 Gerrit-Change-Number: 40125 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log