- gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: paging: Fix recalculate work timer if waiting for retrans
by laforge 06 May '22

06 May '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28052 ) Change subject: paging: Fix recalculate work timer if waiting for retrans ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28052 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7ce6f436286b50dc31331d218ff256cf7be3f619 Gerrit-Change-Number: 28052 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:44:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: paging: Improve logging
by laforge 06 May '22

06 May '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28051 ) Change subject: paging: Improve logging ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28051/comment/479327f6_99c6a2a9 PS1, Line 265: "Paging delayed: retransmission happens in %lld.%06ld\n", might make sense to add 's' to state the unit of time printed here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28051 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3186f841623cad8ed3296ac4d541e5cf4701132d Gerrit-Change-Number: 28051 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:43:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libgtpnl[master]: fix some cases of rc == 0 on error
by laforge 06 May '22

06 May '22

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/26990 ) Change subject: fix some cases of rc == 0 on error ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/26990 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I22fd69709e023572c6c616a4184340a554456faf Gerrit-Change-Number: 26990 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pablo <pablo(a)gnumonks.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:41:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-remsim[master]: rspro_client_fsm: Log clientConnectResult != ok
by laforge 06 May '22

06 May '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28056 ) Change subject: rspro_client_fsm: Log clientConnectResult != ok ...................................................................... rspro_client_fsm: Log clientConnectResult != ok This should aid debugging. Related: SYS#5950 Change-Id: I8f584640758be0cceab61dcb333c81374da3288b --- M src/asn1c_helpers.h M src/rspro_client_fsm.c 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve diff --git a/src/asn1c_helpers.h b/src/asn1c_helpers.h index 8d4e676..ac34a8f 100644 --- a/src/asn1c_helpers.h +++ b/src/asn1c_helpers.h @@ -1,5 +1,6 @@ #pragma once +#include <asn_application.h> struct asn_TYPE_descriptor_t; const char *asn_type_name(const asn_TYPE_descriptor_t *td); diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index bd07330..bd267ca 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -32,6 +32,7 @@ #include <osmocom/gsm/protocol/ipaccess.h> #include "debug.h" +#include "asn1c_helpers.h" #include "rspro_client_fsm.h" #define S(x) (1 << (x)) @@ -229,6 +230,8 @@ pdu = data; res = rspro_get_result(pdu); if (res != ResultCode_ok) { + LOGPFSML(fi, LOGL_ERROR, "Rx RSPRO connectClientRes(result=%s), closing\n", + asn_enum_name(&asn_DEF_ResultCode, res)); ipa_client_conn_close(srvc->conn); osmo_fsm_inst_dispatch(fi, SRVC_E_TCP_DOWN, NULL); } else { -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8f584640758be0cceab61dcb333c81374da3288b Gerrit-Change-Number: 28056 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-remsim[master]: rspro_client_fsm: Log clientConnectResult != ok
by laforge 06 May '22

06 May '22

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28056 ) Change subject: rspro_client_fsm: Log clientConnectResult != ok ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8f584640758be0cceab61dcb333c81374da3288b Gerrit-Change-Number: 28056 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:40:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-remsim[master]: bankd: Log more clearly if we fail to open a PC/SC reader
by laforge 06 May '22

06 May '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28055 ) Change subject: bankd: Log more clearly if we fail to open a PC/SC reader ...................................................................... bankd: Log more clearly if we fail to open a PC/SC reader Related: SYS#5950 Change-Id: I424f585a8a37f21806898e59e350201119645a21 --- M src/bankd/bankd_pcsc.c 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/bankd/bankd_pcsc.c b/src/bankd/bankd_pcsc.c index d7bb39c..ee01c93 100644 --- a/src/bankd/bankd_pcsc.c +++ b/src/bankd/bankd_pcsc.c @@ -237,13 +237,19 @@ &dwActiveProtocol); if (rc == SCARD_S_SUCCESS) result = 0; - else + else { LOGW_PCSC_ERROR(worker, rc, "SCardConnect"); + goto out_readerfree; + } break; } p += strlen(p) + 1; } + if (result < 0) + LOGW(worker, "Error: Cannot find PC/SC reader/slot matching using regex '%s'\n", worker->reader.name); + +out_readerfree: SCardFreeMemory(worker->reader.pcsc.hContext, mszReaders); out_regfree: -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I424f585a8a37f21806898e59e350201119645a21 Gerrit-Change-Number: 28055 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-remsim[master]: bankd: Log more clearly if we fail to open a PC/SC reader
by laforge 06 May '22

06 May '22

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28055 ) Change subject: bankd: Log more clearly if we fail to open a PC/SC reader ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I424f585a8a37f21806898e59e350201119645a21 Gerrit-Change-Number: 28055 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:40:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-remsim[master]: rspro_client_fsm: Log clientConnectResult != ok
by laforge 06 May '22

06 May '22

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28056 ) Change subject: rspro_client_fsm: Log clientConnectResult != ok ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8f584640758be0cceab61dcb333c81374da3288b Gerrit-Change-Number: 28056 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:40:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ttcn3-hacks[master]: msc: add test for OS#5532: crash from CM Serv Rej
by laforge 06 May '22

06 May '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28048 ) Change subject: msc: add test for OS#5532: crash from CM Serv Rej ...................................................................... msc: add test for OS#5532: crash from CM Serv Rej Reproduce the assertion trigger crashing osmo-msc reported in OS#5532, i.e. a CM Service Request that contains a mismatching Mobile Identity. Causes osmo-msc to crash with an assertion, so run it last. Fix of the crash: I6c735b79b67108bcaadada3f01c7046e262f939b Related: OS#5532 Depends: I6c735b79b67108bcaadada3f01c7046e262f939b (osmo-msc) Change-Id: I3f84d00f456aaee578787059d7010c25efcdcf56 --- M msc/MSC_Tests.ttcn 1 file changed, 28 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 2fad7b4..5bf199c 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -6801,6 +6801,32 @@ vc_conn2.done; } +/* Establish a conn with a valid Mobile Identity. Then send a CM Service Request containing a mismatching Mobile + * Identity on the same conn. Caused a crash, see OS#5532. */ +friend function f_tc_cm_serv_wrong_mi(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + f_init_handler(pars); + + /* Set up a fully identified conn */ + f_perform_lu(); + f_establish_fully(); + + /* CM Serv Req with mismatching Mobile Identity */ + var MobileIdentityLV mi := valueof(ts_MI_IMSI_LV(f_gen_imsi(99999))); /* ensure it is different from below*/ + BSSAP.send(ts_PDU_DTAP_MO(ts_CM_SERV_REQ(CM_TYPE_MO_SMS, mi))); + BSSAP.receive(tr_PDU_DTAP_MT(tr_CM_SERV_REJ)); + + /* Cancel the first CM Service from f_establish_fully() */ + BSSAP.send(ts_BSSMAP_ClearRequest(0)); + + f_expect_clear(); +} +testcase TC_cm_serv_wrong_mi() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_tc_cm_serv_wrong_mi), 94); + vc_conn.done; +} + control { execute( TC_cr_before_reset() ); execute( TC_lu_imsi_noauth_tmsi() ); @@ -6963,6 +6989,8 @@ execute( TC_call_re_establishment() ); execute( TC_call_re_establishment_auth() ); execute( TC_call_re_establishment_ciph() ); + + execute( TC_cm_serv_wrong_mi() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28048 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3f84d00f456aaee578787059d7010c25efcdcf56 Gerrit-Change-Number: 28048 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-ttcn3-hacks[master]: msc: add test for OS#5532: crash from CM Serv Rej
by laforge 06 May '22

06 May '22

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28048 ) Change subject: msc: add test for OS#5532: crash from CM Serv Rej ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28048 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3f84d00f456aaee578787059d7010c25efcdcf56 Gerrit-Change-Number: 28048 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:40:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log