- gerrit-log - lists.osmocom.org

Change in osmo-cbc[master]: cbc: Don't crash if peer->remote_host is NULL
by fixeria 06 May '22

06 May '22

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28057 ) Change subject: cbc: Don't crash if peer->remote_host is NULL ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28057 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I455e61f379f042680cdd2600a08d57a1ea22897c Gerrit-Change-Number: 28057 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 06 May 2022 10:24:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: bts.c: prevent signed integer overflow in depends_on code
by laforge 06 May '22

06 May '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28058 ) Change subject: bts.c: prevent signed integer overflow in depends_on code ...................................................................... bts.c: prevent signed integer overflow in depends_on code bts.c:818:37: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' Change-Id: Ic68e6eb11fb70bf68d3f075fe2e467aedcbfaba8 --- M src/osmo-bsc/bts.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/58/28058/1 diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 5786833..df8d93d 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -798,7 +798,7 @@ int idx, bit; depends_calc_index_bit(dep, &idx, &bit); - bts->depends_on[idx] |= 1 << bit; + bts->depends_on[idx] |= 1U << bit; } void bts_depend_clear(struct gsm_bts *bts, int dep) @@ -806,7 +806,7 @@ int idx, bit; depends_calc_index_bit(dep, &idx, &bit); - bts->depends_on[idx] &= ~(1 << bit); + bts->depends_on[idx] &= ~(1U << bit); } int bts_depend_is_depedency(struct gsm_bts *base, struct gsm_bts *other) @@ -815,7 +815,7 @@ depends_calc_index_bit(other->nr, &idx, &bit); /* Check if there is a depends bit */ - return (base->depends_on[idx] & (1 << bit)) > 0; + return (base->depends_on[idx] & (1U << bit)) > 0; } static int bts_is_online(struct gsm_bts *bts) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28058 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic68e6eb11fb70bf68d3f075fe2e467aedcbfaba8 Gerrit-Change-Number: 28058 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in osmo-cbc[master]: cbc: Don't crash if peer->remote_host is NULL
by laforge 06 May '22

06 May '22

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28057 ) Change subject: cbc: Don't crash if peer->remote_host is NULL ...................................................................... cbc: Don't crash if peer->remote_host is NULL As the peer->remote_host is initially NULL when creating a CBC peer, the code should tolerate this. The situation arises in two cases: * if a peer is created by VTY but without any subequent 'remote-ip' statement * if a peer is auto-created by 'unknown-peers accept' Closes: OS#5506 Change-Id: I455e61f379f042680cdd2600a08d57a1ea22897c --- M src/cbc_data.c M src/cbc_vty.c 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/57/28057/1 diff --git a/src/cbc_data.c b/src/cbc_data.c index d1d20f1..60c0998 100644 --- a/src/cbc_data.c +++ b/src/cbc_data.c @@ -99,6 +99,8 @@ struct cbc_peer *peer; llist_for_each_entry(peer, &g_cbc->peers, list) { + if (!peer->remote_host) + continue; if (!strcasecmp(remote_host, peer->remote_host)) { if (peer->remote_port == -1) return peer; diff --git a/src/cbc_vty.c b/src/cbc_vty.c index f0c34d6..b45fbd4 100644 --- a/src/cbc_vty.c +++ b/src/cbc_vty.c @@ -48,7 +48,8 @@ } vty_out(vty, "|%-20s| %-15s| %-5d| %-6s| %-20s|%s", - peer->name ? peer->name : "<unnamed>", peer->remote_host, peer->remote_port, + peer->name ? peer->name : "<unnamed>", + peer->remote_host ? peer->remote_host : "<unset>", peer->remote_port, get_value_string(cbc_peer_proto_name, peer->proto), state, VTY_NEWLINE); } @@ -488,7 +489,8 @@ vty_out(vty, " no remote-port%s", VTY_NEWLINE); else vty_out(vty, " remote-port %d%s", peer->remote_port, VTY_NEWLINE); - vty_out(vty, " remote-ip %s%s", peer->remote_host, VTY_NEWLINE); + if (peer->remote_host) + vty_out(vty, " remote-ip %s%s", peer->remote_host, VTY_NEWLINE); } static int config_write_peer(struct vty *vty) -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28057 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I455e61f379f042680cdd2600a08d57a1ea22897c Gerrit-Change-Number: 28057 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

Change in pysim[master]: ts_102_222: Set number of records when creating linear files
by Christian Amsüss 06 May '22

06 May '22

Attention is currently required from: laforge. Christian Amsüss has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27825 ) Change subject: ts_102_222: Set number of records when creating linear files ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > the question now is: does this break on SJA2 cards, or do we need a card-specific workaround? I tested it on one of them, they accept the full command. (I did not test what they do if there is a conflict between the file size and the number of records, but AIU pysim won't produce such ambiguous requests anyway). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27825 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8aeb869c601ee5d1c8b02da6d72eb3c50e347982 Gerrit-Change-Number: 27825 Gerrit-PatchSet: 1 Gerrit-Owner: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 06 May 2022 08:40:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: osmo-bts-trx: drop Uplink loss detection from Downlink path
by laforge 06 May '22

06 May '22

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20674 ) Change subject: osmo-bts-trx: drop Uplink loss detection from Downlink path ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic292d180ba64206fb4d88adb284f9f9d058b4587 Gerrit-Change-Number: 20674 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:58:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: bts_ipa: Send NM_EV_OML_DOWN following object tree in order
by laforge 06 May '22

06 May '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28044 ) Change subject: bts_ipa: Send NM_EV_OML_DOWN following object tree in order ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28044 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I90a70957dc3fd434ccd82bf2fa8d8c2c59f08059 Gerrit-Change-Number: 28044 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:51:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: nm_is_running(): Drop duplicate check
by laforge 06 May '22

06 May '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28040 ) Change subject: nm_is_running(): Drop duplicate check ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28040 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idac56e5eca2b6f6998195ec764fac7edbc8f53e2 Gerrit-Change-Number: 28040 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:50:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: Update current NM object state before signalling S_NM_STATECHG
by laforge 06 May '22

06 May '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28039 ) Change subject: Update current NM object state before signalling S_NM_STATECHG ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: are we sure all users are fine with that kind of change? esentially the old signal is a 'pre-state-change' signal, and you're now turning it into a [new] post-state-change signal -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28039 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib46234e3f3e446e866d27b0dfee65edf4af4d2ba Gerrit-Change-Number: 28039 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:50:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: nm_statechg_signal_data: Convert state ptr to data
by laforge 06 May '22

06 May '22

Attention is currently required from: pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28038 ) Change subject: nm_statechg_signal_data: Convert state ptr to data ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/28038/comment/373e21ba_2a85d4d5 PS3, Line 11: fro mem for? https://gerrit.osmocom.org/c/osmo-bsc/+/28038/comment/c168191c_e4cef8e9 PS3, Line 16: easies eases -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28038 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9b648dfd8392b7b40bfe2b38f3345017481f5129 Gerrit-Change-Number: 28038 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:49:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: paging: Avoid unnecessary immediate polling in mainloop
by laforge 06 May '22

06 May '22

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28053 ) Change subject: paging: Avoid unnecessary immediate polling in mainloop ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28053/comment/ca580fdc_dd65e9bd PS1, Line 472: if (tdiff.tv_sec == 0 && tdiff.tv_nsec == 0) you might even to one step further and also catch small non_zero tv_nsec. Like (tdiff.tv_sec == 0 && tdiff.tv_nsec < 5000) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28053 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie767bdc8d4353aafe375a424e02d698ef7fd3dea Gerrit-Change-Number: 28053 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:45:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log