Attention is currently required from: neels, pespin, msuraev.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28892 )
Change subject: BSSMAP: add assert to reset resending
......................................................................
Patch Set 3:
(1 comment)
File src/osmo-bsc/bssmap_reset.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28892/comment/23834c9a_1fdb0bae
PS2, Line 249: LOGP(DMSC, LOGL_ERROR, "Attempt to reset non-existent BSSMAP\n");
> No caller should call this function with a NULL argument. […]
The thing also is, even if someone calls it with a NULL pointer it immediately crashes anyway. I think asserts are helpful when the null pointer is not causing an immediate crash (e.g. stored in some priv struct and then the crash happens way later)
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28892
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I235bdd42ea82e7b5a1a40f437ca34c49ad239c48
Gerrit-Change-Number: 28892
Gerrit-PatchSet: 3
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Aug 2022 08:18:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29148 )
Change subject: configure: generate libosmo-gprs.spec from libosmo-gprs.spec.in
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29148
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Ie15c136d9f1919da0217b17d1afa9268f7ceaab1
Gerrit-Change-Number: 29148
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Aug 2022 08:14:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o…
Package network:osmocom:nightly/osmo-upf failed to build in openSUSE_Leap_15.1_ARM/armv7l
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-upf
Last lines of build log:
[ 76s] checking for pkg-config... /usr/bin/pkg-config
[ 76s] checking for armv7hl-suse-linux-gnueabi-pkg-config... /usr/bin/armv7hl-suse-linux-gnueabi-pkg-config
[ 76s] checking pkg-config is at least version 0.20... yes
[ 76s] checking for libosmocore >= 1.5.0... yes
[ 76s] checking for libosmovty >= 1.5.0... yes
[ 76s] checking for libosmoctrl >= 1.5.0... yes
[ 76s] checking for libosmo-gtlv >= 0.1.0... no
[ 76s] configure: error: Package requirements (libosmo-gtlv >= 0.1.0) were not met:
[ 76s]
[ 76s] No package 'libosmo-gtlv' found
[ 76s]
[ 76s] Consider adjusting the PKG_CONFIG_PATH environment variable if you
[ 76s] installed software in a non-standard prefix.
[ 76s]
[ 76s] Alternatively, you may set the environment variables LIBOSMOGTLV_CFLAGS
[ 76s] and LIBOSMOGTLV_LIBS to avoid the need to call pkg-config.
[ 76s] See the pkg-config man page for more details.
[ 76s] error: Bad exit status from /var/tmp/rpm-tmp.6zoJdv (%build)
[ 76s]
[ 76s]
[ 76s] RPM build errors:
[ 76s] Bad exit status from /var/tmp/rpm-tmp.6zoJdv (%build)
[ 76s] ### VM INTERACTION START ###
[ 77s] [ 66.303515] sysrq: SysRq : Power Off
[ 77s] [ 66.304843] reboot: Power down
[ 77s] ### VM INTERACTION END ###
[ 77s]
[ 77s] armbuild02 failed "build osmo-upf.spec" at Thu Aug 18 01:07:37 UTC 2022.
[ 77s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)