fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29148 )
Change subject: configure: generate libosmo-gprs.spec from libosmo-gprs.spec.in
......................................................................
configure: generate libosmo-gprs.spec from libosmo-gprs.spec.in
Change-Id: Ie15c136d9f1919da0217b17d1afa9268f7ceaab1
---
M .gitignore
M Makefile.am
M configure.ac
3 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/48/29148/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29148
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Ie15c136d9f1919da0217b17d1afa9268f7ceaab1
Gerrit-Change-Number: 29148
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: osmith.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29114 )
Change subject: contrib/libosmo-gprs.spec.in: properly define RPM packages
......................................................................
Patch Set 3:
(2 comments)
File contrib/libosmo-gprs.spec.in:
https://gerrit.osmocom.org/c/libosmo-gprs/+/29114/comment/400a46a3_4623629d
PS2, Line 46: Group: System/Libraries
> Why changing tabs to spaces?
Nevermind. I see other osmo-projects use spaces in their *.spec files, so let's be consistent.
https://gerrit.osmocom.org/c/libosmo-gprs/+/29114/comment/d3961939_2283e191
PS2, Line 56: Requires: libosmo-csn1-devel = %{version}
> Why changing tabs to spaces?
See above.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29114
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I9be45c43ba3e342e1dba4b60561880c00841f549
Gerrit-Change-Number: 29114
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 22:29:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
Hello osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/29114
to look at the new patch set (#3).
Change subject: contrib/libosmo-gprs.spec.in: properly define RPM packages
......................................................................
contrib/libosmo-gprs.spec.in: properly define RPM packages
Co-Authored-By: Oliver Smith <osmith(a)sysmocom.de>
Change-Id: I9be45c43ba3e342e1dba4b60561880c00841f549
---
M contrib/libosmo-gprs.spec.in
1 file changed, 77 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/14/29114/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29114
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I9be45c43ba3e342e1dba4b60561880c00841f549
Gerrit-Change-Number: 29114
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: osmith.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29114 )
Change subject: contrib/libosmo-gprs.spec.in: properly define RPM packages
......................................................................
Patch Set 2:
(5 comments)
File contrib/libosmo-gprs.spec.in:
https://gerrit.osmocom.org/c/libosmo-gprs/+/29114/comment/fba3c685_99a5c545
PS2, Line 44: Osmocom GPRS RLC/MAC library
Good catch, thanks for fixing this.
https://gerrit.osmocom.org/c/libosmo-gprs/+/29114/comment/b9a33ba7_6b1606ac
PS2, Line 46: Group: System/Libraries
Why changing tabs to spaces?
https://gerrit.osmocom.org/c/libosmo-gprs/+/29114/comment/c3ba2519_8ddc5e30
PS2, Line 56: Requires: libosmo-csn1-devel = %{version}
Why changing tabs to spaces?
https://gerrit.osmocom.org/c/libosmo-gprs/+/29114/comment/aa391254_2a8d29b8
PS2, Line 72: --includedir="%_includedir/%name"
Both --disable-static and --enable-shared are implicit defaults.
I guess missing --includedir was the problem?
https://gerrit.osmocom.org/c/libosmo-gprs/+/29114/comment/18230766_54fff924
PS2, Line 77: find "%buildroot/%_libdir" -type f -name "*.la" -delete
Interesting. This is something I also noticed while looking at *.spec files in other Osmocom projects: *-dev packages for Debian usually include lib*.{a,la,so} files, while *-devel packages for RPM based distributions do not include lib*.{a,la}. Why do we remove *.la files here if we don't list them below anyway?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29114
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I9be45c43ba3e342e1dba4b60561880c00841f549
Gerrit-Change-Number: 29114
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 21:57:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith, neels.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29119 )
Change subject: osmocom-list-commits: use proper git clone urls
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> This is really weird. It's available at git.osmocom.org over git://, but not over https://.
I created https://osmocom.org/issues/5650 to track this.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29119
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I2acb9880be57411f11805a2195076b514156aaf3
Gerrit-Change-Number: 29119
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 20:56:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith, neels.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29119 )
Change subject: osmocom-list-commits: use proper git clone urls
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Hmm, so AFAIU, osmo-upf is not available over git.osmocom.org, but only via gerrit.osmocom. […]
This is really weird. It's available at git.osmocom.org over git://, but not over https://.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29119
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I2acb9880be57411f11805a2195076b514156aaf3
Gerrit-Change-Number: 29119
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 20:38:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29119 )
Change subject: osmocom-list-commits: use proper git clone urls
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Hmm, so AFAIU, osmo-upf is not available over git.osmocom.org, but only via gerrit.osmocom.org?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29119
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I2acb9880be57411f11805a2195076b514156aaf3
Gerrit-Change-Number: 29119
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 20:35:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment