- gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Fix race conditions during PFCP Association
by pespin 23 Feb '26

23 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42182?usp=email ) Change subject: hnbgw: Fix race conditions during PFCP Association ...................................................................... hnbgw: Fix race conditions during PFCP Association Since osmo-hnbgw now sends Heartbeat Requests, we need to take that into account. Furthermore, since it also now supports retriggering association when detecting peer restarted upon rx of Heartbeat Req, use that to trigger an association to clean up state and have a deterministic way to synchronize at that point regarding state. Change-Id: If62bd6c6e4d6cf73791029172d3d8880629f36a8 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 73 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/42182/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 996b846..cdd3db0 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -290,6 +290,69 @@ f_PFCPEM_unsubscribe_bcast(); } +altstep as_pfcp_handle_heartbeat_req(integer tx_recovery_timestamp) +runs on PFCP_ConnHdlr { + var PDU_PFCP m; + + [] PFCP.receive(tr_PFCP_Heartbeat_Req) -> value m { + var PDU_PFCP tx_pfcp; + tx_pfcp := valueof(ts_PFCP_Heartbeat_Resp(tx_recovery_timestamp)); + tx_pfcp.sequence_number := m.sequence_number; + PFCP.send(tx_pfcp); + } +} + +/* Notify peer that we restarted, it will then try to associate again. */ +private function f_pfcp_force_assoc_setup_req(boolean fail_timeout := true, + boolean fail_rx_others := true, + float wait_timeout := 16.0) +runs on PFCP_ConnHdlr { + var boolean rx_hb_resp := false; + var boolean rx_assoc_setup_req := false; + var integer rts := f_PFCPEM_get_recovery_timestamp(); + var PDU_PFCP m; + timer T := wait_timeout; + + /* ask PFCPEM to route all PDUs to us */ + f_PFCPEM_subscribe_bcast(); + + T.start; + PFCP.send(ts_PFCP_Heartbeat_Req(rts)); + alt { + [not rx_hb_resp] PFCP.receive(tr_PFCP_Heartbeat_Resp) { + rx_hb_resp := true; + if (not rx_assoc_setup_req) { + repeat; + } + } + [not rx_assoc_setup_req] PFCP.receive(tr_PFCP_Assoc_Setup_Req()) -> value m { + rx_assoc_setup_req := true; + PFCP.send(ts_PFCP_Assoc_Setup_Resp(m.sequence_number, ts_PFCP_Node_ID_fqdn(mp_pfcp_upf_node_id), + ts_PFCP_Cause(REQUEST_ACCEPTED), 1234)); + if (not rx_hb_resp) { + repeat; + } + } + [] as_pfcp_handle_heartbeat_req(rts) { repeat; } + [fail_rx_others] PFCP.receive(PDU_PFCP:?) -> value m { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Got an unexpected PFCP message ", m, " vs exp ", tr_PFCP_Assoc_Setup_Req())); + } + [fail_timeout] T.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Timeout waiting for PFCP ", tr_PFCP_Assoc_Setup_Req())); + } + [not fail_timeout] T.timeout { + log("Timeout waiting for PFCP ", tr_PFCP_Assoc_Setup_Req()); + } + } + T.stop; + setverdict(pass); + + /* ask PFCPEM to *not* route all PDUs to us anymore */ + f_PFCPEM_unsubscribe_bcast(); +} + function f_init_pfcp(charstring id) runs on test_CT { id := id & "-PFCP"; @@ -312,13 +375,16 @@ /* Temporarily access Statsd during test startup: */ connect(self:STATSD_PROC, vc_STATSD:STATSD_PROC); - if (not f_statsd_pfcp_associated()) { - connect(self:PFCP, vc_PFCP:CLIENT); - connect(self:PFCP_PROC, vc_PFCP:CLIENT_PROC); + connect(self:PFCP, vc_PFCP:CLIENT); + connect(self:PFCP_PROC, vc_PFCP:CLIENT_PROC); + /* the non-nightly path can be removed once osmo-hnbgw >1.8.1 is released. */ + if (Misc_Helpers.f_osmo_repo_is("nightly")) { + f_pfcp_force_assoc_setup_req(fail_timeout := true); + } else { f_pfcp_wait_assoc_setup_req(fail_timeout := true); - disconnect(self:PFCP, vc_PFCP:CLIENT); - disconnect(self:PFCP_PROC, vc_PFCP:CLIENT_PROC); } + disconnect(self:PFCP, vc_PFCP:CLIENT); + disconnect(self:PFCP_PROC, vc_PFCP:CLIENT_PROC); disconnect(self:STATSD_PROC, vc_STATSD:STATSD_PROC); } @@ -2769,7 +2835,6 @@ * existing subscriber connections: */ private function f_TC_pfcp_heartbeat_recovery_timestamp(charstring id) runs on ConnHdlr { var RANAP_PDU tx; - var PDU_PFCP rx_pfcp, tx_pfcp; var StatsDExpects expect_disconnected := { {name := f_upf_ctr_prefix(0) & "pfcp_associated", mtype := "g", min := 0, max := 0} }; @@ -2782,20 +2847,14 @@ f_PFCPEM_subscribe_bcast(); var integer recovery := f_PFCPEM_get_recovery_timestamp(); - PFCP.receive(tr_PFCP_Heartbeat_Req) -> value rx_pfcp; - tx_pfcp := valueof(ts_PFCP_Heartbeat_Resp(recovery)); - tx_pfcp.sequence_number := rx_pfcp.sequence_number; - PFCP.send(tx_pfcp); + as_pfcp_handle_heartbeat_req(recovery); tx := f_build_initial_ue(g_pars); f_iuh2iu_connect(tx); f_create_rab_ps(); recovery := recovery + 1; - PFCP.receive(tr_PFCP_Heartbeat_Req) -> value rx_pfcp; - tx_pfcp := valueof(ts_PFCP_Heartbeat_Resp(recovery)); - tx_pfcp.sequence_number := rx_pfcp.sequence_number; - PFCP.send(tx_pfcp); + as_pfcp_handle_heartbeat_req(recovery); /* Wait for IUT to detect peer went down after Heartbeat Response with changed Recovery: */ f_statsd_expect(expect_disconnected, wait_converge := true); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42182?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If62bd6c6e4d6cf73791029172d3d8880629f36a8 Gerrit-Change-Number: 42182 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-asf4-dfu[master]: Improve comments on errata 2.6.10
by lynxis lazus 23 Feb '26

23 Feb '26

Attention is currently required from: Hoernchen. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42168?usp=email ) Change subject: Improve comments on errata 2.6.10 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Additionally the explanation is wrong, to, this is not fixed by "wdt enable & disable". And what is the correct explanation? -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42168?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I3c35f590a4e43d778e70f2f377e0d470c3a652b2 Gerrit-Change-Number: 42168 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 13:01:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>

1 0

[S] Change in osmo-asf4-dfu[master]: Improve comments on errata 2.6.10
by Hoernchen 23 Feb '26

23 Feb '26

Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42168?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: Improve comments on errata 2.6.10 ...................................................................... Patch Set 1: Code-Review-2 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42168?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I3c35f590a4e43d778e70f2f377e0d470c3a652b2 Gerrit-Change-Number: 42168 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Feb 2026 12:17:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-asf4-dfu[master]: Improve comments on errata 2.6.10
by Hoernchen 23 Feb '26

23 Feb '26

Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42168?usp=email ) Change subject: Improve comments on errata 2.6.10 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Additionally the explanation is wrong, to, this is not fixed by "wdt enable & disable". -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42168?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I3c35f590a4e43d778e70f2f377e0d470c3a652b2 Gerrit-Change-Number: 42168 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Feb 2026 12:17:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-asf4-dfu[master]: Improve comments on errata 2.6.10
by Hoernchen 23 Feb '26

23 Feb '26

Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42168?usp=email ) Change subject: Improve comments on errata 2.6.10 ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: What is "Workaround: Start low level priority watchdog." supposed to be? -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42168?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I3c35f590a4e43d778e70f2f377e0d470c3a652b2 Gerrit-Change-Number: 42168 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Feb 2026 12:16:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-asf4-dfu[master]: dfu: fix bState transition/reporting order as per dfu spec
by laforge 23 Feb '26

23 Feb '26

Attention is currently required from: Hoernchen, lynxis lazus, pespin. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42178?usp=email ) Change subject: dfu: fix bState transition/reporting order as per dfu spec ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42178?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I06519c73cdb0b082002632da9cfe7436c63f52b0 Gerrit-Change-Number: 42178 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Feb 2026 11:59:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: do not reset itself
by laforge 23 Feb '26

23 Feb '26

Attention is currently required from: Hoernchen, lynxis lazus. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42180?usp=email ) Change subject: dfu: do not reset itself ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42180?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I1b9e48470083597640918a8a1126922b31150153 Gerrit-Change-Number: 42180 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Feb 2026 11:59:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: do not reset itself
by Hoernchen 23 Feb '26

23 Feb '26

Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42180?usp=email ) Change subject: dfu: do not reset itself ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42180?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I1b9e48470083597640918a8a1126922b31150153 Gerrit-Change-Number: 42180 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 23 Feb 2026 11:35:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in osmo-asf4-dfu[master]: dfu: fix bState transition/reporting order as per dfu spec
by Hoernchen 23 Feb '26

23 Feb '26

Attention is currently required from: pespin. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42178?usp=email ) Change subject: dfu: fix bState transition/reporting order as per dfu spec ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > wasn't this just submitted by @lynxis@fe80. […] This whole patchset is from last thursday when I had a look at the state of dfu-util return values and was tested as-is. -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42178?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I06519c73cdb0b082002632da9cfe7436c63f52b0 Gerrit-Change-Number: 42178 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Feb 2026 11:33:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-asf4-dfu[master]: dfu: rewrite firmware downloading
by pespin 23 Feb '26

23 Feb '26

Attention is currently required from: Hoernchen, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email ) Change subject: dfu: rewrite firmware downloading ...................................................................... Patch Set 2: (1 comment) File usb_start.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/ee13aa79_c1ae915… : PS2, Line 171: /* FIXME: check if dfu_download_offset / length are valid */ > Need to lookup the flash_write() if it already handles it. […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I345d5948455b25cd8a2efb1abfd9d0986ebd8cef Gerrit-Change-Number: 42174 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Feb 2026 11:24:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log