- gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: stp: Enable tracking of NULL memory context
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: stp: Enable tracking of NULL memory context ...................................................................... stp: Enable tracking of NULL memory context Similar to what's done in most of the OsmoCNI programs. This allows dumpinng the NULL context using VTY command 'show talloc-context all'. Change-Id: I4a925967e5bb61c346cf6c4dd2c89b6aaea44b94 --- M stp/stp_main.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/13/42213/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4a925967e5bb61c346cf6c4dd2c89b6aaea44b94 Gerrit-Change-Number: 42213 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: tcap: Avoid updating trans_track if AS doesn't have tcap-routing enabled
by pespin 26 Feb '26

26 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42207?usp=email ) Change subject: tcap: Avoid updating trans_track if AS doesn't have tcap-routing enabled ...................................................................... tcap: Avoid updating trans_track if AS doesn't have tcap-routing enabled Change-Id: I0106df80f6c186b184bada8f06d38d0d54cce735 --- M src/ipa.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/ipa.c b/src/ipa.c index 29dc5c0..2f48167 100644 --- a/src/ipa.c +++ b/src/ipa.c @@ -309,8 +309,10 @@ /* Third, patch this into the SCCP message and create M3UA message in XUA structure */ data_hdr.si = MTP_SI_SCCP; #ifdef WITH_TCAP_LOADSHARING - /* update TCAP Transaction Tracking (Rx) */ - tcap_as_rx_sccp_asp(as, asp, opc, dpc, msg); + if (as->cfg.loadshare.tcap.enabled) { + /* update TCAP Transaction Tracking (Rx) */ + tcap_as_rx_sccp_asp(as, asp, opc, dpc, msg); + } #endif /* WITH_TCAP_LOADSHARING */ if (as->cfg.pc_override.sccp_mode == OSMO_SS7_PATCH_BOTH) { struct msgb *msg_patched = patch_sccp_with_pc(asp, msg, opc, dpc); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0106df80f6c186b184bada8f06d38d0d54cce735 Gerrit-Change-Number: 42207 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: tcap: Avoid updating trans_track if AS doesn't have tcap-routing enabled
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: daniel. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42207?usp=email ) Change subject: tcap: Avoid updating trans_track if AS doesn't have tcap-routing enabled ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0106df80f6c186b184bada8f06d38d0d54cce735 Gerrit-Change-Number: 42207 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 11:53:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: tcap: Fix return code in tcap_as_rx_sccp_asp()
by laforge 26 Feb '26

26 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email ) Change subject: tcap: Fix return code in tcap_as_rx_sccp_asp() ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: > IMHO that function is tcap related (and allows it to quickly find it in tcap related routines files) […] Ok, maybe best to update the function documentation comment about this notion. File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210/comment/bbc0491e_5d1ae… : PS1, Line 293: Destination unrelated: This should actually say "Source Address", it looks like a copy+paste from below -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I54c4a1bbaa8e107cf433cc898658a672c2b53c3c Gerrit-Change-Number: 42210 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 11:49:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: tcap: Avoid updating trans_track if AS doesn't have tcap-routing enabled
by lynxis lazus 26 Feb '26

26 Feb '26

Attention is currently required from: daniel, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42207?usp=email ) Change subject: tcap: Avoid updating trans_track if AS doesn't have tcap-routing enabled ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Looks correct. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0106df80f6c186b184bada8f06d38d0d54cce735 Gerrit-Change-Number: 42207 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 11:41:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap: Lower log level failing to parse msg
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42211?usp=email ) Change subject: tcap: Lower log level failing to parse msg ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > How often do such ERROR messages show up? […] Stuff coming from peers is not expected to be ERROR but NOTICE imho. ERROR is for internal system errors or bad configuration, unexpected scenarios, etc. not stuff coming from the outside. We may have some peer we don't control constantly sending garbage to us. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42211?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Idef5736ee2481260f958eece2f5a3bfc009b3d69 Gerrit-Change-Number: 42211 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 11:40:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: stp: Enable tracking of NULL memory context
by fixeria 26 Feb '26

26 Feb '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213?usp=email ) Change subject: stp: Enable tracking of NULL memory context ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File stp/stp_main.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213/comment/75d6bcf3_5f4a6… : PS1, Line 220: talloc_enable_null_tracking I know we already do this in many projects (and not voting against doing this), but there must be a reason why it's disabled by default in talloc. One thing that comes to my mind is potential performance impact. If this is a concern, we may want to enable NULL-tracking conditionally by introducing an environment variable. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4a925967e5bb61c346cf6c4dd2c89b6aaea44b94 Gerrit-Change-Number: 42213 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 11:37:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: stp: Enable tracking of NULL memory context
by laforge 26 Feb '26

26 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213?usp=email ) Change subject: stp: Enable tracking of NULL memory context ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4a925967e5bb61c346cf6c4dd2c89b6aaea44b94 Gerrit-Change-Number: 42213 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 11:37:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap: Support TID with length 1..4
by laforge 26 Feb '26

26 Feb '26

Attention is currently required from: daniel, lynxis lazus, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email ) Change subject: tcap: Support TID with length 1..4 ...................................................................... Patch Set 2: (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212/comment/8e1d7136_cee3b… : PS2, Line 81: OSMO_ASSERT > Might be worth checking if the ASN.1 decoder actually returns an error. exactly. And even if it does now under some circumstances implement those constraint checks in the decoder, that might change with future versions of asn1c. I think in general we should never assert for anything that relates to a received packet, whether in direct representation or some transformation like an asn1decode. We just treat the packet as invalid, log + rate_ctr that and continue to work as usual. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2748d85624e4be708f7554ee3e60a5bda9162845 Gerrit-Change-Number: 42212 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 26 Feb 2026 11:36:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tcap: Support TID with length 1..4
by fixeria 26 Feb '26

26 Feb '26

Attention is currently required from: daniel, laforge, lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email ) Change subject: tcap: Support TID with length 1..4 ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212/comment/0caa4139_ea31c… : PS2, Line 81: OSMO_ASSERT > My understanding is that since asn1 states "OrigTransactionID ::= [APPLICATION 8] IMPLICIT OCTET STR […] Might be worth checking if the ASN.1 decoder actually returns an error. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2748d85624e4be708f7554ee3e60a5bda9162845 Gerrit-Change-Number: 42212 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 26 Feb 2026 11:30:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log