Attention is currently required from: osmith, pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email )
Change subject: lint/checkpatch: support multiple configs
......................................................................
Patch Set 1:
(1 comment)
File lint/lint_all.sh:
https://gerrit.osmocom.org/c/osmo-ci/+/42215/comment/3009a604_02aa63ab?usp=… :
PS1, Line 19: echo "" | "$SCRIPT_DIR"/checkpatch/checkpatch.pl \
> actually it is only needed below, here checkpatch.pl gets called directly, will update the patch.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ia2e75d9783382cefc3900a4ab51a5a919a2cbbbc
Gerrit-Change-Number: 42215
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Feb 2026 13:22:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith, pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: lint/checkpatch: support multiple configs
......................................................................
lint/checkpatch: support multiple configs
Run checkpatch with any .checkpatch*.conf found in the project dir. This
is in preparation for having two .checkpatch.conf files in osmo-trx, in
order to use different linting rules for C++ code:
* .checkpatch.c.conf
* .checkpatch.c++.conf
Related: osmo-trx I0df5b6f2f0bf1469a80a1f5859809c30f523f683
Change-Id: Ia2e75d9783382cefc3900a4ab51a5a919a2cbbbc
---
M .gitignore
M lint/checkpatch/checkpatch.pl
M lint/checkpatch/checkpatch_json.py
M lint/checkpatch/checkpatch_osmo.sh
M lint/lint_all.sh
5 files changed, 74 insertions(+), 47 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/15/42215/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ia2e75d9783382cefc3900a4ab51a5a919a2cbbbc
Gerrit-Change-Number: 42215
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email )
Change subject: lint/checkpatch: support multiple configs
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ia2e75d9783382cefc3900a4ab51a5a919a2cbbbc
Gerrit-Change-Number: 42215
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Feb 2026 13:21:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email )
Change subject: lint/checkpatch: support multiple configs
......................................................................
Patch Set 1:
(1 comment)
File lint/lint_all.sh:
https://gerrit.osmocom.org/c/osmo-ci/+/42215/comment/f31022a6_88ebaa89?usp=… :
PS1, Line 19: echo "" | "$SCRIPT_DIR"/checkpatch/checkpatch.pl \
> The other script `lint/lint_diff.sh` passes `git diff -U0 $COMMIT` on stdin to `checkpatch_osmo.sh`. […]
actually it is only needed below, here checkpatch.pl gets called directly, will update the patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ia2e75d9783382cefc3900a4ab51a5a919a2cbbbc
Gerrit-Change-Number: 42215
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Feb 2026 13:21:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email )
Change subject: lint/checkpatch: support multiple configs
......................................................................
Patch Set 1:
(1 comment)
File lint/lint_all.sh:
https://gerrit.osmocom.org/c/osmo-ci/+/42215/comment/9b76ac60_ad68ed2c?usp=… :
PS1, Line 19: echo "" | "$SCRIPT_DIR"/checkpatch/checkpatch.pl \
> why is this echo needed now?
The other script `lint/lint_diff.sh` passes `git diff -U0 $COMMIT` on stdin to `checkpatch_osmo.sh`. This needs to be stored in a temp file and sent to each instance of `checkpatch` now that we potentially run it multiple times. I've implemented this with:
```
# This script gets called with stdin set to a git diff or empty string. Put it
# into a temp file so we can pass it along to checkpatch multiple times.
cat >"$STDIN_TEMP"
```
The `echo ""` is needed so the script doesn't stop at this `cat` line.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ia2e75d9783382cefc3900a4ab51a5a919a2cbbbc
Gerrit-Change-Number: 42215
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Feb 2026 13:20:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: Hoernchen, laforge, pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-trx/+/42204?usp=email )
Change subject: checkpatch.conf: lint more code
......................................................................
Patch Set 3:
(1 comment)
File .checkpatch.conf:
https://gerrit.osmocom.org/c/osmo-trx/+/42204/comment/71e78a11_6c390f93?usp… :
PS2, Line 4: --ignore INDENTED_LABEL
> Can we apply these ignores only to c++ files? We still have multiple . […]
I have updated the patch to now have separate configs for C and C++ files. It now depends on https://gerrit.osmocom.org/c/osmo-ci/+/42215.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42204?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I0df5b6f2f0bf1469a80a1f5859809c30f523f683
Gerrit-Change-Number: 42204
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Feb 2026 13:10:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>