- gerrit-log - lists.osmocom.org

[S] Change in osmo-trx[master]: checkpatch.conf: lint more code
by osmith 26 Feb '26

26 Feb '26

Attention is currently required from: Hoernchen, laforge, osmith. Hello Hoernchen, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42204?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: checkpatch.conf: lint more code ...................................................................... checkpatch.conf: lint more code The current linter configuration misses to find lots of formatting errors as we've seen here: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comments/f8f1b5a2_3c7e1389 This is caused by the following exclude rules in .checkpatch.conf, which were added there to avoid that some of the checkpatch rules don't work correctly with C++ code: ---exclude .*h ---exclude Transceiver52M/grgsm_vitac/.* ---exclude utils/va-test/.* Fix this by splitting the .checkpatch.conf into two files, .checkpatch.c.conf and .checkpatch.c++.conf. Let the C version use the default rules. Let the C++ version ignore the rules that don't work with C++ code: * SPACING Fails on: std::vector<std::string> With: ERROR:SPACING: spaces required around that '<' (ctx:VxV) ERROR:SPACING: spaces required around that '>' (ctx:VxW) * FUNCTION_ARGUMENTS Fails on: ScopedLock lock(mLock); With: WARNING:FUNCTION_ARGUMENTS: function definition argument 'mLock' should also have an identifier name * INDENTED_LABEL Fails on: private: protected: With: WARNING:INDENTED_LABEL: labels should not be indented * NEW_TYPEDEFS Fails on: typedef std::map<K,D*> Map; With: WARNING:NEW_TYPEDEFS: do not add new typedefs With the new config, the linter only complains about the following things across the existing C++ code, which seem to be legitimate linting problems (and if not, can be ignored as well): BRACES_NOT_NECESSARY, CODE_INDENT, LEADING_SPACE, MULTISTATEMENT_MACRO_USE_DO_WHILE, OPEN_BRACE, POINTER_LOCATION, PRINTF_I_OSMO, SINGLE_STATEMENT_DO_WHILE_MACRO, SPACE_BEFORE_TAB, STATIC_CONST_CHAR_ARRAY, TABSTOP, TRAILING_WHITESPACE Depends: osmo-ci Ia2e75d9783382cefc3900a4ab51a5a919a2cbbbc Change-Id: I0df5b6f2f0bf1469a80a1f5859809c30f523f683 --- A .checkpatch.c++.conf A .checkpatch.c.conf D .checkpatch.conf 3 files changed, 10 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/04/42204/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42204?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0df5b6f2f0bf1469a80a1f5859809c30f523f683 Gerrit-Change-Number: 42204 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-ci[master]: lint/checkpatch: support multiple configs
by osmith 26 Feb '26

26 Feb '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email ) Change subject: lint/checkpatch: support multiple configs ...................................................................... lint/checkpatch: support multiple configs Run checkpatch with any .checkpatch*.conf found in the project dir. This is in preparation for having two .checkpatch.conf files in osmo-trx, in order to use different linting rules for C++ code: * .checkpatch.c.conf * .checkpatch.c++.conf Related: osmo-trx I0df5b6f2f0bf1469a80a1f5859809c30f523f683 Change-Id: Ia2e75d9783382cefc3900a4ab51a5a919a2cbbbc --- M .gitignore M lint/checkpatch/checkpatch.pl M lint/checkpatch/checkpatch_json.py M lint/checkpatch/checkpatch_osmo.sh M lint/lint_all.sh 5 files changed, 75 insertions(+), 48 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/15/42215/1 diff --git a/.gitignore b/.gitignore index 6e99147..b849dfb 100644 --- a/.gitignore +++ b/.gitignore @@ -17,3 +17,4 @@ _temp_manuals/ _temp_releases/ scripts/repo-install-test/run-inside-env.sh +.stdin_temp diff --git a/lint/checkpatch/checkpatch.pl b/lint/checkpatch/checkpatch.pl index eada2a9..d81b953 100755 --- a/lint/checkpatch/checkpatch.pl +++ b/lint/checkpatch/checkpatch.pl @@ -56,7 +56,7 @@ my @ignore = (); my @exclude = (); my $help = 0; -my $configuration_file = ".checkpatch.conf"; +my $configuration_file = $ENV{'CHECKPATCH_CONFIG'} // '.checkpatch.conf'; my $max_line_length = 100; my $ignore_perl_version = 0; my $minimum_perl_version = 5.10.0; diff --git a/lint/checkpatch/checkpatch_json.py b/lint/checkpatch/checkpatch_json.py index bf7f0af..e0c4dcd 100755 --- a/lint/checkpatch/checkpatch_json.py +++ b/lint/checkpatch/checkpatch_json.py @@ -17,13 +17,15 @@ def update_struct( file_path, msg_output, line_number): if file_path not in list_temp: list_temp[file_path] = [] - list_temp[file_path].append({ + error = { "robot_id" : "checkpatch", "robot_run_id" : sys.argv[3], "url" : sys.argv[4], "line" : line_number, - "message" : msg_output,} - ) + "message" : msg_output, + } + if error not in list_temp[file_path]: + list_temp[file_path].append(error) def parse_file(input_file): fp = open (input_file, "r") diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index f56464a..ac586f7 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -2,6 +2,7 @@ SCRIPT_DIR="$(dirname "$(realpath "$0")")" PROJECT_DIR="$(git rev-parse --show-toplevel)" PROJECT="$(basename "$PROJECT_DIR")" +STDIN_TEMP="$SCRIPT_DIR/.stdin_temp" exclude_paths_common() { # Test output @@ -83,48 +84,71 @@ # * UNNECESSARY_INT: not followed (see https://gerrit.osmocom.org/c/libosmocore/+/25345) # * UNSPECIFIED_INT: not followed (doesn't seem useful for us) # * VOLATILE: using volatile makes sense in embedded projects so this warning is not useful for us +run_checkpatch() { + cat "$STDIN_TEMP" | $SCRIPT_DIR/checkpatch.pl \ + $ARGS_EXCLUDE_PATHS_COMMON \ + $ARGS_EXCLUDE_PATHS_COMMON_ASN1C \ + $ARGS_EXCLUDE_PATHS_PROJECT \ + --ignore ASSIGN_IN_IF \ + --ignore AVOID_EXTERNS \ + --ignore BLOCK_COMMENT_STYLE \ + --ignore COMPLEX_MACRO \ + --ignore CONSTANT_COMPARISON \ + --ignore DEEP_INDENTATION \ + --ignore EMBEDDED_FILENAME \ + --ignore EMBEDDED_FUNCTION_NAME \ + --ignore EXECUTE_PERMISSIONS \ + --ignore FILE_PATH_CHANGES \ + --ignore GLOBAL_INITIALISERS \ + --ignore IF_0 \ + --ignore INITIALISED_STATIC \ + --ignore LINE_CONTINUATIONS \ + --ignore LINE_SPACING \ + --ignore LONG_LINE \ + --ignore LONG_LINE_COMMENT \ + --ignore LONG_LINE_STRING \ + --ignore MACRO_WITH_FLOW_CONTROL \ + --ignore MISSING_SPACE \ + --ignore PREFER_DEFINED_ATTRIBUTE_MACRO \ + --ignore PREFER_FALLTHROUGH \ + --ignore REPEATED_WORD \ + --ignore SPDX_LICENSE_TAG \ + --ignore SPLIT_STRING \ + --ignore STRING_FRAGMENTS \ + --ignore SYMBOLIC_PERMS \ + --ignore TRACING_LOGGING \ + --ignore TRAILING_STATEMENTS \ + --ignore UNNECESSARY_BREAK \ + --ignore UNNECESSARY_INT \ + --ignore UNSPECIFIED_INT \ + --ignore VOLATILE \ + --max-line-length 120 \ + --typedefsfile "$SCRIPT_DIR/typedefs_osmo.txt" \ + --no-signoff \ + --no-tree \ + "$@" +} + +# This script gets called with stdin set to a git diff or empty string. Put it +# into a temp file so we can pass it along to checkpatch multiple times. +cat >"$STDIN_TEMP" cd "$PROJECT_DIR" -$SCRIPT_DIR/checkpatch.pl \ - $(exclude_paths_common) \ - $(exclude_paths_common_asn1c) \ - $(exclude_paths_project) \ - --ignore ASSIGN_IN_IF \ - --ignore AVOID_EXTERNS \ - --ignore BLOCK_COMMENT_STYLE \ - --ignore COMPLEX_MACRO \ - --ignore CONSTANT_COMPARISON \ - --ignore DEEP_INDENTATION \ - --ignore EMBEDDED_FILENAME \ - --ignore EMBEDDED_FUNCTION_NAME \ - --ignore EXECUTE_PERMISSIONS \ - --ignore FILE_PATH_CHANGES \ - --ignore GLOBAL_INITIALISERS \ - --ignore IF_0 \ - --ignore INITIALISED_STATIC \ - --ignore LINE_CONTINUATIONS \ - --ignore LINE_SPACING \ - --ignore LONG_LINE \ - --ignore LONG_LINE_COMMENT \ - --ignore LONG_LINE_STRING \ - --ignore MACRO_WITH_FLOW_CONTROL \ - --ignore MISSING_SPACE \ - --ignore PREFER_DEFINED_ATTRIBUTE_MACRO \ - --ignore PREFER_FALLTHROUGH \ - --ignore REPEATED_WORD \ - --ignore SPDX_LICENSE_TAG \ - --ignore SPLIT_STRING \ - --ignore STRING_FRAGMENTS \ - --ignore SYMBOLIC_PERMS \ - --ignore TRACING_LOGGING \ - --ignore TRAILING_STATEMENTS \ - --ignore UNNECESSARY_BREAK \ - --ignore UNNECESSARY_INT \ - --ignore UNSPECIFIED_INT \ - --ignore VOLATILE \ - --max-line-length 120 \ - --typedefsfile "$SCRIPT_DIR/typedefs_osmo.txt" \ - --no-signoff \ - --no-tree \ - "$@" +ARGS_EXCLUDE_PATHS_COMMON="$(exclude_paths_common)" +ARGS_EXCLUDE_PATHS_COMMON_ASN1C="$(exclude_paths_common_asn1c)" +ARGS_EXCLUDE_PATHS_PROJECT="$(exclude_paths_project)" +RET=0 + +for i in .checkpatch*.conf; do + if [ -e "$i" ]; then + echo "config: $i" + CHECKPATCH_CONFIG="$i" run_checkpatch "$@" || RET=1 + else + # The glob found nothing, just run normally + run_checkpatch "$@" || RET=1 + fi +done + +rm "$STDIN_TEMP" +exit $RET diff --git a/lint/lint_all.sh b/lint/lint_all.sh index 1c25578..1af6a16 100755 --- a/lint/lint_all.sh +++ b/lint/lint_all.sh @@ -16,7 +16,7 @@ if [ -n "$TYPES" ]; then echo "Running checkpath with --types="$TYPES" in $GIT_DIR" - "$SCRIPT_DIR"/checkpatch/checkpatch.pl \ + echo "" | "$SCRIPT_DIR"/checkpatch/checkpatch.pl \ -f \ --color=always \ --no-summary \ @@ -30,7 +30,7 @@ else echo "Running checkpath in $GIT_DIR" - "$SCRIPT_DIR"/checkpatch/checkpatch_osmo.sh \ + echo "" | "$SCRIPT_DIR"/checkpatch/checkpatch_osmo.sh \ -f \ --color=always \ --no-summary \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia2e75d9783382cefc3900a4ab51a5a919a2cbbbc Gerrit-Change-Number: 42215 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: tcap: Support TID with length 1..4
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus. Hello Jenkins Builder, daniel, fixeria, laforge, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: tcap: Support TID with length 1..4 ...................................................................... tcap: Support TID with length 1..4 As described in ITU Q.773 4.2.1.3: "The length of a Transaction ID is 1 to 4 octets." asn.1 files also describe TIDs the following way: OrigTransactionID ::= [APPLICATION 8] IMPLICIT OCTET STRING (SIZE (1..4) ) DestTransactionID ::=[APPLICATION 9] IMPLICIT OCTET STRING (SIZE (1..4) ) Take the chance to avoid asserting based on received external input msg. Related: SYS#5423 Change-Id: I2748d85624e4be708f7554ee3e60a5bda9162845 --- M src/sccp2sua.c M src/ss7_internal.h M src/tcap_as_loadshare.c 3 files changed, 42 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/12/42212/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2748d85624e4be708f7554ee3e60a5bda9162845 Gerrit-Change-Number: 42212 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmo-sigtran[master]: stp: Enable tracking of NULL memory context
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: fixeria. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: stp: Enable tracking of NULL memory context ...................................................................... stp: Enable tracking of NULL memory context Similar to what's done in most of the OsmoCNI programs. This allows dumpinng the NULL context using VTY command 'show talloc-context all'. Change-Id: I4a925967e5bb61c346cf6c4dd2c89b6aaea44b94 --- M stp/stp_main.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/13/42213/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4a925967e5bb61c346cf6c4dd2c89b6aaea44b94 Gerrit-Change-Number: 42213 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: stp: Enable tracking of NULL memory context
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213?usp=email ) Change subject: stp: Enable tracking of NULL memory context ...................................................................... Patch Set 2: (1 comment) File stp/stp_main.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213/comment/64b5c99a_31dad… : PS1, Line 220: talloc_enable_null_tracking > I know we already do this in many projects (and not voting against doing this), but there must be a […] This sounds like a total orthogonal task to be done for all projects, so not really related to this patch which puts osmo-stp in line with all other osmo-* CNI programs. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4a925967e5bb61c346cf6c4dd2c89b6aaea44b94 Gerrit-Change-Number: 42213 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 11:59:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: tcap: Support TID with length 1..4
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email ) Change subject: tcap: Support TID with length 1..4 ...................................................................... Patch Set 3: (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212/comment/31e5fe41_b8f43… : PS2, Line 81: OSMO_ASSERT > exactly. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2748d85624e4be708f7554ee3e60a5bda9162845 Gerrit-Change-Number: 42212 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 26 Feb 2026 11:58:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: tcap: Fix return code in tcap_as_rx_sccp_asp()
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email ) Change subject: tcap: Fix return code in tcap_as_rx_sccp_asp() ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > Ok, maybe best to update the function documentation comment about this notion. Done in version I just pushed. File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210/comment/6e5a47f7_a6961… : PS1, Line 293: Destination > unrelated: This should actually say "Source Address", it looks like a copy+paste from below https://gerrit.osmocom.org/c/libosmo-sigtran/+/42214 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I54c4a1bbaa8e107cf433cc898658a672c2b53c3c Gerrit-Change-Number: 42210 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 11:57:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: tcap: Fix wrong address type printed in log line
by pespin 26 Feb '26

26 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42214?usp=email ) Change subject: tcap: Fix wrong address type printed in log line ...................................................................... tcap: Fix wrong address type printed in log line Change-Id: I28b0d488159d9fa88e69e8c8b2e53a97b461763a --- M src/tcap_as_loadshare.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/14/42214/1 diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 0a73533..537e199 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -312,7 +312,7 @@ rc = sua_addr_parse(&calling_addr, sua, SUA_IEI_SRC_ADDR); if (rc < 0) { - LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP Destination Address\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP Source Address\n"); return -3; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42214?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I28b0d488159d9fa88e69e8c8b2e53a97b461763a Gerrit-Change-Number: 42214 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: tcap: Fix return code in tcap_as_rx_sccp_asp()
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: tcap: Fix return code in tcap_as_rx_sccp_asp() ...................................................................... tcap: Fix return code in tcap_as_rx_sccp_asp() That code path is not an error, simply the message is not TCAP. Take the chance to clarify the behavior of the function. Change-Id: I54c4a1bbaa8e107cf433cc898658a672c2b53c3c --- M src/tcap_as_loadshare.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/10/42210/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I54c4a1bbaa8e107cf433cc898658a672c2b53c3c Gerrit-Change-Number: 42210 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: tcap: Support TID with length 1..4
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: daniel, fixeria, lynxis lazus, pespin. Hello Jenkins Builder, daniel, fixeria, laforge, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: tcap: Support TID with length 1..4 ...................................................................... tcap: Support TID with length 1..4 As described in ITU Q.773 4.2.1.3: "The length of a Transaction ID is 1 to 4 octets." asn.1 files also describe TIDs the following way: OrigTransactionID ::= [APPLICATION 8] IMPLICIT OCTET STRING (SIZE (1..4) ) DestTransactionID ::=[APPLICATION 9] IMPLICIT OCTET STRING (SIZE (1..4) ) Take the chance to avoid asserting based on received external input msg. Related: SYS#5423 Change-Id: I2748d85624e4be708f7554ee3e60a5bda9162845 --- M src/sccp2sua.c M src/ss7_internal.h M src/tcap_as_loadshare.c 3 files changed, 40 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/12/42212/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2748d85624e4be708f7554ee3e60a5bda9162845 Gerrit-Change-Number: 42212 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log