- gerrit-log - lists.osmocom.org

[S] Change in osmo-trx[master]: fix(threads): centralize portable strerror handling
by pespin 25 Feb '26

25 Feb '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email ) Change subject: fix(threads): centralize portable strerror handling ...................................................................... Patch Set 4: (1 comment) File CommonLibs/Utils.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42199/comment/06c9d523_787c39a8?usp… : PS2, Line 36: > Yes, agreed. I dropped the C++ wrapper and kept only the C helper `strerror_buf()`. […] I'm fine with updating all of them in this project. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 Gerrit-Change-Number: 42199 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 25 Feb 2026 20:51:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in libosmocore[master]: fix --disable-log-macros
by pespin 25 Feb '26

25 Feb '26

Attention is currently required from: Hoernchen, fixeria, laforge. pespin has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email ) Change subject: fix --disable-log-macros ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab Gerrit-Change-Number: 42203 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 20:48:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: core: fix config.h
by laforge 25 Feb '26

25 Feb '26

Attention is currently required from: Hoernchen, fixeria, pespin. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email ) Change subject: core: fix config.h ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > ..but just hoping people don't just use HAVE_XX and don't include config. […] if we add such a check to libosmocore gerrit build verification, then I am happy to accept the need for config.h include in every source file. The difference to HAVE_XX is that if you use somtehing like that as a developer, you should know from past work experience that you need config.h. But needing it just because you're using libosmocore logging is somewhat unusual and hard to remember. And someone will forget about it, and we will see the issue reappear. I'm 100% sure. Checking in another repo will not prevent breaking changes from being introduced to libosmocore. So whatever we do in terms of checking, it must be done within this repo and its CI. I do believe we're doing an embedded arm-none-eabi build in the verification, and maybe we can add your check there? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000 Gerrit-Change-Number: 42205 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 19:54:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-trx[master]: fix(threads): centralize portable strerror handling
by Timur Davydov 25 Feb '26

25 Feb '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: fix(threads): centralize portable strerror handling ...................................................................... fix(threads): centralize portable strerror handling - Move strerror_r portability logic to Utils - Add strerror_buf() helper - Simplify thread error logging in Threads.cpp Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 --- M CommonLibs/Threads.cpp M CommonLibs/Utils.cpp M CommonLibs/Utils.h 3 files changed, 21 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/99/42199/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 Gerrit-Change-Number: 42199 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: ensure libosmocore logging is properly disabled for builds
by Hoernchen 25 Feb '26

25 Feb '26

Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42208?usp=email ) Change subject: ensure libosmocore logging is properly disabled for builds ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: The failure is expected since right now libosmocore mishandles the config.h include/position and always forces the the logging code and its delays upon the poor fsm... -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42208?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I169a059d8daff0a3993318a4ea3ab7adcb05fee3 Gerrit-Change-Number: 42208 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 25 Feb 2026 19:29:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmocore[master]: core: fix config.h
by Hoernchen 25 Feb '26

25 Feb '26

Attention is currently required from: fixeria, laforge, pespin. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email ) Change subject: core: fix config.h ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > I think you have a point here. […] ..but just hoping people don't just use HAVE_XX and don't include config.h is not really a fix either? The FW build can check if the logging is defined, btw, and if it is, break. Or we could enforce including config.h everywhere by adding a check... See https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42208 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000 Gerrit-Change-Number: 42205 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 19:27:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: ensure libosmocore logging is properly disabled for builds
by Hoernchen 25 Feb '26

25 Feb '26

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42208?usp=email ) Change subject: ensure libosmocore logging is properly disabled for builds ...................................................................... ensure libosmocore logging is properly disabled for builds Change-Id: I169a059d8daff0a3993318a4ea3ab7adcb05fee3 --- M sysmoOCTSIM/gcc/Makefile 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/08/42208/1 diff --git a/sysmoOCTSIM/gcc/Makefile b/sysmoOCTSIM/gcc/Makefile index 0f2a909..461b313 100644 --- a/sysmoOCTSIM/gcc/Makefile +++ b/sysmoOCTSIM/gcc/Makefile @@ -164,7 +164,7 @@ vpath %.S ../ # All Target -all: $(SUB_DIRS) elf bin ihex eep lss +all: $(SUB_DIRS) elf bin ihex eep lss check-no-logging elf: $(OUTPUT_FILE_NAME).elf sysmoOCTSIM.elf bin: $(OUTPUT_FILE_NAME).bin sysmoOCTSIM.bin @@ -246,5 +246,12 @@ $(OUTPUT_FILE_NAME).lss $(OUTPUT_FILE_NAME).eep $(OUTPUT_FILE_NAME).map \ $(OUTPUT_FILE_NAME).srec +check-no-logging: $(OUTPUT_FILE_PATH) + @if $(NM) $< | grep -q ' T logp2'; then \ + echo "FAIL: logging symbols linked into release ELF (libosmocore --disable-log-macros missing/broken?)"; \ + $(NM) $< | grep ' T $logp2\|osmo_vlogp\|log_check_level\|logp_stub$'; \ + exit 1; \ + fi + mrproper: clean rm -f *.o *.d *.a *.elf *.bin *.ihex *.eep *.lss *.map *.srec -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42208?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I169a059d8daff0a3993318a4ea3ab7adcb05fee3 Gerrit-Change-Number: 42208 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

1 0

[S] Change in osmo-trx[master]: fix(threads): centralize portable strerror handling
by Timur Davydov 25 Feb '26

25 Feb '26

Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email ) Change subject: fix(threads): centralize portable strerror handling ...................................................................... Patch Set 3: (1 comment) File CommonLibs/Utils.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42199/comment/74111118_5e7b1342?usp… : PS2, Line 36: > So now you are adding a function which is not used anywhere?I'd rather drop the c++ one and simply u […] Yes, agreed. I dropped the C++ wrapper and kept only the C helper `strerror_buf()`. I also found a few remaining direct `strerror_r()` calls in `trx_rate_ctr.cpp` and `IPCDevice.cpp` — do you want me to switch those to `strerror_buf()` as well to keep error handling consistent across the codebase? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 Gerrit-Change-Number: 42199 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 19:20:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-trx[master]: fix(threads): centralize portable strerror handling
by Timur Davydov 25 Feb '26

25 Feb '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: fix(threads): centralize portable strerror handling ...................................................................... fix(threads): centralize portable strerror handling - Move strerror_r portability logic to Utils - Add strerror_buf() helper - Simplify thread error logging in Threads.cpp Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 --- M CommonLibs/Threads.cpp M CommonLibs/Utils.cpp M CommonLibs/Utils.h 3 files changed, 22 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/99/42199/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 Gerrit-Change-Number: 42199 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: fix --disable-log-macros
by Hoernchen 25 Feb '26

25 Feb '26

Attention is currently required from: fixeria, laforge, pespin. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email ) Change subject: fix --disable-log-macros ...................................................................... Patch Set 4: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/libosmocore/+/42203/comment/8ffe2824_5babf8c8?… : PS3, Line 511: if > @pespin@sysmocom.de is correct here: it's the if-statement that needs to be fixed. […] x -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab Gerrit-Change-Number: 42203 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Feb 2026 19:03:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log