- gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: asp: Make sure previous stream_srv is immediatelly destroyed when req...

by laforge

Attention is currently required from: fixeria, neels, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40194?usp=email ) Change subject: asp: Make sure previous stream_srv is immediatelly destroyed when requested ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8edd64234654ba987f35de2d7ad610e96bda27eb Gerrit-Change-Number: 40194 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 14:26:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months

1
0
0 0

[XS] Change in libosmo-sigtran[master]: asp: Make sure asp->{client,server} is nulled before destroy callback

by laforge

Attention is currently required from: daniel, fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40193?usp=email ) Change subject: asp: Make sure asp->{client,server} is nulled before destroy callback ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3f0774eac630c8bc7e9a10f874e1c72763fd14a0 Gerrit-Change-Number: 40193 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 14:25:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: hnbgw: Configure local ASP/AS in osmo-hnbgw.cfg

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40218?usp=email ) Change subject: hnbgw: Configure local ASP/AS in osmo-hnbgw.cfg ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40218?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic04702b597f7217890ee58734c11b866fb14af8b Gerrit-Change-Number: 40218 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 14:25:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_{cs,ps}_rua_dt_during_sccp_wait_cc

by laforge

Attention is currently required from: fixeria, lynxis lazus, neels, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40184?usp=email ) Change subject: hnbgw: Introduce test TC_{cs,ps}_rua_dt_during_sccp_wait_cc ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I97767db5560edf951202c876726d0c52b5b5b49f Gerrit-Change-Number: 40184 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 06 May 2025 14:24:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months

1
0
0 0

[XS] Change in osmo-hnbgw[master]: sccp: Drop error logging for expected scenario

by laforge

Attention is currently required from: fixeria, neels, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40232?usp=email ) Change subject: sccp: Drop error logging for expected scenario ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: IMHO it would be great to have at least some kind of metric (rate_ctr) for those events -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40232?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ia0941574b05256d6e49babe58df59d938cf637a2 Gerrit-Change-Number: 40232 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 14:24:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 months

1
0
0 0

[XS] Change in osmo-dev[master]: gen_makefile: fix building open5gs

by laforge

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/40231?usp=email ) Change subject: gen_makefile: fix building open5gs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40231?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I6da15a0d825d06a20fe435e3545fa92a27c80cb9 Gerrit-Change-Number: 40231 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 14:23:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months

1
0
0 0

[M] Change in osmo-rp2040-firmware[master]: contrib/jenkins: publish binaries

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40228?usp=email ) Change subject: contrib/jenkins: publish binaries ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: from a usability point of view it might make sense to have per-build sub-directories on the downloads server. Users are typically interested in one specific product/board; the fact that we all build them from one firmware repo is of no user relevance. -- To view, visit https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40228?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-rp2040-firmware Gerrit-Branch: master Gerrit-Change-Id: Ic22d693bfebc33278033514fa5900866454e499f Gerrit-Change-Number: 40228 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 14:23:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 months

1
0
0 0

[S] Change in osmo-rp2040-firmware[master]: contrib/jenkins: iterate over list of targets

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40227?usp=email ) Change subject: contrib/jenkins: iterate over list of targets ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-rp2040-firmware Gerrit-Branch: master Gerrit-Change-Id: Ic106e298a1e6a4aa01e2c1d87b1d806f90f27b73 Gerrit-Change-Number: 40227 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 14:22:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months

1
0
0 0

[XS] Change in osmo-rp2040-firmware[master]: contrib/jenkins: remove previous build dir

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40226?usp=email ) Change subject: contrib/jenkins: remove previous build dir ...................................................................... Patch Set 1: (1 comment) File contrib/jenkins.sh: https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40226/comment/60b89f42_… : PS1, Line 3: rm -rf build wouldn't this fail the entire script if 'build' didn't exist while using 'sh -ex' above? -- To view, visit https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40226?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-rp2040-firmware Gerrit-Branch: master Gerrit-Change-Id: I13ed287fc3d5710cf0a9b6abe0d5f8b89402160b Gerrit-Change-Number: 40226 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 14:21:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 months

1
0
0 0

[M] Change in osmo-bsc[master]: meas_json: add command line option to specify binding ip

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email ) Change subject: meas_json: add command line option to specify binding ip ...................................................................... meas_json: add command line option to specify binding ip Change-Id: I3baa80c95b373e3f9483a2778bd195ff99bbdec0 --- M src/utils/meas_json.c 1 file changed, 70 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/src/utils/meas_json.c b/src/utils/meas_json.c index 953b114..4f58409 100644 --- a/src/utils/meas_json.c +++ b/src/utils/meas_json.c @@ -31,6 +31,8 @@ #include <netinet/in.h> +#include <getopt.h> + #include <osmocom/core/socket.h> #include <osmocom/core/msgb.h> #include <osmocom/core/select.h> @@ -41,6 +43,9 @@ #include <osmocom/bsc/gsm_data.h> #include <osmocom/bsc/meas_feed.h> +/* binding IP */ +static char *bind_ip; + static void print_meas_rep_uni_json(struct gsm_meas_rep_unidir *mru) { printf("\"RXL-FULL\":%d, \"RXL-SUB\":%d, ", @@ -172,6 +177,68 @@ return 0; } +static void print_help(void) +{ + printf(" -h --help. This help text.\n"); + printf(" -b --bind-ip. The IP to bind to.\n"); +} + +static void print_usage(void) +{ + printf("Usage: meas_json [options]\n"); +} + +static void handle_options(int argc, char **argv) +{ + int options_mask = 0; + + /* disable explicit missing arguments error output from getopt_long */ + opterr = 0; + + while (1) { + int option_index = 0, c; + static struct option long_options[] = { + {"help", 0, 0, 'h'}, + {"bind-ip", 0, 0, 'b'}, + {0, 0, 0, 0} + }; + + c = getopt_long(argc, argv, "hb:", + long_options, &option_index); + if (c == -1) + break; + + switch (c) { + case 'h': + print_usage(); + print_help(); + exit(0); + case 'b': + bind_ip = optarg; + break; + case '?': + if (optopt) { + printf("ERROR: missing mandatory argument " + "for `%s' option\n", argv[optind-1]); + } else { + printf("ERROR: unknown option `%s'\n", + argv[optind-1]); + } + print_usage(); + print_help(); + exit(EXIT_FAILURE); + break; + default: + /* ignore */ + break; + } + } + if (argc > optind) { + fprintf(stderr, "Unsupported positional arguments on command line\n"); + exit(2); + } +} + /* default categories */ static struct log_info_cat default_categories[] = { }; @@ -187,11 +254,13 @@ void *tall_ctx = talloc_named_const(NULL, 0, "meas_json"); osmo_init_logging2(tall_ctx, &meas_json_log_info); + handle_options(argc, argv); + int rc; struct osmo_fd udp_ofd; udp_ofd.cb = udp_fd_cb; - rc = osmo_sock_init_ofd(&udp_ofd, AF_INET, SOCK_DGRAM, IPPROTO_UDP, NULL, 8888, OSMO_SOCK_F_BIND); + rc = osmo_sock_init_ofd(&udp_ofd, AF_INET, SOCK_DGRAM, IPPROTO_UDP, bind_ip, 8888, OSMO_SOCK_F_BIND); if (rc < 0) exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3baa80c95b373e3f9483a2778bd195ff99bbdec0 Gerrit-Change-Number: 40224 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Iedema <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log