- gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: meas_json: add command line option to specify binding ip

by laforge

Attention is currently required from: Michael Iedema, fixeria. laforge has posted comments on this change by Michael Iedema. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email ) Change subject: meas_json: add command line option to specify binding ip ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3baa80c95b373e3f9483a2778bd195ff99bbdec0 Gerrit-Change-Number: 40224 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Iedema <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Michael Iedema <michael(a)kapsulate.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 14:20:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_{cs,ps}_rua_dt_during_sccp_wait_cc

by pespin

Attention is currently required from: fixeria, laforge, lynxis lazus, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40184?usp=email ) Change subject: hnbgw: Introduce test TC_{cs,ps}_rua_dt_during_sccp_wait_cc ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: This is testing an issue spotted in production and it's been open for almost a week now, so I'll merge this soon if nobody else provides feedback. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I97767db5560edf951202c876726d0c52b5b5b49f Gerrit-Change-Number: 40184 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 06 May 2025 14:10:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 months

1
0
0 0

[XS] Change in osmo-hnbgw[master]: sccp: Drop error logging for expected scenario

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40232?usp=email ) Change subject: sccp: Drop error logging for expected scenario ...................................................................... sccp: Drop error logging for expected scenario The CN is free to release the SCCP conn at any point through an RLSD, eg. because the end user on the other side decided to do so. This was spotted in a osmo-hnbgw deployed in production, where the CN is sometimes not answering the SCCP-CR[RANAP["Activate PDP Context Req"]] (only answering with CC but never answering the DTAP on the upper layers). As a result, most probably the peer times out and decides to unilaterally release the SCCP conn. Related: SYS#7454 Change-Id: Ia0941574b05256d6e49babe58df59d938cf637a2 --- M src/osmo-hnbgw/context_map_sccp.c 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/32/40232/1 diff --git a/src/osmo-hnbgw/context_map_sccp.c b/src/osmo-hnbgw/context_map_sccp.c index 5ee584d..987e410 100644 --- a/src/osmo-hnbgw/context_map_sccp.c +++ b/src/osmo-hnbgw/context_map_sccp.c @@ -360,9 +360,7 @@ case MAP_SCCP_EV_RX_RELEASED: ranap_msg = data; - /* The CN sends an N-Disconnect (SCCP Released) out of the usual sequence. Not what we expected, but - * handle it. */ - LOGPFSML(fi, LOGL_ERROR, "CN sends SCCP Released sooner than expected\n"); + /* The CN sends an N-Disconnect (SCCP Released). */ handle_rx_sccp(fi, ranap_msg); map_sccp_fsm_state_chg(MAP_SCCP_ST_DISCONNECTED); return; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40232?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ia0941574b05256d6e49babe58df59d938cf637a2 Gerrit-Change-Number: 40232 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

[S] Change in libosmocore[rel-1.11.1]: Bump version: 1.11.0.3-5e10c → 1.11.1

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/40223?usp=email ) Change subject: Bump version: 1.11.0.3-5e10c → 1.11.1 ...................................................................... Bump version: 1.11.0.3-5e10c → 1.11.1 Change-Id: If22e810464a33bcadbd03462b4a84bc303377fae --- M debian/changelog M src/gsm/Makefile.am M src/isdn/Makefile.am 3 files changed, 11 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved osmith: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index 9da8106..c3e7931 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,12 @@ +libosmocore (1.11.1) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * tests: soft_uart: Fix printf int type format + * lapd: Take talloc msgb ownership when enqueueing it + * lapdm: Take talloc msgb ownership when enqueueing it + + -- Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Tue, 06 May 2025 16:24:20 +0700 + libosmocore (1.11.0) unstable; urgency=medium [ Mychaela N. Falconia ] diff --git a/src/gsm/Makefile.am b/src/gsm/Makefile.am index b9900e2..e732c7e 100644 --- a/src/gsm/Makefile.am +++ b/src/gsm/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=22:0:2 +LIBVERSION=22:1:2 AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include AM_CFLAGS = -Wall $(TALLOC_CFLAGS) diff --git a/src/isdn/Makefile.am b/src/isdn/Makefile.am index 5145545..40320c3 100644 --- a/src/isdn/Makefile.am +++ b/src/isdn/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=2:0:2 +LIBVERSION=2:1:2 AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include AM_CFLAGS = -Wall $(TALLOC_CFLAGS) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: rel-1.11.1 Gerrit-Change-Id: If22e810464a33bcadbd03462b4a84bc303377fae Gerrit-Change-Number: 40223 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

[XS] Change in libosmocore[rel-1.11.1]: lapdm: Take talloc msgb ownership when enqueueing it

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/40222?usp=email ) Change subject: lapdm: Take talloc msgb ownership when enqueueing it ...................................................................... lapdm: Take talloc msgb ownership when enqueueing it Otherwise the msg talloc reference is kept parented at some unknown pointer in some unknown upper layer, which may cause memory corruption or use-after-free. Change-Id: Iba7b11bd9541c883588f34df67fdd865d72710d7 Related: OS#6728 (cherry picked from commit 9affae763e296d99eaefa0df59c4020146881bb8) --- M src/gsm/lapdm.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c index 1fc986d..3a0e29b 100644 --- a/src/gsm/lapdm.c +++ b/src/gsm/lapdm.c @@ -376,6 +376,8 @@ *msgb_push(msg, 1) = pad; *msgb_push(msg, 1) = link_id; *msgb_push(msg, 1) = chan_nr; + /* Take ownership of msg, since we are keeping it around in this layer: */ + talloc_steal(tall_lapd_ctx, msg); msgb_enqueue(&dl->dl.tx_queue, msg); return 0; } @@ -403,6 +405,8 @@ *msgb_push(msg, 1) = pad; *msgb_push(msg, 1) = link_id; *msgb_push(msg, 1) = chan_nr; + /* Take ownership of msg, since we are keeping it around in this layer: */ + talloc_steal(tall_lapd_ctx, msg); msgb_enqueue(&dl->tx_ui_queue, msg); return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40222?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: rel-1.11.1 Gerrit-Change-Id: Iba7b11bd9541c883588f34df67fdd865d72710d7 Gerrit-Change-Number: 40222 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

[XS] Change in libosmocore[rel-1.11.1]: tests: soft_uart: Fix printf int type format

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/40220?usp=email ) Change subject: tests: soft_uart: Fix printf int type format ...................................................................... tests: soft_uart: Fix printf int type format This fixes a compiler error when compiling in rpi3. Change-Id: Ib8f190c81f20a28081b06cbd3de099f2b87372f4 (cherry picked from commit 4150c2e6b010aee1e087b206ed43a29d569ebd3d) --- M tests/soft_uart/soft_uart_test.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/soft_uart/soft_uart_test.c b/tests/soft_uart/soft_uart_test.c index 7280bdc..a7de251 100644 --- a/tests/soft_uart/soft_uart_test.c +++ b/tests/soft_uart/soft_uart_test.c @@ -389,14 +389,14 @@ g_tx_cb_cfg.data = (void *)"\x55"; g_tx_cb_cfg.data_len = 1; - printf("======== pulling %lu bits (%u at a time)\n", sizeof(tx_buf), n); + printf("======== pulling %zu bits (%u at a time)\n", sizeof(tx_buf), n); for (unsigned int i = 0; i < sizeof(tx_buf); i += n) { rc = osmo_soft_uart_tx_ubits(suart, &tx_buf[i], n); OSMO_ASSERT(rc == n); } printf("%s\n", osmo_ubit_dump(&tx_buf[0], sizeof(tx_buf))); - printf("======== feeding %lu bits into the receiver\n", sizeof(tx_buf)); + printf("======== feeding %zu bits into the receiver\n", sizeof(tx_buf)); rc = osmo_soft_uart_rx_ubits(suart, &tx_buf[0], sizeof(tx_buf)); OSMO_ASSERT(rc == 0); osmo_soft_uart_flush_rx(suart); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40220?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: rel-1.11.1 Gerrit-Change-Id: Ib8f190c81f20a28081b06cbd3de099f2b87372f4 Gerrit-Change-Number: 40220 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

[XS] Change in libosmocore[rel-1.11.1]: lapd: Take talloc msgb ownership when enqueueing it

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/40221?usp=email ) Change subject: lapd: Take talloc msgb ownership when enqueueing it ...................................................................... lapd: Take talloc msgb ownership when enqueueing it Otherwise the msg talloc reference is kept parented at some unknown pointer in some unknown upper layer, which may cause memory corruption or use-after-free. Related: OS#6728 Change-Id: I32729060b5a18576310b3789da522f4392d9611e (cherry picked from commit 630d9b81c8464a0e859dd6c5c72ab88a00b61841) --- M src/isdn/lapd_core.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/isdn/lapd_core.c b/src/isdn/lapd_core.c index b32ed26..caaf092 100644 --- a/src/isdn/lapd_core.c +++ b/src/isdn/lapd_core.c @@ -1922,6 +1922,8 @@ LOGDL(dl, LOGL_INFO, "writing message to send-queue: l3len: %d\n", msgb_l3len(msg)); + /* Take ownership of msg, since we are keeping it around in this layer: */ + talloc_steal(tall_lapd_ctx, msg); /* Write data into the send queue */ msgb_enqueue(&dl->send_queue, msg); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40221?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: rel-1.11.1 Gerrit-Change-Id: I32729060b5a18576310b3789da522f4392d9611e Gerrit-Change-Number: 40221 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

[XS] Change in osmo-dev[master]: gen_makefile: fix building open5gs

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/40231?usp=email ) Change subject: gen_makefile: fix building open5gs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40231?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I6da15a0d825d06a20fe435e3545fa92a27c80cb9 Gerrit-Change-Number: 40231 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 13:14:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months

1
0
0 0

[XS] Change in osmo-dev[master]: gen_makefile: fix building open5gs

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/40231?usp=email ) Change subject: gen_makefile: fix building open5gs ...................................................................... gen_makefile: fix building open5gs Fix that gen_src_proj_copy() returns a relative path for projects where src_copy is not needed (either because the option is disabled or because the project doesn't use autotools, such as open5gs). This leads to generating the wrong build_to_src dir below, where os.path.relpath is getting called on the generated src_proj_copy: build_to_src = os.path.relpath(src_proj_copy, build_proj) Fix for: $ ./testenv.py run hss --podman … ===== .make.open5gs.configure chmod -R ug+w open5gs rm -rf open5gs mkdir -p open5gs cd open5gs; CFLAGS=-g meson setup ../../../../../../../code/osmo-dev/src/open5gs . \ --prefix /home/user/.cache/osmo-ttcn3-testenv/podman/usr ERROR: Neither directory contains a build file meson.build. make: *** [Makefile:4501: .make.open5gs.configure] Error 1 Fixes: 9cf2b98e ("gen_makefile: add --autoreconf-in-src-copy arg") Change-Id: I6da15a0d825d06a20fe435e3545fa92a27c80cb9 --- M gen_makefile.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/31/40231/1 diff --git a/gen_makefile.py b/gen_makefile.py index 548137d..c6e4a0b 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -437,7 +437,7 @@ def gen_src_proj_copy(src_proj, make_dir, proj): if not is_src_copy_needed(proj): - return src_proj + return os.path.join(make_dir, src_proj) return os.path.join(make_dir, "src_copy", proj) def gen_make(proj, deps, configure_opts, jobs, make_dir, src_dir, build_dir, url, push_url, sudo_make_install, no_ldconfig, ldconfig_without_sudo, make_check): -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40231?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I6da15a0d825d06a20fe435e3545fa92a27c80cb9 Gerrit-Change-Number: 40231 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 months

1
0
0 0

[M] Change in osmo-bsc[master]: meas_json: add command line option to specify binding ip

by pespin

Attention is currently required from: Michael Iedema, fixeria. pespin has posted comments on this change by Michael Iedema. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email ) Change subject: meas_json: add command line option to specify binding ip ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3baa80c95b373e3f9483a2778bd195ff99bbdec0 Gerrit-Change-Number: 40224 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Iedema <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Michael Iedema <michael(a)kapsulate.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 12:24:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log