- gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: meas_json: add command line option to specify binding ip

by pespin

Attention is currently required from: iedemam. pespin has posted comments on this change by iedemam. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email ) Change subject: meas_json: add command line option to specify binding ip ...................................................................... Patch Set 2: (2 comments) File src/utils/meas_json.c: https://gerrit.osmocom.org/c/osmo-bsc/+/40224/comment/a554e367_2a1128f3?usp… : PS2, Line 47: static char *bind_ip = NULL; No need to "= NULL", global vars are zero-initialized by default. https://gerrit.osmocom.org/c/osmo-bsc/+/40224/comment/2c9e4d71_d5b49132?usp… : PS2, Line 257: bind_ip = NULL; Not needed, global vars are zero-initialized by default. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3baa80c95b373e3f9483a2778bd195ff99bbdec0 Gerrit-Change-Number: 40224 Gerrit-PatchSet: 2 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Comment-Date: Tue, 06 May 2025 11:19:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 months

1
0
0 0

[S] Change in libosmocore[rel-1.11.1]: Bump version: 1.11.0.3-5e10c → 1.11.1

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/40223?usp=email ) Change subject: Bump version: 1.11.0.3-5e10c → 1.11.1 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Remember to push tag after merging -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: rel-1.11.1 Gerrit-Change-Id: If22e810464a33bcadbd03462b4a84bc303377fae Gerrit-Change-Number: 40223 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 11:16:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 months

1
0
0 0

[S] Change in libosmocore[rel-1.11.1]: Bump version: 1.11.0.3-5e10c → 1.11.1

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/40223?usp=email ) Change subject: Bump version: 1.11.0.3-5e10c → 1.11.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: rel-1.11.1 Gerrit-Change-Id: If22e810464a33bcadbd03462b4a84bc303377fae Gerrit-Change-Number: 40223 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 11:16:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months

1
0
0 0

[XS] Change in libosmocore[rel-1.11.1]: lapdm: Take talloc msgb ownership when enqueueing it

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/40222?usp=email ) Change subject: lapdm: Take talloc msgb ownership when enqueueing it ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40222?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: rel-1.11.1 Gerrit-Change-Id: Iba7b11bd9541c883588f34df67fdd865d72710d7 Gerrit-Change-Number: 40222 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 11:16:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months

1
0
0 0

[XS] Change in libosmocore[rel-1.11.1]: lapd: Take talloc msgb ownership when enqueueing it

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/40221?usp=email ) Change subject: lapd: Take talloc msgb ownership when enqueueing it ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40221?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: rel-1.11.1 Gerrit-Change-Id: I32729060b5a18576310b3789da522f4392d9611e Gerrit-Change-Number: 40221 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 11:16:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months

1
0
0 0

[XS] Change in libosmocore[rel-1.11.1]: tests: soft_uart: Fix printf int type format

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/40220?usp=email ) Change subject: tests: soft_uart: Fix printf int type format ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40220?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: rel-1.11.1 Gerrit-Change-Id: Ib8f190c81f20a28081b06cbd3de099f2b87372f4 Gerrit-Change-Number: 40220 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 11:16:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/master-builds: add osmo-rp2040-firmware

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40230?usp=email ) Change subject: jobs/master-builds: add osmo-rp2040-firmware ...................................................................... jobs/master-builds: add osmo-rp2040-firmware Related: OS#6784 Change-Id: I94a6135fa48d47fe92007d570670f6f5403ce11b --- M jobs/master-builds.yml 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/30/40230/1 diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 71ad3ac..4b34eb2 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -80,6 +80,7 @@ docker_img_erlang: '$USER/debian-bookworm-erlang' docker_img_android: 'registry.osmocom.org/osmocom-build/debian-bookworm-android' docker_img_aram_applet: 'registry.osmocom.org/osmocom-build/debian-bookworm-aram-applet' + docker_img_rp2040: 'registry.osmocom.org/osmocom-build/debian-bookworm-rp2040' timeout_cmd: '/usr/bin/timeout 30m' cmd: '{docker_run_ccache} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh' trigger: @@ -541,6 +542,14 @@ ssh: - binaries_ftp.osmocom.org - docs_ftp.osmocom.org + - osmo-rp2040-firmware: + cmd: | + docker pull {docker_img_rp2040} + {docker_run} \ + {docker_img_rp2040} {timeout_cmd} contrib/jenkins.sh + email: jenkins-notifications(a)lists.osmocom.org + ssh: + - binaries_ftp.osmocom.org - simtrace: repos_url: '{gitea_url}/sim-card/{repos}' email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org kredon(a)sysmocom.de -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40230?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I94a6135fa48d47fe92007d570670f6f5403ce11b Gerrit-Change-Number: 40230 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 months

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/master: pass osmo-ci to docker

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40229?usp=email ) Change subject: jobs/master: pass osmo-ci to docker ...................................................................... jobs/master: pass osmo-ci to docker Let jobs such as the upcoming one for osmo-rp2040-firmware use the known_hosts file from osmo-ci when uploading binaries. In other jobs we've copied the known_hosts into the contrib/jenkins.sh file, but let's try to have it in a central place at least for new jobs. Related: OS#6784 Change-Id: If5257e7f5e3e2f9e09c52fa558a63e34c276b9a6 --- M jobs/master-builds.yml 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/29/40229/1 diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 720c159..71ad3ac 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -42,6 +42,7 @@ -i \ -u build \ -v $(readlink -f $SSH_AUTH_SOCK):/ssh-agent \ + -v "$HOME/osmo-ci:/osmo-ci:ro" \ -v "$PWD:/build" \ -v "$HOME/.ssh:/home/build/.ssh:ro" \ docker_run_ccache: | @@ -68,6 +69,7 @@ -i \ -u build \ -v $(readlink -f $SSH_AUTH_SOCK):/ssh-agent \ + -v "$HOME/osmo-ci:/osmo-ci:ro" \ -v "$PWD:/build" \ -v "$HOME/.ssh:/home/build/.ssh:ro" \ \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If5257e7f5e3e2f9e09c52fa558a63e34c276b9a6 Gerrit-Change-Number: 40229 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 months

1
0
0 0

[M] Change in osmo-rp2040-firmware[master]: contrib/jenkins: publish binaries

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40228?usp=email ) Change subject: contrib/jenkins: publish binaries ...................................................................... contrib/jenkins: publish binaries Publish binaries to: https://ftp.osmocom.org/binaries/osmo-rp2040-firmware/ Related: OS#6784 Change-Id: Ic22d693bfebc33278033514fa5900866454e499f --- M contrib/jenkins.sh 1 file changed, 56 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-rp2040-firmware refs/changes/28/40228/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 7f72e1b..7049ea6 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -3,6 +3,10 @@ iso7816_cardem osmo-gtm900 " +PUBLISH_EXT=" + elf + uf2 +" rm -rf build mkdir build @@ -16,3 +20,55 @@ make -j$(nproc) "$i" done + +if [ "$PUBLISH" = 1 ]; then + echo + echo "=== publishing binaries ===" + echo + + VERSION="$(git describe HEAD)" + SSH_COMMAND="ssh -o 'UserKnownHostsFile=/osmo-ci/contrib/known_hosts' -p 48" + UPLOAD_PATH="binaries@ftp.osmocom.org:web-files/osmo-rp2040-firmware" + EXISTING_BINARIES="$(rsync \ + --rsh "$SSH_COMMAND" \ + "$UPLOAD_PATH"/all/)" + + if [ -z "$VERSION" ]; then + echo "ERROR: failed to get version from 'git describe HEAD'" + exit 1 + fi + + for target in $TARGETS; do + for ext in $PUBLISH_EXT; do + BIN_PATH="$(find -name "$target.$ext")" + if [ -z "$BIN_PATH" ]; then + echo "ERROR: failed to find $target.$ext" + exit 1 + fi + + BIN_LATEST="$target-$VERSION.$ext" + if echo "$EXISTING_BINARIES" | grep -q "$BIN_LATEST"; then + echo "$BIN_LATEST: exists on server, skipping" + continue + fi + + echo "$BIN_LATEST: uploading $BIN_PATH" + + rsync \ + --rsh "$SSH_COMMAND" \ + -a \ + "$BIN_PATH" \ + "$UPLOAD_PATH"/latest/"$target.$ext" + + rsync \ + --rsh "$SSH_COMMAND" \ + -a \ + "$BIN_PATH" \ + "$UPLOAD_PATH"/all/"$BIN_LATEST" + done + done +fi + +echo +echo "=== success ===" +echo -- To view, visit https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40228?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-rp2040-firmware Gerrit-Branch: master Gerrit-Change-Id: Ic22d693bfebc33278033514fa5900866454e499f Gerrit-Change-Number: 40228 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 months

1
0
0 0

[S] Change in osmo-rp2040-firmware[master]: contrib/jenkins: iterate over list of targets

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40227?usp=email ) Change subject: contrib/jenkins: iterate over list of targets ...................................................................... contrib/jenkins: iterate over list of targets Prepare to add code to upload each target's binary in the next patch. Remove "set -x" to make the output more readable (the shell code is simple, no need to be that verbose about it here). Related: OS#6784 Change-Id: Ic106e298a1e6a4aa01e2c1d87b1d806f90f27b73 --- M CMakeLists.txt M contrib/jenkins.sh 2 files changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-rp2040-firmware refs/changes/27/40227/1 diff --git a/CMakeLists.txt b/CMakeLists.txt index cb0f06f..94a9b6c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -17,5 +17,6 @@ -Wno-maybe-uninitialized ) +# When adding new subdirs, make sure to adjust TARGETS in contrib/jenkins.sh! add_subdirectory(iso7816) add_subdirectory(osmo-gtm900) diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index e24d71a..7f72e1b 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -1,7 +1,18 @@ -#!/bin/sh -ex +#!/bin/sh -e +TARGETS=" + iso7816_cardem + osmo-gtm900 +" rm -rf build mkdir build cd build cmake .. -make -j$(nproc) + +for i in $TARGETS; do + echo + echo "=== make $i ===" + echo + + make -j$(nproc) "$i" +done -- To view, visit https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-rp2040-firmware Gerrit-Branch: master Gerrit-Change-Id: Ic106e298a1e6a4aa01e2c1d87b1d806f90f27b73 Gerrit-Change-Number: 40227 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log