- gerrit-log - lists.osmocom.org

[XS] Change in osmo-rp2040-firmware[master]: contrib/jenkins: remove previous build dir

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40226?usp=email ) Change subject: contrib/jenkins: remove previous build dir ...................................................................... contrib/jenkins: remove previous build dir Change-Id: I13ed287fc3d5710cf0a9b6abe0d5f8b89402160b --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-rp2040-firmware refs/changes/26/40226/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 702eea3..e24d71a 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -1,5 +1,6 @@ #!/bin/sh -ex +rm -rf build mkdir build cd build cmake .. -- To view, visit https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40226?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-rp2040-firmware Gerrit-Branch: master Gerrit-Change-Id: I13ed287fc3d5710cf0a9b6abe0d5f8b89402160b Gerrit-Change-Number: 40226 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 months

1
0
0 0

[XS] Change in docker-playground[master]: debian-bookworm-rp2040: add openssh-client, rsync

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/40225?usp=email ) Change subject: debian-bookworm-rp2040: add openssh-client, rsync ...................................................................... debian-bookworm-rp2040: add openssh-client, rsync Add packages required for publishing binaries. Related: OS#6784 Change-Id: Ie82eff2de77cbe2770b677439f6942f515572f06 --- M debian-bookworm-rp2040/Dockerfile 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/25/40225/1 diff --git a/debian-bookworm-rp2040/Dockerfile b/debian-bookworm-rp2040/Dockerfile index 4741811..6c9d480 100644 --- a/debian-bookworm-rp2040/Dockerfile +++ b/debian-bookworm-rp2040/Dockerfile @@ -28,8 +28,10 @@ libnewlib-arm-none-eabi \ libstdc++-arm-none-eabi-newlib \ libusb-1.0-0-dev \ + openssh-client \ pkg-config \ python3 \ + rsync \ && \ apt-get clean -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40225?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie82eff2de77cbe2770b677439f6942f515572f06 Gerrit-Change-Number: 40225 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 months

1
0
0 0

[M] Change in osmo-bsc[master]: meas_json: add command line option to specify binding ip

by iedemam

Attention is currently required from: iedemam. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: meas_json: add command line option to specify binding ip ...................................................................... meas_json: add command line option to specify binding ip Change-Id: I3baa80c95b373e3f9483a2778bd195ff99bbdec0 --- M src/utils/meas_json.c 1 file changed, 71 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/24/40224/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3baa80c95b373e3f9483a2778bd195ff99bbdec0 Gerrit-Change-Number: 40224 Gerrit-PatchSet: 2 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: iedemam <michael(a)kapsulate.com>

2 months

1
0
0 0

[M] Change in osmo-bsc[master]: meas_json: add command line option to specify binding ip

by Jenkins Builder

Jenkins Builder has posted comments on this change by iedemam. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email ) Change subject: meas_json: add command line option to specify binding ip ...................................................................... Patch Set 1: (1 comment) File src/utils/meas_json.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40224/comment/98c8b3e4_ec0701ba?usp… : PS1, Line 191: static void handle_options(int argc, char** argv) "foo** bar" should be "foo **bar" -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3baa80c95b373e3f9483a2778bd195ff99bbdec0 Gerrit-Change-Number: 40224 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 06 May 2025 10:10:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 months

1
0
0 0

[M] Change in osmo-bsc[master]: meas_json: add command line option to specify binding ip

by iedemam

iedemam has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email ) Change subject: meas_json: add command line option to specify binding ip ...................................................................... meas_json: add command line option to specify binding ip Change-Id: I3baa80c95b373e3f9483a2778bd195ff99bbdec0 --- M src/utils/meas_json.c 1 file changed, 71 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/24/40224/1 diff --git a/src/utils/meas_json.c b/src/utils/meas_json.c index 953b114..7184a4d 100644 --- a/src/utils/meas_json.c +++ b/src/utils/meas_json.c @@ -31,6 +31,8 @@ #include <netinet/in.h> +#include <getopt.h> + #include <osmocom/core/socket.h> #include <osmocom/core/msgb.h> #include <osmocom/core/select.h> @@ -41,6 +43,9 @@ #include <osmocom/bsc/gsm_data.h> #include <osmocom/bsc/meas_feed.h> +/* binding IP */ +static char *bind_ip = NULL; + static void print_meas_rep_uni_json(struct gsm_meas_rep_unidir *mru) { printf("\"RXL-FULL\":%d, \"RXL-SUB\":%d, ", @@ -172,6 +177,68 @@ return 0; } +static void print_help(void) +{ + printf(" -h --help. This help text.\n"); + printf(" -b --bind-ip. The IP to bind to.\n"); +} + +static void print_usage(void) +{ + printf("Usage: meas_json [options]\n"); +} + +static void handle_options(int argc, char** argv) +{ + int options_mask = 0; + + /* disable explicit missing arguments error output from getopt_long */ + opterr = 0; + + while (1) { + int option_index = 0, c; + static struct option long_options[] = { + {"help", 0, 0, 'h'}, + {"bind-ip", 0, 0, 'b'}, + {0, 0, 0, 0} + }; + + c = getopt_long(argc, argv, "hb:", + long_options, &option_index); + if (c == -1) + break; + + switch (c) { + case 'h': + print_usage(); + print_help(); + exit(0); + case 'b': + bind_ip = optarg; + break; + case '?': + if (optopt) { + printf("ERROR: missing mandatory argument " + "for `%s' option\n", argv[optind-1]); + } else { + printf("ERROR: unknown option `%s'\n", + argv[optind-1]); + } + print_usage(); + print_help(); + exit(EXIT_FAILURE); + break; + default: + /* ignore */ + break; + } + } + if (argc > optind) { + fprintf(stderr, "Unsupported positional arguments on command line\n"); + exit(2); + } +} + /* default categories */ static struct log_info_cat default_categories[] = { }; @@ -187,11 +254,14 @@ void *tall_ctx = talloc_named_const(NULL, 0, "meas_json"); osmo_init_logging2(tall_ctx, &meas_json_log_info); + bind_ip = NULL; + handle_options(argc, argv); + int rc; struct osmo_fd udp_ofd; udp_ofd.cb = udp_fd_cb; - rc = osmo_sock_init_ofd(&udp_ofd, AF_INET, SOCK_DGRAM, IPPROTO_UDP, NULL, 8888, OSMO_SOCK_F_BIND); + rc = osmo_sock_init_ofd(&udp_ofd, AF_INET, SOCK_DGRAM, IPPROTO_UDP, bind_ip, 8888, OSMO_SOCK_F_BIND); if (rc < 0) exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3baa80c95b373e3f9483a2778bd195ff99bbdec0 Gerrit-Change-Number: 40224 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael(a)kapsulate.com>

2 months

1
0
0 0

[S] Change in libosmocore[rel-1.11.1]: Bump version: 1.11.0.3-5e10c → 1.11.1

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/40223?usp=email ) Change subject: Bump version: 1.11.0.3-5e10c → 1.11.1 ...................................................................... Bump version: 1.11.0.3-5e10c → 1.11.1 Change-Id: If22e810464a33bcadbd03462b4a84bc303377fae --- M debian/changelog M src/gsm/Makefile.am M src/isdn/Makefile.am 3 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/23/40223/1 diff --git a/debian/changelog b/debian/changelog index 9da8106..c3e7931 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,12 @@ +libosmocore (1.11.1) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * tests: soft_uart: Fix printf int type format + * lapd: Take talloc msgb ownership when enqueueing it + * lapdm: Take talloc msgb ownership when enqueueing it + + -- Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Tue, 06 May 2025 16:24:20 +0700 + libosmocore (1.11.0) unstable; urgency=medium [ Mychaela N. Falconia ] diff --git a/src/gsm/Makefile.am b/src/gsm/Makefile.am index b9900e2..e732c7e 100644 --- a/src/gsm/Makefile.am +++ b/src/gsm/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=22:0:2 +LIBVERSION=22:1:2 AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include AM_CFLAGS = -Wall $(TALLOC_CFLAGS) diff --git a/src/isdn/Makefile.am b/src/isdn/Makefile.am index 5145545..40320c3 100644 --- a/src/isdn/Makefile.am +++ b/src/isdn/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -LIBVERSION=2:0:2 +LIBVERSION=2:1:2 AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include AM_CFLAGS = -Wall $(TALLOC_CFLAGS) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: rel-1.11.1 Gerrit-Change-Id: If22e810464a33bcadbd03462b4a84bc303377fae Gerrit-Change-Number: 40223 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

2 months

1
0
0 0

[XS] Change in libosmocore[rel-1.11.1]: tests: soft_uart: Fix printf int type format

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/40220?usp=email ) Change subject: tests: soft_uart: Fix printf int type format ...................................................................... tests: soft_uart: Fix printf int type format This fixes a compiler error when compiling in rpi3. Change-Id: Ib8f190c81f20a28081b06cbd3de099f2b87372f4 (cherry picked from commit 4150c2e6b010aee1e087b206ed43a29d569ebd3d) --- M tests/soft_uart/soft_uart_test.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/20/40220/1 diff --git a/tests/soft_uart/soft_uart_test.c b/tests/soft_uart/soft_uart_test.c index 7280bdc..a7de251 100644 --- a/tests/soft_uart/soft_uart_test.c +++ b/tests/soft_uart/soft_uart_test.c @@ -389,14 +389,14 @@ g_tx_cb_cfg.data = (void *)"\x55"; g_tx_cb_cfg.data_len = 1; - printf("======== pulling %lu bits (%u at a time)\n", sizeof(tx_buf), n); + printf("======== pulling %zu bits (%u at a time)\n", sizeof(tx_buf), n); for (unsigned int i = 0; i < sizeof(tx_buf); i += n) { rc = osmo_soft_uart_tx_ubits(suart, &tx_buf[i], n); OSMO_ASSERT(rc == n); } printf("%s\n", osmo_ubit_dump(&tx_buf[0], sizeof(tx_buf))); - printf("======== feeding %lu bits into the receiver\n", sizeof(tx_buf)); + printf("======== feeding %zu bits into the receiver\n", sizeof(tx_buf)); rc = osmo_soft_uart_rx_ubits(suart, &tx_buf[0], sizeof(tx_buf)); OSMO_ASSERT(rc == 0); osmo_soft_uart_flush_rx(suart); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40220?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: rel-1.11.1 Gerrit-Change-Id: Ib8f190c81f20a28081b06cbd3de099f2b87372f4 Gerrit-Change-Number: 40220 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

[XS] Change in libosmocore[rel-1.11.1]: lapd: Take talloc msgb ownership when enqueueing it

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/40221?usp=email ) Change subject: lapd: Take talloc msgb ownership when enqueueing it ...................................................................... lapd: Take talloc msgb ownership when enqueueing it Otherwise the msg talloc reference is kept parented at some unknown pointer in some unknown upper layer, which may cause memory corruption or use-after-free. Related: OS#6728 Change-Id: I32729060b5a18576310b3789da522f4392d9611e (cherry picked from commit 630d9b81c8464a0e859dd6c5c72ab88a00b61841) --- M src/isdn/lapd_core.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/21/40221/1 diff --git a/src/isdn/lapd_core.c b/src/isdn/lapd_core.c index b32ed26..caaf092 100644 --- a/src/isdn/lapd_core.c +++ b/src/isdn/lapd_core.c @@ -1922,6 +1922,8 @@ LOGDL(dl, LOGL_INFO, "writing message to send-queue: l3len: %d\n", msgb_l3len(msg)); + /* Take ownership of msg, since we are keeping it around in this layer: */ + talloc_steal(tall_lapd_ctx, msg); /* Write data into the send queue */ msgb_enqueue(&dl->send_queue, msg); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40221?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: rel-1.11.1 Gerrit-Change-Id: I32729060b5a18576310b3789da522f4392d9611e Gerrit-Change-Number: 40221 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

[XS] Change in libosmocore[rel-1.11.1]: lapdm: Take talloc msgb ownership when enqueueing it

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/40222?usp=email ) Change subject: lapdm: Take talloc msgb ownership when enqueueing it ...................................................................... lapdm: Take talloc msgb ownership when enqueueing it Otherwise the msg talloc reference is kept parented at some unknown pointer in some unknown upper layer, which may cause memory corruption or use-after-free. Change-Id: Iba7b11bd9541c883588f34df67fdd865d72710d7 Related: OS#6728 (cherry picked from commit 9affae763e296d99eaefa0df59c4020146881bb8) --- M src/gsm/lapdm.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/22/40222/1 diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c index 1fc986d..3a0e29b 100644 --- a/src/gsm/lapdm.c +++ b/src/gsm/lapdm.c @@ -376,6 +376,8 @@ *msgb_push(msg, 1) = pad; *msgb_push(msg, 1) = link_id; *msgb_push(msg, 1) = chan_nr; + /* Take ownership of msg, since we are keeping it around in this layer: */ + talloc_steal(tall_lapd_ctx, msg); msgb_enqueue(&dl->dl.tx_queue, msg); return 0; } @@ -403,6 +405,8 @@ *msgb_push(msg, 1) = pad; *msgb_push(msg, 1) = link_id; *msgb_push(msg, 1) = chan_nr; + /* Take ownership of msg, since we are keeping it around in this layer: */ + talloc_steal(tall_lapd_ctx, msg); msgb_enqueue(&dl->tx_ui_queue, msg); return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40222?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: rel-1.11.1 Gerrit-Change-Id: Iba7b11bd9541c883588f34df67fdd865d72710d7 Gerrit-Change-Number: 40222 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

2 months

1
0
0 0

[S] Change in libosmocore[master]: vty: remove broken 'show startup-config' command

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/40187?usp=email ) Change subject: vty: remove broken 'show startup-config' command ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/40187/comment/e5e43cd0_14cf22c8?… : PS1, Line 12: If > > Doesn't that mean that the write is then broken? […] Here is an RFC: https://gerrit.osmocom.org/c/libosmocore/+/40219 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If0b4a79052c060cad963e6458b29000a979f95ba Gerrit-Change-Number: 40187 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 06 May 2025 09:11:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log