- gerrit-log - lists.osmocom.org

[XS] Change in osmo-remsim[master]: remsim-client: Don't attempt to pass on TPDU length < 5
by laforge 27 Feb '26

27 Feb '26

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42230?usp=email ) Change subject: remsim-client: Don't attempt to pass on TPDU length < 5 ...................................................................... remsim-client: Don't attempt to pass on TPDU length < 5 TPDUs with length < 5 bytes are illegal in T=0. It doesn't make sense to send them to bankd, triggering bugs in either bankd, pcsc-lite or the CCID firmware down the road. Let's filter them right where they might originate. Change-Id: I175eb4622d0e69dbc6aca2cddfe091a78f225da5 --- M src/client/main_fsm.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/30/42230/1 diff --git a/src/client/main_fsm.c b/src/client/main_fsm.c index dcdd239..c4c3237 100644 --- a/src/client/main_fsm.c +++ b/src/client/main_fsm.c @@ -336,6 +336,11 @@ case MF_E_MDM_TPDU: tpdu = data; OSMO_ASSERT(tpdu); + if (tpdu->len < 5) { + LOGPFSML(fi, LOGL_ERROR, "Modem submitted illegal TPDU length %u (%s), dropping\n", tpdu->len, + osmo_hexdump_nospc(tpdu->buf, tpdu->len)); + return; + } LOGPFSML(fi, LOGL_INFO, "Tx tpduModemToCard (%s)\n", osmo_hexdump_nospc(tpdu->buf, tpdu->len)); /* forward to bankd */ bank_slot2rspro(&bslot, &bc->bankd_slot); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42230?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I175eb4622d0e69dbc6aca2cddfe091a78f225da5 Gerrit-Change-Number: 42230 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-remsim[master]: log at NOTICE level if somebody uses loopback addresses.
by laforge 27 Feb '26

27 Feb '26

Attention is currently required from: laforge, roh. Hello Jenkins Builder, mschramm, roh, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/33812?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: log at NOTICE level if somebody uses loopback addresses. ...................................................................... log at NOTICE level if somebody uses loopback addresses. It appears a common mistake is to e.g. run remsim-server + remsim-bankd on one machine and then instruct them to use localhost or other loopback-routed addresses. This won't work as that address is then sent to a [remote] remsim-client that attempts to reach the bankd at localhost. Change-Id: I3b4eda10e81a705aef8d647a860890a74cba8f13 --- M src/client/main_fsm.c M src/server/rspro_server.c 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/12/33812/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33812?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3b4eda10e81a705aef8d647a860890a74cba8f13 Gerrit-Change-Number: 33812 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: mschramm <mschramm(a)sysmocom.de> Gerrit-Reviewer: roh <jsteiger(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: roh <jsteiger(a)sysmocom.de>

1 0

[XS] Change in simtrace2[master]: Use gsmtap_inst_fd2() to remove compiler warning
by laforge 27 Feb '26

27 Feb '26

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/42228?usp=email ) Change subject: Use gsmtap_inst_fd2() to remove compiler warning ...................................................................... Use gsmtap_inst_fd2() to remove compiler warning gsmtap.c: In function 'osmo_st2_gsmtap_send_apdu': gsmtap.c:69:9: warning: 'gsmtap_inst_fd' is deprecated: Use gsmtap_inst_fd2() instead [-Wdeprecated-declarations] 69 | rc = write(gsmtap_inst_fd(g_gti), buf, gross_len); | ^~ Change-Id: I62de38175e63cb563635a01b025b805981e4b7a9 --- M host/lib/gsmtap.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/28/42228/1 diff --git a/host/lib/gsmtap.c b/host/lib/gsmtap.c index 3fc3da6..41b68fa 100644 --- a/host/lib/gsmtap.c +++ b/host/lib/gsmtap.c @@ -66,7 +66,7 @@ memcpy(buf + sizeof(*gh), apdu, len); - rc = write(gsmtap_inst_fd(g_gti), buf, gross_len); + rc = write(gsmtap_inst_fd2(g_gti), buf, gross_len); if (rc < 0) { perror("write gsmtap"); free(buf); -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/42228?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I62de38175e63cb563635a01b025b805981e4b7a9 Gerrit-Change-Number: 42228 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[S] Change in simtrace2[master]: WIP: make 6Cxx status codes in case 2/4 ambiguous situations work
by laforge 27 Feb '26

27 Feb '26

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/42229?usp=email ) Change subject: WIP: make 6Cxx status codes in case 2/4 ambiguous situations work ...................................................................... WIP: make 6Cxx status codes in case 2/4 ambiguous situations work Change-Id: I968608e73057e9f57d3a89aae485d1a278e503e4 --- M host/include/osmocom/simtrace2/simtrace2_api.h M host/src/simtrace2-cardem-pcsc.c 2 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/29/42229/1 diff --git a/host/include/osmocom/simtrace2/simtrace2_api.h b/host/include/osmocom/simtrace2/simtrace2_api.h index a29389c..baa5ed7 100644 --- a/host/include/osmocom/simtrace2/simtrace2_api.h +++ b/host/include/osmocom/simtrace2/simtrace2_api.h @@ -37,6 +37,12 @@ struct osim_chan_hdl *chan; /* path of the underlying USB device */ char *usb_path; + struct { + /* did we just send a PB=0x6C and hence need to assume case2 on re-transmit? */ + bool last_pb_was_6c; + /* cache of the last APDU header */ + struct osim_apdu_cmd_hdr last_hdr; + } state; /* opaque data TBD by user */ void *priv; }; diff --git a/host/src/simtrace2-cardem-pcsc.c b/host/src/simtrace2-cardem-pcsc.c index f26698e..5d4940d 100644 --- a/host/src/simtrace2-cardem-pcsc.c +++ b/host/src/simtrace2-cardem-pcsc.c @@ -178,6 +178,18 @@ exit(1); } + if (data->flags & CEMU_DATA_F_TPDU_HDR && ci->state.last_pb_was_6c) { + LOGCI(ci, LOGL_INFO, "==== last one was 6C\n"); + if (!memcmp(&ci->state.last_hdr, &ac.hdr, 4)) { + /* force case 2 treatment */ + LOGCI(ci, LOGL_INFO, "==== last one was 6C and hdr matches!\n"); + rc = APDU_ACT_TX_CAPDU_TO_CARD; + ac.lc.tot = 0; + } + LOGCI(ci, LOGL_INFO, "==== last_pb_was_6c => false\n"); + ci->state.last_pb_was_6c = false; + } + if (rc & APDU_ACT_TX_CAPDU_TO_CARD) { struct msgb *tmsg = msgb_alloc(1024, "TPDU"); struct osim_reader_hdl *rh = ci->chan->card->reader; @@ -193,12 +205,14 @@ } /* send to actual card */ tmsg->l3h = tmsg->tail; + LOGCI(ci, LOGL_INFO, "pcsc in: %s\n", msgb_hexdump(tmsg)); rc = rh->ops->transceive(rh, tmsg); if (rc < 0) { fprintf(stderr, "error during transceive: %d\n", rc); msgb_free(tmsg); return rc; } + LOGCI(ci, LOGL_INFO, "pcsc out: %s\n", msgb_hexdump(tmsg)); /* send via GSMTAP for wireshark tracing */ osmo_st2_gsmtap_send_apdu(GSMTAP_SIM_APDU, tmsg->data, msgb_length(tmsg)); @@ -208,6 +222,16 @@ if (msgb_l3len(tmsg)) osmo_st2_cardem_request_pb_and_tx(ci, ac.hdr.ins, tmsg->l3h, msgb_l3len(tmsg)); osmo_st2_cardem_request_sw_tx(ci, ac.sw); + /* update our state for proper handling of case2/4 distinction */ + if (ac.sw[0] == 0x6c) { + LOGCI(ci, LOGL_INFO, "==== last_pb_was_6c => true\n"); + ci->state.last_pb_was_6c = true; + } else { + if (ci->state.last_pb_was_6c) + LOGCI(ci, LOGL_INFO, "==== last_pb_was_6c => false\n"); + ci->state.last_pb_was_6c = false; + } + memcpy(&ci->state.last_hdr, &ac.hdr, sizeof(ci->state.last_hdr)); } else if (ac.lc.tot > ac.lc.cur) { osmo_st2_cardem_request_pb_and_rx(ci, ac.hdr.ins, ac.lc.tot - ac.lc.cur); } -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/42229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I968608e73057e9f57d3a89aae485d1a278e503e4 Gerrit-Change-Number: 42229 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ccid-firmware[master]: After initialisation: turn user led on
by laforge 27 Feb '26

27 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42223?usp=email ) Change subject: After initialisation: turn user led on ...................................................................... After initialisation: turn user led on Related: SYS#5158 Change-Id: Ide37ea32648536d333bd5051b142eb15959d29bf --- M sysmoOCTSIM/main.c 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c index fe569fd..74de4bf 100644 --- a/sysmoOCTSIM/main.c +++ b/sysmoOCTSIM/main.c @@ -616,6 +616,11 @@ ccid_eps_enable(); } +static inline void user_led_set(bool state) +{ + gpio_set_pin_level(USER_LED, state); +} + int main(void) { osmo_set_panic_handler(&bdg_bkptpanic); @@ -655,6 +660,8 @@ get_rstcause_str(rstcause_buf); atmel_start_init(); + user_led_set(true); + init_extpower_detect(); board_init(); usb_init(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ide37ea32648536d333bd5051b142eb15959d29bf Gerrit-Change-Number: 42223 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ccid-firmware[master]: After initialisation: turn user led on
by laforge 27 Feb '26

27 Feb '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42223?usp=email ) Change subject: After initialisation: turn user led on ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42223/comment/faeffd96_ba… : PS2, Line 9: 5158 > that is an issue about osmo_ss7_vty.c ? […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ide37ea32648536d333bd5051b142eb15959d29bf Gerrit-Change-Number: 42223 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 27 Feb 2026 09:46:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ccid-firmware[master]: After initialisation: turn user led on
by laforge 27 Feb '26

27 Feb '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42223?usp=email ) Change subject: After initialisation: turn user led on ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42223/comment/53519763_6c… : PS2, Line 9: 5158 that is an issue about osmo_ss7_vty.c ? SYS#5158 is likely what you meant. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ide37ea32648536d333bd5051b142eb15959d29bf Gerrit-Change-Number: 42223 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 27 Feb 2026 09:45:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: clang-format: set ColumnLimit: 0
by laforge 27 Feb '26

27 Feb '26

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42227?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: clang-format: set ColumnLimit: 0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I1f0d511d90a0725f195e08dd6a99eb3d55bd6fc1 Gerrit-Change-Number: 42227 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 09:43:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: clang-format: set ColumnLimit: 0
by laforge 27 Feb '26

27 Feb '26

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42227?usp=email ) Change subject: clang-format: set ColumnLimit: 0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I1f0d511d90a0725f195e08dd6a99eb3d55bd6fc1 Gerrit-Change-Number: 42227 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 09:42:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-ccid-firmware[master]: same54: make the default irq handler weak
by laforge 27 Feb '26

27 Feb '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email ) Change subject: same54: make the default irq handler weak ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: As this originall started as generated code from some atmel tool, I think it would be best if we try to minimize modifications shoul we ever end up wanting to compare re-generated sources. So what about simply keeping the name, avoiding all those Dummy -> Fallback name changes all over the code? -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I544e9c84dd538bb744fb799904adc58f9d850465 Gerrit-Change-Number: 42224 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 27 Feb 2026 09:42:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log