Attention is currently required from: laforge.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40228?usp=email )
Change subject: contrib/jenkins: publish binaries
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> from a usability point of view it might make sense to have per-build sub-directories on the download […]
ack, I'll rework it to do that
--
To view, visit https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40228?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-rp2040-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ic22d693bfebc33278033514fa5900866454e499f
Gerrit-Change-Number: 40228
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 06 May 2025 14:35:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: laforge.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40226?usp=email )
Change subject: contrib/jenkins: remove previous build dir
......................................................................
Patch Set 1:
(1 comment)
File contrib/jenkins.sh:
https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40226/comment/0a439288_… :
PS1, Line 3: rm -rf build
> wouldn't this fail the entire script if 'build' didn't exist while using 'sh -ex' above?
no, `rm -f` exits with 0 if the paths to delete do not exist:
```
$ rm -f /tmp/non-existing && echo ok
ok
```
--
To view, visit https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40226?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-rp2040-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I13ed287fc3d5710cf0a9b6abe0d5f8b89402160b
Gerrit-Change-Number: 40226
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 06 May 2025 14:34:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40217?usp=email )
Change subject: xua_default_lm_fsm: Avoid accessing asp after restart
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40217?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I009a34d098abd61fa3c014787d52c09491fcab76
Gerrit-Change-Number: 40217
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 06 May 2025 14:29:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40214?usp=email )
Change subject: asp: Avoid accessing dyn sctp-server ASP after closing conn during restart
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40214?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ic9f2b01ddcf38d93396701cf5d406d1cfd18704d
Gerrit-Change-Number: 40214
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 06 May 2025 14:28:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40197?usp=email )
Change subject: Implement ASP adm state shutdown
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/osmo_ss7_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40197/comment/860fb9d1_84fc4… :
PS1, Line 1444: "Terminates SCTP association; New associations will be rejected\n"
does it rally make sense to have this help text for no-shutdown?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40197?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I7e4eedb65c4f2952f8b39ca4c539ca2f40e9946c
Gerrit-Change-Number: 40197
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 06 May 2025 14:28:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes