- gerrit-log - lists.osmocom.org

[L] Change in osmo-ccid-firmware[master]: same54: make the default irq handler weak
by osmith 27 Feb '26

27 Feb '26

Attention is currently required from: lynxis lazus. osmith has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email ) Change subject: same54: make the default irq handler weak ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I looked at the [linter errors](https://jenkins.osmocom.org/jenkins/job/gerrit-lint/27152/consoleFu…: * checkpatch `function definition argument 'void' should also have an identifier name`: fix in https://gerrit.osmocom.org/c/osmo-ci/+/42226 * clang-format: line breaks: fix in https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42227 * clang-format: having exactly one space before `/* ... */` comments: looks like this cannot be configured. There is [SpacesBeforeTrailingComments](https://clang.llvm.org/docs/ClangFormatStyleO…, but it does not affect block comments :\ -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I544e9c84dd538bb744fb799904adc58f9d850465 Gerrit-Change-Number: 42224 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 27 Feb 2026 08:13:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ccid-firmware[master]: clang-format: set ColumnLimit: 0
by osmith 27 Feb '26

27 Feb '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42227?usp=email ) Change subject: clang-format: set ColumnLimit: 0 ...................................................................... clang-format: set ColumnLimit: 0 While our coding style says "we accept line lengths of up to 120 characters", in practice we oftentimes end up preferring longer lines (e.g. due to having comments at the end, or to keep them consistent with similar but shorter lines). The checkpatch config has already been adjusted to just ignore the line length completely. Adjust the clang-format config to do the same. Related: osmo-ci I88fd86ac550fddb3017aeceb647c3d9e75367372 Change-Id: I1f0d511d90a0725f195e08dd6a99eb3d55bd6fc1 --- M .clang-format 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/27/42227/1 diff --git a/.clang-format b/.clang-format index 4de65a5..e1b8d44 100644 --- a/.clang-format +++ b/.clang-format @@ -52,7 +52,7 @@ #BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0 BreakAfterJavaFieldAnnotations: false BreakStringLiterals: false -ColumnLimit: 120 +ColumnLimit: 0 CommentPragmas: '^ IWYU pragma:' #CompactNamespaces: false # Unknown to clang-format-4.0 ConstructorInitializerAllOnOneLineOrOnePerLine: false -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I1f0d511d90a0725f195e08dd6a99eb3d55bd6fc1 Gerrit-Change-Number: 42227 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: lint/checkpatch: fix false FUNCTION_ARGUMENTS
by fixeria 27 Feb '26

27 Feb '26

Attention is currently required from: lynxis lazus, osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42226?usp=email ) Change subject: lint/checkpatch: fix false FUNCTION_ARGUMENTS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42226?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I139bdabb38bd0c9ceda99921ebdc0196850c2a53 Gerrit-Change-Number: 42226 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 27 Feb 2026 08:04:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: lint/checkpatch: fix false FUNCTION_ARGUMENTS
by osmith 27 Feb '26

27 Feb '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42226?usp=email ) Change subject: lint/checkpatch: fix false FUNCTION_ARGUMENTS ...................................................................... lint/checkpatch: fix false FUNCTION_ARGUMENTS Fix that the linter complains about: WARNING:FUNCTION_ARGUMENTS: function definition argument 'void' should also have an identifier name For functions with attributes at the end, e.g.: void Fallback_Handler(void) __attribute__((weak, alias("Dummy_Handler"))); Related: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/7c5b3be0_6f… Change-Id: I139bdabb38bd0c9ceda99921ebdc0196850c2a53 --- M lint/checkpatch/checkpatch.pl 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/26/42226/1 diff --git a/lint/checkpatch/checkpatch.pl b/lint/checkpatch/checkpatch.pl index eada2a9..9a81dc2 100755 --- a/lint/checkpatch/checkpatch.pl +++ b/lint/checkpatch/checkpatch.pl @@ -6964,7 +6964,8 @@ # check for function declarations that have arguments without identifier names if (defined $stat && $stat =~ /^.\s*(?:extern\s+)?$Type\s*(?:$Ident|$\s*\*\s*$Ident\s*$)\s*$\s*([^{]+)\s*$\s*;/s && - $1 ne "void") { + $1 ne "void" && + $1 !~ /^void\)/) { my $args = trim($1); while ($args =~ m/\s*($Type\s*(?:$Ident|$\s*\*\s*$Ident?\s*$\s*$balanced_parens)?)/g) { my $arg = trim($1); -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42226?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I139bdabb38bd0c9ceda99921ebdc0196850c2a53 Gerrit-Change-Number: 42226 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-trx[master]: fix(threads): centralize portable strerror handling
by Timur Davydov 26 Feb '26

26 Feb '26

Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email ) Change subject: fix(threads): centralize portable strerror handling ...................................................................... Patch Set 5: (1 comment) File CommonLibs/Utils.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42199/comment/0693034d_00679330?usp… : PS2, Line 36: > I'm fine with updating all of them in this project. Replaced all `strerror_r()` with `strerror_buf()` -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 Gerrit-Change-Number: 42199 Gerrit-PatchSet: 5 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 18:39:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XL] Change in osmo-trx[master]: feat(usdr): add USDR backend support (osmo-trx-usdr)
by Timur Davydov 26 Feb '26

26 Feb '26

Attention is currently required from: Hoernchen, laforge, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42198?usp=email ) Change subject: feat(usdr): add USDR backend support (osmo-trx-usdr) ...................................................................... Patch Set 4: (15 comments) File Transceiver52M/device/usdr/USDRDevice.h: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/fde924c1_67adf011?usp… : PS3, Line 54: int txsps; ///< samples count per GSM symbol for Tx > unsigned? […] Replaced with `tx_sps` and `rx_sps` from `RadioDevice` https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/5f773925_80a65db5?usp… : PS3, Line 60: int timeTxCorr = 0; ///< time correction for TX timestamp, in samples, to align it with RX timestamp, which is needed to achieve correct timing of the transmitted signal. This is a device-specific parameter that can be configured via dev_args and defaults to 0 if not specified. > Change all these comments using /* */ and properly split into acceptable width (<=120 chars). Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/759ac574_3dbc84cc?usp… : PS3, Line 63: TIMESTAMP ts_last_recv = 0; > wrong indentation Fixed indentation throughout the file https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/13bb2d0c_ebe1bb7d?usp… : PS3, Line 90: Read samples from the USDR. > syntax for comment (at least indentation) is different here and in next block. […] Fixed comments throughout the file https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/11c53e1b_2da632ff?usp… : PS3, Line 100: TIMESTAMP timestamp = 0xffffffff, bool *underrun = NULL); > wrong indentation here and below. Fixed indentation throughout the file https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/6db5b421_a78965f2?usp… : PS3, Line 121: > Pleasr get rid of trailing whitespace. Fixed whitespaces throughout the file https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/18b3af14_e7b02b16?usp… : PS3, Line 132: TIMESTAMP initialReadTimestamp(void) { return ts_initial;} > Please, fix indentation in the whole file. Fixed indentation throughout the file File Transceiver52M/device/usdr/USDRDevice.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/4caa58e6_8913e869?usp… : PS3, Line 49: {"limemini", {tx_offset: 86.769us}}, /* 94 samples at 1083333.33333 sps corresponds to 86.769 us */ > are you sure this is correct? isn't it xsdr? maybe add an extra commit explaining? Thanks, good catch — I indeed lost xSDR in that section. Regarding LimeSDR Mini: this was not a typo. The hardware is supported in principle, but I have temporarily removed it from the list. The current implementation does not correctly handle readSamples() / writeSamples() for LimeSDR Mini, as it requires inserting/handling transport headers every 1020 samples, which is not yet implemented properly in this backend. https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/c7e929e9_29a91fc9?usp… : PS3, Line 52: enum { > I don't see why this should be an enum. […] Replaced the enum with #define constants as suggested https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/ccd2e811_6347436b?usp… : PS3, Line 85: std::string msg = std::string("Error creating USDR device with connection string '") + connection_string + "' res: " + std::to_string(res) + "(" + strerror(res) + ")"; > Fix all lines too long like this. Maximum is 120 chars. Reformatted the file to ensure all lines are within the 120-character limit https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/911172c1_6a1c3831?usp… : PS3, Line 180: dev = NULL; > Please fix indentation in the whole file. Better use tabs everywhere. Fixed indentation throughout the file File debian/osmo-trx-usdr.postinst: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/a45a71ec_6ba40876?usp… : PS3, Line 18: # Fix permissions of previous (root-owned) install (OS#4107) > This is AFAICT not needed here, because there's no previous root-owned install ;) Removed the unnecessary legacy permission-fix block. File doc/manuals/chapters/trx-backends.adoc: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/a326e3d4_9f3a2817?usp… : PS3, Line 85: The backend supports single-channel SDR hardware and is designed for setups > But in the other . […] Yes, xSDR and sSDR hardware support multiple RF channels sharing a common LO. These channels are intended for MIMO operation and do not represent independent GSM TRX instances. So the current osmo-trx-usdr implementation operates in single-channel mode only. https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/6ad051c2_7ba4ff76?usp… : PS3, Line 86: where multiple small SDRs are combined to present one or more TRX instances > You mean using multiple SDR devices controlled by one osmo-trx-usdr process? […] Currently, one osmo-trx-usdr process handles one SDR device. Multi-TRX deployments are achieved by running multiple osmo-trx-usdr instances, typically one per device. In synchronized systems such as xMass (4 × xSDR with shared clock and sync), hardware-level clock and synchronization distribution ensures timing alignment between devices. While `osmo-trx-usdr` can theoretically operate with multiple externally synchronized devices, the Osmocom OsmoTRX architecture operates with one TRX per `osmo-trx` process. File doc/manuals/chapters/trx-devices.adoc: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/798bfb33_61cbc8ec?usp… : PS3, Line 102: scale the number of TRX instances. > I'd welcome some extra documentation here regarding how "multi-unit setups to […] Good point, thanks. By "multi-unit setups" I mean deployments where multiple independent SDR devices (e.g. several uSDR units) are used, each controlled by its own `osmo-trx-usdr` process instance, thereby providing one TRX per device. If synchronization between devices is required, it must be provided externally via shared clock and sync distribution (e.g. 1PPS and reference clock, as in xMass setups). I will extend this section to clarify the deployment model and add a reference to the relevant USDR documentation. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5d1d25921514954c4929ae6e7352168b3ceb05df Gerrit-Change-Number: 42198 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 18:37:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-trx[master]: fix(threads): centralize portable strerror handling
by Timur Davydov 26 Feb '26

26 Feb '26

Attention is currently required from: Timur Davydov. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: fix(threads): centralize portable strerror handling ...................................................................... fix(threads): centralize portable strerror handling - Move strerror_r portability logic to Utils - Add strerror_buf() helper - Simplify thread error logging in Threads.cpp Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 --- M CommonLibs/Threads.cpp M CommonLibs/Utils.cpp M CommonLibs/Utils.h M CommonLibs/trx_rate_ctr.cpp M Transceiver52M/device/ipc/IPCDevice.cpp 5 files changed, 31 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/99/42199/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 Gerrit-Change-Number: 42199 Gerrit-PatchSet: 5 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XL] Change in osmo-trx[master]: feat(usdr): add USDR backend support (osmo-trx-usdr)
by Timur Davydov 26 Feb '26

26 Feb '26

Attention is currently required from: Hoernchen, Timur Davydov, laforge, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42198?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: feat(usdr): add USDR backend support (osmo-trx-usdr) ...................................................................... feat(usdr): add USDR backend support (osmo-trx-usdr) - Implement USDRDevice backend for Transceiver52M - Add --with-usdr configure option and build integration - Add systemd service unit (osmo-trx-usdr.service) - Add Debian packaging files for osmo-trx-usdr - Provide example configuration file - Extend manuals and device documentation with USDR backend section Change-Id: I5d1d25921514954c4929ae6e7352168b3ceb05df --- M .gitignore M Transceiver52M/Makefile.am M Transceiver52M/device/Makefile.am A Transceiver52M/device/usdr/Makefile.am A Transceiver52M/device/usdr/USDRDevice.cpp A Transceiver52M/device/usdr/USDRDevice.h M configure.ac M contrib/systemd/Makefile.am A contrib/systemd/osmo-trx-usdr.service A debian/osmo-trx-usdr.install A debian/osmo-trx-usdr.postinst M doc/examples/Makefile.am A doc/examples/osmo-trx-usdr/osmo-trx-usdr.cfg M doc/manuals/Makefile.am M doc/manuals/chapters/trx-backends.adoc M doc/manuals/chapters/trx-devices.adoc 16 files changed, 1,146 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/98/42198/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5d1d25921514954c4929ae6e7352168b3ceb05df Gerrit-Change-Number: 42198 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in osmo-ccid-firmware[master]: After initialisation: turn user led on
by lynxis lazus 26 Feb '26

26 Feb '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42223?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: After initialisation: turn user led on ...................................................................... After initialisation: turn user led on Related: OS#5158 Change-Id: Ide37ea32648536d333bd5051b142eb15959d29bf --- M sysmoOCTSIM/main.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/23/42223/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ide37ea32648536d333bd5051b142eb15959d29bf Gerrit-Change-Number: 42223 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[L] Change in osmo-ccid-firmware[master]: same54: make the default irq handler weak
by Jenkins Builder 26 Feb '26

26 Feb '26

Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email ) Change subject: same54: make the default irq handler weak ...................................................................... Patch Set 1: (125 comments) File sysmoOCTSIM/gcc/gcc/startup_same54.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/7c5b3be0_6f… : PS1, Line 50: void Fallback_Handler(void) __attribute__((weak, alias("Dummy_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/7593a731_89… : PS1, Line 53: void NonMaskableInt_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/45115d33_ea… : PS1, Line 54: void HardFault_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/965d0e0b_75… : PS1, Line 55: void MemManagement_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/8c0cc460_50… : PS1, Line 56: void BusFault_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/60cf64be_d2… : PS1, Line 57: void UsageFault_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/dd36cfcf_d7… : PS1, Line 58: void SVCall_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/bca87c2f_4a… : PS1, Line 59: void DebugMonitor_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/6ea9f8c0_ba… : PS1, Line 60: void PendSV_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/dc6eca9c_40… : PS1, Line 61: void SysTick_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/26411d9e_fc… : PS1, Line 64: void PM_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/9143d18d_85… : PS1, Line 65: void MCLK_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/165a3827_ae… : PS1, Line 66: void OSCCTRL_0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* OSCCTRL_XOSCFAIL_0, OSCCTRL_XOSCRDY_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/e0b9d5b5_0e… : PS1, Line 67: void OSCCTRL_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* OSCCTRL_XOSCFAIL_1, OSCCTRL_XOSCRDY_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/b2df139d_59… : PS1, Line 68: void OSCCTRL_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* OSCCTRL_DFLLLOCKC, OSCCTRL_DFLLLOCKF, function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/ab0199b5_9e… : PS1, Line 75: void OSC32KCTRL_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/1d8306ea_ca… : PS1, Line 76: void SUPC_0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SUPC_B12SRDY, SUPC_B33SRDY, SUPC_BOD12RDY, function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/6ad57b20_f6… : PS1, Line 79: void SUPC_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SUPC_BOD12DET, SUPC_BOD33DET */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/5973dade_92… : PS1, Line 80: void WDT_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/21251f90_ce… : PS1, Line 81: void RTC_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/95a54923_7a… : PS1, Line 82: void EIC_0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EIC_EXTINT_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/87f2b882_ad… : PS1, Line 83: void EIC_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EIC_EXTINT_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/7077a18f_86… : PS1, Line 84: void EIC_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EIC_EXTINT_2 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/b17f3795_ad… : PS1, Line 85: void EIC_3_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EIC_EXTINT_3 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/6712ab50_4d… : PS1, Line 86: void EIC_4_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EIC_EXTINT_4 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/3e5e7c96_93… : PS1, Line 87: void EIC_5_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EIC_EXTINT_5 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/8d0e6daf_8a… : PS1, Line 88: void EIC_6_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EIC_EXTINT_6 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/b7b5a495_2b… : PS1, Line 89: void EIC_7_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EIC_EXTINT_7 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/f162a19e_1b… : PS1, Line 90: void EIC_8_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EIC_EXTINT_8 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/e54ca52a_85… : PS1, Line 91: void EIC_9_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EIC_EXTINT_9 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/44405516_e2… : PS1, Line 92: void EIC_10_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EIC_EXTINT_10 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/a6c1a162_56… : PS1, Line 93: void EIC_11_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EIC_EXTINT_11 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/5959ea00_22… : PS1, Line 94: void EIC_12_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EIC_EXTINT_12 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/a38442e4_49… : PS1, Line 95: void EIC_13_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EIC_EXTINT_13 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/df18448f_2a… : PS1, Line 96: void EIC_14_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EIC_EXTINT_14 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/50094022_9b… : PS1, Line 97: void EIC_15_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EIC_EXTINT_15 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/707d0e7a_99… : PS1, Line 98: void FREQM_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/55b09d54_63… : PS1, Line 99: void NVMCTRL_0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* NVMCTRL_0, NVMCTRL_1, NVMCTRL_2, function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/3ebf019f_b5… : PS1, Line 102: void NVMCTRL_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* NVMCTRL_10, NVMCTRL_8, NVMCTRL_9 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/bf747d69_6a… : PS1, Line 103: void DMAC_0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* DMAC_SUSP_0, DMAC_TCMPL_0, DMAC_TERR_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/f3a78e44_18… : PS1, Line 104: void DMAC_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* DMAC_SUSP_1, DMAC_TCMPL_1, DMAC_TERR_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/a06b2f93_89… : PS1, Line 105: void DMAC_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* DMAC_SUSP_2, DMAC_TCMPL_2, DMAC_TERR_2 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/e8519909_25… : PS1, Line 106: void DMAC_3_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* DMAC_SUSP_3, DMAC_TCMPL_3, DMAC_TERR_3 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/a5ef2a83_57… : PS1, Line 127: void EVSYS_0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EVSYS_EVD_0, EVSYS_OVR_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/60274cc9_90… : PS1, Line 128: void EVSYS_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EVSYS_EVD_1, EVSYS_OVR_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/af7ec2ac_4f… : PS1, Line 129: void EVSYS_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EVSYS_EVD_2, EVSYS_OVR_2 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/6654e40c_01… : PS1, Line 130: void EVSYS_3_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EVSYS_EVD_3, EVSYS_OVR_3 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/c1080b11_d5… : PS1, Line 131: void EVSYS_4_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* EVSYS_EVD_10, EVSYS_EVD_11, EVSYS_EVD_4, function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/18d28228_76… : PS1, Line 137: void PAC_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/06afdb11_51… : PS1, Line 138: void RAMECC_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/6c11a7de_80… : PS1, Line 139: void SERCOM0_0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM0_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/ffc8c6e9_0f… : PS1, Line 140: void SERCOM0_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM0_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/f6f6aefe_af… : PS1, Line 141: void SERCOM0_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM0_2 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/4acaf16c_c5… : PS1, Line 144: void SERCOM1_0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM1_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/be8a4aec_c8… : PS1, Line 145: void SERCOM1_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM1_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/9e62f79f_73… : PS1, Line 146: void SERCOM1_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM1_2 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/8c215c01_ab… : PS1, Line 149: void SERCOM2_0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM2_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/f177fe4e_92… : PS1, Line 150: void SERCOM2_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM2_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/ef87b4e5_3f… : PS1, Line 151: void SERCOM2_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM2_2 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/336fc234_2a… : PS1, Line 154: void SERCOM3_0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM3_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/08b6c62a_6e… : PS1, Line 155: void SERCOM3_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM3_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/c473b6ca_aa… : PS1, Line 156: void SERCOM3_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM3_2 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/a95e29c4_2f… : PS1, Line 160: void SERCOM4_0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM4_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/1f3a2ba3_c0… : PS1, Line 161: void SERCOM4_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM4_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/3a1728b6_18… : PS1, Line 162: void SERCOM4_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM4_2 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/07e83c7a_8e… : PS1, Line 167: void SERCOM5_0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM5_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/8c5a9aeb_aa… : PS1, Line 168: void SERCOM5_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM5_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/c79342b4_19… : PS1, Line 169: void SERCOM5_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM5_2 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/3e5713a3_5f… : PS1, Line 174: void SERCOM6_0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM6_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/77bcb4f5_8b… : PS1, Line 175: void SERCOM6_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM6_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/ad44dda8_87… : PS1, Line 176: void SERCOM6_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM6_2 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/c9257529_5c… : PS1, Line 181: void SERCOM7_0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM7_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/b000a91e_f9… : PS1, Line 182: void SERCOM7_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM7_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/125c220c_ba… : PS1, Line 183: void SERCOM7_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* SERCOM7_2 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/b3261d79_db… : PS1, Line 188: void CAN0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/7e9aa3d4_a7… : PS1, Line 191: void CAN1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/1e339bdd_44… : PS1, Line 210: void USB_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* USB_SOF_HSOF */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/4b2d508b_19… : PS1, Line 211: void USB_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* USB_TRCPT0_0, USB_TRCPT0_1, USB_TRCPT0_2, function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/da02e334_2e… : PS1, Line 214: void USB_3_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* USB_TRCPT1_0, USB_TRCPT1_1, USB_TRCPT1_2, function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/82b3cd23_af… : PS1, Line 219: void GMAC_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/8db9fa10_aa… : PS1, Line 225: void TCC0_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* TCC0_MC_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/7e2ce1eb_4a… : PS1, Line 226: void TCC0_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* TCC0_MC_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/4f91a270_82… : PS1, Line 227: void TCC0_3_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* TCC0_MC_2 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/83f9eab7_d8… : PS1, Line 228: void TCC0_4_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* TCC0_MC_3 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/aa9390d4_b4… : PS1, Line 229: void TCC0_5_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* TCC0_MC_4 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/3daa52f3_d3… : PS1, Line 230: void TCC0_6_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* TCC0_MC_5 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/d369e208_12… : PS1, Line 235: void TCC1_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* TCC1_MC_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/dcd69ec6_f3… : PS1, Line 236: void TCC1_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* TCC1_MC_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/6c815951_8d… : PS1, Line 237: void TCC1_3_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* TCC1_MC_2 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/8e872303_a0… : PS1, Line 238: void TCC1_4_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* TCC1_MC_3 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/e5fc883c_be… : PS1, Line 243: void TCC2_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* TCC2_MC_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/fa30f58b_bf… : PS1, Line 244: void TCC2_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* TCC2_MC_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/c371585a_b6… : PS1, Line 245: void TCC2_3_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* TCC2_MC_2 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/fdeeb371_b1… : PS1, Line 251: void TCC3_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* TCC3_MC_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/353422b4_6b… : PS1, Line 252: void TCC3_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* TCC3_MC_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/a891a8e5_92… : PS1, Line 259: void TCC4_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* TCC4_MC_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/482239ba_1a… : PS1, Line 260: void TCC4_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* TCC4_MC_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/2de26dd9_ef… : PS1, Line 262: void TC0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/d1ff249f_3f… : PS1, Line 263: void TC1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/33cbc806_9a… : PS1, Line 264: void TC2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/fd7655ce_19… : PS1, Line 265: void TC3_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/88b03540_b6… : PS1, Line 267: void TC4_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/9d3ebcbf_51… : PS1, Line 270: void TC5_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/35eed653_c9… : PS1, Line 273: void TC6_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/1a2ab462_ad… : PS1, Line 276: void TC7_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/38d82061_4f… : PS1, Line 280: void PDEC_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* PDEC_MC_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/e04794c9_f4… : PS1, Line 281: void PDEC_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* PDEC_MC_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/9f208cd3_31… : PS1, Line 282: void ADC0_0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* ADC0_OVERRUN, ADC0_WINMON */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/12a2634c_e8… : PS1, Line 283: void ADC0_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* ADC0_RESRDY */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/8d4a7d9a_52… : PS1, Line 284: void ADC1_0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* ADC1_OVERRUN, ADC1_WINMON */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/cbee2fc6_d5… : PS1, Line 285: void ADC1_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* ADC1_RESRDY */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/cf1adcfc_80… : PS1, Line 286: void AC_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/59ab2f28_fc… : PS1, Line 290: void DAC_1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* DAC_EMPTY_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/72dd9cd3_c0… : PS1, Line 291: void DAC_2_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* DAC_EMPTY_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/625cecf3_06… : PS1, Line 292: void DAC_3_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* DAC_RESRDY_0 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/f1fe609b_23… : PS1, Line 293: void DAC_4_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); /* DAC_RESRDY_1 */ function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/1ba5273b_96… : PS1, Line 295: void I2S_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/73b48863_d3… : PS1, Line 297: void PCC_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/2c1f3f19_eb… : PS1, Line 298: void AES_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/c7449c9e_42… : PS1, Line 299: void TRNG_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/0408df34_7c… : PS1, Line 301: void ICM_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/cbae3646_85… : PS1, Line 304: void PUKCC_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/70c56914_cb… : PS1, Line 306: void QSPI_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/c8994982_36… : PS1, Line 308: void SDHC0_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224/comment/24c69143_f9… : PS1, Line 311: void SDHC1_Handler(void) __attribute__((weak, alias("Fallback_Handler"))); function definition argument 'void' should also have an identifier name -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I544e9c84dd538bb744fb799904adc58f9d850465 Gerrit-Change-Number: 42224 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 26 Feb 2026 17:05:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log