Attention is currently required from: daniel, laforge, lynxis lazus.
lynxis lazus has uploaded a new patch set (#7) to the change originally created by daniel. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39703?usp=email )
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: Use osmo_select_main_ctx to support talloc context OTC_SELECT
......................................................................
Use osmo_select_main_ctx to support talloc context OTC_SELECT
The libvlr code is using the OTC_SELECT talloc context.
Change-Id: I4b26b73af706ce790181085880c6866e7f7e8c65
---
M src/sgsn/sgsn_main.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/03/39703/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39703?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I4b26b73af706ce790181085880c6866e7f7e8c65
Gerrit-Change-Number: 39703
Gerrit-PatchSet: 7
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: dexter, laforge.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620?usp=email )
Change subject: IPAd: Add test case for multple eIM packages
......................................................................
Patch Set 1:
(2 comments)
File ipad/IPAd_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620/comment/0d71f854_cda6… :
PS1, Line 1170: var integer i, rounds := 5;
> maybe have the rounds parameter as a module parameter? (mp_tc_multi_package_rounds)?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620/comment/f6a6d39a_158d… :
PS1, Line 1209: f_init(id, 300.0);
> maybe write t_guard := 300.0, than its more obvious what the number means. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I74bba77cc391ed243729e99a5aeaefb9dbde2922
Gerrit-Change-Number: 43620
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 15 Sep 2026 07:35:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43621?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: IPAd: Cleanly process TC_set_device_capabilities
......................................................................
IPAd: Cleanly process TC_set_device_capabilities
Process the test and make IPAd terminate cleanly. This is required to
check if all memory was freed and there is no memory leak.
Related: SYS#8199
Change-Id: I426b2d0d00790577468599fedd65377a4e4bfeed
---
M ipad/IPAd_Tests.ttcn
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/43621/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43621?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I426b2d0d00790577468599fedd65377a4e4bfeed
Gerrit-Change-Number: 43621
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: dexter, jolly, laforge.
Hello Jenkins Builder, dexter, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by dexter, Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: IPAd: Add test case for multple eIM packages
......................................................................
IPAd: Add test case for multple eIM packages
IPAd will cycle through the main loop until there is no eIM package
available. The IPAd process keeps running. Provide multiple eIM packes
to see if they do not conflict with each other. At the end there must be
no memory leak, but this is checked in a later patch.
To re-use code from other tests, move the package processing of other
tests to extra functions. These functions are called in this test
multiple times.
Related: SYS#8199
Change-Id: I74bba77cc391ed243729e99a5aeaefb9dbde2922
---
M ipad/IPAd_Tests.ttcn
1 file changed, 106 insertions(+), 37 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/43620/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I74bba77cc391ed243729e99a5aeaefb9dbde2922
Gerrit-Change-Number: 43620
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43619?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: IPAd: Split f_terminate_poll_cycle()
......................................................................
IPAd: Split f_terminate_poll_cycle()
Remove the handling of notification list polling from
f_terminate_poll_cycle() and put it into an extra function. The
notification list is polled by IPAd after every eIM package processing.
This allows to send multiple eIM packages (and process notification list
polling) before terminating the poll cycle at the end. Later tests will
use this to check for memory leaks.
Related: SYS#8199
Change-Id: I4e278f74ce3bb9bbd666f13c2a72ed90eba34af7
---
M ipad/IPAd_Tests.ttcn
1 file changed, 34 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/43619/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43619?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4e278f74ce3bb9bbd666f13c2a72ed90eba34af7
Gerrit-Change-Number: 43619
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43622?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: IPAd: Check for memory leaks after each test
......................................................................
IPAd: Check for memory leaks after each test
After each test, use grep to verify that no pending allocation is left
after the last free() function call.
The built-in memory leak detection will print the current memory useage
to stdout. The last debug message must have an allocation count of 0
bytes.
Related: SYS#8199
Change-Id: Ifd5390ac230b48614585d2820b9133daebd8c321
---
M ipad/IPAd_Tests.ttcn
A ipad/checkleak.sh
M ipad/testenv.cfg
3 files changed, 15 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/22/43622/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43622?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifd5390ac230b48614585d2820b9133daebd8c321
Gerrit-Change-Number: 43622
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: dexter.
fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/43637?usp=email )
Change subject: pySim-shell: use verify_adm command for commandline ADM auth
......................................................................
Patch Set 2:
(2 comments)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/43637/comment/367e52f1_dba9f557?usp=em… :
PS2, Line 1132: PIN_ADM1
also remove `1` here?
https://gerrit.osmocom.org/c/pysim/+/43637/comment/81b52dc4_61c570b2?usp=em… :
PS2, Line 1188: pin_adm_type = ""
: if opts.pin_adm_type:
: pin_adm_type = "--adm-type %s" % opts.pin_adm_type
: if opts.pin_adm:
: app.onecmd_plus_hooks("verify_adm %s %s" %
: (opts.pin_adm, pin_adm_type), add_to_history = False)
: elif opts.pin_adm_hex:
: app.onecmd_plus_hooks("verify_adm %s --pin-is-hex %s" %
:
Why don't you just call `app.do_verify_adm()` directly here, passing it a `Namespace` object with the parameters? This way there's no need to compose an argv string at all.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43637?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7164fad757048774aa7186a84041febde75c351c
Gerrit-Change-Number: 43637
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Sep 2026 21:20:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No