Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43612?usp=email )
Change subject: proxy: queue BURST.req and dispatch per TDMA frame tick ......................................................................
Patch Set 4:
(1 comment)
File proxy/src/burst_fwd.c:
https://gerrit.osmocom.org/c/osmo-trx/+/43612/comment/4a483cfe_5dba5890?usp=... : PS4, Line 156: llist_add(&msg->list, &cur->list);
but shouldn't this be llist_add_tail now?
No. Despite we're iterating the list in reverse, we still want to add the new entry right after the `cur`, not before. Using `llist_add_tail` would break the sort (new entry would land ahead of an entry it must come after).
-
fixeria