September 2026 - gerrit-log - lists.osmocom.org

[S] Change in dahdi-linux[master]: drivers/dahdi/icE1usb: defer USB transfer when setting loopback mode
by manawyrm 15 Sep '26

15 Sep '26

manawyrm has posted comments on this change by manawyrm. ( https://gerrit.osmocom.org/c/dahdi-linux/+/43642?usp=email ) Change subject: drivers/dahdi/icE1usb: defer USB transfer when setting loopback mode ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Enabling loopback now works on my machine: root@isdnpi ~ # dahdi_maint -s 1 --loopback networkline Span 1: network line loopback ON root@isdnpi ~ # dmesg [..] Sep 15 15:06:02 isdnpi kernel: icE1usb 3-2:1.0: entering e1u_d_maint(2) Sep 15 15:06:02 isdnpi kernel: icE1usb 3-2:1.0: Turning on network line loopback Sep 15 15:06:02 isdnpi kernel: icE1usb 3-2:1.0: TX-CONFIG (crc4=TS0_CRC4_E, timing=LOCAL, ext_loopback=SAME, tx_yellow_alarm=0) This fixes https://osmocom.org/issues/7089 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/43642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Iba99fc5261059c77cc89d867b21c70a34c9b4ea6 Gerrit-Change-Number: 43642 Gerrit-PatchSet: 1 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 15 Sep 2026 13:43:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in dahdi-linux[master]: drivers/dahdi/icE1usb: defer USB transfer when setting loopback mode
by manawyrm 15 Sep '26

15 Sep '26

manawyrm has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/43642?usp=email ) Change subject: drivers/dahdi/icE1usb: defer USB transfer when setting loopback mode ...................................................................... drivers/dahdi/icE1usb: defer USB transfer when setting loopback mode The icE1usb driver would deadlock/hang the kernel when trying to configure a internal loopback mode via the "dahdi_maint" utility. Previously, it tried to do a USB transfer without enabled interrupts inside a spinlock, which caused the infinite hang. This change moves the ice1usb_tx_config() call to a workqueue. Change-Id: Iba99fc5261059c77cc89d867b21c70a34c9b4ea6 --- M drivers/dahdi/icE1usb/icE1usb.c 1 file changed, 26 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/42/43642/1 diff --git a/drivers/dahdi/icE1usb/icE1usb.c b/drivers/dahdi/icE1usb/icE1usb.c index a861515..ebeaee6 100644 --- a/drivers/dahdi/icE1usb/icE1usb.c +++ b/drivers/dahdi/icE1usb/icE1usb.c @@ -29,6 +29,7 @@ #include <linux/slab.h> #include <linux/kernel.h> #include <linux/spinlock.h> +#include <linux/workqueue.h> #include <linux/pm_runtime.h> #include <dahdi/kernel.h> @@ -135,6 +136,8 @@ } dahdi; /* is the device still present (true) or already absent/unplugged (false) */ bool present; + /* deferred ice1usb_tx_config(), scheduled from the atomic .maint callback */ + struct work_struct tx_config_work; /* spinlock protecting concurrent access to fc, {read,write}chunk_idx, ... */ spinlock_t lock; /* maximum number of 32-byte E1 frames to send in one ISO OUT packet */ @@ -880,11 +883,26 @@ return 0; } -/* set some maintenance mode according to 'cmd' */ +static void ice1usb_deferred_tx_config(struct work_struct *work) +{ + struct ice1usb *ieu = container_of(work, struct ice1usb, tx_config_work); + int rc; + + if (!ieu->present) + return; + + rc = ice1usb_tx_config(ieu); + if (rc < 0) + ieu_err(ieu, "Failed to apply maint TX config: %d\n", rc); +} + +/* set some maintenance mode according to 'cmd' + * + * Called by the DAHDI core with span->lock held and IRQs disabled, so the + * blocking USB I/O is deferred to ice1usb_deferred_tx_config(). */ static int e1u_d_maint(struct dahdi_span *span, int cmd) { struct ice1usb *ieu = container_of(span, struct ice1usb, dahdi.span); - int rc = 0; ieu_dbg(ieu, "entering %s(%d)", __FUNCTION__, cmd); @@ -892,12 +910,12 @@ case DAHDI_MAINT_NONE: ieu_info(ieu, "Clearing all maint modes\n"); ieu->cfg.tx.ext_loopback = ICE1USB_TX_EXT_LOOPBACK_OFF; - rc = ice1usb_tx_config(ieu); + schedule_work(&ieu->tx_config_work); break; case DAHDI_MAINT_NETWORKLINELOOP: ieu_info(ieu, "Turning on network line loopback\n"); ieu->cfg.tx.ext_loopback = ICE1USB_TX_EXT_LOOPBACK_SAME; - rc = ice1usb_tx_config(ieu); + schedule_work(&ieu->tx_config_work); break; /* TODO: DAHDI_MAINT_*_DEFECT */ /* TODO: DAHDI_MAINT_ALARM_SIM */ @@ -910,7 +928,7 @@ return -ENOSYS; } - return rc; + return 0; } static const struct dahdi_span_ops ice1usb_span_ops = { @@ -1413,6 +1431,7 @@ ieu->fc.r_sw = 8192; ieu->present = true; spin_lock_init(&ieu->lock); + INIT_WORK(&ieu->tx_config_work, ice1usb_deferred_tx_config); /* locate ON / OFF altsettings */ ieu->alt_off = find_altsetting_off(ieu->usb_intf); @@ -1514,6 +1533,8 @@ /* will in turn call e1u_d_shutdown() which stops all transfers */ dahdi_unregister_device(ieu->dahdi.dev); + cancel_work_sync(&ieu->tx_config_work); + ice1usb_free(ieu); } -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/43642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Iba99fc5261059c77cc89d867b21c70a34c9b4ea6 Gerrit-Change-Number: 43642 Gerrit-PatchSet: 1 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de>

1 0

[L] Change in osmo-dev[master]: README: modernize
by pespin 15 Sep '26

15 Sep '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/43641?usp=email ) Change subject: README: modernize ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/43641?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ie653062d43c486ce977ed772f0d06f0199952188 Gerrit-Change-Number: 43641 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Sep 2026 10:56:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-dev[master]: README: modernize
by osmith 15 Sep '26

15 Sep '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/43641?usp=email ) Change subject: README: modernize ...................................................................... README: modernize Change-Id: Ie653062d43c486ce977ed772f0d06f0199952188 --- D README A README.md A ttcn3/tmux/README.md 3 files changed, 191 insertions(+), 156 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/41/43641/1 diff --git a/README b/README deleted file mode 100644 index e425c8e..0000000 --- a/README +++ /dev/null @@ -1,156 +0,0 @@ -=== WHAT IS THIS? - -* quickly build the entire Osmocom core network stack from source, with a - generated top-level makefile (see the rest of this README file below). - -* quickly configure, launch and tear down an entire Osmocom core network on - your box (see net/README). - - -=== Quick Start - -sudo apt install \ - build-essential gcc g++ make automake autoconf libtool pkg-config \ - libtalloc-dev libpcsclite-dev libortp-dev libsctp-dev libssl-dev libdbi-dev \ - libdbd-sqlite3 libsqlite3-dev libpcap-dev libc-ares-dev libgnutls28-dev \ - libsctp-dev sqlite3 libusb-1.0-0-dev libmnl-dev libsofia-sip-ua-glib-dev - -./gen_makefile.py default.opts iu.opts no_dahdi.opts -I -m make - -cd make -make - -- 'make' will ask for sudo password to run 'make install' and 'ldconfig'. - To run non-interactively: - - - 'make install': - chown $USER: /usr/local - Then call gen_makefile.py once without the -I option - - - 'ldconfig': - echo "$USER ALL= NOPASSWD: /sbin/ldconfig" > /etc/sudoers.d/ldconfig - - -=== gen_makefile.py - -This provides a set of top-level makefiles to build variants of the Osmocom -source trees. It is inteded for the core network components and related -projects, but works generically. - -The idea is to have all your Osmocom git clones in ./src, while keeping one or -more separate build trees in ./make-*. - -Run ./gen_makefile.py with a choice of choice of configure options. - - -Examples: - -CN with full 2G and 3G support: - - ./gen_makefile.py default.opts iu.opts -m make - cd make - make cn - -Other make targets exist for specific use cases: - - - 'usrp': - Build the CN, OsmoBSC, OsmoBTS and OsmoTRX (default, e.g. when connecting - to an USRP) - - - 'cn-bsc': - Build the CN and OsmoBSC (e.g. when connecting to an external sysmoBTS) - - - 'osmo-msc': - Build only the OsmoMSC project and its dependencies (this can be used for - any project in all.deps). - - - '.make.osmo-ttcn3-hacks.clone' - Clone the osmo-ttcn3-hacks git repository (it cannot be built by osmo-dev, - but cloning it is still useful.) - -If you make modifications in one of the source trees, this Makefile will pick -it up, rebuild the project and also rebuild all dependencies (according to -all.deps). - -If you modify the all.deps or *.opts file, you can easily run 'make regen' in a -make-* subdir to regenerate the Makefile from the same files. - -In your make-* subdir there are empty status files that are touched for every -completed make target. From these, 'make' can detect what needs to be rebuilt. -You can manually remove them to force a rebuild of a specific target. - -For example, if you 'rm .make.libosmocore.autoconf', libosmocore and all -projects depending on libosmocore will be rebuilt from scratch. - -For more details on the *.opts and all.deps syntax, read the docs at the top of -./gen_makefile.py. - -It is also easily possible to keep sources and build trees in various -configurations, see the command line options of ./gen_makefile.py. - - -=== Install in /usr - -By default, the Osmocom install prefix is /usr/local, while (currently) the -default systemd *.service files expect binaries installed in /usr/bin. To -install in /usr instead, use prefix_usr.opts, which sets --prefix=/usr. - - -=== Systemd Service Files - -If you encounter problems installing *.service files, no_systemd.opts may help: - -Systemd recommends installing service files in the distribution's single -service file location; that may sound sane, but if that location is -/lib/systemd/system, that means even a --prefix=/home/private/prefix ends up -trying to install service files system-wide in /lib/systemd/system, making all -attempts to install to a user-writable location fail. - -no_systemd.opts disables installing *.service files. - - -=== Build Environment - -For dependencies, see the "External dependencies" on: - - https://osmocom.org/projects/cellular-infrastructure/wiki/Build_from_Source - -If /usr/local/ is not writable by your user, pass the --sudo-make-install -option to gen_makefile.py above (a custom --prefix is not yet supported). - -If your system doesn't have this by default, you will need: - - export LD_LIBRARY_PATH="/usr/local/lib" - -and - - export PKG_CONFIG_PATH="/usr/local/lib/pkgconfig" - -to your environment. To use the installed binaries after installation, also - - export PATH="$PATH:/usr/local/bin" - - -=== osmo-uninstall.sh - -Remove osmocom built binaries and headers from given prefix, -default is /usr/local. - - -=== src/* - -Find other useful scripts in src/, see src/README. - -=== ttcn3/tmux - -It's possible to run TTCN-3 test cases without using Docker. This directory -contains scripts for starting a testsuite and the related binaries in a tmux -session. For example, ttcn3-bsc-test.sh does the following: - -* Starts osmo-bsc, osmo-stp, and three instances of osmo-bts-omldummy. -* Prepares a command for execuring the test suite. - -=== Troubleshooting - -When using sanitize.opts, osmo-trx is not built with the address sanitizer -enabled. Linking a sanitizer-enabled libosmocore will not work. diff --git a/README.md b/README.md new file mode 100644 index 0000000..af26d84 --- /dev/null +++ b/README.md @@ -0,0 +1,185 @@ +# osmo-dev + +## Overview + +The main purpose of this project is building the Osmocom stack (and related +projects such as Open5GS) from source with `gen_makefile.py`. This is described +in more detail below. + +### Additional scripts + +* `net`: quickly configure, launch and tear down an entire Osmocom core network + on your box (see `net/README`). + +* `ttcn3/tmux`: start a tmux session with a TTCN-3 testsuite and related + binaries (see `ttcn3/tmux/README.md`). + +* `src`: other useful scripts related to git and gerrit (see `src/README`). + +* `osmo-uninstall.sh`: remove installed binaries, libraries and headers from a + given prefix, the default is `/usr/local`. + +## `gen_makefile.py` + +This script generates a `Makefile` that was originally intended to build the +Osmocom core network components, but has since been extended to also build +Open5GS, PyHSS and more. See `all.deps` for a list of supported projects. + +The idea is to have all your git clones in `./src`, while keeping one or more +separate build trees in `./make*` dirs. + +`gen_makefile.py` gets used by +[`testenv.py`](https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks/src/branch/master/_testenv/README.md) +in `osmo-ttcn3-hacks.git` to build projects from source when running without +the `--binary-repo` argument. + +### Dependencies + +Install required packages first. To have enough dependencies for building and +installing most Osmocom programs, you can run this on Debian-based systems: + +``` +$ sudo apt install \ + build-essential gcc g++ make automake autoconf libtool pkg-config \ + libtalloc-dev libpcsclite-dev libortp-dev libsctp-dev libssl-dev libdbi-dev \ + libdbd-sqlite3 libsqlite3-dev libpcap-dev libc-ares-dev libgnutls28-dev \ + libsctp-dev sqlite3 libusb-1.0-0-dev libmnl-dev libsofia-sip-ua-glib-dev +``` + +### Example usage + +Build the Osmocom core network with full 2G and 3G support: + +``` +$ ./gen_makefile.py default.opts iu.opts no_dahdi.opts no_systemd.opts -I -m make +$ cd make +$ make cn +``` + +If you make modifications in one of the source trees, this `Makefile` will pick +it up, rebuild the project and also rebuild all dependencies (according to +`all.deps`). It is also easily possible to keep sources and build trees in +various configurations, see the command line options of `gen_makefile.py`. + +### Make targets + +Other make targets exist for specific use cases: + +* `usrp`: + Build the CN, OsmoBSC, OsmoBTS and OsmoTRX (default, e.g. when connecting + to an USRP) + +* `cn-bsc`: + Build the CN and OsmoBSC (e.g. when connecting to an external sysmoBTS) + +* `osmo-msc`: + Build only the OsmoMSC project and its dependencies (this can be used for + any project in `all.deps`). + +* `.make.osmo-ttcn3-hacks.clone`: + Clone the osmo-ttcn3-hacks git repository (it cannot be built by osmo-dev, + but cloning it is still useful.) + +If you modify the `all.deps` or `*.opts` file, you can easily run `make regen` +in a `make*` subdir to regenerate the `Makefile` from the same files, with the +same options for `gen_makefile.py`. + +In your `make*` subdir there are empty status files that are touched for every +completed make target. From these, `make` can detect what needs to be rebuilt. +You can manually remove them to force a rebuild of a specific target. For +example, if you `rm .make.libosmocore.autoconf`, libosmocore and all projects +depending on libosmocore will be rebuilt from scratch. + +### Configuration files + +### all.deps + +Whitespace-separated listing of: +``` +project_name depends_on_project_1 depends_on_project_2 ... +``` + +### all.urls + +Projects that are not developed at `gerrit.osmocom.org/$project` are listed +here in the following format: +``` +project_name URL +``` + +### all.buildsystems + +Projects that are not using `autotools` need an entry in this file in the +form of: +``` +project_name BUILDSYSTEM +``` + +Supported buildsystems are: +* `autotools` +* `cmake` +* `erlang` +* `meson` +* `python` + +#### `*.opts` files + +The `*.opts` files provide options that are passed to `./configure`, +`meson setup` and `cmake`. They have the following format: + +``` +project_name OPTION(S) +``` + +If `project_name` is `ALL`, the option gets added to all projects using the +`autotools` build system. This is because `./configure` just ignores any +options it does not understand and initially only `autotools` was supported by +`gen_makefile.py`. + +Find more information about specific `*.opts` files below. + +##### `prefix_usr.opts` + +By default, the Osmocom install prefix is `/usr/local`, while the systemd +`*.service` files expect binaries installed in `/usr/bin`. To install to `/usr` +instead, it is possible to add `prefix_usr.opts` to the `gen_makefile.py` +arguments, which sets `--prefix=/usr`. Be aware that this will cause problems +with distribution packages. + +##### `no_systemd.opts` + +`no_systemd.opts` disables installing `*.service` files, which is useful +because these files get installed to `/usr/lib/systemd/system` even if the +prefix is not `/usr`. Using `no_systemd.opts` is required for running +`gen_makefile.py` without the `-I` (`--sudo-make-install`) argument. + +### Run without sudo prompts + +`make` will ask for the sudo password to run `make install` and `ldconfig`. To +run non-interactively: + +``` +$ sudo chown -R $USER: /usr/local +$ echo "$USER ALL= NOPASSWD: $(command -v ldconfig)" | sudo tee /etc/sudoers.d/ldconfig +``` + +Then call `gen_makefile.py` once without `-I` (`--sudo-make-install`). + +## Troubleshooting + +### Environment variables + +If your system can't find installed libraries (e.g. if you run +`gen_makefile.py` with `--no-ldconfig`), pkg-config files or binaries then +setting these environment variables should help: + +``` +export LD_LIBRARY_PATH="/usr/local/lib" +export PKG_CONFIG_PATH="/usr/local/lib/pkgconfig" +export PATH="$PATH:/usr/local/bin" +``` + +### sanitize.opts and osmo-trx + +When using sanitize.opts, osmo-trx is not built with the address sanitizer +enabled. Linking a sanitizer-enabled libosmocore will not work. diff --git a/ttcn3/tmux/README.md b/ttcn3/tmux/README.md new file mode 100644 index 0000000..0d09976 --- /dev/null +++ b/ttcn3/tmux/README.md @@ -0,0 +1,6 @@ +It's possible to run TTCN-3 test cases without using Docker. This directory +contains scripts for starting a testsuite and the related binaries in a tmux +session. For example, ttcn3-bsc-test.sh does the following: + +* Starts osmo-bsc, osmo-stp, and three instances of osmo-bts-omldummy. +* Prepares a command for execuring the test suite. -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/43641?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ie653062d43c486ce977ed772f0d06f0199952188 Gerrit-Change-Number: 43641 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 7a628a1029ef174328f7e86183f19e54e5d9df8f
by Jenkins Builder 15 Sep '26

15 Sep '26

Attention is currently required from: laforge, lynxis lazus, osmith. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email ) Change subject: add libvlr based on MSC commit 7a628a1029ef174328f7e86183f19e54e5d9df8f ...................................................................... Patch Set 11: (1 comment) File src/libvlr/vlr.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/70a7277a_e59a717e?us… : PS11, Line 265: strcpy(name + maxlen - 2, ".."); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Sep 2026 09:46:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 7a628a1029ef174328f7e86183f19e54e5d9df8f
by Jenkins Builder 15 Sep '26

15 Sep '26

Attention is currently required from: laforge, lynxis lazus, osmith. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email ) Change subject: add libvlr based on MSC commit 7a628a1029ef174328f7e86183f19e54e5d9df8f ...................................................................... Patch Set 10: (1 comment) File src/libvlr/vlr.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/7a83c326_0b0ebaf7?us… : PS10, Line 265: strcpy(name + maxlen - 2, ".."); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Sep 2026 09:46:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-sgsn[master]: sgsn_libgtp.c: cosmetic white space fix
by pespin 15 Sep '26

15 Sep '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43640?usp=email ) Change subject: sgsn_libgtp.c: cosmetic white space fix ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43640?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I7ec15c54a5352ab5bde0671cc329ae54099cc4fc Gerrit-Change-Number: 43640 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Sep 2026 09:38:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in osmo-sgsn[master]: Rework SGSN code to use new libvlr code
by lynxis lazus 15 Sep '26

15 Sep '26

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email ) Change subject: Rework SGSN code to use new libvlr code ...................................................................... Patch Set 19: (6 comments) File include/osmocom/sgsn/debug.h: https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/485c2271_3f90a840?us… : PS16, Line 31: DSGS, /* only as placeholder, SGS isn't used by the SGSN */ > because libvlr is using it. I improved the comment. I removed it. File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/c52baeb1_692aec49?us… : PS17, Line 2602: osmo_vlr_set_log_cat(OSMO_VLR_LOGC_VLR, DVLR); > If we can set the log category here, I wonder why it does use the SGS category hardcoded as you ment […] I'm using it now. Still not happy with the usage of SGS fsm, but it doesn't hurt atm. I want to remove it from the SGSN later, when libvlr only uses SGS on CS. File src/sgsn/gprs_gmm_fsm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/8b33f704_83775b61?us… : PS16, Line 262: /* fixme: this state seems to be wrong. When in COMMON_PROC_INIT, we shouldn't go into deregistered. */ > FIXME Done https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/a78d2e54_ec510f2c?us… : PS16, Line 307: .allstate_event_mask = X(E_GMM_CLEANUP) | X(E_GMM_RAT_CHANGE) | X(E_GMM_SERVICE_ACCEPT) | X(E_GMM_SERVICE_REJECT), > plese better move to one per line, it's much easier to read. Done File src/sgsn/gprs_rau_fsm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/70685dfa_e5ed2078?us… : PS16, Line 303: .action = gmm_rau_fsm_s_init, > I'd really welcome using at least "st" for state, not only "s". Done File src/sgsn/sgsn_libgtp.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/8cb49ea2_cbd10987?us… : PS16, Line 534: return 0; /* Nothing to do */ > This is the kind of fixes which can be done in a separate patch. […] another white space slipped through... -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 Gerrit-Change-Number: 39562 Gerrit-PatchSet: 19 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Sep 2026 09:37:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-sgsn[master]: libvlr: Remove MSC specific parts
by pespin 15 Sep '26

15 Sep '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43461?usp=email ) Change subject: libvlr: Remove MSC specific parts ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I35e3edc56c7c64ac2a4462dec8ea684b00ab3881 Gerrit-Change-Number: 43461 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Sep 2026 09:34:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in osmo-sgsn[master]: Rework SGSN code to use new libvlr code
by lynxis lazus 15 Sep '26

15 Sep '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email to look at the new patch set (#19). Change subject: Rework SGSN code to use new libvlr code ...................................................................... Rework SGSN code to use new libvlr code The libvlr code will take most of the logic of the Routing Area handling. By using the new libvlr code, the ACL and usage of the SGSN without the HLR has been removed. Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 --- M include/osmocom/sgsn/Makefile.am M include/osmocom/sgsn/debug.h A include/osmocom/sgsn/gmm_rau_fsm.h M include/osmocom/sgsn/gprs_gmm.h M include/osmocom/sgsn/gprs_gmm_attach.h M include/osmocom/sgsn/gprs_gmm_fsm.h M include/osmocom/sgsn/gprs_subscriber.h M include/osmocom/sgsn/mmctx.h M include/osmocom/sgsn/sgsn.h M src/sgsn/Makefile.am A src/sgsn/gmm_rau_fsm.c M src/sgsn/gprs_gmm.c M src/sgsn/gprs_gmm_attach.c M src/sgsn/gprs_gmm_fsm.c M src/sgsn/gprs_ranap.c M src/sgsn/gprs_subscriber.c M src/sgsn/mmctx.c M src/sgsn/sgsn.c M src/sgsn/sgsn_auth.c M src/sgsn/sgsn_libgtp.c M src/sgsn/sgsn_main.c M src/sgsn/sgsn_vty.c M tests/gprs_routing_area/Makefile.am M tests/sgsn/Makefile.am M tests/sgsn/sgsn_test.c M tests/sgsn/sgsn_test.ok M tests/vty_test_runner.py 27 files changed, 1,316 insertions(+), 3,833 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/62/39562/19 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 Gerrit-Change-Number: 39562 Gerrit-PatchSet: 19 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log September 2026