September 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-sgsn[master]: gprs_gmm: Attach Complete: add TODO for follow-on request
by lynxis lazus 15 Sep '26

15 Sep '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43597?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: gprs_gmm: Attach Complete: add TODO for follow-on request ...................................................................... gprs_gmm: Attach Complete: add TODO for follow-on request Iu supports a follow-on request after an Attach Req. Currently unsupported. Change-Id: I136ff28262b5caec139765881ba2efd64ab75dcc --- M src/sgsn/gprs_gmm.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index 6df849d..84c6387 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -1417,6 +1417,7 @@ LOGMMCTXP(LOGL_INFO, mmctx, "-> GMM ATTACH COMPLETE\n"); #ifdef BUILD_IU + /* TODO: check follow-on request */ if (mmctx->iu.ue_ctx) { sgsn_ranap_iu_tx_release(mmctx->iu.ue_ctx, NULL); } -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I136ff28262b5caec139765881ba2efd64ab75dcc Gerrit-Change-Number: 43597 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: gprs_gmm: cosmetic
by lynxis lazus 15 Sep '26

15 Sep '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43596?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: gprs_gmm: cosmetic ...................................................................... gprs_gmm: cosmetic Change-Id: I8f3e647cb7dc3a1b59a560e0301e4d4db1f94f8b --- M src/sgsn/gprs_gmm.c 1 file changed, 4 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index 8ebd123..6df849d 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -196,7 +196,6 @@ sgsn_mm_ctx_cleanup_free(ctx); } - /* 3GPP TS 24.008 § 10.5.7.1 Process PDP context status value, bit 0 corresponds to nsapi 0 */ static void process_ms_ctx_status(struct sgsn_mm_ctx *mmctx, uint16_t pdp_status) @@ -891,8 +890,9 @@ return gsm48_gmm_sendmsg(msg, 0, NULL, true); } + static int gsm48_tx_gmm_service_rej_oldmsg(const struct msgb *old_msg, - uint8_t gmm_cause) + uint8_t gmm_cause) { struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 SERVICE REJ OLD"); gmm_copy_id(msg, old_msg); @@ -901,7 +901,7 @@ #if 0 -- currently unused -- static int gsm48_tx_gmm_service_rej(struct sgsn_mm_ctx *mm, - uint8_t gmm_cause) + uint8_t gmm_cause) { struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 SERVICE REJ"); mmctx2msgid(msg, mm); @@ -1407,7 +1407,6 @@ gprs_llgmm_unassign(llme); return rc; - } /* 3GPP TS 24.008 § 9.4.3 Attach complete */ @@ -1772,7 +1771,7 @@ #endif if (mmctx->ran_type == MM_CTX_T_GERAN_Gb) { /* Even if there is no P-TMSI allocated, the MS will switch from - * foreign TLLI to local TLLI */ + * foreign TLLI to local TLLI */ mmctx->gb.tlli_new = gprs_tmsi2tlli(mmctx->p_tmsi, TLLI_LOCAL); /* Inform LLC layer about new TLLI but keep accepting the old one during Rx */ @@ -1974,10 +1973,8 @@ rc = gsm48_tx_gmm_service_rej_oldmsg(msg, reject_cause); return rc; - } - static int gsm48_rx_gmm_status(struct sgsn_mm_ctx *mmctx, struct msgb *msg) { struct gsm48_hdr *gh = msgb_l3(msg); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43596?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8f3e647cb7dc3a1b59a560e0301e4d4db1f94f8b Gerrit-Change-Number: 43596 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-sgsn[master]: gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request
by lynxis lazus 15 Sep '26

15 Sep '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email ) Change subject: gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request ...................................................................... gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request gprs_gmm_parse_att_req() is a parser for Attach Request, use it. Change-Id: Iee3c66d6ab21ead103241753f927d9245aad9e64 --- M src/sgsn/gprs_gmm.c 1 file changed, 22 insertions(+), 55 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index 3d4b940..8ebd123 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -1244,20 +1244,22 @@ static int gsm48_rx_gmm_att_req(struct sgsn_mm_ctx *ctx, struct msgb *msg, struct gprs_llc_llme *llme) { - struct gsm48_hdr *gh = (struct gsm48_hdr *) msgb_gmmh(msg); - uint8_t *cur = gh->data, *msnc, *mi_data, *ms_ra_acc_cap; - uint8_t msnc_len, att_type, mi_len, ms_ra_acc_cap_len; - uint16_t drx_par; + struct gprs_gmm_att_req req = {}; char mi_log_string[32]; struct osmo_routing_area_id rai; uint16_t cid = 0; enum gsm48_gmm_cause reject_cause; - struct osmo_mobile_identity mi; int rc; LOGMMCTXP(LOGL_INFO, ctx, "-> GMM ATTACH REQUEST "); rate_ctr_inc(rate_ctr_group_get_ctr(sgsn->rate_ctrs, CTR_GPRS_ATTACH_REQUEST)); + rc = gprs_gmm_parse_att_req(msg, &req); + if (rc) { + LOGMMCTXP(LOGL_ERROR, ctx, "Invalid Attach Request message received.\n"); + goto err_inval; + } + /* As per TS 04.08 Chapter 4.7.1.4, the attach request arrives either * with a foreign TLLI (P-TMSI that was allocated to the MS before), * or with random TLLI. */ @@ -1274,58 +1276,23 @@ #endif } - /* MS network capability 10.5.5.12 */ - msnc_len = *cur++; - msnc = cur; - if (msnc_len > sizeof(ctx->ms_network_capa.buf)) - goto err_inval; - cur += msnc_len; - /* TODO: In iu mode - handle follow-on request. * The follow-on request can be signaled in an Attach Request on IuPS. * This means the MS/UE asks to keep the PS connection open for further requests * after the Attach Request succeed. * The SGSN can decide if it close the connection or not. Both are spec conform. */ - /* aTTACH Type 10.5.5.2 */ - att_type = *cur++ & 0x07; - - /* DRX parameter 10.5.5.6 */ - drx_par = *cur++ << 8; - drx_par |= *cur++; - - /* Mobile Identity (P-TMSI or IMSI) 10.5.1.4 */ - mi_len = *cur++; - mi_data = cur; - cur += mi_len; - - rc = osmo_mobile_identity_decode(&mi, mi_data, mi_len, false); - if (rc) - goto err_inval; - osmo_mobile_identity_to_str_buf(mi_log_string, sizeof(mi_log_string), &mi); - - DEBUGPC(DMM, "MI(%s) type=\"%s\" ", mi_log_string, - get_value_string(gprs_att_t_strs, att_type)); - - /* Old routing area identification 10.5.5.15. Skip it */ - cur += 6; - - /* MS Radio Access Capability 10.5.5.12a */ - ms_ra_acc_cap_len = *cur++; - ms_ra_acc_cap = cur; - if (ms_ra_acc_cap_len > sizeof(ctx->ms_radio_access_capa.buf)) - goto err_inval; - cur += ms_ra_acc_cap_len; - - LOGPC(DMM, LOGL_INFO, "\n"); + osmo_mobile_identity_to_str_buf(mi_log_string, sizeof(mi_log_string), &req.mi); + LOGPC(DMM, LOGL_INFO, "MI(%s) type=\"%s\"\n", mi_log_string, + get_value_string(gprs_att_t_strs, req.attach_type)); /* Optional: Old P-TMSI Signature, Requested READY timer, TMSI Status */ - switch (mi.type) { + switch (req.mi.type) { case GSM_MI_TYPE_IMSI: /* Try to find MM context based on IMSI */ if (!ctx) - ctx = sgsn_mm_ctx_by_imsi(mi.imsi); + ctx = sgsn_mm_ctx_by_imsi(req.mi.imsi); if (!ctx) { if (MSG_IU_UE_CTX(msg)) ctx = sgsn_mm_ctx_alloc_iu(MSG_IU_UE_CTX(msg)); @@ -1335,13 +1302,13 @@ reject_cause = GMM_CAUSE_NET_FAIL; goto rejected; } - OSMO_STRLCPY_ARRAY(ctx->imsi, mi.imsi); + OSMO_STRLCPY_ARRAY(ctx->imsi, req.mi.imsi); } break; case GSM_MI_TYPE_TMSI: /* Try to find MM context based on P-TMSI */ if (!ctx) - ctx = sgsn_mm_ctx_by_ptmsi(mi.tmsi); + ctx = sgsn_mm_ctx_by_ptmsi(req.mi.tmsi); if (!ctx) { /* Allocate a context as most of our code expects one. * Context will not have an IMSI ultil ID RESP is received */ @@ -1353,7 +1320,7 @@ reject_cause = GMM_CAUSE_NET_FAIL; goto rejected; } - ctx->p_tmsi = mi.tmsi; + ctx->p_tmsi = req.mi.tmsi; } break; default: @@ -1377,14 +1344,15 @@ ctx->gb.cell_id = cid; /* Update MM Context with other data */ - ctx->drx_parms = drx_par; - ctx->ms_radio_access_capa.len = ms_ra_acc_cap_len; - memcpy(ctx->ms_radio_access_capa.buf, ms_ra_acc_cap, + ctx->drx_parms = req.drx_parms; + ctx->ms_radio_access_capa.len = OSMO_MIN(req.ms_radio_cap_len, sizeof(ctx->ms_radio_access_capa.buf)); + memcpy(ctx->ms_radio_access_capa.buf, req.ms_radio_cap, ctx->ms_radio_access_capa.len); - ctx->ms_network_capa.len = msnc_len; - memcpy(ctx->ms_network_capa.buf, msnc, msnc_len); - ctx->ue_cipher_mask = gprs_ms_net_cap_gea_mask(ctx->ms_network_capa.buf, msnc_len); + ctx->ms_network_capa.len = OSMO_MIN(req.ms_network_cap_len, sizeof(ctx->ms_network_capa.buf)); + memcpy(ctx->ms_network_capa.buf, req.ms_network_cap, ctx->ms_network_capa.len); + + ctx->ue_cipher_mask = gprs_ms_net_cap_gea_mask(ctx->ms_network_capa.buf, ctx->ms_network_capa.len); if (!(ctx->ue_cipher_mask & sgsn->cfg.gea_encryption_mask)) { reject_cause = GMM_CAUSE_PROTO_ERR_UNSPEC; @@ -1425,7 +1393,6 @@ return 0; err_inval: - LOGPC(DMM, LOGL_INFO, "\n"); reject_cause = GMM_CAUSE_SEM_INCORR_MSG; rejected: -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iee3c66d6ab21ead103241753f927d9245aad9e64 Gerrit-Change-Number: 43595 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: Routing Area Update: ensure PDP_CTX_STATUS has correct lenght
by lynxis lazus 15 Sep '26

15 Sep '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43599?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: gprs_gmm: Routing Area Update: ensure PDP_CTX_STATUS has correct lenght ...................................................................... gprs_gmm: Routing Area Update: ensure PDP_CTX_STATUS has correct lenght Change-Id: Ic9560108ee424634e15a5af1424ea44df491a474 --- M src/sgsn/gprs_gmm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index 976e710..fcb243f 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -1782,7 +1782,7 @@ /* Look at PDP Context Status IE and see if MS's view of * activated/deactivated NSAPIs agrees with our view */ - if (TLVP_PRESENT(&req.tlv, GSM48_IE_GMM_PDP_CTX_STATUS)) { + if (TLVP_PRES_LEN(&req.tlv, GSM48_IE_GMM_PDP_CTX_STATUS, 2)) { uint16_t pdp_status = osmo_load16le(TLVP_VAL(&req.tlv, GSM48_IE_GMM_PDP_CTX_STATUS)); process_ms_ctx_status(mmctx, pdp_status); } -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43599?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic9560108ee424634e15a5af1424ea44df491a474 Gerrit-Change-Number: 43599 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: Service Request: add FIXME to check authentication
by lynxis lazus 15 Sep '26

15 Sep '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43598?usp=email ) Change subject: gprs_gmm: Service Request: add FIXME to check authentication ...................................................................... gprs_gmm: Service Request: add FIXME to check authentication Before parsing the PDP status of a Service Request, the Service Request has to be authenticated, otherwise it is possible to close a UE's PDP context by sending a fake Service Request. Change-Id: Icab4a223ec9a7987ede38772339f544312d950c2 --- M src/sgsn/gprs_gmm.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index 84c6387..976e710 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -1945,6 +1945,7 @@ /* TODO: Use tlvp_val16le when available */ uint16_t pdp_status = osmo_load16le(TLVP_VAL(&tp, GSM48_IE_GMM_PDP_CTX_STATUS)); + /* FIXME: this should be done after the connection has been authenticated! */ process_ms_ctx_status(ctx, pdp_status); /* 3GPP TS 24.008 § 4.7.13.4 Service request procedure not -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icab4a223ec9a7987ede38772339f544312d950c2 Gerrit-Change-Number: 43598 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: gprs_gmm: refactor handling of GMM Detach Accept into own function
by lynxis lazus 15 Sep '26

15 Sep '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43600?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: gprs_gmm: refactor handling of GMM Detach Accept into own function ...................................................................... gprs_gmm: refactor handling of GMM Detach Accept into own function Change-Id: Iae846bbff0df04295a1579017117b3e84fa29157 --- M src/sgsn/gprs_gmm.c 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index fcb243f..778457d 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -1501,6 +1501,14 @@ return rc; } +/* CHapter 9.4.6: MT Detach Ack */ +static int gsm48_rx_gmm_det_accept(struct sgsn_mm_ctx *ctx, struct msgb *msg) +{ + LOGMMCTXP(LOGL_INFO, ctx, "-> DETACH ACK\n"); + mm_ctx_cleanup_free(ctx, "GMM DETACH ACK"); + return 0; +} + /* Chapter 9.4.15: Routing area update accept */ static int gsm48_tx_gmm_ra_upd_ack(struct sgsn_mm_ctx *mm) { @@ -2099,9 +2107,7 @@ case GSM48_MT_GMM_DETACH_ACK: if (!mmctx) goto null_mmctx; - LOGMMCTXP(LOGL_INFO, mmctx, "-> DETACH ACK\n"); - mm_ctx_cleanup_free(mmctx, "GMM DETACH ACK"); - rc = 0; + rc = gsm48_rx_gmm_det_accept(mmctx, msg); break; case GSM48_MT_GMM_ATTACH_COMPL: if (!mmctx) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iae846bbff0df04295a1579017117b3e84fa29157 Gerrit-Change-Number: 43600 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: Use osmo_select_main_ctx to support talloc context OTC_SELECT
by lynxis lazus 15 Sep '26

15 Sep '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39703?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Use osmo_select_main_ctx to support talloc context OTC_SELECT ...................................................................... Use osmo_select_main_ctx to support talloc context OTC_SELECT The libvlr code is using the OTC_SELECT talloc context. Change-Id: I4b26b73af706ce790181085880c6866e7f7e8c65 --- M src/sgsn/sgsn_main.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/src/sgsn/sgsn_main.c b/src/sgsn/sgsn_main.c index 7489790..253a733 100644 --- a/src/sgsn/sgsn_main.c +++ b/src/sgsn/sgsn_main.c @@ -486,7 +486,7 @@ } while (1) { - rc = osmo_select_main(0); + rc = osmo_select_main_ctx(0); if (rc < 0) exit(3); } -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39703?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4b26b73af706ce790181085880c6866e7f7e8c65 Gerrit-Change-Number: 39703 Gerrit-PatchSet: 8 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in osmo-sgsn[master]: Rework SGSN code to use new libvlr code
by lynxis lazus 15 Sep '26

15 Sep '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email to look at the new patch set (#18). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Rework SGSN code to use new libvlr code ...................................................................... Rework SGSN code to use new libvlr code The libvlr code will take most of the logic of the Routing Area handling. By using the new libvlr code, the ACL and usage of the SGSN without the HLR has been removed. Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 --- M include/osmocom/sgsn/Makefile.am M include/osmocom/sgsn/debug.h A include/osmocom/sgsn/gmm_rau_fsm.h M include/osmocom/sgsn/gprs_gmm.h M include/osmocom/sgsn/gprs_gmm_attach.h M include/osmocom/sgsn/gprs_gmm_fsm.h M include/osmocom/sgsn/gprs_subscriber.h M include/osmocom/sgsn/mmctx.h M include/osmocom/sgsn/sgsn.h M src/sgsn/Makefile.am A src/sgsn/gmm_rau_fsm.c M src/sgsn/gprs_gmm.c M src/sgsn/gprs_gmm_attach.c M src/sgsn/gprs_gmm_fsm.c M src/sgsn/gprs_ranap.c M src/sgsn/gprs_subscriber.c M src/sgsn/mmctx.c M src/sgsn/sgsn.c M src/sgsn/sgsn_auth.c M src/sgsn/sgsn_libgtp.c M src/sgsn/sgsn_main.c M src/sgsn/sgsn_vty.c M tests/gprs_routing_area/Makefile.am M tests/sgsn/Makefile.am M tests/sgsn/sgsn_test.c M tests/sgsn/sgsn_test.ok M tests/vty_test_runner.py 27 files changed, 1,310 insertions(+), 3,833 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/62/39562/18 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 Gerrit-Change-Number: 39562 Gerrit-PatchSet: 18 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: sgsn_libgtp.c: cosmetic white space fix
by lynxis lazus 15 Sep '26

15 Sep '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43640?usp=email ) Change subject: sgsn_libgtp.c: cosmetic white space fix ...................................................................... sgsn_libgtp.c: cosmetic white space fix Change-Id: I7ec15c54a5352ab5bde0671cc329ae54099cc4fc --- M src/sgsn/sgsn_libgtp.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/40/43640/1 diff --git a/src/sgsn/sgsn_libgtp.c b/src/sgsn/sgsn_libgtp.c index 03f4942..b4c24a0 100644 --- a/src/sgsn/sgsn_libgtp.c +++ b/src/sgsn/sgsn_libgtp.c @@ -531,7 +531,7 @@ * a Cause value "Non-existent", it shall delete the PDP Context." */ if (cause != GTPCAUSE_NON_EXIST) - return 0; /* Nothing to do */ + return 0; /* Nothing to do */ LOGPDPCTXP(LOGL_INFO, pctx, "PDP CTX we tried to update doesn't exist in " "the GGSN anymore, deleting it locally.\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43640?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I7ec15c54a5352ab5bde0671cc329ae54099cc4fc Gerrit-Change-Number: 43640 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-sgsn[master]: gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request
by pespin 15 Sep '26

15 Sep '26

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email ) Change subject: gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iee3c66d6ab21ead103241753f927d9245aad9e64 Gerrit-Change-Number: 43595 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Sep 2026 09:22:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log September 2026