Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43622?usp=email )
Change subject: IPAd: Check for memory leaks after each test
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43622?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifd5390ac230b48614585d2820b9133daebd8c321
Gerrit-Change-Number: 43622
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 14 Sep 2026 14:57:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620?usp=email )
Change subject: IPAd: Add test case for multple eIM packages
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Patchset:
PS1:
To me this looks good, just two suggestions regarding the rounds parameter.
File ipad/IPAd_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620/comment/4903035c_33dd… :
PS1, Line 1170: var integer i, rounds := 5;
maybe have the rounds parameter as a module parameter? (mp_tc_multi_package_rounds)?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620/comment/410bb9bc_8f0e… :
PS1, Line 1209: f_init(id, 300.0);
maybe write t_guard := 300.0, than its more obvious what the number means. You could also interoperate the rounds parameter. t_guard := rounds * 6.0 ?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I74bba77cc391ed243729e99a5aeaefb9dbde2922
Gerrit-Change-Number: 43620
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 14 Sep 2026 14:42:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43619?usp=email )
Change subject: IPAd: Split f_terminate_poll_cycle()
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
To me this looks good. When I understand everything correctly, then the functionality should not be changed by this patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43619?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4e278f74ce3bb9bbd666f13c2a72ed90eba34af7
Gerrit-Change-Number: 43619
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 14 Sep 2026 14:24:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes