September 2026 - gerrit-log - lists.osmocom.org

[M] Change in osmo-sgsn[master]: gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request
by lynxis lazus 15 Sep '26

15 Sep '26

Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email ) Change subject: gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request ...................................................................... Patch Set 2: (1 comment) File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/43595/comment/afc22752_acce94c7?us… : PS2, Line 1286: LOGPC(DMM, LOGL_INFO, "MI(%s) type=\"%s\"\n", mi_log_string, > What's actually the pooint of printing with LOGPC here if we add a \n at the end? I guess original the idea was to start the log line with "-> GMM ATTACH REQUEST " and then extend it with more and more logging as process goes. But AFAIU LOGPC should be only used if the LOG_LEVEL is the same and there is no log line in between. So this log line is only extending it here once instead of multiple time. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iee3c66d6ab21ead103241753f927d9245aad9e64 Gerrit-Change-Number: 43595 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Sep 2026 09:13:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-sgsn[master]: gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request
by pespin 15 Sep '26

15 Sep '26

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email ) Change subject: gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request ...................................................................... Patch Set 2: (1 comment) File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/43595/comment/64414ae7_a69f73b8?us… : PS2, Line 1286: LOGPC(DMM, LOGL_INFO, "MI(%s) type=\"%s\"\n", mi_log_string, What's actually the pooint of printing with LOGPC here if we add a \n at the end? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iee3c66d6ab21ead103241753f927d9245aad9e64 Gerrit-Change-Number: 43595 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Sep 2026 09:09:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-sgsn[master]: gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request
by laforge 15 Sep '26

15 Sep '26

Attention is currently required from: fixeria, lynxis lazus, pespin. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email ) Change subject: gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iee3c66d6ab21ead103241753f927d9245aad9e64 Gerrit-Change-Number: 43595 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Sep 2026 09:07:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: Service Request: add FIXME to check authentication
by laforge 15 Sep '26

15 Sep '26

Attention is currently required from: fixeria, lynxis lazus, pespin. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43598?usp=email ) Change subject: gprs_gmm: Service Request: add FIXME to check authentication ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icab4a223ec9a7987ede38772339f544312d950c2 Gerrit-Change-Number: 43598 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Sep 2026 09:07:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-sgsn[master]: gprs_gmm: cosmetic
by lynxis lazus 15 Sep '26

15 Sep '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43596?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: gprs_gmm: cosmetic ...................................................................... gprs_gmm: cosmetic Change-Id: I8f3e647cb7dc3a1b59a560e0301e4d4db1f94f8b --- M src/sgsn/gprs_gmm.c 1 file changed, 4 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/96/43596/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43596?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8f3e647cb7dc3a1b59a560e0301e4d4db1f94f8b Gerrit-Change-Number: 43596 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-sgsn[master]: gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request
by lynxis lazus 15 Sep '26

15 Sep '26

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request ...................................................................... gprs_gmm: Use gprs_gmm_parse_att_req() to parse Attach Request gprs_gmm_parse_att_req() is a parser for Attach Request, use it. Change-Id: Iee3c66d6ab21ead103241753f927d9245aad9e64 --- M src/sgsn/gprs_gmm.c 1 file changed, 22 insertions(+), 55 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/95/43595/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43595?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iee3c66d6ab21ead103241753f927d9245aad9e64 Gerrit-Change-Number: 43595 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: Attach Complete: add TODO for follow-on request
by lynxis lazus 15 Sep '26

15 Sep '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43597?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: gprs_gmm: Attach Complete: add TODO for follow-on request ...................................................................... gprs_gmm: Attach Complete: add TODO for follow-on request Iu supports a follow-on request after an Attach Req. Currently unsupported. Change-Id: I136ff28262b5caec139765881ba2efd64ab75dcc --- M src/sgsn/gprs_gmm.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/97/43597/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I136ff28262b5caec139765881ba2efd64ab75dcc Gerrit-Change-Number: 43597 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: Service Request: add FIXME to check authentication
by lynxis lazus 15 Sep '26

15 Sep '26

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43598?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: gprs_gmm: Service Request: add FIXME to check authentication ...................................................................... gprs_gmm: Service Request: add FIXME to check authentication Before parsing the PDP status of a Service Request, the Service Request has to be authenticated, otherwise it is possible to close a UE's PDP context by sending a fake Service Request. Change-Id: Icab4a223ec9a7987ede38772339f544312d950c2 --- M src/sgsn/gprs_gmm.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/98/43598/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icab4a223ec9a7987ede38772339f544312d950c2 Gerrit-Change-Number: 43598 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: Routing Area Update: ensure PDP_CTX_STATUS has correct lenght
by lynxis lazus 15 Sep '26

15 Sep '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43599?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: gprs_gmm: Routing Area Update: ensure PDP_CTX_STATUS has correct lenght ...................................................................... gprs_gmm: Routing Area Update: ensure PDP_CTX_STATUS has correct lenght Change-Id: Ic9560108ee424634e15a5af1424ea44df491a474 --- M src/sgsn/gprs_gmm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/99/43599/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43599?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic9560108ee424634e15a5af1424ea44df491a474 Gerrit-Change-Number: 43599 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-sgsn[master]: gprs_gmm: refactor handling of GMM Detach Accept into own function
by lynxis lazus 15 Sep '26

15 Sep '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43600?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: gprs_gmm: refactor handling of GMM Detach Accept into own function ...................................................................... gprs_gmm: refactor handling of GMM Detach Accept into own function Change-Id: Iae846bbff0df04295a1579017117b3e84fa29157 --- M src/sgsn/gprs_gmm.c 1 file changed, 9 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/00/43600/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iae846bbff0df04295a1579017117b3e84fa29157 Gerrit-Change-Number: 43600 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log September 2026