August 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-sgsn[master]: libvlr: lu_fsm: split off creation and start of the LU FSM
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43475?usp=email ) Change subject: libvlr: lu_fsm: split off creation and start of the LU FSM ...................................................................... libvlr: lu_fsm: split off creation and start of the LU FSM Change-Id: I2ed3d7cc79b208d1810b4c03c4cb2d6cab83020f --- M include/osmocom/vlr/vlr.h M src/libvlr/vlr_lu_fsm.c M src/sgsn/gprs_rau_fsm.c 3 files changed, 25 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/75/43475/1 diff --git a/include/osmocom/vlr/vlr.h b/include/osmocom/vlr/vlr.h index d40d680..a931d48 100644 --- a/include/osmocom/vlr/vlr.h +++ b/include/osmocom/vlr/vlr.h @@ -312,6 +312,8 @@ bool is_r99, bool is_utran, bool assign_tmsi); +int vlr_loc_start(struct osmo_fsm_inst *fi); + struct osmo_fsm_inst * vlr_ra_update(struct osmo_fsm_inst *parent, uint32_t parent_event_success, @@ -328,6 +330,8 @@ bool is_r99, bool is_utran, bool assign_tmsi); +int vlr_ra_start(struct osmo_fsm_inst *fi); + void vlr_loc_update_cancel(struct osmo_fsm_inst *fi, enum osmo_fsm_term_cause fsm_cause, uint8_t gsm48_cause); diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index e2b714b..1b1a1d2 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -1750,11 +1750,17 @@ LOGPFSML(fi, LOGL_ERROR, "Authentication off on UTRAN network. Good luck.\n"); - osmo_fsm_inst_dispatch(fi, VLR_ULA_E_UPDATE_LA, NULL); - return fi; } +int vlr_loc_start(struct osmo_fsm_inst *fi) +{ + if (fi) + return osmo_fsm_inst_dispatch(fi, VLR_ULA_E_UPDATE_LA, NULL); + + return -ENOENT; +} + struct osmo_fsm_inst * vlr_ra_update(struct osmo_fsm_inst *parent, uint32_t parent_event_success, @@ -1808,11 +1814,17 @@ LOGPFSML(fi, LOGL_ERROR, "Authentication off on UTRAN network. Good luck.\n"); - osmo_fsm_inst_dispatch(fi, VLR_ULA_E_UPDATE_LA, NULL); - return fi; } +int vlr_ra_start(struct osmo_fsm_inst *fi) +{ + if (fi) + return osmo_fsm_inst_dispatch(fi, VLR_ULA_E_UPDATE_LA, NULL); + + return -ENOENT; +} + void vlr_loc_update_cancel(struct osmo_fsm_inst *fi, enum osmo_fsm_term_cause fsm_cause, uint8_t gsm48_cause) diff --git a/src/sgsn/gprs_rau_fsm.c b/src/sgsn/gprs_rau_fsm.c index a9a79e6..1253975 100644 --- a/src/sgsn/gprs_rau_fsm.c +++ b/src/sgsn/gprs_rau_fsm.c @@ -77,10 +77,11 @@ static void gmm_rau_fsm_s_init(struct osmo_fsm_inst *fi, uint32_t event, void *data) { struct sgsn_mm_ctx *mmctx = gmm_rau_fsm_priv(fi); + struct osmo_fsm_inst *inst; switch (event) { case GMM_RAU_E_UE_RAU_REQUEST: - mmctx->vsub->lu_fsm = vlr_ra_update( + inst = vlr_ra_update( mmctx->attach_rau.rau_fsm, GMM_RAU_E_VLR_TERM_SUCCESS, GMM_RAU_E_VLR_TERM_FAIL, NULL, sgsn->vlr, mmctx, @@ -99,6 +100,9 @@ osmo_tdef_fsm_inst_state_chg(fi, GMM_RAU_S_WAIT_VLR_ANSWER, gmm_rau_tdef_states, gmm_rau_tdefs, 0); osmo_fsm_inst_dispatch(mmctx->gmm_fsm, E_GMM_COMMON_PROC_INIT_REQ, NULL); + if (inst) + vlr_ra_start(inst); + break; default: OSMO_ASSERT(0); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43475?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2ed3d7cc79b208d1810b4c03c4cb2d6cab83020f Gerrit-Change-Number: 43475 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: libvlr: lu_fsm: dont terminate by timer to prevent cascade
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43473?usp=email ) Change subject: libvlr: lu_fsm: dont terminate by timer to prevent cascade ...................................................................... libvlr: lu_fsm: dont terminate by timer to prevent cascade Change-Id: Ie726c21c2f9dc064c1dfd9bc9f9ec12d1e47fadf --- M src/libvlr/vlr_lu_fsm.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/73/43473/1 diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index 4bde280..a3f553f 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -1601,8 +1601,8 @@ } lfp->vlr->ops.tx_lu_rej(lfp->msc_conn_ref, gsm48_cause, lfp->lu_type); - /* 1 will terminate the fsm */ - return 1; + /* The callback might already cleaned up this FSM */ + return 0; } switch (fi->state) { -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43473?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie726c21c2f9dc064c1dfd9bc9f9ec12d1e47fadf Gerrit-Change-Number: 43473 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: RFC: Use osmo_select_main_ctx to support talloc context OTC_SELECT
by lynxis lazus 31 Aug '26

31 Aug '26

Attention is currently required from: daniel, lynxis lazus, pespin. lynxis lazus has uploaded a new patch set (#2) to the change originally created by daniel. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39703?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by pespin, Code-Review-1 by lynxis lazus, Verified-1 by Jenkins Builder Change subject: RFC: Use osmo_select_main_ctx to support talloc context OTC_SELECT ...................................................................... RFC: Use osmo_select_main_ctx to support talloc context OTC_SELECT Change-Id: I4b26b73af706ce790181085880c6866e7f7e8c65 --- M src/sgsn/sgsn_main.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/03/39703/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39703?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4b26b73af706ce790181085880c6866e7f7e8c65 Gerrit-Change-Number: 39703 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-sgsn[master]: libvlr: add PVLR support
by lynxis lazus 31 Aug '26

31 Aug '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39561?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: libvlr: add PVLR support ...................................................................... libvlr: add PVLR support Allow to retrieve information from the PVLR (Previous VLR). In case of PS/SGSN this can be another SGSN or a MME. Change-Id: I7ef8e10e9553181913c66546c97a71b21fa9ef64 --- M include/osmocom/vlr/vlr.h M src/libvlr/vlr.c M src/libvlr/vlr_lu_fsm.c 3 files changed, 45 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/61/39561/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39561?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I7ef8e10e9553181913c66546c97a71b21fa9ef64 Gerrit-Change-Number: 39561 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[L] Change in osmo-sgsn[master]: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection
by lynxis lazus 31 Aug '26

31 Aug '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection ...................................................................... Add Gn support to allow MME->SGSN, SGSN->MME cell reselection The Gn interface allow to transfer the state of MS/UE between SGSNs and SGSN to MME and vice versa. The code won't use the old key material from the old core network component. Instead it will ask the HLR for new material. FIXUP: go again over the code Change-Id: Iffe83b31db2b6e6869fedf2351375184096cff6f --- M include/osmocom/sgsn/gprs_rau_fsm.h M include/osmocom/sgsn/gtp.h M include/osmocom/sgsn/mmctx.h M include/osmocom/sgsn/pdpctx.h M src/sgsn/gprs_gmm.c M src/sgsn/gprs_rau_fsm.c M src/sgsn/mmctx.c M src/sgsn/pdpctx.c M src/sgsn/sgsn_libgtp.c 9 files changed, 928 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/63/39563/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iffe83b31db2b6e6869fedf2351375184096cff6f Gerrit-Change-Number: 39563 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-sgsn[master]: libvlr: Remove MSC specific parts
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43461?usp=email ) Change subject: libvlr: Remove MSC specific parts ...................................................................... libvlr: Remove MSC specific parts The libvlr should not contain any MSC specific parts. Remove include and usage of MSC objects. Change-Id: I35e3edc56c7c64ac2a4462dec8ea684b00ab3881 --- M include/osmocom/vlr/vlr.h M src/libvlr/vlr.c 2 files changed, 0 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/61/43461/1 diff --git a/include/osmocom/vlr/vlr.h b/include/osmocom/vlr/vlr.h index 9b49ff2..497fa4f 100644 --- a/include/osmocom/vlr/vlr.h +++ b/include/osmocom/vlr/vlr.h @@ -13,7 +13,6 @@ #include <osmocom/gsm/gsm0808.h> #include <osmocom/gsm/gsup.h> #include <osmocom/gsm/ipa.h> -#include <osmocom/msc/msc_common.h> #include <osmocom/gsupclient/gsup_client.h> #include <osmocom/vlr/vlr_sgs.h> diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index 919def3..ebc978f 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -35,8 +35,6 @@ #include <osmocom/vlr/vlr_sgs.h> #include <osmocom/vlr/vlr.h> #include <osmocom/gsupclient/gsup_client_mux.h> -#include <osmocom/msc/paging.h> -#include <osmocom/msc/silent_call.h> #include <netinet/in.h> #include <arpa/inet.h> @@ -605,8 +603,6 @@ exists->imsi, osmo_use_count_to_str_c(OTC_SELECT, &exists->use_count), osmo_use_count_to_str_c(OTC_SELECT, &vsub->use_count)); - /* Take over some state from the previous vsub */ - paging_request_join_vsub(vsub, exists); if (!vsub->msisdn[0]) OSMO_STRLCPY_ARRAY(vsub->msisdn, exists->msisdn); if (!vsub->name[0]) @@ -643,12 +639,6 @@ if (!strcmp(vsub->imsi, imsi)) return; - /* If the same subscriber has silent call (probably pending) stop the silent call to prevent - * use count mismatch when freeing the transaction. */ - exists = vlr_subscr_find_by_imsi(vsub->vlr, imsi, NULL); - if (gsm_silent_call_is_ongoing(exists)) - gsm_silent_call_stop(exists); - /* We've just learned about this new IMSI, our primary key in the VLR. make sure to invalidate any prior VLR * entries for this IMSI. */ exists = vlr_subscr_find_by_imsi(vsub->vlr, imsi, NULL); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I35e3edc56c7c64ac2a4462dec8ea684b00ab3881 Gerrit-Change-Number: 43461 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 80955b9454776166dd43972db2141b431444ad7f
by lynxis lazus 31 Aug '26

31 Aug '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: add libvlr based on MSC commit 80955b9454776166dd43972db2141b431444ad7f ...................................................................... add libvlr based on MSC commit 80955b9454776166dd43972db2141b431444ad7f Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d --- M TODO-RELEASE M configure.ac M include/osmocom/Makefile.am A include/osmocom/vlr/Makefile.am A include/osmocom/vlr/vlr.h A include/osmocom/vlr/vlr_sgs.h M src/Makefile.am A src/libvlr/Makefile.am A src/libvlr/vlr.c A src/libvlr/vlr_access_req_fsm.c A src/libvlr/vlr_access_req_fsm.h A src/libvlr/vlr_auth_fsm.c A src/libvlr/vlr_auth_fsm.h A src/libvlr/vlr_core.h A src/libvlr/vlr_logging.c A src/libvlr/vlr_lu_fsm.c A src/libvlr/vlr_lu_fsm.h A src/libvlr/vlr_sgs.c A src/libvlr/vlr_sgs_fsm.c A src/libvlr/vlr_sgs_fsm.h M src/sgsn/Makefile.am M tests/gprs_routing_area/Makefile.am M tests/sgsn/Makefile.am 23 files changed, 6,748 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/60/39560/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: Iu: ensure every tests use a new subscriber
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43452?usp=email ) Change subject: SGSN: Iu: ensure every tests use a new subscriber ...................................................................... SGSN: Iu: ensure every tests use a new subscriber If a test uses the same subscriber as the previuos tests, the test might fail, because there is no need to request for authentication data, because the UE still has a valid security context with the network Change-Id: I4928d63b3166843fa90b19bea4880da125474906 --- M sgsn/SGSN_Tests_Iu.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/52/43452/1 diff --git a/sgsn/SGSN_Tests_Iu.ttcn b/sgsn/SGSN_Tests_Iu.ttcn index aa4af49..a1a89bc 100644 --- a/sgsn/SGSN_Tests_Iu.ttcn +++ b/sgsn/SGSN_Tests_Iu.ttcn @@ -83,7 +83,7 @@ f_init(); f_vty_config(SGSNVTY, "sgsn", "encryption uea 1 2"); f_sleep(1.0); - vc_conn := f_start_handler(refers(f_TC_iu_attach), testcasename(), g_gb, 1001, expect_ciph := true); + vc_conn := f_start_handler(refers(f_TC_iu_attach), testcasename(), g_gb, 1010, expect_ciph := true); vc_conn.done; f_cleanup(); } @@ -417,7 +417,7 @@ var BSSGP_ConnHdlr vc_conn; f_init(); f_sleep(1.0); - vc_conn := f_start_handler(refers(f_TC_update_ctx_err_ind_from_ggsn), testcasename(), g_gb, 1004); + vc_conn := f_start_handler(refers(f_TC_update_ctx_err_ind_from_ggsn), testcasename(), g_gb, 1011); vc_conn.done; f_cleanup(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43452?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4928d63b3166843fa90b19bea4880da125474906 Gerrit-Change-Number: 43452 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: f_routing_area_update(): expect a Location Update by default
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43453?usp=email ) Change subject: SGSN: f_routing_area_update(): expect a Location Update by default ...................................................................... SGSN: f_routing_area_update(): expect a Location Update by default As long the libvlr is always doing an Location Update, even when the location is still located at the same SGSN, which it would not require to do so, expect a Location Update by default. Change-Id: Ib67af3197399f1bf94e8d691f4e356f9a926c0d5 --- M sgsn/BSSGP_ConnHdlr.ttcn 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/43453/1 diff --git a/sgsn/BSSGP_ConnHdlr.ttcn b/sgsn/BSSGP_ConnHdlr.ttcn index f11eee8..7220ba0 100644 --- a/sgsn/BSSGP_ConnHdlr.ttcn +++ b/sgsn/BSSGP_ConnHdlr.ttcn @@ -706,7 +706,8 @@ GprsUpdateType upd_type := GPRS_UPD_T_RA, integer ran_index := 0, float Tval := 2.0, - SGSN_auth_mode auth_mode := SGSN_AUTH_MODE_REQUIRED) runs on BSSGP_ConnHdlr { + SGSN_auth_mode auth_mode := SGSN_AUTH_MODE_REQUIRED, + boolean expect_lu_isd := true) runs on BSSGP_ConnHdlr { var template (omit) OCT4 p_tmsi := omit; var boolean authed := false; timer T := Tval; @@ -727,6 +728,7 @@ [] as_routing_area_update(ran_index) { setverdict(pass); } [is_gb(ran_index)] BSSGP[ran_index].receive { repeat; } [is_iu(ran_index)] RAN_CONN.receive { repeat; } + [expect_lu_isd] as_gmm_gsup_lu_isd() { repeat; } [] T.timeout { setverdict(fail, "Timeout completing the RAU procedure"); mtc.stop; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43453?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib67af3197399f1bf94e8d691f4e356f9a926c0d5 Gerrit-Change-Number: 43453 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: as_service_request(): use as_ciph_utran() to parse the Security...
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43454?usp=email ) Change subject: SGSN: as_service_request(): use as_ciph_utran() to parse the Security Command ...................................................................... SGSN: as_service_request(): use as_ciph_utran() to parse the Security Command as_ciph_utran() parse the Ciphering Command in more detail than the alt step before. Change-Id: Ice385045c96e2d2eac7aa3c523c7b7c3c39e8bf4 --- M sgsn/BSSGP_ConnHdlr.ttcn 1 file changed, 3 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/54/43454/1 diff --git a/sgsn/BSSGP_ConnHdlr.ttcn b/sgsn/BSSGP_ConnHdlr.ttcn index 7220ba0..8c12ea6 100644 --- a/sgsn/BSSGP_ConnHdlr.ttcn +++ b/sgsn/BSSGP_ConnHdlr.ttcn @@ -399,7 +399,7 @@ * CommonId * (out of order: GMM ID Req) */ -function f_gmm_auth (boolean umts_aka_challenge := false, boolean force_gsm_sres := false, integer ran_index := 0) runs on BSSGP_ConnHdlr { +function f_gmm_auth(boolean umts_aka_challenge := false, boolean force_gsm_sres := false, integer ran_index := 0) runs on BSSGP_ConnHdlr { var PDU_L3_MS_SGSN l3_mo; var PDU_L3_SGSN_MS l3_mt; var default di := activate(as_mm_identity(ran_index)); @@ -765,15 +765,10 @@ mtc.stop; } /* 24.008 4.7.13.3: a SecurityModeCommand is an implicit Service Accept if UE was in PMM-IDLE */ - [] RAN_CONN.receive(tr_RANAP_SecurityModeCmd(uia_algs := ?, - uia_key := oct2bit(g_pars.vec.ik), - key_sts := ?)) { - var IntegrityProtectionAlgorithm uia_chosen := 0; /* 0 = standard_UMTS_integrity_algorithm_UIA1 */ - RAN_CONN.send(ts_RANAP_SecurityModeComplete(uia_chosen)); + [] as_ciph_utran() { if (not exp_service_acc) { - /* Because we stop processing early, we need to consume the CommonID */ + /* We need to consume the CommonID */ RAN_CONN.receive(tr_RANAP_CommonId(imsi_hex2oct(g_pars.imsi))); - setverdict(pass); } else { /* This repeat would be wrong if you follow the spec correct. Because: * a) the UE is in PMM Idle and in this case the exp_service_acc would be true -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43454?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ice385045c96e2d2eac7aa3c523c7b7c3c39e8bf4 Gerrit-Change-Number: 43454 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026