August 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-sgsn[master]: libvlr: add missing declaration for vlr_subscr_rx_rau_complete()
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43464?usp=email ) Change subject: libvlr: add missing declaration for vlr_subscr_rx_rau_complete() ...................................................................... libvlr: add missing declaration for vlr_subscr_rx_rau_complete() Change-Id: I331a4e042c776ce1de1e4dc170ddfc541c89a4d5 --- M include/osmocom/vlr/vlr.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/64/43464/1 diff --git a/include/osmocom/vlr/vlr.h b/include/osmocom/vlr/vlr.h index b8debdc..d40d680 100644 --- a/include/osmocom/vlr/vlr.h +++ b/include/osmocom/vlr/vlr.h @@ -343,6 +343,7 @@ void vlr_subscr_rx_ciph_res(struct vlr_subscr *vsub, enum vlr_ciph_result_cause result); int vlr_subscr_rx_tmsi_reall_compl(struct vlr_subscr *vsub); int vlr_subscr_rx_imsi_detach(struct vlr_subscr *vsub); +int vlr_subscr_rx_rau_complete(struct vlr_subscr *vsub); void vlr_subscr_rx_pvlr_id_ack(struct vlr_subscr *vsub); void vlr_subscr_rx_pvlr_id_nack(struct vlr_subscr *vsub); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43464?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I331a4e042c776ce1de1e4dc170ddfc541c89a4d5 Gerrit-Change-Number: 43464 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: libvlr: add FIXME for separation of local and foreign TMSI
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43465?usp=email ) Change subject: libvlr: add FIXME for separation of local and foreign TMSI ...................................................................... libvlr: add FIXME for separation of local and foreign TMSI Change-Id: I62ddaa17f7f627d61f26db5e299e01ef016df045 --- M src/libvlr/vlr.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/65/43465/1 diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index 4354564..cc03f93 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -574,6 +574,7 @@ const char *file, int line) { + /* FIXME: we need to add a type to the tmsi (local, foreign) so overlaps doesn't matter */ struct vlr_subscr *vsub; vsub = _vlr_subscr_find_by_tmsi(vlr, tmsi, use, file, line); if (vsub) { -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43465?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I62ddaa17f7f627d61f26db5e299e01ef016df045 Gerrit-Change-Number: 43465 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-sgsn[master]: RFC: libvlr: use a talloc_zero instead of OTC_SELECT
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43466?usp=email ) Change subject: RFC: libvlr: use a talloc_zero instead of OTC_SELECT ...................................................................... RFC: libvlr: use a talloc_zero instead of OTC_SELECT Use a temporary talloc object for a rare error message instead of using OTC_SELECT which requires the usage of a different osmo_loop Change-Id: I879b7ac6126d896a7bdae7ab4cbfe0655ac35760 --- M src/libvlr/vlr.c 1 file changed, 7 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/66/43466/1 diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index cc03f93..a7134ce 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -599,10 +599,13 @@ struct vlr_instance *vlr = exists->vlr; int i; int j; - LOGVSUBP(LOGL_NOTICE, vsub, - "There is an existing subscriber for IMSI %s used by %s, replacing with this VLR subscr, used by %s\n", - exists->imsi, osmo_use_count_to_str_c(OTC_SELECT, &exists->use_count), - osmo_use_count_to_str_c(OTC_SELECT, &vsub->use_count)); + void *tmp = talloc_zero_size(vsub, 4); + LOGVLR(LOGL_NOTICE, + "There is an existing subscriber for IMSI %s used by %s, replacing with new VLR subscr: %s used by %s\n", + exists->imsi, osmo_use_count_to_str_c(tmp, &exists->use_count), + vlr_subscr_name(vsub), + osmo_use_count_to_str_c(tmp, &vsub->use_count)); + talloc_free(tmp); if (!vsub->msisdn[0]) OSMO_STRLCPY_ARRAY(vsub->msisdn, exists->msisdn); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43466?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I879b7ac6126d896a7bdae7ab4cbfe0655ac35760 Gerrit-Change-Number: 43466 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: RFC: libvlr: introduce lfp variable hlr_update_req
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43467?usp=email ) Change subject: RFC: libvlr: introduce lfp variable hlr_update_req ...................................................................... RFC: libvlr: introduce lfp variable hlr_update_req The HLR don't have to be notificed for every Location Update. Instead it is good enough to only update the HLR when needed. Change-Id: Ic959c13695c2cfd4e0bfeef336efac1eb4a3418e --- M src/libvlr/vlr_lu_fsm.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/67/43467/1 diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index 4150fbd..4bde280 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -771,6 +771,7 @@ bool is_r99; bool is_utran; bool assign_tmsi; + bool hlr_update_req; /*! count times timer T timed out */ int N; @@ -874,7 +875,7 @@ /* FIXME: Delete subscriber record */ /* LU REJ: Roaming not allowed */ lu_fsm_failure(fi, GSM48_REJECT_ROAMING_NOT_ALLOWED); - } else { + } else { /* Correct would be if (lfp->lu_type == VLR_LU_TYPE_IMSI_ATTACH || lfp->hlr_update_req) */ /* Update_HLR_VLR */ osmo_fsm_inst_state_chg(fi, VLR_ULA_S_WAIT_HLR_UPD, LU_TIMEOUT_LONG, 0); @@ -1200,6 +1201,7 @@ struct lu_fsm_priv *lfp = lu_fsm_fi_priv(fi); struct vlr_instance *vlr = lfp->vlr; + lfp->hlr_update_req = true; vlr->ops.tx_pvlr_request(lfp->msc_conn_ref, &lfp->old_rai); } -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43467?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic959c13695c2cfd4e0bfeef336efac1eb4a3418e Gerrit-Change-Number: 43467 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: gprs_routing_area: add FIXMEs for unit tests
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43469?usp=email ) Change subject: gprs_routing_area: add FIXMEs for unit tests ...................................................................... gprs_routing_area: add FIXMEs for unit tests Change-Id: Ia8bb1c4b6ae77bd0e5a44171d99851c74c083835 --- M src/sgsn/gprs_routing_area.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/69/43469/1 diff --git a/src/sgsn/gprs_routing_area.c b/src/sgsn/gprs_routing_area.c index 4400d6d..abb613e 100644 --- a/src/sgsn/gprs_routing_area.c +++ b/src/sgsn/gprs_routing_area.c @@ -327,6 +327,11 @@ ra_created = true; } + /* FIXME: write a unit tests + * move a present cell into a new routing area + * The old cell isn't found then! + */ + if (!ra_created) { cell = sgsn_ra_geran_get_cell_by_ra(ra, cgi_ps->cell_identity); if (cell && cell->ran_type == RA_TYPE_GERAN_Gb) { -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43469?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia8bb1c4b6ae77bd0e5a44171d99851c74c083835 Gerrit-Change-Number: 43469 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: Set RAT on the VLR object
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43470?usp=email ) Change subject: gprs_gmm: Set RAT on the VLR object ...................................................................... gprs_gmm: Set RAT on the VLR object Will be used in GSUP messages. Change-Id: I66270d07371501afc9e6bc00c654d7612543e0ca --- M src/sgsn/gprs_gmm.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/70/43470/1 diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index f2f9459..12c0cb0 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -1828,6 +1828,15 @@ goto rejected; } + switch (mmctx->ran_type) { + case MM_CTX_T_GERAN_Gb: + mmctx->vsub->cs.attached_via_ran = OSMO_RAT_GERAN_A; + break; + case MM_CTX_T_UTRAN_Iu: + mmctx->vsub->cs.attached_via_ran = OSMO_RAT_UTRAN_IU; + break; + } + mmctx->attach_rau.old_rai = req.old_rai; /* FIXME: copy stuff from VSUB over */ -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43470?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I66270d07371501afc9e6bc00c654d7612543e0ca Gerrit-Change-Number: 43470 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: gsm48_tx_gmm_ra_upd_ack: add some comments to unencoded TLVs
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43468?usp=email ) Change subject: gsm48_tx_gmm_ra_upd_ack: add some comments to unencoded TLVs ...................................................................... gsm48_tx_gmm_ra_upd_ack: add some comments to unencoded TLVs Change-Id: Icc83186da4fa562bac716c3c7f4448ab46439c3c --- M src/sgsn/gprs_gmm.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/68/43468/1 diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index ff00de2..f2f9459 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -1419,6 +1419,9 @@ /* MS identity */ /* List of Received N-PDU */ + /* MS identity */ + /* List of Received N-PDU */ + /* Optional: Negotiated READY timer value */ t = osmo_tdef_get(sgsn->cfg.T_defs, 3314, OSMO_TDEF_S, -1); msgb_tv_put(msg, GSM48_IE_GMM_TIMER_READY, gprs_secs_to_tmr_floor(t)); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc83186da4fa562bac716c3c7f4448ab46439c3c Gerrit-Change-Number: 43468 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: WIP: libvlr: add RAT type to GSUP messages
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43471?usp=email ) Change subject: WIP: libvlr: add RAT type to GSUP messages ...................................................................... WIP: libvlr: add RAT type to GSUP messages The HLR should know which RAT is used. This commit will be replaced by msc commit Change-Id: Id1951f2dc201475c3decb411a81a4d12a61b8ed7 --- M src/libvlr/vlr.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/71/43471/1 diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index a7134ce..20f14b4 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -903,6 +903,7 @@ gsup_msg.message_type = OSMO_GSUP_MSGT_UPDATE_LOCATION_REQUEST; gsup_msg.cn_domain = vlr_is_cs(vsub->vlr) ? OSMO_GSUP_CN_DOMAIN_CS : OSMO_GSUP_CN_DOMAIN_PS; + gsup_msg.current_rat_type = vsub->cs.attached_via_ran; rc = vlr_subscr_tx_gsup_message(vsub, &gsup_msg); return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43471?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id1951f2dc201475c3decb411a81a4d12a61b8ed7 Gerrit-Change-Number: 43471 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-sgsn[master]: libvlr: auth: never re-use auth tuples for authentication
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43472?usp=email ) Change subject: libvlr: auth: never re-use auth tuples for authentication ...................................................................... libvlr: auth: never re-use auth tuples for authentication The auth tuples should only ever sent once over the air for authentication. Later the auth tuples may be re-used multiple times for ciphering, but can't be re-used other the air for authentication. Change-Id: I102e0cca101525b11ae2b0f5796b60e263205d61 --- M src/libvlr/vlr_auth_fsm.c 1 file changed, 5 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/72/43472/1 diff --git a/src/libvlr/vlr_auth_fsm.c b/src/libvlr/vlr_auth_fsm.c index b3bd236..68c9a54 100644 --- a/src/libvlr/vlr_auth_fsm.c +++ b/src/libvlr/vlr_auth_fsm.c @@ -119,12 +119,11 @@ return at; } -/* Return an auth tuple and increment its use count. */ +/* Return an auth tuple */ static struct vlr_auth_tuple * -vlr_subscr_get_auth_tuple(struct vlr_subscr *vsub, int max_reuse_count) +vlr_subscr_get_auth_tuple(struct vlr_subscr *vsub) { - struct vlr_auth_tuple *at = _vlr_subscr_next_auth_tuple(vsub, - max_reuse_count); + struct vlr_auth_tuple *at = _vlr_subscr_next_auth_tuple(vsub, 0); if (!at) return NULL; at->use_count++; @@ -311,7 +310,7 @@ bool use_umts_aka; /* Caller ensures we have vectors available */ - at = vlr_subscr_get_auth_tuple(vsub, afp->auth_tuple_max_reuse_count); + at = vlr_subscr_get_auth_tuple(vsub); if (!at) { LOGPFSML(fi, LOGL_ERROR, "A previous check ensured that an" " auth tuple was available, but now there is in fact" @@ -350,7 +349,7 @@ afp->auth_tuple_max_reuse_count = vsub->vlr->cfg.auth_tuple_max_reuse_count; /* Check if we have vectors available */ - if (!vlr_subscr_has_auth_tuple(vsub, afp->auth_tuple_max_reuse_count)) { + if (!vlr_subscr_has_auth_tuple(vsub, 0)) { /* Obtain_Authentication_Sets_VLR */ int rc = vlr_subscr_req_sai(vsub, NULL, NULL); if (rc < 0) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43472?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I102e0cca101525b11ae2b0f5796b60e263205d61 Gerrit-Change-Number: 43472 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-sgsn[master]: libvlr: auth_fsm: split off fsm creation and start of it
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43474?usp=email ) Change subject: libvlr: auth_fsm: split off fsm creation and start of it ...................................................................... libvlr: auth_fsm: split off fsm creation and start of it The auth fsm may destroy itself from a chain of fsm event resulting in a use-after-free of the fsm instance. Change-Id: Id5c77290f7181adb40d3429183b9696b4a40013b --- M src/libvlr/vlr_access_req_fsm.c M src/libvlr/vlr_auth_fsm.c M src/libvlr/vlr_auth_fsm.h M src/libvlr/vlr_lu_fsm.c 4 files changed, 19 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/74/43474/1 diff --git a/src/libvlr/vlr_access_req_fsm.c b/src/libvlr/vlr_access_req_fsm.c index 6d4a084..e57cd50 100644 --- a/src/libvlr/vlr_access_req_fsm.c +++ b/src/libvlr/vlr_access_req_fsm.c @@ -358,12 +358,13 @@ if (is_auth_to_be_attempted(par)) { osmo_fsm_inst_state_chg(fi, PR_ARQ_S_WAIT_AUTH, 0, 0); - vsub->auth_fsm = auth_fsm_start(vsub, fi, + vsub->auth_fsm = auth_fsm_create(vsub, fi, PR_ARQ_E_AUTH_RES, PR_ARQ_E_AUTH_NO_INFO, PR_ARQ_E_AUTH_FAILURE, par->is_r99, par->is_utran); + auth_fsm_start(vsub->auth_fsm); } else { _proc_arq_vlr_node2(fi); } diff --git a/src/libvlr/vlr_auth_fsm.c b/src/libvlr/vlr_auth_fsm.c index 68c9a54..7557971 100644 --- a/src/libvlr/vlr_auth_fsm.c +++ b/src/libvlr/vlr_auth_fsm.c @@ -641,7 +641,7 @@ ***********************************************************************/ /* MSC->VLR: Start Procedure Authenticate_VLR (TS 23.012 Ch. 4.1.2.2) */ -struct osmo_fsm_inst *auth_fsm_start(struct vlr_subscr *vsub, +struct osmo_fsm_inst *auth_fsm_create(struct vlr_subscr *vsub, struct osmo_fsm_inst *parent, uint32_t parent_event_success, uint32_t parent_event_no_auth_info, @@ -675,11 +675,17 @@ fi->priv = afp; vsub->auth_fsm = fi; - osmo_fsm_inst_dispatch(fi, VLR_AUTH_E_START, NULL); - return fi; } +int auth_fsm_start(struct osmo_fsm_inst *fi) +{ + if (fi) + return osmo_fsm_inst_dispatch(fi, VLR_AUTH_E_START, NULL); + + return -ENOENT; +} + bool auth_try_reuse_tuple(struct vlr_subscr *vsub, uint8_t key_seq) { int max_reuse_count = vsub->vlr->cfg.auth_tuple_max_reuse_count; diff --git a/src/libvlr/vlr_auth_fsm.h b/src/libvlr/vlr_auth_fsm.h index 1cb25b6..ca462a3 100644 --- a/src/libvlr/vlr_auth_fsm.h +++ b/src/libvlr/vlr_auth_fsm.h @@ -29,7 +29,7 @@ VLR_AUTH_E_MS_ID_IMSI, }; -struct osmo_fsm_inst *auth_fsm_start(struct vlr_subscr *vsub, +struct osmo_fsm_inst *auth_fsm_create(struct vlr_subscr *vsub, struct osmo_fsm_inst *parent, uint32_t parent_event_success, uint32_t parent_event_no_auth_info, @@ -37,6 +37,8 @@ bool is_r99, bool is_utran); +int auth_fsm_start(struct osmo_fsm_inst *fi); + void vlr_auth_fsm_init(bool is_ps); void vlr_auth_fsm_set_log_subsys(int log_level); bool auth_try_reuse_tuple(struct vlr_subscr *vsub, uint8_t key_seq); diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index a3f553f..e2b714b 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -986,17 +986,21 @@ OSMO_ASSERT(vsub); + /* check if we need to do an authentication, if only ciphering, check if ciphering key is available */ if (try_auth(lfp)) { /* Authenticate_VLR */ osmo_fsm_inst_state_chg(fi, VLR_ULA_S_WAIT_AUTH, LU_TIMEOUT_LONG, 0); - vsub->auth_fsm = auth_fsm_start(lfp->vsub, + /* if auth_fsm_start fails and the fsm already ran into a failure of auth_fsm,. + * auth_fsm is assigned an already free'ed fsm */ + vsub->auth_fsm = auth_fsm_create(lfp->vsub, fi, VLR_ULA_E_AUTH_SUCCESS, VLR_ULA_E_AUTH_NO_INFO, VLR_ULA_E_AUTH_FAILURE, lfp->is_r99, lfp->is_utran); + auth_fsm_start(vsub->auth_fsm); } else { /* no need for authentication */ vlr_loc_upd_post_auth(fi); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43474?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id5c77290f7181adb40d3429183b9696b4a40013b Gerrit-Change-Number: 43474 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026