Attention is currently required from: fixeria, laforge, lynxis lazus, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email
to look at the new patch set (#15).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed
......................................................................
SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed
Add a TC to to simulate multiple GMM Attach with a different
content.
When receiving a GMM Attach while in an Attach procedure, but with a different
content, the old GMM Attach should be discarded silently and a new
GMM Attach procedure should be initiated.
Change-Id: Ia721d3c29bf09014b197670ae02d1cd1901750bc
---
M sgsn/SGSN_Tests.ttcn
M sgsn/expected-results.xml
2 files changed, 70 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/39256/15
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia721d3c29bf09014b197670ae02d1cd1901750bc
Gerrit-Change-Number: 39256
Gerrit-PatchSet: 15
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39260?usp=email
to look at the new patch set (#16).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: remove TC_attach_no_imei_response
......................................................................
SGSN: remove TC_attach_no_imei_response
The SGSN doesn't request the IMEI via Identity Response anymore.
This information is requested via Authentication/Ciphering Req/Resp.
Change-Id: I42dc927513fb54b0fd2d07dda4cf8d4646b9f351
---
M sgsn/SGSN_Tests.ttcn
M sgsn/expected-results.xml
2 files changed, 0 insertions(+), 48 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/39260/16
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39260?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I42dc927513fb54b0fd2d07dda4cf8d4646b9f351
Gerrit-Change-Number: 39260
Gerrit-PatchSet: 16
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: daniel, laforge, lynxis lazus, pespin.
Hello Jenkins Builder, daniel, dexter, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email
to look at the new patch set (#17).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: SGSN: Remove unsupported acl test cases
......................................................................
SGSN: Remove unsupported acl test cases
The functionality for ACL based authentication (only use
the IMSI, but don't request information from the HLR) will
be removed from the SGSN.
Change-Id: I1506324300fe3864069706d5b05860e7b44cd895
---
M sgsn/SGSN_Tests.ttcn
M sgsn/expected-results.xml
2 files changed, 0 insertions(+), 181 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/61/39261/17
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1506324300fe3864069706d5b05860e7b44cd895
Gerrit-Change-Number: 39261
Gerrit-PatchSet: 17
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43449?usp=email )
Change subject: esipa_asn_handler: add TODO about missing download options
......................................................................
esipa_asn_handler: add TODO about missing download options
SGP.32 also defines other download trigger options next to the
commonly used activationCode method. Let's add a related TODO
to the code.
Related: SYS#8100
Change-Id: I5e72416284027731627c264fa81c62a4a9a0d407
---
M src/esipa_asn1_handler.erl
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/49/43449/1
diff --git a/src/esipa_asn1_handler.erl b/src/esipa_asn1_handler.erl
index c006a7a..f1be50a 100644
--- a/src/esipa_asn1_handler.erl
+++ b/src/esipa_asn1_handler.erl
@@ -292,6 +292,9 @@
mnesia_db_work:bind(Pid, EimTransactionId),
mnesia_db_work:update(Pid, #{}),
{[{<<"download">>, {Download}}]} = Order,
+ % TODO: Add missing download options: This eIM currently only allows to trigger a profile download using
+ % an activationCode (option a) It still lacks download triggers via SM-DS (option b) and downloads from
+ % the default SM-DP+ (option c). See also GSMA SGP.32, section 3.2.3.2
ActivationCode = proplists:get_value(<<"activationCode">>, Download),
{profileDownloadTriggerRequest, #{
profileDownloadData => {activationCode, ActivationCode},
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43449?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I5e72416284027731627c264fa81c62a4a9a0d407
Gerrit-Change-Number: 43449
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>