dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43450?usp=email )
Change subject: esipa_rest_utils: add spec reference to existing TODO
......................................................................
esipa_rest_utils: add spec reference to existing TODO
Related: SYS#8100
Change-Id: I33a1b1a03c67632b4a10a043928e0a265730b7e2
---
M src/esipa_rest_utils.erl
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/50/43450/1
diff --git a/src/esipa_rest_utils.erl b/src/esipa_rest_utils.erl
index 4cdf1ad..b481d1c 100644
--- a/src/esipa_rest_utils.erl
+++ b/src/esipa_rest_utils.erl
@@ -536,7 +536,7 @@
% Generate an ipaEuiccDataRequest from a eDR Order (JSON REST API)
edr_order_to_ipaEuiccDataRequest(Order, EimTransactionId) ->
% TODO: also add support for the two optional parameters euiccCiPKIdentifierToBeUsed, searchCriteriaNotification,
- % and searchCriteriaEuiccPackageResult.
+ % and searchCriteriaEuiccPackageResult (see also GSMA SGP.32, section 2.11.1.2)
case Order of
{[{<<"edr">>, {[{<<"tagList">>, TagList}]}}]} ->
{ipaEuiccDataRequest, #{
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43450?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I33a1b1a03c67632b4a10a043928e0a265730b7e2
Gerrit-Change-Number: 43450
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43451?usp=email )
Change subject: esipa_asn_handler: add TODO about missing TLS / SNI support.
......................................................................
esipa_asn_handler: add TODO about missing TLS / SNI support.
SGP.32 requires an eIM to support SNI, however since this eIM has
no multi tenant support at all, it may not benefit much from this
feature at the moment.
However, according to the cowboy documentation SNI is supported
and the effort to integrate it is manageable. Let's postpone this
until we add multi tenant support.
Related: SYS#8100
Change-Id: Iaebe29563259ae5fabeb9825839a03062d7fc24d
---
M src/onomondo_eim_app.erl
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/51/43451/1
diff --git a/src/onomondo_eim_app.erl b/src/onomondo_eim_app.erl
index e796c96..1d8c73f 100644
--- a/src/onomondo_eim_app.erl
+++ b/src/onomondo_eim_app.erl
@@ -31,6 +31,9 @@
[InterfaceName, Ip, Port, Cert, Key]
),
+ % TODO: GSMA SGP.32, section 2.6.5 requires an eIM to support the SNI TLS extension. However, this eIM
+ % implementation still lacks SNI support. The effort required to add SNI support should be manageable as Cowboy
+ % offers SNI support (sni_fun).
cowboy:start_tls(
https_listener_esipa,
[
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43451?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Iaebe29563259ae5fabeb9825839a03062d7fc24d
Gerrit-Change-Number: 43451
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
neels has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/43290?usp=email )
Change subject: ts_31_102.py: EF_SUCI_Calc_Info(TransparentEF): fix len test
......................................................................
ts_31_102.py: EF_SUCI_Calc_Info(TransparentEF): fix len test
while len(foo):
throws an exception when foo == None.
Instead doing
while foo:
fixes a problem when reading in empty SUCI calc info data, e.g. from
TS48v7.0_SAIP2.3_BERTLV_SUCI_NoRAMRFM.der.
Change-Id: Ia4e2356d0241d7a6ca399ba7e8be7f27ec836104
Jenkins: skip-card-test
---
M pySim/ts_31_102.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py
index b354b32..843f7c4 100644
--- a/pySim/ts_31_102.py
+++ b/pySim/ts_31_102.py
@@ -335,7 +335,7 @@
"""conversion method to generate list of {hnet_pubkey_identifier, hnet_pubkey} dicts
from flat [{hnet_pubkey_identifier: }, {net_pubkey: }, ...] list"""
out = []
- while len(l):
+ while l:
a = l.pop(0)
b = l.pop(0)
z = {**a, **b}
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43290?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia4e2356d0241d7a6ca399ba7e8be7f27ec836104
Gerrit-Change-Number: 43290
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
neels has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/43287?usp=email )
Change subject: saip BatchPersonalization: call rebuild_mandatory_services()
......................................................................
saip BatchPersonalization: call rebuild_mandatory_services()
Particular reason: when manipulating the 5G SUCI parameters, the
mandatory services get-identity, profile-a-x25519 and profile-b-p256 may
need to be reconfigured.
In general, it is a good idea to run these checks anyway.
Change-Id: I5e6eef0f1845a25cddb03af8d16c40e305bcdc1f
Jenkins: skip-card-test
---
M pySim/esim/saip/batch.py
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
neels: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/pySim/esim/saip/batch.py b/pySim/esim/saip/batch.py
index 6d3ded1..338c5d1 100644
--- a/pySim/esim/saip/batch.py
+++ b/pySim/esim/saip/batch.py
@@ -123,6 +123,8 @@
except Exception as e:
raise ValueError(f'{p.param_cls.get_name()} fed by {p.src.name}: {e}') from e
+ pes.rebuild_mandatory_services()
+
yield pes
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43287?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5e6eef0f1845a25cddb03af8d16c40e305bcdc1f
Gerrit-Change-Number: 43287
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
neels has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/43289?usp=email )
(
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: typo 'concetenation' in personalization.py
......................................................................
typo 'concetenation' in personalization.py
Change-Id: I51345db014335e8a70a7437a9cad5a3e47570a95
Jenkins: skip-card-test
---
M pySim/esim/saip/personalization.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py
index a73678f..6f88d52 100644
--- a/pySim/esim/saip/personalization.py
+++ b/pySim/esim/saip/personalization.py
@@ -1156,7 +1156,7 @@
class MilenageXoringConstants(BinaryParam, AlgoConfig):
"""XOR-ing constants c1,c2,c3,c4,c5 of Milenage, 128bit each. See 3GPP TS 35.206 Sections 2.3 + 5.3.
- Provided as octet-string concatenation of all 5 constants. The default value by 3GPP is the concetenation
+ Provided as octet-string concatenation of all 5 constants. The default value by 3GPP is the concatenation
of::
00000000000000000000000000000000
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43289?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I51345db014335e8a70a7437a9cad5a3e47570a95
Gerrit-Change-Number: 43289
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Attention is currently required from: laforge.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43287?usp=email )
Change subject: saip BatchPersonalization: call rebuild_mandatory_services()
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
though there is an unresolved comment (with a response) there are two +1, so i will go ahead and merge
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43287?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5e6eef0f1845a25cddb03af8d16c40e305bcdc1f
Gerrit-Change-Number: 43287
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 31 Aug 2026 12:25:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43288?usp=email )
Change subject: test_configurable_parameters: test less templates
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> how long is "long"? Is it really at the scale where we need to reduce testing?
something like a minute in total, tendency growing
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43288?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib75b6919a3acfddd99bf9baa9b6847ef731b9e67
Gerrit-Change-Number: 43288
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 31 Aug 2026 12:24:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: dexter, jolly, laforge, pespin.
Hello Jenkins Builder, jolly, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43144?usp=email
to look at the new patch set (#11).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: library/euicc: add ESipa JSON encoder/decoder module
......................................................................
library/euicc: add ESipa JSON encoder/decoder module
In order to test an eIM (or IPAd), which uses the JSON ESipa bindings
instead of the ASN.1 ESipa bindings a set of encoder/decoder functions
is needed to generate/parse the JSON messages exchanged on the ESipa
interface
Change-Id: I8b6a87f39ca23658d980d19cf257b8994ea1cecb
Related: SYS#8100
---
M eim/eIM_Tests.cfg
M eim/eIM_Tests.ttcn
M eim/gen_links.sh
M library/euicc/RSPDefinitions_Types.ttcn
M library/euicc/SGP32Definitions_Types.ttcn
A library/euicc/esipa_Types_JSON.ttcn
6 files changed, 700 insertions(+), 43 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/43144/11
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43144?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8b6a87f39ca23658d980d19cf257b8994ea1cecb
Gerrit-Change-Number: 43144
Gerrit-PatchSet: 11
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter, osmith.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43373?usp=email )
Change subject: IPAd: A test to verify proper session cancellation by eIM
......................................................................
Patch Set 9:
(1 comment)
File ipad/IPAd_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43373/comment/a4dcfe1f_61b6… :
PS5, Line 1069: /* A testcase to trigger an indirect profile download. This download will fail because the eUICC indicates so. */
> Do you mean "... will fail because the eIM indicates so. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43373?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6b2360b043e11c8a20eda7cda426b822c6876b45
Gerrit-Change-Number: 43373
Gerrit-PatchSet: 9
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Aug 2026 11:10:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>