Attention is currently required from: dexter.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43302?usp=email )
Change subject: Add missing Pepare Download error handling
......................................................................
Patch Set 2:
(1 comment)
File src/ipa/libipa/proc_prfle_dwnld.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43302/comment/599086d4_1dae227a… :
PS1, Line 53: * result as a whole to the eIM. In case of failure it is the responsibility of the eIM to look at error
> Now this comment is wrong, I would rephrase it like this: […]
Done
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43302?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I6f13a12c494be57d6a6f377567bf38b0235ec4aa
Gerrit-Change-Number: 43302
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Aug 2026 13:16:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter, laforge.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43062?usp=email )
Change subject: V1.2: Change of IpaEuiccDataRequest and results
......................................................................
Patch Set 9:
(4 comments)
File src/ipa/libipa/es10b_retr_notif_from_lst.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43062/comment/697bcab1_406ec7e8… :
PS8, Line 168: "no euiccPackageResults searchCriteria in IpaEuiccDataRequest!\n");
> In SGP.32 2.11.1. […]
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43062/comment/dd1f64e4_e629da1e… :
PS8, Line 229: "no searchCriteria in IpaEuiccDataRequest!\n");
> (see comment above)
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43062/comment/e30383ad_28cf4604… :
PS8, Line 246: "empty searchCriteria in IpaEuiccDataRequest!\n");
> (see comment above)
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43062/comment/c4435fd8_6d1eeddb… :
PS8, Line 255: "no searchCriteria in IpaEuiccDataRequest!\n");
> (see comment above)
Done
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43062?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I411111c71787ce27615b6b66fc8b19488883d15b
Gerrit-Change-Number: 43062
Gerrit-PatchSet: 9
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Aug 2026 13:16:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter, laforge.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43055?usp=email )
Change subject: V1.2: Change fields in ProvideEimPackage(Result)
......................................................................
Patch Set 7:
(1 comment)
File src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43055/comment/9ca2e1fc_651177fe… :
PS6, Line 86: res->eim_acknowledgements = &msg_to_ipa->choice.provideEimPackageResultResponse.choice.eimAcknowledgements;
> I wonder if we should be more explcit in the case of an emptyResponse. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43055?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I24baab4f9351aec27c58403b94974cba4b274c34
Gerrit-Change-Number: 43055
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Aug 2026 13:15:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter, laforge.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email )
Change subject: V1.2: Add function ES10b.GetConnectivityParameters
......................................................................
Patch Set 8:
(2 comments)
File src/ipa/libipa/ipad.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43054/comment/54c0eef1_1a1631cb… :
PS7, Line 366: res->res->choice.connectivityParameters.httpParams->buf);
> maybe the sheer absence of httpParams is not an error. Its an optional fields. […]
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43054/comment/775159a8_18a28b38… :
PS7, Line 369: }
> maybe it makes sense to evaluate the GetConnectivityParametersResponse_PR_connectivityParametersErro […]
Done
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I075590e095dbbe05fa6cdb0a96d5b38c7a17ff78
Gerrit-Change-Number: 43054
Gerrit-PatchSet: 8
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Aug 2026 13:15:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>