neels has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/43290?usp=email ) Change subject: ts_31_102.py: EF_SUCI_Calc_Info(TransparentEF): fix len test ...................................................................... ts_31_102.py: EF_SUCI_Calc_Info(TransparentEF): fix len test while len(foo): throws an exception when foo == None. Instead doing while foo: fixes a problem when reading in empty SUCI calc info data, e.g. from TS48v7.0_SAIP2.3_BERTLV_SUCI_NoRAMRFM.der. Change-Id: Ia4e2356d0241d7a6ca399ba7e8be7f27ec836104 Jenkins: skip-card-test --- M pySim/ts_31_102.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index b354b32..843f7c4 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -335,7 +335,7 @@ """conversion method to generate list of {hnet_pubkey_identifier, hnet_pubkey} dicts from flat [{hnet_pubkey_identifier: }, {net_pubkey: }, ...] list""" out = [] - while len(l): + while l: a = l.pop(0) b = l.pop(0) z = {**a, **b} -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia4e2356d0241d7a6ca399ba7e8be7f27ec836104 Gerrit-Change-Number: 43290 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>