Attention is currently required from: laforge, lynxis lazus, neels.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/43480?usp=email )
Change subject: libvlr: auth: never re-use auth tuples for authentication
......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/43480/comment/c643aa30_5a992b5c?usp… :
PS1, Line 9: The auth tuples should only ever sent once over the air for authentication.
ever be sent
https://gerrit.osmocom.org/c/osmo-msc/+/43480/comment/1920b864_115c3dfc?usp… :
PS1, Line 11: be re-used other the air for authentication.
over the air
File src/libvlr/vlr_auth_fsm.c:
https://gerrit.osmocom.org/c/osmo-msc/+/43480/comment/69bba615_d4c093f6?usp… :
PS1, Line 126: struct vlr_auth_tuple *at = _vlr_subscr_next_auth_tuple(vsub, 0);
id we always pass zero here, why having the param at all?
https://gerrit.osmocom.org/c/osmo-msc/+/43480/comment/74cc0ce0_cbe9f0c9?usp… :
PS1, Line 135: int max_reuse_count)
this should be removed then too?
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43480?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I5c628ef4b43f7c22f62d1405cbe1f717a7918548
Gerrit-Change-Number: 43480
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 31 Aug 2026 19:00:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/43479?usp=email )
Change subject: RFC: libvlr: add PVLR support
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Why not using different callbacks? In the end if the user is only caring about CS or PS, the other ones can be skipped right away with a NULL cb.
Otherwise, what about passing a pointer to
struct gsm0808_cell_id, which can contain either RAI or LAI based on "
enum CELL_IDENT id_discr" ?
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43479?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I189c041dbc3a33ad15746092691cb382d1911495
Gerrit-Change-Number: 43479
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 31 Aug 2026 18:53:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/43478?usp=email )
Change subject: libvlr: add FIXME for separation of local and foreign TMSI
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43478?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I62ddaa17f7f627d61f26db5e299e01ef016df045
Gerrit-Change-Number: 43478
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 31 Aug 2026 18:48:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43452?usp=email )
Change subject: SGSN: Iu: ensure every tests use a new subscriber
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43452/comment/ce7f0cbf_971a… :
PS1, Line 7: SGSN: Iu: ensure every tests use a new subscriber
test uses
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43452?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4928d63b3166843fa90b19bea4880da125474906
Gerrit-Change-Number: 43452
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 31 Aug 2026 18:47:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43455?usp=email )
Change subject: SGSN: f_service_request: fix required authentication when doing Service Request
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File sgsn/BSSGP_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43455/comment/97d801fb_d608… :
PS1, Line 817: /* f_gmm_auth can't be used because it consume the Security Command */
will consume/consumes
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43455?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1a4248c93514293ffdcdf9b42857bffab1fb92d9
Gerrit-Change-Number: 43455
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 31 Aug 2026 18:46:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43460?usp=email )
Change subject: SGSN: TC_sgsn_context_req_out(): rework TC and make it work
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43460?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I83a596aff460e7db88b86b7f18361db5ad91a24e
Gerrit-Change-Number: 43460
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 31 Aug 2026 18:44:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes