August 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: osmo-sgsn.cfg: assign gummei to test-mme0
by pespin 31 Aug '26

31 Aug '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43458?usp=email ) Change subject: SGSN: osmo-sgsn.cfg: assign gummei to test-mme0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43458?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4d3f6b9910756e78d3425459bdfd3196886097ef Gerrit-Change-Number: 43458 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 31 Aug 2026 18:42:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: Iu: follow Service Request according to ETSI PMM IDLE exception
by pespin 31 Aug '26

31 Aug '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43457?usp=email ) Change subject: SGSN: Iu: follow Service Request according to ETSI PMM IDLE exception ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43457?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I04d980d27c0c61830da8e1c52b988d6fecace171 Gerrit-Change-Number: 43457 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 31 Aug 2026 18:41:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: ensure every tests use a new subscriber
by pespin 31 Aug '26

31 Aug '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43456?usp=email ) Change subject: SGSN: ensure every tests use a new subscriber ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43456?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I76e4b503bae1078d1c6ec2480aa221e029abed24 Gerrit-Change-Number: 43456 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 31 Aug 2026 18:40:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: as_service_request(): use as_ciph_utran() to parse the Security...
by pespin 31 Aug '26

31 Aug '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43454?usp=email ) Change subject: SGSN: as_service_request(): use as_ciph_utran() to parse the Security Command ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43454?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ice385045c96e2d2eac7aa3c523c7b7c3c39e8bf4 Gerrit-Change-Number: 43454 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 31 Aug 2026 18:40:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: Remove unsupported acl test cases
by pespin 31 Aug '26

31 Aug '26

Attention is currently required from: daniel, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email ) Change subject: SGSN: Remove unsupported acl test cases ...................................................................... Patch Set 17: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1506324300fe3864069706d5b05860e7b44cd895 Gerrit-Change-Number: 39261 Gerrit-PatchSet: 17 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 31 Aug 2026 18:39:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed
by pespin 31 Aug '26

31 Aug '26

Attention is currently required from: fixeria, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email ) Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed ...................................................................... Patch Set 15: (2 comments) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/4eaaac83_f9b6… : PS15, Line 2199: // f_bssgp_client_register(g_pars.imsi, g_pars.tlli, BSSGP_PROC[0]); This can be removed? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/b70e1a3b_b5dd… : PS15, Line 2228: Misc_Helpers.f_shutdown(__BFILE__, __LINE__); Why do you need to shutdown like this here? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia721d3c29bf09014b197670ae02d1cd1901750bc Gerrit-Change-Number: 39256 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 31 Aug 2026 18:37:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-sgsn[master]: Avoid accessing struct log_target members directly
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43462?usp=email ) Change subject: Avoid accessing struct log_target members directly ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This is a commit from the msc. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43462?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4f42916080a2f4073bcc9bba9cce5870a23312b5 Gerrit-Change-Number: 43462 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Aug 2026 16:11:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in osmo-sgsn[master]: add libvlr based on MSC commit 80955b9454776166dd43972db2141b431444ad7f
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email ) Change subject: add libvlr based on MSC commit 80955b9454776166dd43972db2141b431444ad7f ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: The build failure is intentional because it still contains some minor parts of msc specific code. See the following commit. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Aug 2026 16:07:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-msc[master]: libvlr: lu_fsm: PS: don't terminate by timer to prevent cascade
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/43481?usp=email ) Change subject: libvlr: lu_fsm: PS: don't terminate by timer to prevent cascade ...................................................................... libvlr: lu_fsm: PS: don't terminate by timer to prevent cascade To prevent a termination cascade, don't termine the FSM by the timer callback when running as SGSN. Change-Id: I483bd3e734b1046fcafdae31189bc5df5b122a48 --- M src/libvlr/vlr_lu_fsm.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/81/43481/1 diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index 4bed335..e20c04b 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -1594,8 +1594,8 @@ } lfp->vlr->ops.tx_lu_rej(lfp->msc_conn_ref, gsm48_cause, lfp->lu_type); - /* 1 will terminate the fsm */ - return 1; + /* The callback might already cleaned up this FSM */ + return 0; } switch (fi->state) { -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I483bd3e734b1046fcafdae31189bc5df5b122a48 Gerrit-Change-Number: 43481 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-msc[master]: libvlr: auth: never re-use auth tuples for authentication
by lynxis lazus 31 Aug '26

31 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/43480?usp=email ) Change subject: libvlr: auth: never re-use auth tuples for authentication ...................................................................... libvlr: auth: never re-use auth tuples for authentication The auth tuples should only ever sent once over the air for authentication. Later the auth tuples may be re-used multiple times for ciphering, but can't be re-used other the air for authentication. Change-Id: I5c628ef4b43f7c22f62d1405cbe1f717a7918548 --- M src/libvlr/vlr_auth_fsm.c 1 file changed, 5 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/80/43480/1 diff --git a/src/libvlr/vlr_auth_fsm.c b/src/libvlr/vlr_auth_fsm.c index b3bd236..68c9a54 100644 --- a/src/libvlr/vlr_auth_fsm.c +++ b/src/libvlr/vlr_auth_fsm.c @@ -119,12 +119,11 @@ return at; } -/* Return an auth tuple and increment its use count. */ +/* Return an auth tuple */ static struct vlr_auth_tuple * -vlr_subscr_get_auth_tuple(struct vlr_subscr *vsub, int max_reuse_count) +vlr_subscr_get_auth_tuple(struct vlr_subscr *vsub) { - struct vlr_auth_tuple *at = _vlr_subscr_next_auth_tuple(vsub, - max_reuse_count); + struct vlr_auth_tuple *at = _vlr_subscr_next_auth_tuple(vsub, 0); if (!at) return NULL; at->use_count++; @@ -311,7 +310,7 @@ bool use_umts_aka; /* Caller ensures we have vectors available */ - at = vlr_subscr_get_auth_tuple(vsub, afp->auth_tuple_max_reuse_count); + at = vlr_subscr_get_auth_tuple(vsub); if (!at) { LOGPFSML(fi, LOGL_ERROR, "A previous check ensured that an" " auth tuple was available, but now there is in fact" @@ -350,7 +349,7 @@ afp->auth_tuple_max_reuse_count = vsub->vlr->cfg.auth_tuple_max_reuse_count; /* Check if we have vectors available */ - if (!vlr_subscr_has_auth_tuple(vsub, afp->auth_tuple_max_reuse_count)) { + if (!vlr_subscr_has_auth_tuple(vsub, 0)) { /* Obtain_Authentication_Sets_VLR */ int rc = vlr_subscr_req_sai(vsub, NULL, NULL); if (rc < 0) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43480?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5c628ef4b43f7c22f62d1405cbe1f717a7918548 Gerrit-Change-Number: 43480 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026