lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/43481?usp=email )

Change subject: libvlr: lu_fsm: PS: don't terminate by timer to prevent cascade ......................................................................

libvlr: lu_fsm: PS: don't terminate by timer to prevent cascade

To prevent a termination cascade, don't termine the FSM by the timer callback when running as SGSN.

Change-Id: I483bd3e734b1046fcafdae31189bc5df5b122a48 --- M src/libvlr/vlr_lu_fsm.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/81/43481/1

diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index 4bed335..e20c04b 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -1594,8 +1594,8 @@ }

lfp->vlr->ops.tx_lu_rej(lfp->msc_conn_ref, gsm48_cause, lfp->lu_type); - /* 1 will terminate the fsm */ - return 1; + /* The callback might already cleaned up this FSM */ + return 0; }

switch (fi->state) {