Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43261?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: sgsn: Fail in obvious way when unexpected ServiceAccept is received
......................................................................
sgsn: Fail in obvious way when unexpected ServiceAccept is received
since osmo-ttcn3-hacks.git 2ff5b2633a43cecaed75b30b85537d6de3a52c97, the
code doesn't expect to receive a ServiceAccept after SecurityCommand,
ie. osmo-sgsn is wrong. As a result, tests such as
TC_attach_pdp_act_user end up failing with a tGuard timeout waiting for
a RAB ASs Req. The result is confusing since osmo-sgsn actually sends
the RAB Ass Req, but since the unexpected ServiceAccept is first in the
queue, the ttcn3 code doesn't process the RAB Ass Req.
Make the test explicitly fail if something else from RAB Ass Req is in
the queue preventing reading from it.
Change-Id: Ifbb7da1d02c8bde3406a9dd445c03ed140b8c0a3
---
M sgsn/BSSGP_ConnHdlr.ttcn
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/61/43261/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43261?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifbb7da1d02c8bde3406a9dd445c03ed140b8c0a3
Gerrit-Change-Number: 43261
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43306?usp=email )
Change subject: testenv: various small syntax tweaks
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43306?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib07577c34b90abd936e005ca4f20c4e50fabb3a3
Gerrit-Change-Number: 43306
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 20 Aug 2026 07:33:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43306?usp=email )
Change subject: testenv: various small syntax tweaks
......................................................................
Patch Set 3:
(1 comment)
File _testenv/testenv/podman.py:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43306/comment/52bcee6b_632c… :
PS2, Line 64: else:
> this would be even cleaner with an early return: "if not testenv.arg. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43306?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib07577c34b90abd936e005ca4f20c4e50fabb3a3
Gerrit-Change-Number: 43306
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 20 Aug 2026 06:58:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith, pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43306?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: testenv: various small syntax tweaks
......................................................................
testenv: various small syntax tweaks
Change-Id: Ib07577c34b90abd936e005ca4f20c4e50fabb3a3
---
M .ruff.toml
M _testenv/testenv.py
M _testenv/testenv/__init__.py
M _testenv/testenv/podman.py
M _testenv/testenv/testenv_cfg.py
M _testenv/testenv/testsuite.py
6 files changed, 11 insertions(+), 21 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/43306/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43306?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib07577c34b90abd936e005ca4f20c4e50fabb3a3
Gerrit-Change-Number: 43306
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/43288?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: test_configurable_parameters: test less templates
......................................................................
test_configurable_parameters: test less templates
Change-Id: Ib75b6919a3acfddd99bf9baa9b6847ef731b9e67
Jenkins: skip-card-test
---
M tests/unittests/test_configurable_parameters.py
M tests/unittests/xo/test_configurable_parameters
2 files changed, 0 insertions(+), 1,402 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/88/43288/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43288?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib75b6919a3acfddd99bf9baa9b6847ef731b9e67
Gerrit-Change-Number: 43288
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder