Attention is currently required from: dexter.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/42996?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Remote Card Procedure Framework
......................................................................
Remote Card Procedure Framework
Problem: When UICC/eUICC cards are deployed into the field it is often
difficult to perform modifications to those cards. One important factor
that makes after-deployment modifications often difficult is that the
key material needed to perform the task must not be handed to the card
holder due to security requirements.
The presented Remote Card Procedure Framework solves this problem. It
provides a so called Remote Card Procedure Client (RCPC), which is a
lightwight software client which can be run by the card holder on the
remote machine.
With the RCPC, the card holder can access a so called Remote Card
Procedure Server (RCPC), to which so called Remote Card Procedure
Modules (RCPM) can subscribe and publish their functionality. With
the RCPC, the card holder can browse the functionality offered by
those connected modules and eventually the card holder may execute
a certain procedure by passing a command to the RCPS.
When a procedure is carried out, the RCPS automatically retrieves the
required key material from a database or CSV file and passes those
keys on to the selected RCPM. The RCPM can then use the key material
to establish a secure channel to carry out the procedure. The procedure
is then protected by a secure channel and the key material is never
disclosed towards the card holder on the remote end.
The framework is desinged in such a way that existing pySim APIs and
functions can be used from the RCPM API user code. Also only minimal
boilerplate code is required. The implementation also ships with a
comprehensive example.
Change-Id: I8500a98492328ed5b3eb4bb177af2a4a8e481f80
Related: SYS#6959
---
A contrib/rcp/rcp_client.py
A contrib/rcp/rcp_module_utils.py
A contrib/rcp/rcp_server.py
A contrib/rcp/rcp_utils.py
A contrib/rcp/rcpc_to_rcps_schema.json
A contrib/rcp/rcpm_to_rcps_schema.json
A contrib/rcp/rcpmcs_to_rcps_schema.json
A contrib/rcp/rcps_to_rcpc_schema.json
A contrib/rcp/rcps_to_rcpm_schema.json
A contrib/rcp/rcps_to_rcpmcs_schema.json
A contrib/rcp/usage_example/card_data.csv
A contrib/rcp/usage_example/card_data.csv.encr
A contrib/rcp/usage_example/certs/example_ssl_rcp_ca_cert.crt
A contrib/rcp/usage_example/certs/example_ssl_rcpc_rcps_cert.pem
A contrib/rcp/usage_example/certs/example_ssl_rcpm_rcps_cert.pem
A contrib/rcp/usage_example/certs/example_ssl_rcps_rcpm_cert.pem
A contrib/rcp/usage_example/certs/make_certs.sh
A contrib/rcp/usage_example/encrypt_card_data.sh
A contrib/rcp/usage_example/params.cfg
A contrib/rcp/usage_example/rcp_module.py
A contrib/rcp/usage_example/readme.txt
A contrib/rcp/usage_example/run_rcp_client.sh
A contrib/rcp/usage_example/run_rcp_client_cmd.sh
A contrib/rcp/usage_example/run_rcp_client_help.sh
A contrib/rcp/usage_example/run_rcp_client_help_cmd.sh
A contrib/rcp/usage_example/run_rcp_client_help_cmd_specific.sh
A contrib/rcp/usage_example/start_rcp_module.sh
A contrib/rcp/usage_example/start_rcp_server.sh
M docs/conf.py
M docs/index.rst
A docs/rcpf.rst
31 files changed, 3,610 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/96/42996/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42996?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I8500a98492328ed5b3eb4bb177af2a4a8e481f80
Gerrit-Change-Number: 42996
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43314?usp=email )
Change subject: Fix possible race conditions in RemsimServer_Tests
......................................................................
Fix possible race conditions in RemsimServer_Tests
Some tests sporadically fail. The slotmap is expected to be in ACTIVE
state, but it is sometimes still in the UNACKNOWLEDGED state. The log
output of osmo-remsim-server shows that the state always changes from
UNACKNOWLEDGED to ACTIVE. So there actually no failure.
It is quire likely that the state change is checked too early. The
acknowledged of the bankd seems not to be processed yet. Add a delay to
ensure that the acknowledgement has been processed before checking the
slotmap state.
Related: OS#6996
Change-Id: If5ec1ecd5689414252a73a2787e10495e23e4d30
---
M remsim/RemsimServer_Tests.ttcn
1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/43314/1
diff --git a/remsim/RemsimServer_Tests.ttcn b/remsim/RemsimServer_Tests.ttcn
index de2c478..2fd420e 100644
--- a/remsim/RemsimServer_Tests.ttcn
+++ b/remsim/RemsimServer_Tests.ttcn
@@ -406,6 +406,9 @@
/* 6) expect bankd to receive that mapping */
as_rspro_create_mapping(1, sm.client, sm.bank);
+ /* An immediate slotmaps check may causes a race condition. */
+ f_sleep(1.0);
+
/* 7) verify that the slotmap exists and is ACTIVE */
f_ensure_slotmap_exists_only(sm.client, sm.bank, ACTIVE);
@@ -451,6 +454,9 @@
/* 6) expect bankd to receive that mapping */
as_rspro_create_mapping(1, sm.client, sm.bank);
+ /* An immediate slotmaps check may causes a race condition. */
+ f_sleep(1.0);
+
/* 7) verify that the slotmap exists and is ACTIVE */
f_ensure_slotmap_exists_only(sm.client, sm.bank, ACTIVE);
@@ -544,6 +550,9 @@
/* expect the slotmap to be pushed to bank and ACK it */
as_rspro_create_mapping(0, sm.client, sm.bank);
+ /* An immediate slotmaps check may causes a race condition. */
+ f_sleep(1.0);
+
/* verify that the slotmap exists and is ACTIVE */
f_ensure_slotmap_exists_only(sm.client, sm.bank, ACTIVE);
@@ -595,6 +604,9 @@
/* expect the slotmap to be pushed to bank and ACK it */
as_rspro_create_mapping(0, sm.client, sm.bank);
+ /* An immediate slotmaps check may causes a race condition. */
+ f_sleep(1.0);
+
/* verify that the slotmap exists and is ACTIVE */
f_ensure_slotmap_exists_only(sm.client, sm.bank, ACTIVE);
@@ -642,6 +654,9 @@
/* expect the slotmap to be pushed to bank and ACK it */
as_rspro_create_mapping(0, sm.client, sm.bank);
+ /* An immediate slotmaps check may causes a race condition. */
+ f_sleep(1.0);
+
/* verify that the slotmap exists and is ACTIVE */
f_ensure_slotmap_exists_only(sm.client, sm.bank, ACTIVE);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43314?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If5ec1ecd5689414252a73a2787e10495e23e4d30
Gerrit-Change-Number: 43314
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>