lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/43281?usp=email )
Change subject: contrib/jenkins.sh: pin libosmocore to the last release
......................................................................
contrib/jenkins.sh: pin libosmocore to the last release
Ensure the libosmocore version doesn't move while building
firmwares which are published.
This improve reproducible builds.
Change-Id: I753d634674f76c50e1a9cf67e5adc43201d54f0c
---
M contrib/jenkins.sh
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
lynxis lazus: Looks good to me, approved
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index e53a450..deaeea5 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -1,6 +1,11 @@
#!/bin/bash
TOPDIR=`pwd`
+# empty env LIBOSMOCORE_COMMIT means master, default for release to 1.14.1
+# Having a known commit for libosmocore allow more reproducible builds of the published firmwares
+if [ "$publish" = "--publish" ] && [ -z "$LIBOSMOCORE_COMMIT" ]; then
+ LIBOSMOCORE_COMMIT="1.14.1"
+fi
if ! [ -x "$(command -v osmo-build-dep.sh)" ]; then
echo "Error: We need to have scripts/osmo-deps.sh from http://git.osmocom.org/osmo-ci/ in PATH !"
@@ -19,7 +24,7 @@
mkdir "$deps" || true
-osmo-build-dep.sh libosmocore "" '--disable-doxygen --enable-gnutls'
+osmo-build-dep.sh libosmocore "$LIBOSMOCORE_COMMIT" '--disable-doxygen --enable-gnutls'
# verify only after building the dependency (to ensure we have most recent source of dependency)
verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]")
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43281?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I753d634674f76c50e1a9cf67e5adc43201d54f0c
Gerrit-Change-Number: 43281
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43299?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: hnbgw: Move generic PFCP ConnHdlr helpers to library/PFCP_Emulation.ttcn
......................................................................
hnbgw: Move generic PFCP ConnHdlr helpers to library/PFCP_Emulation.ttcn
Change-Id: Ic40bea51934ad465a68e0d5690de066cbe1dc57d
---
M hnbgw/HNBGW_Tests.ttcn
M library/PFCP_Emulation.ttcn
2 files changed, 112 insertions(+), 98 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/43299/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43299?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic40bea51934ad465a68e0d5690de066cbe1dc57d
Gerrit-Change-Number: 43299
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43302?usp=email )
Change subject: Add missing Pepare Download error handling
......................................................................
Patch Set 1:
(1 comment)
File src/ipa/libipa/proc_prfle_dwnld.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43302/comment/69f1e512_e0f73047… :
PS1, Line 53: * result as a whole to the eIM. In case of failure it is the responsibility of the eIM to look at error
Now this comment is wrong, I would rephrase it like this:
In case the ES10b PrepareDownload returns a PrepareDownloadResponseError, the procedure is stopped. In all other cases we will forward the unmodified result to the eIM to continue the procedure normally. (see also: GSMA SGP.32, section 3.2.3.2, step 16)
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43302?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I6f13a12c494be57d6a6f377567bf38b0235ec4aa
Gerrit-Change-Number: 43302
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 19 Aug 2026 14:42:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43306?usp=email )
Change subject: testenv: various small syntax tweaks
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File _testenv/testenv/podman.py:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43306/comment/0a29c78c_b605… :
PS2, Line 64: else:
this would be even cleaner with an early return: "if not testenv.arg.force: return"
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43306?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib07577c34b90abd936e005ca4f20c4e50fabb3a3
Gerrit-Change-Number: 43306
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Aug 2026 14:39:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43305?usp=email )
Change subject: testenv: remove *args from various functions
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43305?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I18edc0ee16bd23e1188162156939e9b51f6b13d2
Gerrit-Change-Number: 43305
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Aug 2026 14:37:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43304?usp=email )
Change subject: smdpp/generate_all_test_certificates: use f-string
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43304?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2671f03e5f35d1e71fb3f090e90a37961fae6a1d
Gerrit-Change-Number: 43304
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Aug 2026 14:37:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes