osmith has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/37816?usp=email )
Change subject: (Do not merge) CI test
......................................................................
Abandoned
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37816?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: libosmocore
Gerrit-Branch: osmith/wip
Gerrit-Change-Id: Idd0d5b64644f98a8c195bcafb6ff2aed9109eb11
Gerrit-Change-Number: 37816
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Attention is currently required from: dexter, laforge.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email )
Change subject: V1.2: Add function to set Device Capabilities
......................................................................
Patch Set 8:
(3 comments)
File src/ipa/libipa/euicc.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43060/comment/0f8b46a7_b45b2e56… :
PS7, Line 535: /* Capabilities according to 3GPP TS 102.221, section 11.1.19.2.4 and GSMA SGP.32, section 3.8.2 */
> Maybe we should also add GSMA SGP.22, section 3.4.2. In ipad.h you refer to this spec.
Done
File src/ipa/main.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43060/comment/0ca2ade6_cd72445a… :
PS7, Line 72: printf(" -D 0xXX ..................... set SGP.22 device capabilities other than the 3 that are required by this IPAd\n");
> maybe point directly to the table like: set optional device capabilities (SGP. […]
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43060/comment/67e891cc_7d30ffa2… :
PS7, Line 288: printf(" device_capabilities = %u\n", cfg.device_capabilities);
> Maybe use %02x because it is a bitmask?
Done
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I866787b8cda9a87a9f2e0db4965fbb554d339a6c
Gerrit-Change-Number: 43060
Gerrit-PatchSet: 8
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Aug 2026 12:39:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/43301?usp=email )
Change subject: OBS: fix 45-60 min delay for libosmocore CI jobs
......................................................................
OBS: fix 45-60 min delay for libosmocore CI jobs
In our jenkins, installing packages for centos7 is very slow when doing
it right before building packages. Work around it by installing all
build dependencies when building the docker image already.
Related: OS#7064
Change-Id: I0983201f6c65589e39d23f30c728fc8b0e2e5069
---
M scripts/obs/data/build_binpkg.Dockerfile
1 file changed, 27 insertions(+), 0 deletions(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/scripts/obs/data/build_binpkg.Dockerfile b/scripts/obs/data/build_binpkg.Dockerfile
index 386147e..fb3df72 100644
--- a/scripts/obs/data/build_binpkg.Dockerfile
+++ b/scripts/obs/data/build_binpkg.Dockerfile
@@ -122,4 +122,31 @@
;; \
esac
+# OS#7064: In our jenkins, installing packages for centos7 is very slow when
+# doing it right before building packages. Work around it by installing all
+# build dependencies when building the docker image already (where for some
+# reason it is not slow). This saves ~45 min for each CI run and can be done
+# here since we only have very few packages that we still must build for
+# centos7.
+# List of packages are from BuildRequires in these files:
+# https://gitea.osmocom.org/osmocom/libosmocore/src/branch/master/contrib/lib…
+# https://gitea.osmocom.org/osmocom/libosmo-netif/src/branch/master/contrib/l…
+# https://gitea.osmocom.org/osmocom/osmo-pcap/src/branch/master/contrib/osmo-…
+RUN case "$DISTRO" in \
+ centos:7) \
+ yum -y install \
+ 'pkgconfig(gnutls)' \
+ 'pkgconfig(libmnl)' \
+ 'pkgconfig(libpcsclite)' \
+ 'pkgconfig(libsystemd)' \
+ 'pkgconfig(libusb-1.0)' \
+ 'pkgconfig(libzmq)' \
+ 'pkgconfig(talloc)' \
+ libpcap-devel \
+ lksctp-tools-devel \
+ python3 \
+ xz \
+ ;; \
+ esac
+
WORKDIR /obs/
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43301?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I0983201f6c65589e39d23f30c728fc8b0e2e5069
Gerrit-Change-Number: 43301
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43302?usp=email )
Change subject: Add missing Pepare Download error handling
......................................................................
Add missing Pepare Download error handling
If Prepare Download on eUICC fails, an error code ist set. Be sure to
check the error code and trigger session cancellation, if set.
Related: SYS#8101
Change-Id: I6f13a12c494be57d6a6f377567bf38b0235ec4aa
---
M src/ipa/libipa/proc_prfle_dwnld.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/02/43302/1
diff --git a/src/ipa/libipa/proc_prfle_dwnld.c b/src/ipa/libipa/proc_prfle_dwnld.c
index 2c6893e..1ac4bb5 100644
--- a/src/ipa/libipa/proc_prfle_dwnld.c
+++ b/src/ipa/libipa/proc_prfle_dwnld.c
@@ -46,6 +46,8 @@
prep_dwnld_res = ipa_es10b_prep_dwnld(ctx, &prep_dwnld_req);
if (!prep_dwnld_res)
goto error;
+ if (prep_dwnld_res->prep_dwnld_err)
+ goto error;
/* The request may still have failed but we do not have to take any action on this since we forward the
* result as a whole to the eIM. In case of failure it is the responsibility of the eIM to look at error
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43302?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I6f13a12c494be57d6a6f377567bf38b0235ec4aa
Gerrit-Change-Number: 43302
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Attention is currently required from: dexter, jolly, laforge.
Hello Jenkins Builder, dexter, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Code-Review+1 by dexter, Verified+1 by Jenkins Builder
Change subject: V1.2: Add function to set Device Capabilities
......................................................................
V1.2: Add function to set Device Capabilities
Add new library function to set the SGP.22 Device Capabilities. Also
add an option to the command line interface to call the library
function.
The IoT device (modem) may and the IPA must set Device Capabilities.
They cannot be set independently. The IoT device would overwrite what
IPA has set and vice versa. Therefore add a library function for the
IoT device that takes care about setting the required capabilities for
IPA.
Reference: SGP.22 Section 3.4.2
Related: SYS#8101
Change-Id: I866787b8cda9a87a9f2e0db4965fbb554d339a6c
---
M include/onomondo/ipa/ipad.h
M src/ipa/libipa/euicc.c
M src/ipa/main.c
3 files changed, 15 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/60/43060/8
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I866787b8cda9a87a9f2e0db4965fbb554d339a6c
Gerrit-Change-Number: 43060
Gerrit-PatchSet: 8
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43063?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Add eimTransactionId to EuiccPackageErrorUnsigned
......................................................................
V1.2: Add eimTransactionId to EuiccPackageErrorUnsigned
Add new field eimTransactionId to EuiccPackageErrorUnsigned. The IoT
eUICC emulation set this field, if found in EuiccPackageSigned of
EuiccPackageRequest.
Reference: SGP.23 Section 2.11.2.1
Related: SYS#8101
Change-Id: Idfd596c56ef8cfe745f96cbaa6b8a5537927a919
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/EuiccPackageErrorUnsigned.c
M src/ipa/libasn/EuiccPackageErrorUnsigned.h
M src/ipa/libipa/es10b_load_euicc_pkg.c
4 files changed, 24 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/63/43063/8
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43063?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Idfd596c56ef8cfe745f96cbaa6b8a5537927a919
Gerrit-Change-Number: 43063
Gerrit-PatchSet: 8
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43061?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Add AuthenticateResponseOk and EuiccSigned1
......................................................................
V1.2: Add AuthenticateResponseOk and EuiccSigned1
Both structures are taken from SGP.22 but do not change. The IPA process uses these new structures, because the may be expanded in the future.
Reference: SGP.23 Section 5.14.3
Related: SYS#8101
Change-Id: I501247132de30618a2b1ace44c7c3772ab42eb09
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/CMakeLists.txt
A src/ipa/libasn/SGP32-AuthenticateResponseOk.c
A src/ipa/libasn/SGP32-AuthenticateResponseOk.h
M src/ipa/libasn/SGP32-AuthenticateServerResponse.c
M src/ipa/libasn/SGP32-AuthenticateServerResponse.h
A src/ipa/libasn/SGP32-EuiccSigned1.c
A src/ipa/libasn/SGP32-EuiccSigned1.h
M src/ipa/libipa/es10b_auth_serv.c
M src/ipa/libipa/es10b_auth_serv.h
10 files changed, 301 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/61/43061/8
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43061?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I501247132de30618a2b1ace44c7c3772ab42eb09
Gerrit-Change-Number: 43061
Gerrit-PatchSet: 8
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43064?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Remove error code from ListEimResult
......................................................................
V1.2: Remove error code from ListEimResult
Remove the commandError code from listEimError in ListEimResult. The
IPA process must use undefinedError instead.
Reference: SGP.23 Section 2.11.2.1
Related: SYS#8101
Change-Id: I8acb868970a589e70c1688427994854f9393a01b
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/ListEimResult.h
M src/ipa/libipa/es10b_load_euicc_pkg.c
3 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/64/43064/8
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43064?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I8acb868970a589e70c1688427994854f9393a01b
Gerrit-Change-Number: 43064
Gerrit-PatchSet: 8
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>