August 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: sccp2sua: sccp_(long)ptr_part_consistent() Fix read buffer overflow i...
by pespin 26 Aug '26

26 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43415?usp=email ) Change subject: sccp2sua: sccp_(long)ptr_part_consistent() Fix read buffer overflow if ptr in tail ...................................................................... sccp2sua: sccp_(long)ptr_part_consistent() Fix read buffer overflow if ptr in tail Since we are dereferencing the otctet ptr, ptr must be at least 1 octet before the tail pointer, otherwise we are reading outside of msgb data boundaries. Take the chance to rewrite a bit the functions to use variables to store intermediate results, which makes it easier to follow the logic behind the calculations following the example diagram in ITU-T Q.713 Figure 2/Q.713. Related: OS#7075 Reported-By: Tristan Madani <tristan(a)talencesecurity.com> Change-Id: Ibc5da4d03fff9bd83e85945c28dded3608611ab7 --- M src/sccp2sua.c 1 file changed, 19 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/15/43415/1 diff --git a/src/sccp2sua.c b/src/sccp2sua.c index b8030a6..5460732 100644 --- a/src/sccp2sua.c +++ b/src/sccp2sua.c @@ -475,21 +475,26 @@ static bool sccp_ptr_part_consistent(const struct msgb *msg, const uint8_t *ptr_addr) { const uint8_t *ptr; + uint8_t offs; + uint8_t len; /* check the address of the relative pointer is within msg */ - if (ptr_addr < msg->data || ptr_addr > msg->tail) { + if (ptr_addr < msg->data || ptr_addr >= msg->tail) { LOGP(DLSUA, LOGL_ERROR, "ptr_addr outside msg boundary\n"); return false; } - ptr = ptr_addr + *ptr_addr; - if (ptr > msg->tail) { + offs = *ptr_addr; + ptr = ptr_addr + offs; + if (ptr >= msg->tail) { LOGP(DLSUA, LOGL_ERROR, "ptr points outside msg boundary\n"); return false; } /* at destination of relative pointer is the length */ - if (ptr + 1 + *ptr > msg->tail) { + len = *ptr; + ptr++; + if (ptr + len > msg->tail) { LOGP(DLSUA, LOGL_ERROR, "ptr + len points outside msg boundary\n"); return false; } @@ -504,31 +509,31 @@ static bool sccp_longptr_part_consistent(const struct msgb *msg, const uint8_t *ptr_addr, bool len_is_long) { const uint8_t *ptr; - uint8_t offs; + uint16_t offs; + uint8_t len_size = len_is_long ? 2 : 1; uint16_t len; /* check the address of the relative pointer is within msg */ - if (ptr_addr < msg->data || ptr_addr > msg->tail) { + if (ptr_addr < msg->data || (ptr_addr + sizeof(uint16_t)) > msg->tail) { LOGP(DLSUA, LOGL_ERROR, "ptr_addr outside msg boundary\n"); return false; } + offs = osmo_load16le(ptr_addr); /* +1: Distance from MSB of pointer */ - ptr = ptr_addr + 1 + osmo_load16le(ptr_addr); - if (ptr > msg->tail) { + ptr = ptr_addr + 1 + offs; + if (ptr + len_size > msg->tail) { LOGP(DLSUA, LOGL_ERROR, "ptr %p points outside msg boundary %p\n", ptr, msg->tail); return false; } /* at destination of relative pointer is the length */ - if (len_is_long) { - offs = 2; + if (len_is_long) len = osmo_load16le(ptr); - } else { - offs = 1; + else len = *ptr; - } - if (ptr + offs + len > msg->tail) { + ptr += len_size; + if (ptr + len > msg->tail) { LOGP(DLSUA, LOGL_ERROR, "ptr + len points outside msg boundary\n"); return false; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibc5da4d03fff9bd83e85945c28dded3608611ab7 Gerrit-Change-Number: 43415 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: sccp2sua: sccp_to_xua_opt(): Fix read buffer overflow on truncated msg
by pespin 26 Aug '26

26 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43416?usp=email ) Change subject: sccp2sua: sccp_to_xua_opt(): Fix read buffer overflow on truncated msg ...................................................................... sccp2sua: sccp_to_xua_opt(): Fix read buffer overflow on truncated msg If a malformed/truncated message is received which lacks contents where the last byte of the (1-2 bytes) length Indicator should be, we'd be reading outside of the msgb data. See how in the switch statement the first offset is one less than the follow-up checks. Clean up the function by increasing the pointer on each state in order to fix it. Related: OS#7075 Reported-By: Tristan Madani <tristan(a)talencesecurity.com> Change-Id: I8f9a20b4eff4f4fd76f6c5a7e87ac0afb5921a8b --- M src/sccp2sua.c 1 file changed, 20 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/16/43416/1 diff --git a/src/sccp2sua.c b/src/sccp2sua.c index 5460732..80c24ab 100644 --- a/src/sccp2sua.c +++ b/src/sccp2sua.c @@ -807,7 +807,7 @@ /* some bounds checking */ if (ptr_opt < msg->data) return NULL; - if (ptr_opt > msg->tail - (ptr_opt_is_long ? 2 : 1)) + if (ptr_opt + (ptr_opt_is_long ? 2 : 1) > msg->tail) return NULL; if (ptr_opt_is_long) @@ -831,34 +831,36 @@ enum sccp_parameter_name_codes opt_type = 0; /* dummy value not used */ while (oneopt < msg->tail) { - uint8_t opt_len; - uint16_t opt_len16; + uint8_t len_size; + uint16_t opt_len; + opt_type = oneopt[0]; + oneopt++; switch (opt_type) { case SCCP_PNC_END_OF_OPTIONAL: return xua; case SCCP_PNC_LONG_DATA: - /* two byte length field */ - if (oneopt + 2 > msg->tail) + /* two byte "Length Indicator" */ + len_size = 2; + if (oneopt + len_size > msg->tail) goto malformed; - opt_len16 = oneopt[1] << 8 | oneopt[2]; - if (oneopt + 3 + opt_len16 > msg->tail) - goto malformed; - xua_msg_add_sccp_opt(xua, opt_type, opt_len16, oneopt+3); - oneopt += 3 + opt_len16; + opt_len = oneopt[0] << 8 | oneopt[1]; + oneopt += len_size; break; default: - /* one byte length field */ - if (oneopt + 1 > msg->tail) + /* one byte "Length Indicator" */ + len_size = 1; + if (oneopt + len_size > msg->tail) goto malformed; - - opt_len = oneopt[1]; - if (oneopt + 2 + opt_len > msg->tail) - goto malformed; - xua_msg_add_sccp_opt(xua, opt_type, opt_len, oneopt+2); - oneopt += 2 + opt_len; + opt_len = oneopt[0]; + oneopt += len_size; } + + if (oneopt + opt_len > msg->tail) + goto malformed; + xua_msg_add_sccp_opt(xua, opt_type, opt_len, oneopt); + oneopt += opt_len; } LOGP(DLSUA, LOGL_ERROR, "Parameter %s not found\n", osmo_sccp_pnc_name(SCCP_PNC_END_OF_OPTIONAL)); return NULL; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8f9a20b4eff4f4fd76f6c5a7e87ac0afb5921a8b Gerrit-Change-Number: 43416 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-sgsn[master]: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on re-Attach
by fixeria 26 Aug '26

26 Aug '26

Attention is currently required from: lynxis lazus, osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email ) Change subject: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on re-Attach ...................................................................... Patch Set 4: Code-Review-2 (1 comment) Patchset: PS4: Actually, we cannot merge this patch as-is. Releasing PDP contexts early, before the authentication completed, opens a door for a DoS vector: an attacker sending an ATTACH REQUEST on behalf of the victim will efficiently terminate all active PDP contexts of the victim. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I20c1f5f741275115635188b2f4b1c5fe7c6e40f1 Gerrit-Change-Number: 42594 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 26 Aug 2026 14:33:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: mtp3_rtpc: Fix potential assert getting rcxt_ie->len < 4
by pespin 26 Aug '26

26 Aug '26

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43410?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by osmith Change subject: mtp3_rtpc: Fix potential assert getting rcxt_ie->len < 4 ...................................................................... mtp3_rtpc: Fix potential assert getting rcxt_ie->len < 4 If an incoming message which contains an unbounded Routing Context IE, it may be that it comes malformed and hence len is < 4. In that case, xua_msg_part_get_u32() would have hit an ASSERT. Fix the problem by simply passing by the whole Routing Context (removing non-multiple of 4 potential churn at the end), since anyway we should be sending the same whole set of Routing Contexts we received. Related: OS#7074 Reported-By: Tristan Madani <tristan(a)talencesecurity.com> Change-Id: Ia0a8dd4907d6ad786e9cc257d299a1521dd45dee --- M src/mtp3_rtpc.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/10/43410/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia0a8dd4907d6ad786e9cc257d299a1521dd45dee Gerrit-Change-Number: 43410 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: m3ua: Remove unnecessary check in m3ua_decode_notify()
by pespin 26 Aug '26

26 Aug '26

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43411?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith Change subject: m3ua: Remove unnecessary check in m3ua_decode_notify() ...................................................................... m3ua: Remove unnecessary check in m3ua_decode_notify() M3UA_IEI_STATUS is mandatory in M3UA NOTIFY Req, and its presence and fixed length is hence being validated in struct xua_msg_part_class m3ua_ntfy_req_ies. Related: OS#7074 Reported-By: Tristan Madani <tristan(a)talencesecurity.com> Change-Id: I9fe6417ccc560e13603fbd2d5823afbeba8c9064 --- M src/m3ua.c 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/11/43411/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9fe6417ccc560e13603fbd2d5823afbeba8c9064 Gerrit-Change-Number: 43411 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in onomondo-ipa[master]: cosmetic: remove trailing whitespaces in copyright notices
by dexter 26 Aug '26

26 Aug '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43414?usp=email ) Change subject: cosmetic: remove trailing whitespaces in copyright notices ...................................................................... cosmetic: remove trailing whitespaces in copyright notices Related: SYS#8101 Change-Id: Iee4148927b5ae978bc384eca8369b3e44678bc02 --- M src/ipa/libipa/es10b_add_init_eim.c M src/ipa/libipa/es10b_cancel_session.c M src/ipa/libipa/es10b_prep_dwnld.c M src/ipa/libipa/es10c_get_eid.c M src/ipa/libipa/esipa_auth_clnt.c M src/ipa/libipa/esipa_get_bnd_prfle_pkg.c M src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c 7 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/14/43414/1 diff --git a/src/ipa/libipa/es10b_add_init_eim.c b/src/ipa/libipa/es10b_add_init_eim.c index 0b9fd5e..a095967 100644 --- a/src/ipa/libipa/es10b_add_init_eim.c +++ b/src/ipa/libipa/es10b_add_init_eim.c @@ -4,7 +4,7 @@ * SPDX-License-Identifier: AGPL-3.0-only * * Author: Philipp Maier <pmaier(a)sysmocom.de> / sysmocom - s.f.m.c. GmbH - * + * * See also: GSMA SGP.32, 5.9.4: Function (ES10b): AddInitialEim */ diff --git a/src/ipa/libipa/es10b_cancel_session.c b/src/ipa/libipa/es10b_cancel_session.c index e37f660..04e3153 100644 --- a/src/ipa/libipa/es10b_cancel_session.c +++ b/src/ipa/libipa/es10b_cancel_session.c @@ -4,7 +4,7 @@ * SPDX-License-Identifier: AGPL-3.0-only * * Author: Philipp Maier <pmaier(a)sysmocom.de> / sysmocom - s.f.m.c. GmbH - * + * * See also: GSMA SGP.22, 5.7.14: Function (ES10b): CancelSession */ diff --git a/src/ipa/libipa/es10b_prep_dwnld.c b/src/ipa/libipa/es10b_prep_dwnld.c index f623527..32f70dd 100644 --- a/src/ipa/libipa/es10b_prep_dwnld.c +++ b/src/ipa/libipa/es10b_prep_dwnld.c @@ -4,7 +4,7 @@ * SPDX-License-Identifier: AGPL-3.0-only * * Author: Philipp Maier <pmaier(a)sysmocom.de> / sysmocom - s.f.m.c. GmbH - * + * * See also: GSMA SGP.22, section 5.7.5: Function (ES10b): PrepareDownload */ diff --git a/src/ipa/libipa/es10c_get_eid.c b/src/ipa/libipa/es10c_get_eid.c index 78a5c3e..ceffaf3 100644 --- a/src/ipa/libipa/es10c_get_eid.c +++ b/src/ipa/libipa/es10c_get_eid.c @@ -4,7 +4,7 @@ * SPDX-License-Identifier: AGPL-3.0-only * * Author: Philipp Maier <pmaier(a)sysmocom.de> / sysmocom - s.f.m.c. GmbH - * + * * See also: GSMA SGP.22, 5.7.20: Function (ES10c): GetEID */ diff --git a/src/ipa/libipa/esipa_auth_clnt.c b/src/ipa/libipa/esipa_auth_clnt.c index 8af59a6..8b9a6bd 100644 --- a/src/ipa/libipa/esipa_auth_clnt.c +++ b/src/ipa/libipa/esipa_auth_clnt.c @@ -4,7 +4,7 @@ * SPDX-License-Identifier: AGPL-3.0-only * * Author: Philipp Maier <pmaier(a)sysmocom.de> / sysmocom - s.f.m.c. GmbH - * + * * See also: GSMA SGP.32, section 5.14.3: Function: (Esipa) AuthenticateClient */ diff --git a/src/ipa/libipa/esipa_get_bnd_prfle_pkg.c b/src/ipa/libipa/esipa_get_bnd_prfle_pkg.c index 4e25c3b..37c9ecf 100644 --- a/src/ipa/libipa/esipa_get_bnd_prfle_pkg.c +++ b/src/ipa/libipa/esipa_get_bnd_prfle_pkg.c @@ -4,7 +4,7 @@ * SPDX-License-Identifier: AGPL-3.0-only * * Author: Philipp Maier <pmaier(a)sysmocom.de> / sysmocom - s.f.m.c. GmbH - * + * * See also: GSMA SGP.32, section 5.14.2: Function: (ESipa) GetBoundProfilePackage */ diff --git a/src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c b/src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c index 2d5a31b..5ed7c38 100644 --- a/src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c +++ b/src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c @@ -4,7 +4,7 @@ * SPDX-License-Identifier: AGPL-3.0-only * * Author: Philipp Maier <pmaier(a)sysmocom.de> / sysmocom - s.f.m.c. GmbH - * + * * See also: GSMA SGP.32, section 5.14.6: Function (ESipa): ProvideEimPackageResult */ -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43414?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Iee4148927b5ae978bc384eca8369b3e44678bc02 Gerrit-Change-Number: 43414 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in onomondo-ipa[master]: Update copyright notice in all files
by dexter 26 Aug '26

26 Aug '26

Attention is currently required from: jolly. dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43404?usp=email ) Change subject: Update copyright notice in all files ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43404?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I0be68590607d88140c6b478fb4a88d2354cd0605 Gerrit-Change-Number: 43404 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 26 Aug 2026 13:34:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in onomondo-ipa[master]: Update README.md related to the current command line parameters
by dexter 26 Aug '26

26 Aug '26

Attention is currently required from: jolly. dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43403?usp=email ) Change subject: Update README.md related to the current command line parameters ...................................................................... Patch Set 2: Code-Review+1 (4 comments) File README.md: https://gerrit.osmocom.org/c/onomondo-ipa/+/43403/comment/6c0b2589_0e7c1ee4… : PS2, Line 4: element in the 3GPP IoT eSIM system as described in SGP.31 and SGP.32. It interfaces between the eUICC on one side, oops! There is a trailing white space that was already there before... https://gerrit.osmocom.org/c/onomondo-ipa/+/43403/comment/3026d2b4_48729ad7… : PS2, Line 95: * `add-initial-eim <PATH>` specifies the path to an initial eIM configuration file. I would move this line to the bottom since we usually pass the operations at the end of the command-line. And it looks more consistent. https://gerrit.osmocom.org/c/onomondo-ipa/+/43403/comment/3db718a6_91f023a4… : PS2, Line 104: During the first run, onomondo-ipa will create an `nvstate.bin` file in its working directory. again A whitsepace that has been overlooked. We should remove it with this patch. https://gerrit.osmocom.org/c/onomondo-ipa/+/43403/comment/b844be2a_92b7404f… : PS2, Line 121: the eidValue from the eUICC and use it to query the eIM for eIM packages. In case no eIM package is available (error I would change "it will read the eUICC configuration" To "it will read the eIM configuration data" -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43403?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I66b89db33676139c8746eb1f94133e14af6e1485 Gerrit-Change-Number: 43403 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 26 Aug 2026 13:20:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in onomondo-ipa[master]: main: load addInitialEimRequest from hex-file
by dexter 26 Aug '26

26 Aug '26

Attention is currently required from: jolly. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43413?usp=email ) Change subject: main: load addInitialEimRequest from hex-file ...................................................................... Patch Set 1: (1 comment) File README.md: https://gerrit.osmocom.org/c/onomondo-ipa/+/43413/comment/5f6a6d47_450256a6… : PS1, Line 115: ./src/ipa/ipa -r 2 -f ../contrib/sample_eim_cfg.ber I intentionally didn't change the file ending here to avoid merge conflicts with the patches from @andreas@eversberg.eu -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43413?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Ib2095e5042f42ce77af498831be9c8bd1af32401 Gerrit-Change-Number: 43413 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 26 Aug 2026 12:59:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in onomondo-ipa[master]: ipad/log: fix incorrectly referenced ASN.1 object
by dexter 26 Aug '26

26 Aug '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43412?usp=email ) Change subject: ipad/log: fix incorrectly referenced ASN.1 object ...................................................................... ipad/log: fix incorrectly referenced ASN.1 object The object that loads the initial eIM configuration is called "AddInitialEimRequest" and not "EimConfigurationData" Related: SYS#8101 Change-Id: I6b488081abc27fb0c66ea1e696f80f7d67f23365 --- M src/ipa/libipa/ipad.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/12/43412/1 diff --git a/src/ipa/libipa/ipad.c b/src/ipa/libipa/ipad.c index 730ff50..1798c37 100644 --- a/src/ipa/libipa/ipad.c +++ b/src/ipa/libipa/ipad.c @@ -235,7 +235,7 @@ /* Decode AddInitialEimRequest */ rc = ber_decode(0, &asn_DEF_AddInitialEimRequest, (void **)&eim_cfg_decoded, cfg->data, cfg->len); if (rc.code != RC_OK) { - IPA_LOGP(SIPA, LERROR, "unable decode EimConfigurationData\n"); + IPA_LOGP(SIPA, LERROR, "unable decode AddInitialEimRequest\n"); ASN_STRUCT_FREE(asn_DEF_AddInitialEimRequest, eim_cfg_decoded); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43412?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I6b488081abc27fb0c66ea1e696f80f7d67f23365 Gerrit-Change-Number: 43412 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026