August 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: sua: Do SUA specific MGMT msg validation [3/6]
by osmith 26 Aug '26

26 Aug '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43407?usp=email ) Change subject: sua: Do SUA specific MGMT msg validation [3/6] ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43407?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I97ae5683d8eee2c6d30ae49736ca3fffe33a665f Gerrit-Change-Number: 43407 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Aug 2026 12:21:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: xua: Validate IE lengths of incoming messages [1/6]
by osmith 26 Aug '26

26 Aug '26

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43386?usp=email ) Change subject: xua: Validate IE lengths of incoming messages [1/6] ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9b1ae0dbc324123790942c9e6068f6822e3bb957 Gerrit-Change-Number: 43386 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Aug 2026 12:21:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: xua: Validate IE lengths of incoming messages [1/6]
by pespin 26 Aug '26

26 Aug '26

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43386?usp=email ) Change subject: xua: Validate IE lengths of incoming messages [1/6] ...................................................................... Patch Set 7: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9b1ae0dbc324123790942c9e6068f6822e3bb957 Gerrit-Change-Number: 43386 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Aug 2026 12:19:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: xua: Validate IE lengths of incoming messages [1/6]
by pespin 26 Aug '26

26 Aug '26

Attention is currently required from: fixeria, laforge, osmith. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43386?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: xua: Validate IE lengths of incoming messages [1/6] ...................................................................... xua: Validate IE lengths of incoming messages [1/6] Improve the data structures defining M3UA/SUA messages to also include expected min/max lengths of each IE in a given message. This way we already cover in one place validation of fixed length IEs. This patch is the first in a series of patches that go together, since now that more checks are done some message structure definitions need to be added in both M3UA and SUA. xua_dialect_check_all_ies_ext() is split into helper xua_dialect_check_all_ies_ext() because it will also be used directly when checking grouped IEs for RKM message Routing key and (De)Registration Result. Related: OS#7074 Reported-By: Tristan Madani <tristan(a)talencesecurity.com> Change-Id: I9b1ae0dbc324123790942c9e6068f6822e3bb957 --- M src/m3ua.c M src/sua.c M src/xua_msg.c M src/xua_msg.h 4 files changed, 435 insertions(+), 128 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/86/43386/7 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9b1ae0dbc324123790942c9e6068f6822e3bb957 Gerrit-Change-Number: 43386 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: sua: Do SUA specific SNM msg validation [4/6]
by pespin 26 Aug '26

26 Aug '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43399?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sua: Do SUA specific SNM msg validation [4/6] ...................................................................... sua: Do SUA specific SNM msg validation [4/6] SUA SNM messages contain IEs different than those of related M3UA SNM messages. Until now it was fine because we only checked for mandatory IEs, but it's not the case anymore. Related: OS#7074 Reported-By: Tristan Madani <tristan(a)talencesecurity.com> Change-Id: Iba32835035867175fa83f3c1e0639918b37432b5 --- M src/sua.c 1 file changed, 77 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/99/43399/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43399?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iba32835035867175fa83f3c1e0639918b37432b5 Gerrit-Change-Number: 43399 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: sua: Do SUA specific MGMT msg validation [3/6]
by pespin 26 Aug '26

26 Aug '26

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43407?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: sua: Do SUA specific MGMT msg validation [3/6] ...................................................................... sua: Do SUA specific MGMT msg validation [3/6] SUA MGMT ERR messages contain Network Appearance IE, which has different tag than related IE in M3UA. Until now it was fine because we only checked for mandatory IEs, but it's not the case anymore. Related: OS#7074 Reported-By: Tristan Madani <tristan(a)talencesecurity.com> Change-Id: I97ae5683d8eee2c6d30ae49736ca3fffe33a665f --- M src/m3ua.c M src/sua.c M src/xua_internal.h 3 files changed, 32 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/07/43407/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43407?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I97ae5683d8eee2c6d30ae49736ca3fffe33a665f Gerrit-Change-Number: 43407 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: xua_rkm: rx REG REQ: clean up Routing Context IE checks
by pespin 26 Aug '26

26 Aug '26

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43396?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: xua_rkm: rx REG REQ: clean up Routing Context IE checks ...................................................................... xua_rkm: rx REG REQ: clean up Routing Context IE checks RFC4666 3.6.1 clearly marks the IE as optional. Our exisitng logic also expected that the routing key may not be there. Validate existence of the IE and explicitly set local variable to 0 instead of relying on xua_msg_get_u32() returning 0 on failure. Change-Id: I0dd6b2892f9ffa72880f98d03e13f0b354c47c61 --- M src/xua_rkm.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/96/43396/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0dd6b2892f9ffa72880f98d03e13f0b354c47c61 Gerrit-Change-Number: 43396 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: xua_rkm: REG REQ: clean up Traffic Mode Type checks
by pespin 26 Aug '26

26 Aug '26

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43397?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: xua_rkm: REG REQ: clean up Traffic Mode Type checks ...................................................................... xua_rkm: REG REQ: clean up Traffic Mode Type checks Validate existence of the IE and explicitly set local variable to 0 instead of relying on xua_msg_get_u32() returning 0 on failure. Change-Id: I4b07b0608eaf2e841f47f7c664e056152ca68f72 --- M src/xua_rkm.c 1 file changed, 17 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/97/43397/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43397?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4b07b0608eaf2e841f47f7c664e056152ca68f72 Gerrit-Change-Number: 43397 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: xua_rkm: rx DEREG REQ: Fix potential read buffer overflow
by pespin 26 Aug '26

26 Aug '26

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43395?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: xua_rkm: rx DEREG REQ: Fix potential read buffer overflow ...................................................................... xua_rkm: rx DEREG REQ: Fix potential read buffer overflow The loop in the function was not taking into account cases like data being non-multiple of 4. Related: OS#7074 Reported-By: Tristan Madani <tristan(a)talencesecurity.com> Change-Id: I861259b2bb57ce80167a8f2d1c1770b56dc09718 --- M src/xua_rkm.c 1 file changed, 21 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/95/43395/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43395?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I861259b2bb57ce80167a8f2d1c1770b56dc09718 Gerrit-Change-Number: 43395 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: xua_asp_fsm: ASP ACT: Avoid double lookup of Traffic Mode Type IE
by pespin 26 Aug '26

26 Aug '26

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43398?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: xua_asp_fsm: ASP ACT: Avoid double lookup of Traffic Mode Type IE ...................................................................... xua_asp_fsm: ASP ACT: Avoid double lookup of Traffic Mode Type IE Change-Id: Idc764d9d6f517cd28defaf226e6b0957cce92585 --- M src/xua_asp_fsm.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/98/43398/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43398?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Idc764d9d6f517cd28defaf226e6b0957cce92585 Gerrit-Change-Number: 43398 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026