Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43070?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Change tag in TransferEimPackageResponse
......................................................................
V1.2: Change tag in TransferEimPackageResponse
Change tag value of notificationList in TransferEimPackageResponse.
Also change it from RetrieveNotificationsListResponse to
PendingNotificationList.
Reference: SGP.23 Section 6.3.1
Related: SYS#8101
Change-Id: I4c9cdd1b79ec22a1d5e36d1720cf5c703890c28b
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/SGP32-RetrieveNotificationsListResponse.c
M src/ipa/libasn/SGP32-RetrieveNotificationsListResponse.h
M src/ipa/libasn/TransferEimPackageResponse.c
M src/ipa/libasn/TransferEimPackageResponse.h
5 files changed, 9 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/70/43070/8
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43070?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I4c9cdd1b79ec22a1d5e36d1720cf5c703890c28b
Gerrit-Change-Number: 43070
Gerrit-PatchSet: 8
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43223?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: Use mandatory transaction ID in AuthenticateClientOkDPEsipa
......................................................................
Use mandatory transaction ID in AuthenticateClientOkDPEsipa
The transaction ID in the sequence of AuthenticateClientOkDPEsipa is
optional, so lets use the mandatory transaction ID from the smdpSigned2
field instead.
If the optional transaction ID exists, check if it matches with the
mandatory one.
Related: SYS#8101
Change-Id: I3aed3f6ff6f10b49045ff7a4b0f0019ac1d75c65
---
M src/ipa/libipa/esipa_auth_clnt.c
1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/23/43223/2
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43223?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I3aed3f6ff6f10b49045ff7a4b0f0019ac1d75c65
Gerrit-Change-Number: 43223
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43301?usp=email )
Change subject: OBS: fix 45-60 min delay for libosmocore CI jobs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43301?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I0983201f6c65589e39d23f30c728fc8b0e2e5069
Gerrit-Change-Number: 43301
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Aug 2026 12:35:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43301?usp=email )
Change subject: OBS: fix 45-60 min delay for libosmocore CI jobs
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43301?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I0983201f6c65589e39d23f30c728fc8b0e2e5069
Gerrit-Change-Number: 43301
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Aug 2026 12:34:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/43301?usp=email )
Change subject: OBS: fix 45-60 min delay for libosmocore CI jobs
......................................................................
OBS: fix 45-60 min delay for libosmocore CI jobs
In our jenkins, installing packages for centos7 is very slow when doing
it right before building packages. Work around it by installing all
build dependencies when building the docker image already.
Related: OS#7064
Change-Id: I0983201f6c65589e39d23f30c728fc8b0e2e5069
---
M scripts/obs/data/build_binpkg.Dockerfile
1 file changed, 27 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/01/43301/1
diff --git a/scripts/obs/data/build_binpkg.Dockerfile b/scripts/obs/data/build_binpkg.Dockerfile
index 386147e..fb3df72 100644
--- a/scripts/obs/data/build_binpkg.Dockerfile
+++ b/scripts/obs/data/build_binpkg.Dockerfile
@@ -122,4 +122,31 @@
;; \
esac
+# OS#7064: In our jenkins, installing packages for centos7 is very slow when
+# doing it right before building packages. Work around it by installing all
+# build dependencies when building the docker image already (where for some
+# reason it is not slow). This saves ~45 min for each CI run and can be done
+# here since we only have very few packages that we still must build for
+# centos7.
+# List of packages are from BuildRequires in these files:
+# https://gitea.osmocom.org/osmocom/libosmocore/src/branch/master/contrib/lib…
+# https://gitea.osmocom.org/osmocom/libosmo-netif/src/branch/master/contrib/l…
+# https://gitea.osmocom.org/osmocom/osmo-pcap/src/branch/master/contrib/osmo-…
+RUN case "$DISTRO" in \
+ centos:7) \
+ yum -y install \
+ 'pkgconfig(gnutls)' \
+ 'pkgconfig(libmnl)' \
+ 'pkgconfig(libpcsclite)' \
+ 'pkgconfig(libsystemd)' \
+ 'pkgconfig(libusb-1.0)' \
+ 'pkgconfig(libzmq)' \
+ 'pkgconfig(talloc)' \
+ libpcap-devel \
+ lksctp-tools-devel \
+ python3 \
+ xz \
+ ;; \
+ esac
+
WORKDIR /obs/
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43301?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I0983201f6c65589e39d23f30c728fc8b0e2e5069
Gerrit-Change-Number: 43301
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43055?usp=email )
Change subject: V1.2: Change fields in ProvideEimPackage(Result)
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43055/comment/582d45c9_c65bba65… :
PS6, Line 86: res->eim_acknowledgements = &msg_to_ipa->choice.provideEimPackageResultResponse.choice.eimAcknowledgements;
I wonder if we should be more explcit in the case of an emptyResponse. We could have a bool empty_response in the result and set that to true in case ProvideEimPackageResultResponse_PR_emptyResponse is present. Then the caller has a more exact result.
We also do not return the provideEimPackageResultError field yet. Maybe we should do that.
(sure, the caller can always look into msg_to_ipa but that pointer servers more as an input for the free functions. The philosophy is to bring the interesting IEs directly to the front in the response structure.)
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43055?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I24baab4f9351aec27c58403b94974cba4b274c34
Gerrit-Change-Number: 43055
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 19 Aug 2026 12:21:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43299?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: hnbgw: Move generic PFCP ConnHdlr helpers to library/PFCP_Emulation.ttcn
......................................................................
hnbgw: Move generic PFCP ConnHdlr helpers to library/PFCP_Emulation.ttcn
Change-Id: Ic40bea51934ad465a68e0d5690de066cbe1dc57d
---
M hnbgw/HNBGW_Tests.ttcn
M library/PFCP_Emulation.ttcn
2 files changed, 108 insertions(+), 98 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/43299/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43299?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic40bea51934ad465a68e0d5690de066cbe1dc57d
Gerrit-Change-Number: 43299
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>