Attention is currently required from: fixeria, laforge, osmith.
Hello Jenkins Builder, fixeria, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43386?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: xua: Validate IE lengths of incoming messages [1/6] ......................................................................
xua: Validate IE lengths of incoming messages [1/6]
Improve the data structures defining M3UA/SUA messages to also include expected min/max lengths of each IE in a given message.
This way we already cover in one place validation of fixed length IEs.
This patch is the first in a series of patches that go together, since now that more checks are done some message structure definitions need to be added in both M3UA and SUA.
xua_dialect_check_all_ies_ext() is split into helper xua_dialect_check_all_ies_ext() because it will also be used directly when checking grouped IEs for RKM message Routing key and (De)Registration Result.
Related: OS#7074 Reported-By: Tristan Madani tristan@talencesecurity.com Change-Id: I9b1ae0dbc324123790942c9e6068f6822e3bb957 --- M src/m3ua.c M src/sua.c M src/xua_msg.c M src/xua_msg.h 4 files changed, 435 insertions(+), 128 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/86/43386/7