August 2026 - gerrit-log - lists.osmocom.org

[XS] Change in onomondo-ipa[master]: ipad/log: fix incorrectly referenced ASN.1 object
by laforge 26 Aug '26

26 Aug '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43412?usp=email ) Change subject: ipad/log: fix incorrectly referenced ASN.1 object ...................................................................... ipad/log: fix incorrectly referenced ASN.1 object The object that loads the initial eIM configuration is called "AddInitialEimRequest" and not "EimConfigurationData" Related: SYS#8101 Change-Id: I6b488081abc27fb0c66ea1e696f80f7d67f23365 --- M src/ipa/libipa/ipad.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/ipa/libipa/ipad.c b/src/ipa/libipa/ipad.c index 730ff50..1798c37 100644 --- a/src/ipa/libipa/ipad.c +++ b/src/ipa/libipa/ipad.c @@ -235,7 +235,7 @@ /* Decode AddInitialEimRequest */ rc = ber_decode(0, &asn_DEF_AddInitialEimRequest, (void **)&eim_cfg_decoded, cfg->data, cfg->len); if (rc.code != RC_OK) { - IPA_LOGP(SIPA, LERROR, "unable decode EimConfigurationData\n"); + IPA_LOGP(SIPA, LERROR, "unable decode AddInitialEimRequest\n"); ASN_STRUCT_FREE(asn_DEF_AddInitialEimRequest, eim_cfg_decoded); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43412?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I6b488081abc27fb0c66ea1e696f80f7d67f23365 Gerrit-Change-Number: 43412 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in onomondo-ipa[master]: ipad/log: fix incorrectly referenced ASN.1 object
by laforge 26 Aug '26

26 Aug '26

Attention is currently required from: dexter, jolly. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43412?usp=email ) Change subject: ipad/log: fix incorrectly referenced ASN.1 object ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43412?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I6b488081abc27fb0c66ea1e696f80f7d67f23365 Gerrit-Change-Number: 43412 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Aug 2026 16:03:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in onomondo-ipa[master]: cosmetic: remove trailing whitespaces in copyright notices
by laforge 26 Aug '26

26 Aug '26

Attention is currently required from: dexter, jolly. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43414?usp=email ) Change subject: cosmetic: remove trailing whitespaces in copyright notices ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43414?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Iee4148927b5ae978bc384eca8369b3e44678bc02 Gerrit-Change-Number: 43414 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Aug 2026 16:03:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: sccp2sua: osmo_sccp_addr_parse(): Fix read buffer overflow
by laforge 26 Aug '26

26 Aug '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43417?usp=email ) Change subject: sccp2sua: osmo_sccp_addr_parse(): Fix read buffer overflow ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43417?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1feabda052dc7a78b7d1d146aeb684e763923f74 Gerrit-Change-Number: 43417 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Aug 2026 16:03:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: sccp2sua: sccp_to_xua_opt(): Fix read buffer overflow on truncated msg
by laforge 26 Aug '26

26 Aug '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43416?usp=email ) Change subject: sccp2sua: sccp_to_xua_opt(): Fix read buffer overflow on truncated msg ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8f9a20b4eff4f4fd76f6c5a7e87ac0afb5921a8b Gerrit-Change-Number: 43416 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Aug 2026 16:02:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: sccp2sua: sccp_(long)ptr_part_consistent() Fix read buffer overflow i...
by laforge 26 Aug '26

26 Aug '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43415?usp=email ) Change subject: sccp2sua: sccp_(long)ptr_part_consistent() Fix read buffer overflow if ptr in tail ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibc5da4d03fff9bd83e85945c28dded3608611ab7 Gerrit-Change-Number: 43415 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Aug 2026 16:02:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: m3ua: Remove unnecessary check in m3ua_decode_notify()
by laforge 26 Aug '26

26 Aug '26

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43411?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: m3ua: Remove unnecessary check in m3ua_decode_notify() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9fe6417ccc560e13603fbd2d5823afbeba8c9064 Gerrit-Change-Number: 43411 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Aug 2026 16:01:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: m3ua: Remove unnecessary check in m3ua_decode_notify()
by laforge 26 Aug '26

26 Aug '26

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43411?usp=email ) Change subject: m3ua: Remove unnecessary check in m3ua_decode_notify() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9fe6417ccc560e13603fbd2d5823afbeba8c9064 Gerrit-Change-Number: 43411 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Aug 2026 16:01:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: mtp3_rtpc: Fix potential assert getting rcxt_ie->len < 4
by laforge 26 Aug '26

26 Aug '26

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43410?usp=email ) Change subject: mtp3_rtpc: Fix potential assert getting rcxt_ie->len < 4 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia0a8dd4907d6ad786e9cc257d299a1521dd45dee Gerrit-Change-Number: 43410 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Aug 2026 16:01:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: sccp2sua: osmo_sccp_addr_parse(): Fix read buffer overflow
by pespin 26 Aug '26

26 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43417?usp=email ) Change subject: sccp2sua: osmo_sccp_addr_parse(): Fix read buffer overflow ...................................................................... sccp2sua: osmo_sccp_addr_parse(): Fix read buffer overflow The function was not validating reads passed the input buffer length. Related: OS#7077 Reported-By: Tristan Madani <tristan(a)talencesecurity.com> Change-Id: I1feabda052dc7a78b7d1d146aeb684e763923f74 --- M src/sccp2sua.c 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/17/43417/1 diff --git a/src/sccp2sua.c b/src/sccp2sua.c index 80c24ab..84e06df 100644 --- a/src/sccp2sua.c +++ b/src/sccp2sua.c @@ -115,16 +115,20 @@ * \returns 0 in case of success, negative on error * According to Q.713/3.4 and RFC3868/3.10.2 */ int osmo_sccp_addr_parse(struct osmo_sccp_addr *out, - const uint8_t *addr, unsigned int addrlen) + const uint8_t *addr, unsigned int addrlen) { struct sccp_called_party_address *sca; uint8_t *cur; + const uint8_t *tail = addr + addrlen; uint8_t encoding; bool odd; int rc; memset(out, 0, sizeof(*out)); + if (addrlen < sizeof(struct sccp_called_party_address)) + return -1; + sca = (struct sccp_called_party_address *) addr; cur = sca->data; @@ -134,6 +138,8 @@ out->ri = OSMO_SCCP_RI_GT; if (sca->point_code_indicator) { + if (cur + 2 > tail) + return -1; out->presence |= OSMO_SCCP_ADDR_T_PC; out->pc = (uint16_t) (cur[1] & 0x3f) << 8; out->pc |= cur[0]; @@ -141,6 +147,8 @@ } if (sca->ssn_indicator) { + if (cur + 1 > tail) + return -1; out->presence |= OSMO_SCCP_ADDR_T_SSN; out->ssn = *cur; cur += 1; @@ -151,6 +159,8 @@ out->gt.gti = OSMO_SCCP_GTI_NO_GT; return 0; case SCCP_TITLE_IND_NATURE_ONLY: + if (cur + 1 > tail) + return -1; out->presence |= OSMO_SCCP_ADDR_T_GT; out->gt.gti = OSMO_SCCP_GTI_NAI_ONLY; out->gt.nai = *cur & 0x7f; @@ -160,6 +170,8 @@ odd = false; break; case SCCP_TITLE_IND_TRANSLATION_ONLY: + if (cur + 1 > tail) + return -1; out->presence |= OSMO_SCCP_ADDR_T_GT; out->gt.gti = OSMO_SCCP_GTI_TT_ONLY; out->gt.tt = *cur++; @@ -167,6 +179,8 @@ LOGP(DLSUA, LOGL_ERROR, "Unsupported national GTI %u\n", sca->global_title_indicator); return -EINVAL; case SCCP_TITLE_IND_TRANS_NUM_ENC: + if (cur + 2 > tail) + return -1; out->presence |= OSMO_SCCP_ADDR_T_GT; out->gt.gti = OSMO_SCCP_GTI_TT_NPL_ENC; out->gt.tt = *cur++; @@ -185,6 +199,8 @@ } break; case SCCP_TITLE_IND_TRANS_NUM_ENC_NATURE: + if (cur + 3 > tail) + return -1; out->presence |= OSMO_SCCP_ADDR_T_GT; out->gt.gti = OSMO_SCCP_GTI_TT_NPL_ENC_NAI; out->gt.tt = *cur++; @@ -210,7 +226,7 @@ return -EINVAL; } rc = osmo_isup_party_parse(out->gt.digits, sizeof(out->gt.digits), - cur, (addr+addrlen-cur), odd); + cur, (tail - cur), odd); if (rc < 0) return rc; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43417?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1feabda052dc7a78b7d1d146aeb684e763923f74 Gerrit-Change-Number: 43417 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026