Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43304?usp=email )
Change subject: smdpp/generate_all_test_certificates: use f-string
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43304?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2671f03e5f35d1e71fb3f090e90a37961fae6a1d
Gerrit-Change-Number: 43304
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Aug 2026 14:37:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43062?usp=email )
Change subject: V1.2: Change of IpaEuiccDataRequest and results
......................................................................
Patch Set 8:
(4 comments)
File src/ipa/libipa/es10b_retr_notif_from_lst.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43062/comment/04e70327_b1ad0adb… :
PS8, Line 168: "no euiccPackageResults searchCriteria in IpaEuiccDataRequest!\n");
In SGP.32 2.11.1.2: "if there is no searchCriteriaNotification the IPA SHALL return the notificationsList as part of the IpaEuiccDataResponse containing all Notifications stored in the eUICC." (similar sentence for A2).
So it is technically not an error wen the dr_tag is set to 0xA0. Section 5.9.11 (Function (ES10b): RetrieveNotificationsList) is also coherent with this: "If searchCriteria data object is omitted, the eUICC SHALL return all stored Notifications that are in the format of PendingNotificationList.."
I would recommend to drop (or to change the log level to LDEBUG) the error message as it is legal to ask for euiccPackageResults without specifying a search criteria. Having no criteria just means that the criteria is "all"
https://gerrit.osmocom.org/c/onomondo-ipa/+/43062/comment/85d5f140_d0198cad… :
PS8, Line 229: "no searchCriteria in IpaEuiccDataRequest!\n");
(see comment above)
https://gerrit.osmocom.org/c/onomondo-ipa/+/43062/comment/bbe101a8_3dd6da5a… :
PS8, Line 246: "empty searchCriteria in IpaEuiccDataRequest!\n");
(see comment above)
https://gerrit.osmocom.org/c/onomondo-ipa/+/43062/comment/05c3a46e_2634b791… :
PS8, Line 255: "no searchCriteria in IpaEuiccDataRequest!\n");
(see comment above)
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43062?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I411111c71787ce27615b6b66fc8b19488883d15b
Gerrit-Change-Number: 43062
Gerrit-PatchSet: 8
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 19 Aug 2026 14:36:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43306?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: testenv: various small syntax tweaks
......................................................................
testenv: various small syntax tweaks
Change-Id: Ib07577c34b90abd936e005ca4f20c4e50fabb3a3
---
M .ruff.toml
M _testenv/testenv.py
M _testenv/testenv/__init__.py
M _testenv/testenv/podman.py
M _testenv/testenv/testenv_cfg.py
M _testenv/testenv/testsuite.py
6 files changed, 12 insertions(+), 21 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/43306/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43306?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib07577c34b90abd936e005ca4f20c4e50fabb3a3
Gerrit-Change-Number: 43306
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Attention is currently required from: jolly, laforge.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email )
Change subject: V1.2: Add function to set Device Capabilities
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I866787b8cda9a87a9f2e0db4965fbb554d339a6c
Gerrit-Change-Number: 43060
Gerrit-PatchSet: 8
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 19 Aug 2026 13:26:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes